)]}'
{"tempest/api/network/base.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f71498191eec32780eca9a8f5328091cd7baf901","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    @classmethod"},{"line_number":308,"context_line":"    def create_firewall_rule(cls, action, protocol):"},{"line_number":309,"context_line":"        \"\"\"Wrapper utility that returns a test firewall rule.\"\"\""},{"line_number":310,"context_line":"        resp, body \u003d cls.client.create_firewall_rule("},{"line_number":311,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":312,"context_line":"            action\u003daction,"},{"line_number":313,"context_line":"            protocol\u003dprotocol)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BPB0%3D","line":310,"updated":"2014-03-28 07:50:42.000000000","message":"unused variable \"resp\", can you change it on \"_, body\" ?","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"8d68e4d8e60b50964a2404eb5444fced7b06383c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    @classmethod"},{"line_number":308,"context_line":"    def create_firewall_rule(cls, action, protocol):"},{"line_number":309,"context_line":"        \"\"\"Wrapper utility that returns a test firewall rule.\"\"\""},{"line_number":310,"context_line":"        resp, body \u003d cls.client.create_firewall_rule("},{"line_number":311,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":312,"context_line":"            action\u003daction,"},{"line_number":313,"context_line":"            protocol\u003dprotocol)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BPAg%3D","line":310,"in_reply_to":"AAAAWH%2F%2BPB0%3D","updated":"2014-03-28 07:51:39.000000000","message":"Done","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f71498191eec32780eca9a8f5328091cd7baf901","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    @classmethod"},{"line_number":319,"context_line":"    def create_firewall_policy(cls):"},{"line_number":320,"context_line":"        \"\"\"Wrapper utility that returns a test firewall policy.\"\"\""},{"line_number":321,"context_line":"        resp, body \u003d cls.client.create_firewall_policy("},{"line_number":322,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":323,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":324,"context_line":"        cls.fw_policies.append(fw_policy)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BPBw%3D","line":321,"updated":"2014-03-28 07:50:42.000000000","message":"unused variable \"resp\", can you change it on \"_, body\" ?","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"8d68e4d8e60b50964a2404eb5444fced7b06383c","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    @classmethod"},{"line_number":319,"context_line":"    def create_firewall_policy(cls):"},{"line_number":320,"context_line":"        \"\"\"Wrapper utility that returns a test firewall policy.\"\"\""},{"line_number":321,"context_line":"        resp, body \u003d cls.client.create_firewall_policy("},{"line_number":322,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":323,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":324,"context_line":"        cls.fw_policies.append(fw_policy)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2BPAc%3D","line":321,"in_reply_to":"AAAAWH%2F%2BPBw%3D","updated":"2014-03-28 07:51:39.000000000","message":"Done","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"}],"tempest/api/network/test_fwaas_extensions.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ed8925ee2de442cb88c1d71726b1773d30012050","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":57,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":58,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":59,"context_line":"        self.assertIn((self.fw_rule[\u0027id\u0027], self.fw_rule[\u0027name\u0027]),"},{"line_number":60,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in fw_rules])"},{"line_number":61,"context_line":"        self.assertIn(self.fw_rule[\u0027action\u0027],"},{"line_number":62,"context_line":"                      [m[\u0027action\u0027] for m in fw_rules])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F%2F8Q%3D","line":59,"updated":"2014-03-12 12:54:23.000000000","message":"Do we really need those huge number of iterations  (list comprehensions)?\nWhy you cannot get the exact rule only once from the list, and compare the parameters ?","commit_id":"b52abd8e1734a35d271d5d035a81f9c844a8983d"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ed8925ee2de442cb88c1d71726b1773d30012050","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":113,"context_line":"        fw_policies \u003d fw_policies[\u0027firewall_policies\u0027]"},{"line_number":114,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":115,"context_line":"        self.assertIn((self.fw_policy[\u0027id\u0027], self.fw_policy[\u0027name\u0027]),"},{"line_number":116,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in fw_policies])"},{"line_number":117,"context_line":"        self.assertIn(self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":118,"context_line":"                      [m[\u0027firewall_rules\u0027] for m in fw_policies])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F%2F8E%3D","line":115,"updated":"2014-03-12 12:54:23.000000000","message":"ditto","commit_id":"b52abd8e1734a35d271d5d035a81f9c844a8983d"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # List firewall rules"},{"line_number":56,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":57,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":58,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":59,"context_line":"        self.assertIn((self.fw_rule[\u0027id\u0027],"},{"line_number":60,"context_line":"                       self.fw_rule[\u0027name\u0027],"},{"line_number":61,"context_line":"                       self.fw_rule[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3mE%3D","line":58,"updated":"2014-03-13 09:21:44.000000000","message":"the status code checking should be close to api call.","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # List firewall rules"},{"line_number":56,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":57,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":58,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":59,"context_line":"        self.assertIn((self.fw_rule[\u0027id\u0027],"},{"line_number":60,"context_line":"                       self.fw_rule[\u0027name\u0027],"},{"line_number":61,"context_line":"                       self.fw_rule[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2rM%3D","line":58,"in_reply_to":"AAAAWH%2F%2F3mE%3D","updated":"2014-03-13 11:04:15.000000000","message":"Adding in next Patch","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":79,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":80,"context_line":"        fw_rule_id \u003d fw_rule[\u0027id\u0027]"},{"line_number":81,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Update firewall rule"},{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3k0%3D","line":81,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":79,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":80,"context_line":"        fw_rule_id \u003d fw_rule[\u0027id\u0027]"},{"line_number":81,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Update firewall rule"},{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2rA%3D","line":81,"in_reply_to":"AAAAWH%2F%2F3k0%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"},{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":87,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(True, updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3kg%3D","line":87,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"},{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":87,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(True, updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qk%3D","line":87,"in_reply_to":"AAAAWH%2F%2F3kg%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # show a created firewall rule"},{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":103,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":104,"context_line":"        self.assertEqual(self.fw_rule[\u0027id\u0027], fw_rule[\u0027id\u0027])"},{"line_number":105,"context_line":"        self.assertEqual(self.fw_rule[\u0027protocol\u0027], fw_rule[\u0027protocol\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.fw_rule[\u0027shared\u0027], fw_rule[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3kU%3D","line":103,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # show a created firewall rule"},{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":103,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":104,"context_line":"        self.assertEqual(self.fw_rule[\u0027id\u0027], fw_rule[\u0027id\u0027])"},{"line_number":105,"context_line":"        self.assertEqual(self.fw_rule[\u0027protocol\u0027], fw_rule[\u0027protocol\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.fw_rule[\u0027shared\u0027], fw_rule[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qc%3D","line":103,"in_reply_to":"AAAAWH%2F%2F3kU%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":137,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":138,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":139,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Update firewall policy"},{"line_number":142,"context_line":"        resp, body \u003d self.client.update_firewall_policy(fw_policy_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3jo%3D","line":139,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":137,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":138,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":139,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Update firewall policy"},{"line_number":142,"context_line":"        resp, body \u003d self.client.update_firewall_policy(fw_policy_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qU%3D","line":139,"in_reply_to":"AAAAWH%2F%2F3jo%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                                        shared\u003dTrue,"},{"line_number":144,"context_line":"                                                        name\u003d\"updated_policy\")"},{"line_number":145,"context_line":"        updated_fw_policy \u003d body[\"firewall_policy\"]"},{"line_number":146,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":147,"context_line":"        self.assertEqual(True, updated_fw_policy[\u0027shared\u0027])"},{"line_number":148,"context_line":"        self.assertEqual(\"updated_policy\", updated_fw_policy[\u0027name\u0027])"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3jY%3D","line":146,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                                        shared\u003dTrue,"},{"line_number":144,"context_line":"                                                        name\u003d\"updated_policy\")"},{"line_number":145,"context_line":"        updated_fw_policy \u003d body[\"firewall_policy\"]"},{"line_number":146,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":147,"context_line":"        self.assertEqual(True, updated_fw_policy[\u0027shared\u0027])"},{"line_number":148,"context_line":"        self.assertEqual(\"updated_policy\", updated_fw_policy[\u0027name\u0027])"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2oM%3D","line":146,"in_reply_to":"AAAAWH%2F%2F3jY%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":162,"context_line":"            self.fw_policy[\u0027id\u0027])"},{"line_number":163,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":164,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":165,"context_line":"        self.assertEqual(self.fw_policy[\u0027id\u0027], fw_policy[\u0027id\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":167,"context_line":"                         fw_policy[\u0027firewall_rules\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3jQ%3D","line":164,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":162,"context_line":"            self.fw_policy[\u0027id\u0027])"},{"line_number":163,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":164,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":165,"context_line":"        self.assertEqual(self.fw_policy[\u0027id\u0027], fw_policy[\u0027id\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":167,"context_line":"                         fw_policy[\u0027firewall_rules\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qQ%3D","line":164,"in_reply_to":"AAAAWH%2F%2F3jQ%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027])"},{"line_number":181,"context_line":"        created_firewall \u003d body[\u0027firewall\u0027]"},{"line_number":182,"context_line":"        firewall_id \u003d created_firewall[\u0027id\u0027]"},{"line_number":183,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # show a created firewall"},{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3jE%3D","line":183,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027])"},{"line_number":181,"context_line":"        created_firewall \u003d body[\u0027firewall\u0027]"},{"line_number":182,"context_line":"        firewall_id \u003d created_firewall[\u0027id\u0027]"},{"line_number":183,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # show a created firewall"},{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qM%3D","line":183,"in_reply_to":"AAAAWH%2F%2F3jE%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # show a created firewall"},{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"},{"line_number":187,"context_line":"        firewall \u003d firewall[\u0027firewall\u0027]"},{"line_number":188,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":189,"context_line":"        self.assertEqual(created_firewall[\u0027id\u0027], firewall[\u0027id\u0027])"},{"line_number":190,"context_line":"        self.assertEqual(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":191,"context_line":"                         firewall[\u0027firewall_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3jI%3D","line":188,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # show a created firewall"},{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"},{"line_number":187,"context_line":"        firewall \u003d firewall[\u0027firewall\u0027]"},{"line_number":188,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":189,"context_line":"        self.assertEqual(created_firewall[\u0027id\u0027], firewall[\u0027id\u0027])"},{"line_number":190,"context_line":"        self.assertEqual(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":191,"context_line":"                         firewall[\u0027firewall_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qI%3D","line":188,"in_reply_to":"AAAAWH%2F%2F3jI%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # list firewall"},{"line_number":199,"context_line":"        resp, firewalls \u003d self.client.list_firewalls()"},{"line_number":200,"context_line":"        firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":201,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":202,"context_line":"        self.assertIn((created_firewall[\u0027id\u0027], created_firewall[\u0027name\u0027]),"},{"line_number":203,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in firewalls])"},{"line_number":204,"context_line":"        self.assertIn(created_firewall[\u0027firewall_policy_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3i4%3D","line":201,"updated":"2014-03-13 09:21:44.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # list firewall"},{"line_number":199,"context_line":"        resp, firewalls \u003d self.client.list_firewalls()"},{"line_number":200,"context_line":"        firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":201,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":202,"context_line":"        self.assertIn((created_firewall[\u0027id\u0027], created_firewall[\u0027name\u0027]),"},{"line_number":203,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in firewalls])"},{"line_number":204,"context_line":"        self.assertIn(created_firewall[\u0027firewall_policy_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2qE%3D","line":201,"in_reply_to":"AAAAWH%2F%2F3i4%3D","updated":"2014-03-13 11:04:15.000000000","message":"ditto","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e5eb487980c20b7f911489c141618a7cac7754dc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self.assertIn(created_firewall[\u0027tenant_id\u0027],"},{"line_number":207,"context_line":"                      [m[\u0027tenant_id\u0027] for m in firewalls])"},{"line_number":208,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":209,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Update firewall"},{"line_number":212,"context_line":"        # TODO(raies): \"Update can be done only when created status"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F3ig%3D","line":209,"updated":"2014-03-13 09:21:44.000000000","message":"there are some duplicate assertIn and assertEqual codes in this file. could you add a helper function to do that?","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"d213ae9f341c1981d3b7873340fd7023622e0fd1","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self.assertIn(created_firewall[\u0027tenant_id\u0027],"},{"line_number":207,"context_line":"                      [m[\u0027tenant_id\u0027] for m in firewalls])"},{"line_number":208,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":209,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Update firewall"},{"line_number":212,"context_line":"        # TODO(raies): \"Update can be done only when created status"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2F2oc%3D","line":209,"in_reply_to":"AAAAWH%2F%2F3ig%3D","updated":"2014-03-13 11:04:15.000000000","message":"What I see, In most cases onli name and ID parameter are being checked multiple times. But for these two three  \"assertIn\u0027s\" I think a new helper function will not be good to add.","commit_id":"d7f9c7c06d5a3ef8eb446859dfc0731016063836"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ce548791c9ac5637d6482dbf36aa91d17e0280c0","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # updated_fw \u003d body[\"firewall\"]"},{"line_number":220,"context_line":"        # self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":221,"context_line":"        # self.assertEqual(True, updated_fw[\u0027admin_state_up\u0027])"},{"line_number":222,"context_line":"        # self.assertEqual(name, updated_fw[\u0027name\u0027])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # Delete firewall"},{"line_number":225,"context_line":"        resp, _ \u003d self.client.delete_firewall(firewall_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Fuos%3D","line":222,"updated":"2014-03-14 07:02:49.000000000","message":"Please remove the commented code.\nThat would not be nice for the maintenancebility.","commit_id":"f9c99b694700428a0046b4bc6a223e4c55c79060"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3cb95775ae4ec1a960f831487bbf533e1fec8416","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # updated_fw \u003d body[\"firewall\"]"},{"line_number":220,"context_line":"        # self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":221,"context_line":"        # self.assertEqual(True, updated_fw[\u0027admin_state_up\u0027])"},{"line_number":222,"context_line":"        # self.assertEqual(name, updated_fw[\u0027name\u0027])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # Delete firewall"},{"line_number":225,"context_line":"        resp, _ \u003d self.client.delete_firewall(firewall_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Fujw%3D","line":222,"in_reply_to":"AAAAWH%2F%2Fuos%3D","updated":"2014-03-14 07:04:25.000000000","message":"Will be done in next patch","commit_id":"f9c99b694700428a0046b4bc6a223e4c55c79060"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ce548791c9ac5637d6482dbf36aa91d17e0280c0","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        # \"PENDING_DELETE\"."},{"line_number":231,"context_line":"        # resp, firewalls \u003d self.client.list_firewalls()"},{"line_number":232,"context_line":"        # firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":233,"context_line":"        # self.assertNotIn(firewall_id, [m[\u0027id\u0027] for m in firewalls])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Fuok%3D","line":233,"updated":"2014-03-14 07:02:49.000000000","message":"ditto","commit_id":"f9c99b694700428a0046b4bc6a223e4c55c79060"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3cb95775ae4ec1a960f831487bbf533e1fec8416","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        # \"PENDING_DELETE\"."},{"line_number":231,"context_line":"        # resp, firewalls \u003d self.client.list_firewalls()"},{"line_number":232,"context_line":"        # firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":233,"context_line":"        # self.assertNotIn(firewall_id, [m[\u0027id\u0027] for m in firewalls])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Fujo%3D","line":233,"in_reply_to":"AAAAWH%2F%2Fuok%3D","updated":"2014-03-14 07:04:25.000000000","message":"ditto","commit_id":"f9c99b694700428a0046b4bc6a223e4c55c79060"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"bc9f64174352cb333800504a0712e09b3f0adabe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FtIY%3D","line":1,"updated":"2014-03-14 11:06:15.000000000","message":"Please update the year here","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuaA%3D","line":1,"updated":"2014-03-14 13:24:11.000000000","message":"you should change it to 2014 and company name.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"04ae9bb72aaa7963112f264e38ba1d9da4e64746","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FtGk%3D","line":1,"in_reply_to":"AAAAWH%2F%2FtIY%3D","updated":"2014-03-14 11:08:40.000000000","message":"Nice catch, and the company name also is ..","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FqcQ%3D","line":1,"in_reply_to":"AAAAWH%2F%2FuaA%3D","updated":"2014-03-14 16:24:48.000000000","message":"Thanks for comments.\nI will amend in next patch.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"},{"line_number":92,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":93,"context_line":"        # Confirm deletion"},{"line_number":94,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":95,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":96,"context_line":"        self.assertNotIn(fw_rule_id, [m[\u0027id\u0027] for m in fw_rules])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuX4%3D","line":93,"updated":"2014-03-14 13:24:11.000000000","message":"As return code from delete is 204, wait for the deletion completion.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"},{"line_number":92,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":93,"context_line":"        # Confirm deletion"},{"line_number":94,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":95,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":96,"context_line":"        self.assertNotIn(fw_rule_id, [m[\u0027id\u0027] for m in fw_rules])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fqhw%3D","line":93,"in_reply_to":"AAAAWH%2F%2FuX4%3D","updated":"2014-03-14 16:24:48.000000000","message":"Firewall rule will get delete just API is called.\nNo PENDING_DELETE/DELETED like status is defined for rule, so there is no need to wait for any delete status.\nIt mean as soon as API is called rule is deleted.\nBelow code is here for to check whether rule is deleted actually or not.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(self.fw_rule[\u0027enabled\u0027], fw_rule[\u0027enabled\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(self.fw_rule[\u0027ip_version\u0027], fw_rule[\u0027ip_version\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(self.fw_rule[\u0027action\u0027], fw_rule[\u0027action\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(self.fw_rule[\u0027name\u0027], fw_rule[\u0027name\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":113,"context_line":"    def test_list_firewall_policies(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuVw%3D","line":110,"updated":"2014-03-14 13:24:11.000000000","message":"make a lists of elements and do assertEqual by iterating those key something like-\nexpected_rule \u003d [self.rule[\u0027id\u0027], ....]\nactual_rule  \u003d [rule[\u0027id\u0027], ....]\nfor key in expected_rule:\n    for key1 in actual_rule:\n         self.assertEqual(key, key1)","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"79e20e3dae80fb35f10dfc1d26d0e548c9b82a2c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(self.fw_rule[\u0027enabled\u0027], fw_rule[\u0027enabled\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(self.fw_rule[\u0027ip_version\u0027], fw_rule[\u0027ip_version\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(self.fw_rule[\u0027action\u0027], fw_rule[\u0027action\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(self.fw_rule[\u0027name\u0027], fw_rule[\u0027name\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":113,"context_line":"    def test_list_firewall_policies(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FRAQ%3D","line":110,"in_reply_to":"AAAAWH%2F%2Fqeo%3D","updated":"2014-03-19 01:12:39.000000000","message":"it reduce the LOC.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(self.fw_rule[\u0027enabled\u0027], fw_rule[\u0027enabled\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(self.fw_rule[\u0027ip_version\u0027], fw_rule[\u0027ip_version\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(self.fw_rule[\u0027action\u0027], fw_rule[\u0027action\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(self.fw_rule[\u0027name\u0027], fw_rule[\u0027name\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":113,"context_line":"    def test_list_firewall_policies(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fqeo%3D","line":110,"in_reply_to":"AAAAWH%2F%2FuVw%3D","updated":"2014-03-14 16:24:48.000000000","message":"Nice approach but I have a question, \nHere we have to write piece of code to populate two lists(Expected/Actual) and again same number of assertEqaul will be visited making no complexity is reduced and it will increase unnecessary loc while same thing is being accomplished in my code.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        # Delete firewall policy"},{"line_number":151,"context_line":"        resp, _ \u003d self.client.delete_firewall_policy(fw_policy_id)"},{"line_number":152,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":153,"context_line":"        # Confirm deletion"},{"line_number":154,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":155,"context_line":"        fw_policies \u003d fw_policies[\u0027firewall_policies\u0027]"},{"line_number":156,"context_line":"        self.assertNotIn(fw_policy_id, [m[\u0027id\u0027] for m in fw_policies])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuVk%3D","line":153,"updated":"2014-03-14 13:24:11.000000000","message":"same as above","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        # Delete firewall policy"},{"line_number":151,"context_line":"        resp, _ \u003d self.client.delete_firewall_policy(fw_policy_id)"},{"line_number":152,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":153,"context_line":"        # Confirm deletion"},{"line_number":154,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":155,"context_line":"        fw_policies \u003d fw_policies[\u0027firewall_policies\u0027]"},{"line_number":156,"context_line":"        self.assertNotIn(fw_policy_id, [m[\u0027id\u0027] for m in fw_policies])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fqck%3D","line":153,"in_reply_to":"AAAAWH%2F%2FuVk%3D","updated":"2014-03-14 16:24:48.000000000","message":"Same as above,\nNo wait to check actual deletion is required,\nOnly delete confirmation will be done in this case.","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual(self.fw_policy[\u0027audited\u0027], fw_policy[\u0027audited\u0027])"},{"line_number":171,"context_line":"        self.assertEqual(self.fw_policy[\u0027name\u0027], fw_policy[\u0027name\u0027])"},{"line_number":172,"context_line":"        self.assertEqual(self.fw_policy[\u0027description\u0027],"},{"line_number":173,"context_line":"                         fw_policy[\u0027description\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":176,"context_line":"    def test_create_show_update_delete_firewall(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuVg%3D","line":173,"updated":"2014-03-14 13:24:11.000000000","message":"same as above","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual(self.fw_policy[\u0027audited\u0027], fw_policy[\u0027audited\u0027])"},{"line_number":171,"context_line":"        self.assertEqual(self.fw_policy[\u0027name\u0027], fw_policy[\u0027name\u0027])"},{"line_number":172,"context_line":"        self.assertEqual(self.fw_policy[\u0027description\u0027],"},{"line_number":173,"context_line":"                         fw_policy[\u0027description\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":176,"context_line":"    def test_create_show_update_delete_firewall(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fqcg%3D","line":173,"in_reply_to":"AAAAWH%2F%2FuVg%3D","updated":"2014-03-14 16:24:48.000000000","message":"ditto","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6439f988673adffcb0bfdd58b9a210d69f5fd469","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual(created_firewall[\u0027tenant_id\u0027],"},{"line_number":193,"context_line":"                         firewall[\u0027tenant_id\u0027])"},{"line_number":194,"context_line":"        self.assertEqual(created_firewall[\u0027name\u0027], firewall[\u0027name\u0027])"},{"line_number":195,"context_line":"        self.assertEqual(created_firewall[\u0027description\u0027],"},{"line_number":196,"context_line":"                         firewall[\u0027description\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # list firewall"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FuVc%3D","line":195,"updated":"2014-03-14 13:24:11.000000000","message":"same as above","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"42c8621b007c19ea8d7db0dd6d98ae23e1201b92","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual(created_firewall[\u0027tenant_id\u0027],"},{"line_number":193,"context_line":"                         firewall[\u0027tenant_id\u0027])"},{"line_number":194,"context_line":"        self.assertEqual(created_firewall[\u0027name\u0027], firewall[\u0027name\u0027])"},{"line_number":195,"context_line":"        self.assertEqual(created_firewall[\u0027description\u0027],"},{"line_number":196,"context_line":"                         firewall[\u0027description\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # list firewall"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fqcc%3D","line":195,"in_reply_to":"AAAAWH%2F%2FuVc%3D","updated":"2014-03-14 16:24:48.000000000","message":"ditto","commit_id":"168714a77b9ffeca64724e1e6d376f465f5f04db"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f7b04d8012f542833aa260875b0a4cf0a2d2b18","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":104,"context_line":"        self.assertEqual(self.fw_rule[\u0027id\u0027], fw_rule[\u0027id\u0027])"},{"line_number":105,"context_line":"        self.assertEqual(self.fw_rule[\u0027protocol\u0027], fw_rule[\u0027protocol\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.fw_rule[\u0027shared\u0027], fw_rule[\u0027shared\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(self.fw_rule[\u0027enabled\u0027], fw_rule[\u0027enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXhk%3D","line":104,"updated":"2014-03-18 10:40:55.000000000","message":"Is not it possible to check all of this using\n\n    for key, value in fw_rule.iteritems():\n        self.assertEqual(self.fw_rule[key], value) ?","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"872997ec93a2e42904a4bd1af5c10fc2f613ef5c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":104,"context_line":"        self.assertEqual(self.fw_rule[\u0027id\u0027], fw_rule[\u0027id\u0027])"},{"line_number":105,"context_line":"        self.assertEqual(self.fw_rule[\u0027protocol\u0027], fw_rule[\u0027protocol\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.fw_rule[\u0027shared\u0027], fw_rule[\u0027shared\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(self.fw_rule[\u0027enabled\u0027], fw_rule[\u0027enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXOw%3D","line":104,"in_reply_to":"AAAAWH%2F%2FXhk%3D","updated":"2014-03-18 11:15:17.000000000","message":"Done","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f7b04d8012f542833aa260875b0a4cf0a2d2b18","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self.fw_policy[\u0027id\u0027])"},{"line_number":163,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":164,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":165,"context_line":"        self.assertEqual(self.fw_policy[\u0027id\u0027], fw_policy[\u0027id\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":167,"context_line":"                         fw_policy[\u0027firewall_rules\u0027])"},{"line_number":168,"context_line":"        self.assertEqual(self.fw_policy[\u0027tenant_id\u0027], fw_policy[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXhQ%3D","line":165,"updated":"2014-03-18 10:40:55.000000000","message":"the same as above","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"872997ec93a2e42904a4bd1af5c10fc2f613ef5c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self.fw_policy[\u0027id\u0027])"},{"line_number":163,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":164,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":165,"context_line":"        self.assertEqual(self.fw_policy[\u0027id\u0027], fw_policy[\u0027id\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":167,"context_line":"                         fw_policy[\u0027firewall_rules\u0027])"},{"line_number":168,"context_line":"        self.assertEqual(self.fw_policy[\u0027tenant_id\u0027], fw_policy[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXO4%3D","line":165,"in_reply_to":"AAAAWH%2F%2FXhQ%3D","updated":"2014-03-18 11:15:17.000000000","message":"Done","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f7b04d8012f542833aa260875b0a4cf0a2d2b18","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"},{"line_number":187,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":188,"context_line":"        firewall \u003d firewall[\u0027firewall\u0027]"},{"line_number":189,"context_line":"        self.assertEqual(created_firewall[\u0027id\u0027], firewall[\u0027id\u0027])"},{"line_number":190,"context_line":"        self.assertEqual(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":191,"context_line":"                         firewall[\u0027firewall_policy_id\u0027])"},{"line_number":192,"context_line":"        self.assertEqual(created_firewall[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXg8%3D","line":189,"updated":"2014-03-18 10:40:55.000000000","message":"the same as above","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"872997ec93a2e42904a4bd1af5c10fc2f613ef5c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        resp, firewall \u003d self.client.show_firewall(firewall_id)"},{"line_number":187,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":188,"context_line":"        firewall \u003d firewall[\u0027firewall\u0027]"},{"line_number":189,"context_line":"        self.assertEqual(created_firewall[\u0027id\u0027], firewall[\u0027id\u0027])"},{"line_number":190,"context_line":"        self.assertEqual(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":191,"context_line":"                         firewall[\u0027firewall_policy_id\u0027])"},{"line_number":192,"context_line":"        self.assertEqual(created_firewall[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FXO0%3D","line":189,"in_reply_to":"AAAAWH%2F%2FXg8%3D","updated":"2014-03-18 11:15:17.000000000","message":"Done","commit_id":"ba402ef9cf982161495fd7676ad9a92a46b663e1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5aa8759d73f59a685c2c7e2a95bdb29b596cead1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":110,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":111,"context_line":"        fw_policies \u003d fw_policies[\u0027firewall_policies\u0027]"},{"line_number":112,"context_line":"        self.assertIn((self.fw_policy[\u0027id\u0027],"},{"line_number":113,"context_line":"                       self.fw_policy[\u0027name\u0027],"},{"line_number":114,"context_line":"                       self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":115,"context_line":"                       self.fw_policy[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FPh0%3D","line":112,"updated":"2014-03-19 06:39:04.000000000","message":"I wonder why do you check all this parameters in list operation? Why it is not enough just to check \u0027id\u0027, \u0027name\u0027 and \u0027firewall_rules\u0027? In fact you check all parameters in testing show operation which is seem more reliable. And in my opinion it is a good idea to add check for list operation with filters.","commit_id":"5133a51c50ad552fe8c01b47028fb82db4220f63"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8ae4ba5dd3e0ee95ddabd519a8d1c0ad8977dcbc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":110,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":111,"context_line":"        fw_policies \u003d fw_policies[\u0027firewall_policies\u0027]"},{"line_number":112,"context_line":"        self.assertIn((self.fw_policy[\u0027id\u0027],"},{"line_number":113,"context_line":"                       self.fw_policy[\u0027name\u0027],"},{"line_number":114,"context_line":"                       self.fw_policy[\u0027firewall_rules\u0027],"},{"line_number":115,"context_line":"                       self.fw_policy[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FGLM%3D","line":112,"in_reply_to":"AAAAWH%2F%2FPh0%3D","updated":"2014-03-20 09:51:01.000000000","message":"Done","commit_id":"5133a51c50ad552fe8c01b47028fb82db4220f63"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"398013002953ed004220e376179cc2a1df02f2ea","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":88,"context_line":"        self.assertEqual(True, updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFeA%3D","line":88,"updated":"2014-03-20 11:44:20.000000000","message":"this can be replaced with\n\n    self.assertTrue(updated_fw_rule[\u0027shared\u0027])","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"478bc7536a34764bd2b91579281891683f800022","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":88,"context_line":"        self.assertEqual(True, updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFKc%3D","line":88,"in_reply_to":"AAAAWH%2F%2FFeA%3D","updated":"2014-03-20 12:20:11.000000000","message":"Will do in next","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"398013002953ed004220e376179cc2a1df02f2ea","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                                        name\u003d\"updated_policy\")"},{"line_number":132,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":133,"context_line":"        updated_fw_policy \u003d body[\"firewall_policy\"]"},{"line_number":134,"context_line":"        self.assertEqual(True, updated_fw_policy[\u0027shared\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\"updated_policy\", updated_fw_policy[\u0027name\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Delete firewall policy"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFd4%3D","line":134,"updated":"2014-03-20 11:44:20.000000000","message":"the same as above","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"478bc7536a34764bd2b91579281891683f800022","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                                        name\u003d\"updated_policy\")"},{"line_number":132,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":133,"context_line":"        updated_fw_policy \u003d body[\"firewall_policy\"]"},{"line_number":134,"context_line":"        self.assertEqual(True, updated_fw_policy[\u0027shared\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\"updated_policy\", updated_fw_policy[\u0027name\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Delete firewall policy"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFKg%3D","line":134,"in_reply_to":"AAAAWH%2F%2FFd4%3D","updated":"2014-03-20 12:20:11.000000000","message":"Will do in next","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"398013002953ed004220e376179cc2a1df02f2ea","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in firewalls])"},{"line_number":178,"context_line":"        self.assertIn(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":179,"context_line":"                      [m[\u0027firewall_policy_id\u0027] for m in firewalls])"},{"line_number":180,"context_line":"        self.assertIn(created_firewall[\u0027tenant_id\u0027],"},{"line_number":181,"context_line":"                      [m[\u0027tenant_id\u0027] for m in firewalls])"},{"line_number":182,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":183,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFcc%3D","line":180,"updated":"2014-03-20 11:44:20.000000000","message":"I think that it is enough to check \u0027id\u0027, \u0027name\u0027 and \u0027firewall_policy_id\u0027","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"478bc7536a34764bd2b91579281891683f800022","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                      [(m[\u0027id\u0027], m[\u0027name\u0027]) for m in firewalls])"},{"line_number":178,"context_line":"        self.assertIn(created_firewall[\u0027firewall_policy_id\u0027],"},{"line_number":179,"context_line":"                      [m[\u0027firewall_policy_id\u0027] for m in firewalls])"},{"line_number":180,"context_line":"        self.assertIn(created_firewall[\u0027tenant_id\u0027],"},{"line_number":181,"context_line":"                      [m[\u0027tenant_id\u0027] for m in firewalls])"},{"line_number":182,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":183,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFKs%3D","line":180,"in_reply_to":"AAAAWH%2F%2FFcc%3D","updated":"2014-03-20 12:20:11.000000000","message":"Will amend in next patch.","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"398013002953ed004220e376179cc2a1df02f2ea","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":183,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Update firewall"},{"line_number":186,"context_line":"        # TODO(raies): \"Update can be done only when created status"},{"line_number":187,"context_line":"        # is \u0027ACTIVE\u0027.\""},{"line_number":188,"context_line":"        # If created firewall status is \"PENDING_CREATE\", update can\u0027t be done"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFbg%3D","line":185,"updated":"2014-03-20 11:44:20.000000000","message":"As far as I remember if test depends on status it should be part of scenario test not API.","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"478bc7536a34764bd2b91579281891683f800022","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertIn(created_firewall[\u0027description\u0027],"},{"line_number":183,"context_line":"                      [m[\u0027description\u0027] for m in firewalls])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Update firewall"},{"line_number":186,"context_line":"        # TODO(raies): \"Update can be done only when created status"},{"line_number":187,"context_line":"        # is \u0027ACTIVE\u0027.\""},{"line_number":188,"context_line":"        # If created firewall status is \"PENDING_CREATE\", update can\u0027t be done"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FFJ4%3D","line":185,"in_reply_to":"AAAAWH%2F%2FFbg%3D","updated":"2014-03-20 12:20:11.000000000","message":"Ok will remove it from here.","commit_id":"f901a27b54fd5adf7fd93c39feb65fc8aa29541a"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f1306125197ba9e4de1d615f9e772b07dc86d37c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":79,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":81,"context_line":"        fw_rule_id \u003d fw_rule[\u0027id\u0027]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Update firewall rule"},{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bxyc%3D","line":81,"updated":"2014-03-24 13:10:17.000000000","message":"Please can you change it on fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027] and delete previous line","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2ae74e555cf8ce2074a3e1b9bc1e8e22d4905196","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":79,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":81,"context_line":"        fw_rule_id \u003d fw_rule[\u0027id\u0027]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Update firewall rule"},{"line_number":84,"context_line":"        resp, body \u003d self.client.update_firewall_rule(fw_rule_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bpg0%3D","line":81,"in_reply_to":"AAAAWH%2F%2Bxyc%3D","updated":"2014-03-25 10:02:48.000000000","message":"Done","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f1306125197ba9e4de1d615f9e772b07dc86d37c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":88,"context_line":"        self.assertTrue(updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2BxxU%3D","line":88,"updated":"2014-03-24 13:10:17.000000000","message":"Please, can you change it on self.assertTrue(body[\"firewall_rule\"][\u0027shared\u0027]) and delete previous line","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2ae74e555cf8ce2074a3e1b9bc1e8e22d4905196","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                                      shared\u003dTrue)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":87,"context_line":"        updated_fw_rule \u003d body[\"firewall_rule\"]"},{"line_number":88,"context_line":"        self.assertTrue(updated_fw_rule[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete firewall rule"},{"line_number":91,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bpgs%3D","line":88,"in_reply_to":"AAAAWH%2F%2BxxU%3D","updated":"2014-03-25 10:02:48.000000000","message":"Done","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f1306125197ba9e4de1d615f9e772b07dc86d37c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # Confirm deletion"},{"line_number":94,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":95,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":96,"context_line":"        self.assertNotIn(fw_rule_id, [m[\u0027id\u0027] for m in fw_rules])"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":99,"context_line":"    def test_show_firewall_rule(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bxu0%3D","line":96,"updated":"2014-03-24 13:10:17.000000000","message":"Please, can you change it on self.assertNotIn(fw_rule_id, [m[\u0027id\u0027] for m in fw_rules[\u0027firewall_rules\u0027]]) and delete previous line","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2ae74e555cf8ce2074a3e1b9bc1e8e22d4905196","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # Confirm deletion"},{"line_number":94,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":95,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":96,"context_line":"        self.assertNotIn(fw_rule_id, [m[\u0027id\u0027] for m in fw_rules])"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":99,"context_line":"    def test_show_firewall_rule(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bpgk%3D","line":96,"in_reply_to":"AAAAWH%2F%2Bxu0%3D","updated":"2014-03-25 10:02:48.000000000","message":"Done","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f1306125197ba9e4de1d615f9e772b07dc86d37c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":104,"context_line":"        for key, value in fw_rule.iteritems():"},{"line_number":105,"context_line":"            self.assertEqual(self.fw_rule[key], value)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bxug%3D","line":104,"updated":"2014-03-24 13:10:17.000000000","message":"Please, can you change it on for key, value in fw_rule[\u0027firewall_rule\u0027].iteritems() and delete previous line","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2ae74e555cf8ce2074a3e1b9bc1e8e22d4905196","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        resp, fw_rule \u003d self.client.show_firewall_rule(self.fw_rule[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":"        fw_rule \u003d fw_rule[\u0027firewall_rule\u0027]"},{"line_number":104,"context_line":"        for key, value in fw_rule.iteritems():"},{"line_number":105,"context_line":"            self.assertEqual(self.fw_rule[key], value)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bpgc%3D","line":104,"in_reply_to":"AAAAWH%2F%2Bxug%3D","updated":"2014-03-25 10:02:48.000000000","message":"Done","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"f1306125197ba9e4de1d615f9e772b07dc86d37c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":124,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":125,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":126,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # Update firewall policy"},{"line_number":129,"context_line":"        resp, body \u003d self.client.update_firewall_policy(fw_policy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Bxt0%3D","line":126,"updated":"2014-03-24 13:10:17.000000000","message":"Please, can you change it on fw_policy_id \u003d body[\u0027firewall_policy\u0027][\u0027id\u0027] and delete previous line","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"2ae74e555cf8ce2074a3e1b9bc1e8e22d4905196","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":124,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":125,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":126,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # Update firewall policy"},{"line_number":129,"context_line":"        resp, body \u003d self.client.update_firewall_policy(fw_policy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2BpgU%3D","line":126,"in_reply_to":"AAAAWH%2F%2Bxt0%3D","updated":"2014-03-25 10:02:48.000000000","message":"Done","commit_id":"dd671c8813b99414477f270421f796a82295db04"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"671c731612d135027faa03c224c45a4526db55b4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def test_list_firewall_rules(self):"},{"line_number":55,"context_line":"        # List firewall rules"},{"line_number":56,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":57,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":58,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":59,"context_line":"        self.assertIn((self.fw_rule[\u0027id\u0027],"},{"line_number":60,"context_line":"                       self.fw_rule[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yj8%3D","line":57,"updated":"2014-04-02 06:07:41.000000000","message":"The check ways for status are different in each places(line90, 135, etc).\nbetter to do it with the same way.","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"91e57cc0bb5dcb5fe39c7289bc91a5432c025537","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def test_list_firewall_rules(self):"},{"line_number":55,"context_line":"        # List firewall rules"},{"line_number":56,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":57,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":58,"context_line":"        fw_rules \u003d fw_rules[\u0027firewall_rules\u0027]"},{"line_number":59,"context_line":"        self.assertIn((self.fw_rule[\u0027id\u0027],"},{"line_number":60,"context_line":"                       self.fw_rule[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yXI%3D","line":57,"in_reply_to":"AAAAWH%2F9yj8%3D","updated":"2014-04-02 06:15:39.000000000","message":"Will be done in next patch","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"671c731612d135027faa03c224c45a4526db55b4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Create firewall policy"},{"line_number":119,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":120,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":121,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":122,"context_line":"        fw_policy_id \u003d body[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Update firewall policy"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yac%3D","line":121,"updated":"2014-04-02 06:07:41.000000000","message":"here needs\n\n self.addCleanup(self.client.delete_firewall_policy, fw_policy_id)\n\nto avoid the creation remains in environments when the test fails.","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"0985cc02e6d81540247c7f9d74499d269dda5121","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Create firewall policy"},{"line_number":119,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":120,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":121,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":122,"context_line":"        fw_policy_id \u003d body[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Update firewall policy"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yLM%3D","line":121,"in_reply_to":"AAAAWH%2F9yac%3D","updated":"2014-04-02 06:46:05.000000000","message":"will be done in next patch","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"671c731612d135027faa03c224c45a4526db55b4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # Create firewall"},{"line_number":154,"context_line":"        resp, body \u003d self.client.create_firewall("},{"line_number":155,"context_line":"            name\u003ddata_utils.rand_name(\"firewall\"),"},{"line_number":156,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027])"},{"line_number":157,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":158,"context_line":"        created_firewall \u003d body[\u0027firewall\u0027]"},{"line_number":159,"context_line":"        firewall_id \u003d created_firewall[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yZY%3D","line":156,"updated":"2014-04-02 06:07:41.000000000","message":"when fw_policy is deleted, is the firewall deleted automatically?\n\nIf yes, addCleanup is not necessary. but no, it is necessary because of the same reason.","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"0985cc02e6d81540247c7f9d74499d269dda5121","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # Create firewall"},{"line_number":154,"context_line":"        resp, body \u003d self.client.create_firewall("},{"line_number":155,"context_line":"            name\u003ddata_utils.rand_name(\"firewall\"),"},{"line_number":156,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027])"},{"line_number":157,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":158,"context_line":"        created_firewall \u003d body[\u0027firewall\u0027]"},{"line_number":159,"context_line":"        firewall_id \u003d created_firewall[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F9yLQ%3D","line":156,"in_reply_to":"AAAAWH%2F9yZY%3D","updated":"2014-04-02 06:46:05.000000000","message":"Yes addcleanup is required I will write it in next patch.","commit_id":"8251f6d85e6ce5d5338dcdefb86c105ce879842a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d03f109c838bb9be0aa0950b15be5bd5162894c6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        m[\u0027firewall_rules\u0027]) for m in fw_policies])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":117,"context_line":"    def test_create_update_delete_firewall_policy(self):"},{"line_number":118,"context_line":"        # Create firewall policy"},{"line_number":119,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":120,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWH%2F9wSc%3D","line":117,"updated":"2014-04-02 11:04:26.000000000","message":"this test continues to fail.\n\nPlease see http://logs.openstack.org/57/78857/15/check/check-tempest-dsvm-neutron/ba3a3f7/logs/testr_results.html.gz\n\nTraceback (most recent call last):\n  File \"tempest/services/network/network_client_base.py\", line 118, in _delete\n    return self.delete(uri)\n  File \"tempest/services/network/network_client_base.py\", line 78, in delete\n    return self.rest_client.delete(uri, headers)\n  File \"tempest/common/rest_client.py\", line 207, in delete\n    return self.request(\u0027DELETE\u0027, url, headers, body)\n  File \"tempest/common/rest_client.py\", line 443, in request\n    resp, resp_body)\n  File \"tempest/common/rest_client.py\", line 487, in _error_checker\n    raise exceptions.NotFound(resp_body)\nNotFound: Object not found\nDetails: {\"NeutronError\": {\"message\": \"Firewall Policy 1b712817-cc62-4389-9f16-c02f3d8dfd72 could not be found.\", \"type\": \"FirewallPolicyNotFound\", \"detail\": \"\"}}","commit_id":"aee973ea3b4c9554c018dd852339a60433a9ffcf"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"085751a9d2cc375d4614e01ca573986d022c471f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        m[\u0027firewall_rules\u0027]) for m in fw_policies])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":117,"context_line":"    def test_create_update_delete_firewall_policy(self):"},{"line_number":118,"context_line":"        # Create firewall policy"},{"line_number":119,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":120,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWH%2F9pQ4%3D","line":117,"in_reply_to":"AAAAWH%2F9wSc%3D","updated":"2014-04-03 05:12:51.000000000","message":"Done","commit_id":"aee973ea3b4c9554c018dd852339a60433a9ffcf"}]}