)]}'
{"tempest/api/network/common.py":[{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"b6940a53fcb8d30f993310b557b735fbf7994e01","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.client \u003d kwargs.pop(\u0027client\u0027, None)"},{"line_number":40,"context_line":"        super(DeletableResource, self).__init__(*args, **kwargs)"},{"line_number":41,"context_line":"        self.underscore_name \u003d camelcase_to_underscore("},{"line_number":42,"context_line":"            self.__class__.__name__.replace(\u0027Deletable\u0027, \u0027\u0027, 1))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __str__(self):"},{"line_number":45,"context_line":"        return \u0027\u003c%s id\u003d\"%s\" name\u003d\"%s\"\u003e\u0027 % (self.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FecI%3D","line":42,"updated":"2014-03-17 17:28:08.000000000","message":"Here you deal with the naming, see comment in other file.","commit_id":"60681c25ba14e861fca611fd22f5c4dc56854526"},{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"b6940a53fcb8d30f993310b557b735fbf7994e01","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class DeletableNetwork(DeletableResource):"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    Deletable Network class"},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fecw%3D","line":58,"updated":"2014-03-17 17:28:08.000000000","message":"Please don\u0027t introcude useless docstring, ever! If you think the docstring is worth of having there make it usefull, or just use `pass`.\n\nFind 5 differences game: class DeletableNetwork \u003d\u003e Deletable Network class.\n\nSee for ex. http://stackoverflow.com/questions/601900/how-to-write-meaningful-docstrings or any other guide for writing code documentation.","commit_id":"60681c25ba14e861fca611fd22f5c4dc56854526"}],"tempest/scenario/manager.py":[{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"b6940a53fcb8d30f993310b557b735fbf7994e01","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            return ("},{"line_number":496,"context_line":"                getattr("},{"line_number":497,"context_line":"                    net_common,"},{"line_number":498,"context_line":"                    \u0027Deletable%s\u0027 % camelcase_name"},{"line_number":499,"context_line":"                )(client\u003dself.network_client, **res)"},{"line_number":500,"context_line":"                for res in raw_resource_list)"},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FeYE%3D","line":498,"updated":"2014-03-17 17:28:08.000000000","message":"Here in this file, you are dealing with interal stuff of another module/class, which actually should be dealt with internally there.\n\nI mean this would be better encapsulated in the \u0027net_common\u0027, as cls2resource/resource2cls (just an example of naming). Or even in some other better way, which hides this problem for external consumers in meaningful way.","commit_id":"60681c25ba14e861fca611fd22f5c4dc56854526"}]}