)]}'
{"id":"openstack%2Ftempest~791850","triplet_id":"openstack%2Ftempest~master~I3c8c5a5261e135bcf56cfa5624ee1a504f31bdf3","project":"openstack/tempest","branch":"master","topic":"enc-type-create-fix","hashtags":[],"change_id":"I3c8c5a5261e135bcf56cfa5624ee1a504f31bdf3","subject":"Update encryption-type-create","status":"MERGED","created":"2021-05-17 23:48:55.000000000","updated":"2021-06-04 00:57:27.000000000","submitted":"2021-06-04 00:55:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"791850-enc-type-create-fix","meta_rev_id":"8b436965647dccc6939b11a9f585c60e8a0ec77c","_number":791850,"virtual_id_number":791850,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-04 00:55:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":2,"date":"2021-06-03 22:50:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-21 12:38:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":1,"date":"2021-06-03 22:50:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}],"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-18 01:41:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-18 15:11:22.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"CC"},{"updated":"2021-05-21 12:38:31.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"},{"updated":"2021-05-21 12:38:39.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2021-06-04 00:26:10.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"CC"}],"messages":[{"id":"ad0d484b0a0422f7e2a825573549486b1e379d89","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-05-17 23:48:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4a7fd72cd883c0d27a454e7d65de10693bc61803","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-18 01:41:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/510f66e5d7774976976546d3ee4ff1a7 : SUCCESS in 1h 24m 25s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/22309fc3498443d4af377c3a66be01d6 : FAILURE in 1h 33m 09s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cd5f2ddd56cf40f086266f0d6bad8a7a : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad65da7b44e94b8c85e10730347bee3e : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c612ea724ad9460a8c98790024289d6a : SUCCESS in 4m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9df3d15bf7f748b389d397d38967a052 : SUCCESS in 4m 25s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/88e9b656250540bca9393efa0b94722d : SUCCESS in 4m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2075ce9ed0284331985d995821bef73b : SUCCESS in 16m 32s\n- tempest-full-parallel https://zuul.opendev.org/t/openstack/build/4ef9012390a1417382bd76a11e156ba4 : FAILURE in 1h 11m 28s (non-voting)\n- tempest-full-py3-ipv6 https://zuul.opendev.org/t/openstack/build/2c6a2d1d899a44c1a4a42b27bef13572 : FAILURE in 1h 37m 46s (non-voting)\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/53e32111278a407ba89b1466ef9e176e : FAILURE in 1h 32m 25s (non-voting)\n- tempest-full-wallaby-py3 https://zuul.opendev.org/t/openstack/build/0aedc0eeafd34e82bc483429c1c6778a : FAILURE in 1h 36m 49s\n- tempest-full-victoria-py3 https://zuul.opendev.org/t/openstack/build/c0b3b179565d458da3771e6136fa9df3 : FAILURE in 1h 51m 03s\n- tempest-full-ussuri-py3 https://zuul.opendev.org/t/openstack/build/c52d9392c4b7453cb6a59d11d57606ae : FAILURE in 1h 14m 53s\n- tempest-full-train-py3 https://zuul.opendev.org/t/openstack/build/05bae95b60144c38ac1564f65289c6d5 : FAILURE in 57m 21s\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/89568c848e0948728c60e88686729919 : FAILURE in 1h 45m 11s\n- tempest-tox-plugin-sanity-check https://zuul.opendev.org/t/openstack/build/c67e30ee2dd14cd4b1350fc5745424f2 : SUCCESS in 35m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ad271e8ab397400ba74984f9d907a18f : SUCCESS in 1h 19m 09s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/ad1b3e2c06f14b8b929c14723f41aaa1 : FAILURE in 1h 34m 26s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e6e14f5968564df7a834033c1d834da4 : POST_FAILURE in 49m 48s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/65aceb984eb04007ae8e76666057debe : FAILURE in 51m 23s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/b6583f02ad984dff86420a7e4906a714 : SUCCESS in 48m 03s\n- neutron-tempest-dvr https://zuul.opendev.org/t/openstack/build/fabea5e79dec458599bdb8dc1c712a07 : SUCCESS in 58m 55s (non-voting)\n- interop-tempest-consistency https://zuul.opendev.org/t/openstack/build/578cac03271b4bb8adcb847902631ce9 : SUCCESS in 4m 34s\n- tempest-full-test-account-py3 https://zuul.opendev.org/t/openstack/build/ed58bacb462b4fd7b389b35c667d8167 : FAILURE in 56m 31s (non-voting)\n- tempest-full-test-account-no-admin-py3 https://zuul.opendev.org/t/openstack/build/7c68daa8e4e74494ba465fe782f2418b : FAILURE in 57m 16s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/264ca84254504e0e94c249469c5be5ac : SUCCESS in 4m 25s","accounts_in_message":[],"_revision_number":1},{"id":"990a9c13467cb6165ccd138464081ecd7bbbc503","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-05-18 12:38:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c4955647ec06747244ddf0a330275729d7bcc96c","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2021-05-18 15:11:22.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"696bb8beee68fa03d1160ad2bcc37eb08474ee94","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-18 15:31:27.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/b2ca734d949649629e42da78eebd1f8e : SUCCESS in 1h 01m 45s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7e8b3fde0e7b4951b238b9c415bae448 : SUCCESS in 1h 21m 50s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d5b54ca9ff964eb490cc480c68ad9234 : SUCCESS in 6m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/441723d5f315400284a04b06f3334f06 : SUCCESS in 4m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/994b8837216e41aebc88fcf1ffe61603 : SUCCESS in 5m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/99990fccd2054595847a586c25e85ea5 : SUCCESS in 5m 14s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4557d143006c4328ba570414756294f2 : SUCCESS in 5m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3d422e8fb7ba4d31a0233b744119529e : SUCCESS in 11m 59s\n- tempest-full-parallel https://zuul.opendev.org/t/openstack/build/cc3cd783a38146dba2770a660c5dcf38 : SUCCESS in 1h 41m 10s (non-voting)\n- tempest-full-py3-ipv6 https://zuul.opendev.org/t/openstack/build/d20adead12104598b105a1cb6a227c62 : SUCCESS in 1h 19m 51s (non-voting)\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/438f1b0222ac4c9c91d9e9202fda3d6a : FAILURE in 1h 06m 06s (non-voting)\n- tempest-full-wallaby-py3 https://zuul.opendev.org/t/openstack/build/e045e96db6f24b948f60338cf31be0e2 : SUCCESS in 1h 18m 44s\n- tempest-full-victoria-py3 https://zuul.opendev.org/t/openstack/build/e37954f19ddb481ab5852a996a504bfb : SUCCESS in 1h 28m 42s\n- tempest-full-ussuri-py3 https://zuul.opendev.org/t/openstack/build/9ea3e4dd845449a681b3a0ed03de36b6 : SUCCESS in 1h 22m 25s\n- tempest-full-train-py3 https://zuul.opendev.org/t/openstack/build/e229f50c50a940fdae83430c513165ab : SUCCESS in 1h 37m 19s\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/225742b54fd44e799131d53d15e70d8d : SUCCESS in 1h 47m 18s\n- tempest-tox-plugin-sanity-check https://zuul.opendev.org/t/openstack/build/f1cdfeed0b3e4d18bc09a61911171bbe : SUCCESS in 41m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7dd58f09cf304cf489aa2ae24bee702a : SUCCESS in 51m 38s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/d27cf81169c540729d80f0dd0ea672ec : FAILURE in 2h 51m 49s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ee4cfbc4ae9c461f85ffa7d355b55c33 : SUCCESS in 45m 52s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/4f47aaa24e864402940974efdfc05e54 : FAILURE in 1h 01m 55s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/24d203aaec6442e893695a3dd89aee6a : SUCCESS in 1h 27m 25s\n- neutron-tempest-dvr https://zuul.opendev.org/t/openstack/build/579e08d908bd4ef6a9acc17d534fabfc : SUCCESS in 1h 08m 45s (non-voting)\n- interop-tempest-consistency https://zuul.opendev.org/t/openstack/build/9efa2b122adb4e2cadc7d0e523dc0fd7 : SUCCESS in 2m 59s\n- tempest-full-test-account-py3 https://zuul.opendev.org/t/openstack/build/234ccc1418894a459b99a3088a30303f : FAILURE in 1h 40m 48s (non-voting)\n- tempest-full-test-account-no-admin-py3 https://zuul.opendev.org/t/openstack/build/d8b10a35c2ac4574934b528c3fe5a2db : SUCCESS in 53m 41s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/6dd090b8b0f34a9c8b144af2f2cc41e1 : SUCCESS in 3m 53s","accounts_in_message":[],"_revision_number":2},{"id":"962a4cb9d89cd17225df1b4aed0bf81597ef9869","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-05-20 19:50:38.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"2061eb6148bd2678dae32ef7221ad7d0ebb328f7","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-05-20 19:56:44.000000000","message":"Patch Set 2:\n\n@Martin: Yes, making these required is what we want to do.  We\u0027d like to do it without adding a new microversion, because we don\u0027t want operators to have to opt in to the correct behavior, it should be the same whether you specify a microversion or not.  This patch is meant to get the discussion rolling with the QA team to find out whether it\u0027s ok for cinder to enhance the request validation for the create encryption-type call.","accounts_in_message":[],"_revision_number":2},{"id":"30edf7c915e96c5d02ddf65a54268648b6c3b33f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 22:03:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/0872d8be5ab549c8b38339e4e6caa6c7 : SUCCESS in 1h 13m 43s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/30270f38530b47df957905a6a7433211 : SUCCESS in 1h 30m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/894a07a78908424bbb605a4466f42e77 : SUCCESS in 7m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60f077e2ac4a4d85805f0358a8eee3ef : SUCCESS in 4m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/13ddcea829684944ae02e0b647d6c987 : SUCCESS in 4m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2d17d4c765f74448a23823e2b893821a : SUCCESS in 5m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bd75a7e7e60b4ab3951010f0fd476e12 : SUCCESS in 5m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5e7f5e137bf4023b2040ec25313be0a : SUCCESS in 12m 24s\n- tempest-full-parallel https://zuul.opendev.org/t/openstack/build/309636f88b424236acf18e886cc3cd59 : FAILURE in 2h 02m 52s (non-voting)\n- tempest-full-py3-ipv6 https://zuul.opendev.org/t/openstack/build/ac25c50cdfc44e27817ccd974e84c34c : SUCCESS in 1h 35m 13s (non-voting)\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/31fde7457a454f79868603567f511431 : FAILURE in 1h 52m 16s (non-voting)\n- tempest-full-wallaby-py3 https://zuul.opendev.org/t/openstack/build/4df5bb6762554620a65a5a3cf3f78576 : SUCCESS in 1h 43m 09s\n- tempest-full-victoria-py3 https://zuul.opendev.org/t/openstack/build/98f7964f883846fcb685d449db1a68f2 : SUCCESS in 1h 42m 28s\n- tempest-full-ussuri-py3 https://zuul.opendev.org/t/openstack/build/9174e2a849b64ec0b1cd647a902e242c : SUCCESS in 1h 27m 10s\n- tempest-full-train-py3 https://zuul.opendev.org/t/openstack/build/c63aa34ed1744f0b895819e57a846020 : SUCCESS in 1h 27m 11s\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/050a1a27b3154c988540ac0b3761bc90 : SUCCESS in 2h 05m 18s\n- tempest-tox-plugin-sanity-check https://zuul.opendev.org/t/openstack/build/ab4fd84ba9024362b0e1615c6e9717aa : SUCCESS in 44m 41s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dedd6b963e0a4f5c92d5f3610352aa34 : SUCCESS in 57m 09s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/682d6e5261a44776a086fb873a8bd86e : SUCCESS in 2h 07m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/d7b127b1504b4ecfbb8a89074d70b8cc : FAILURE in 55m 31s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/f135213468354a0d8b1a69c20fc32870 : SUCCESS in 1h 19m 16s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/17c11bb84f2145cb8c7de7be5f2626ee : SUCCESS in 1h 30m 47s\n- neutron-tempest-dvr https://zuul.opendev.org/t/openstack/build/37a72936503442e08baaf81e439b8b70 : SUCCESS in 59m 03s (non-voting)\n- interop-tempest-consistency https://zuul.opendev.org/t/openstack/build/ed242b4f57ae45a49b86fc472c855b6d : SUCCESS in 3m 37s\n- tempest-full-test-account-py3 https://zuul.opendev.org/t/openstack/build/1281d9a9772d4fbdac0bba6d859b1dd4 : FAILURE in 1h 14m 42s (non-voting)\n- tempest-full-test-account-no-admin-py3 https://zuul.opendev.org/t/openstack/build/cf1c322c04c0400dbfbd0239cc9cbe91 : FAILURE in 56m 39s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/e9abeb91295d440482ea222e7f12537d : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":2},{"id":"45944f7ab4ddfe34515ff5ea3e2545deaf05d133","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2021-05-21 12:38:31.000000000","message":"Patch Set 2: Code-Review+2\n\n\u003e Patch Set 2:\n\u003e \n\u003e @Martin: Yes, making these required is what we want to do.  We\u0027d like to do it without adding a new microversion, because we don\u0027t want operators to have to opt in to the correct behavior, it should be the same whether you specify a microversion or not.  This patch is meant to get the discussion rolling with the QA team to find out whether it\u0027s ok for cinder to enhance the request validation for the create encryption-type call.\n\ni see, thanks for the clarification, lgtm then","accounts_in_message":[],"_revision_number":2},{"id":"91d2aaada083172110efedc88d5e19c4e456164d","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-06-03 22:50:35.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n\u003e Patch Set 2:\n\u003e \n\u003e @Martin: Yes, making these required is what we want to do.  We\u0027d like to do it without adding a new microversion, because we don\u0027t want operators to have to opt in to the correct behavior, it should be the same whether you specify a microversion or not.  This patch is meant to get the discussion rolling with the QA team to find out whether it\u0027s ok for cinder to enhance the request validation for the create encryption-type call.\n\nThanks for details. I saw the error in bug and IMO also this is completely valid to fix as bug without microversion as volume creation is going to fail at later stage so there is change in behavior from user perspective instead a bug fix. If any such request was passing in cinder and now we raise error then it would have been case of 200-\u003e4XX but here it is case of later-Error-\u003eearly-Error.\n\nTempest test change seems valid change for me.","accounts_in_message":[],"_revision_number":2},{"id":"44cc45b1e94383c8ea8f750868c7b691193089ef","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 22:50:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"d812db8977ba0dc0b6024f35d23652cc29bc4e14","author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"date":"2021-06-04 00:26:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c206ab0df777885e9d751018f97e0892f5ab8f85","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 00:55:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/9e1c58a8e93349e9b88c1ddbcb91925c : SUCCESS in 48m 55s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8116818d1e9248f5a1c27a0ed85eb23a : SUCCESS in 1h 13m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/637add82c4e7467aa71f3d573abc8268 : SUCCESS in 5m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1df62c4ed2e846039bbde7a1e9f58223 : SUCCESS in 5m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fbbc5837a8fa4ac886f1deda6a56fb44 : SUCCESS in 5m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f31dd65cb74b428fb91ab2cef8585af6 : SUCCESS in 13m 11s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/3a535ac859354259acbb4ba94d854aa7 : SUCCESS in 2h 00m 11s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/bda8d194926b437abc54a5a8f816c12b : SUCCESS in 49m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3c856b42a619452da19d37fedbd11574 : SUCCESS in 51m 06s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/e8cc60f069b04729ac562956a7b9a10f : SUCCESS in 1h 35m 01s","accounts_in_message":[],"_revision_number":2},{"id":"b1a115a31a89c733d6d995bfaf65973d8bf4c8df","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 00:55:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"8b436965647dccc6939b11a9f585c60e8a0ec77c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 00:57:27.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fd419b457c874f9f8740112034f995e8 : SUCCESS in 1m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"41a7ae9edd78d042066f387bd68ed056ebe40f24","revisions":{"079ec33680883b09874510dbe8c0d344522e8d59":{"kind":"REWORK","_number":1,"created":"2021-05-17 23:48:55.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/791850/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/50/791850/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/50/791850/1"}}},"commit":{"parents":[{"commit":"393e94a604f29940025c2c2d8f406419e7733e5c","subject":"Merge \"Fix unstability in test_subnet_details\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/393e94a604f29940025c2c2d8f406419e7733e5c"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2021-05-17 23:43:18.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2021-05-17 23:43:18.000000000","tz":-240},"subject":"Update encryption-type-create","message":"Update encryption-type-create\n\nCreating an encryption-type without key_size or cipher results in\na useless volume type that cannot be built, but this only becomes\nevident later when the volume type is used.  The Block Storage API\nis adding validation to make sure these fields are specified at the\ntime of encryption-type creation to avoid this situation.\n\nThe current test_volume_type_encryption_create_get_update_delete\ncreates a not-fully-specified volume type, which should not be\nallowed, so update the test.\n\nChange-Id: I3c8c5a5261e135bcf56cfa5624ee1a504f31bdf3\nRelated-bug: Bug #1926630\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/079ec33680883b09874510dbe8c0d344522e8d59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/079ec33680883b09874510dbe8c0d344522e8d59"}]},"branch":"refs/heads/master"},"41a7ae9edd78d042066f387bd68ed056ebe40f24":{"kind":"REWORK","_number":2,"created":"2021-05-18 12:38:23.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/791850/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/50/791850/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/50/791850/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/50/791850/2"}}},"commit":{"parents":[{"commit":"393e94a604f29940025c2c2d8f406419e7733e5c","subject":"Merge \"Fix unstability in test_subnet_details\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/393e94a604f29940025c2c2d8f406419e7733e5c"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2021-05-17 23:43:18.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2021-05-18 12:38:16.000000000","tz":-240},"subject":"Update encryption-type-create","message":"Update encryption-type-create\n\nCreating an encryption-type without key_size or cipher results in\na useless volume type that cannot be built, but this only becomes\nevident later when the volume type is used.  The Block Storage API\nis adding validation to make sure these fields are specified at the\ntime of encryption-type creation to avoid this situation.\n\nThe current test_volume_type_encryption_create_get_update_delete\ncreates a not-fully-specified volume type, which should not be\nallowed, so update the test.\n\nChange-Id: I3c8c5a5261e135bcf56cfa5624ee1a504f31bdf3\nRelated-bug: Bug #1926630\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/41a7ae9edd78d042066f387bd68ed056ebe40f24"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/41a7ae9edd78d042066f387bd68ed056ebe40f24"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}