)]}'
{"tempest/api/volume/v2/test_volumes_list.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b673e082d0393bfdc77f9502eec035b7c51b242c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                             with_detail\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":213,"context_line":"    def test_volume_list_detail_with_multiple_params(self):"},{"line_number":214,"context_line":"        # List volumes detail using combined condition"},{"line_number":215,"context_line":"        limit \u003d 2"},{"line_number":216,"context_line":"        status \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FCik%3D","line":213,"updated":"2014-03-10 14:11:22.000000000","message":"Lot of duplicated code. Maybe you could define an inner function (one arg whichvalue would be either desc or asc) that would perform the list_with_detail call and the different asserts.","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9aa494c00b0d7966fed2bf525666f8197d8cc585","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                             with_detail\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":213,"context_line":"    def test_volume_list_detail_with_multiple_params(self):"},{"line_number":214,"context_line":"        # List volumes detail using combined condition"},{"line_number":215,"context_line":"        limit \u003d 2"},{"line_number":216,"context_line":"        status \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B9kY%3D","line":213,"in_reply_to":"AAAAVn%2F%2FCik%3D","updated":"2014-03-11 02:02:31.000000000","message":"Done","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b673e082d0393bfdc77f9502eec035b7c51b242c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        resp, fetched_volume \u003d self.client.list_volumes_with_detail(params)"},{"line_number":223,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":224,"context_line":"        self.assertEqual(2, len(fetched_volume),"},{"line_number":225,"context_line":"                         \"The count of volumes is not %s\" % limit)"},{"line_number":226,"context_line":"        self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":227,"context_line":"        self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":228,"context_line":"        self.assertTrue(fetched_volume[0][\u0027created_at\u0027] \u003c"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FCiA%3D","line":225,"updated":"2014-03-10 14:11:22.000000000","message":"In the error message, also print the number of volume you actually got.","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9aa494c00b0d7966fed2bf525666f8197d8cc585","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        resp, fetched_volume \u003d self.client.list_volumes_with_detail(params)"},{"line_number":223,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":224,"context_line":"        self.assertEqual(2, len(fetched_volume),"},{"line_number":225,"context_line":"                         \"The count of volumes is not %s\" % limit)"},{"line_number":226,"context_line":"        self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":227,"context_line":"        self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":228,"context_line":"        self.assertTrue(fetched_volume[0][\u0027created_at\u0027] \u003c"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B9kI%3D","line":225,"in_reply_to":"AAAAVn%2F%2FCiA%3D","updated":"2014-03-11 02:02:31.000000000","message":"Done","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b673e082d0393bfdc77f9502eec035b7c51b242c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                         \"The count of volumes is not %s\" % limit)"},{"line_number":226,"context_line":"        self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":227,"context_line":"        self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":228,"context_line":"        self.assertTrue(fetched_volume[0][\u0027created_at\u0027] \u003c"},{"line_number":229,"context_line":"                        fetched_volume[1][\u0027created_at\u0027])"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        params \u003d {\u0027limit\u0027: limit,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FCho%3D","line":228,"updated":"2014-03-10 14:11:22.000000000","message":"Could you provide an explicit error message in case of failure ?","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9aa494c00b0d7966fed2bf525666f8197d8cc585","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                         \"The count of volumes is not %s\" % limit)"},{"line_number":226,"context_line":"        self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":227,"context_line":"        self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":228,"context_line":"        self.assertTrue(fetched_volume[0][\u0027created_at\u0027] \u003c"},{"line_number":229,"context_line":"                        fetched_volume[1][\u0027created_at\u0027])"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        params \u003d {\u0027limit\u0027: limit,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2B9kE%3D","line":228,"in_reply_to":"AAAAVn%2F%2FCho%3D","updated":"2014-03-11 02:02:31.000000000","message":"Done","commit_id":"f68297e9227de28e0755c7793ce6185d6fb16f99"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf2abea9ef9b53f0d752ede9e4c44e1171e35a44","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":230,"context_line":"            self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":231,"context_line":"            if sort_dir \u003d\u003d \u0027asc\u0027:"},{"line_number":232,"context_line":"                self.assertGreater(fetched_volume[1][sort_key],"},{"line_number":233,"context_line":"                                   fetched_volume[0][sort_key])"},{"line_number":234,"context_line":"            elif sort_dir \u003d\u003d \u0027desc\u0027:"},{"line_number":235,"context_line":"                self.assertGreater(fetched_volume[0][sort_key],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2B86c%3D","line":232,"updated":"2014-03-11 03:25:57.000000000","message":"I think assertTrue() can be used here bcz assertGreater() not in PY 26. We have workaround present in tempest base class to use the assertGreater() but better will be assertTrue()","commit_id":"431f9ce0bbe7a783f2c613dbc501086d3554868a"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"fc9efe1c6e140074a0e6d73f6c79d0aa91119670","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":230,"context_line":"            self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":231,"context_line":"            if sort_dir \u003d\u003d \u0027asc\u0027:"},{"line_number":232,"context_line":"                self.assertGreater(fetched_volume[1][sort_key],"},{"line_number":233,"context_line":"                                   fetched_volume[0][sort_key])"},{"line_number":234,"context_line":"            elif sort_dir \u003d\u003d \u0027desc\u0027:"},{"line_number":235,"context_line":"                self.assertGreater(fetched_volume[0][sort_key],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Bzzk%3D","line":232,"in_reply_to":"AAAAVn%2F%2B86c%3D","updated":"2014-03-12 01:20:47.000000000","message":"@Ghanshyam, thanks for your comments. IMO, assertGreater is more convenient than assertTrue. As you said, tempest already have workaround to support assertGreater by unittest2. Is there any potential reason that we can not use those assert* functions?","commit_id":"431f9ce0bbe7a783f2c613dbc501086d3554868a"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"a46e3845ea9e87ca7de16df4d32bc1a88f35d584","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":230,"context_line":"            self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":231,"context_line":"            if sort_dir \u003d\u003d \u0027asc\u0027:"},{"line_number":232,"context_line":"                self.assertGreater(fetched_volume[1][sort_key],"},{"line_number":233,"context_line":"                                   fetched_volume[0][sort_key])"},{"line_number":234,"context_line":"            elif sort_dir \u003d\u003d \u0027desc\u0027:"},{"line_number":235,"context_line":"                self.assertGreater(fetched_volume[0][sort_key],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2ByyI%3D","line":232,"in_reply_to":"AAAAVn%2F%2BzEo%3D","updated":"2014-03-12 05:21:26.000000000","message":"I understand your point, thank you! Let\u0027s see if there are other opinions about this. I\u0027m not sure whether this workaround would be removed in the future.","commit_id":"431f9ce0bbe7a783f2c613dbc501086d3554868a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9e544b088e87a65057eeccc0d8244980f3d5fd8","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            self.assertEqual(status, fetched_volume[0][\u0027status\u0027])"},{"line_number":230,"context_line":"            self.assertEqual(status, fetched_volume[1][\u0027status\u0027])"},{"line_number":231,"context_line":"            if sort_dir \u003d\u003d \u0027asc\u0027:"},{"line_number":232,"context_line":"                self.assertGreater(fetched_volume[1][sort_key],"},{"line_number":233,"context_line":"                                   fetched_volume[0][sort_key])"},{"line_number":234,"context_line":"            elif sort_dir \u003d\u003d \u0027desc\u0027:"},{"line_number":235,"context_line":"                self.assertGreater(fetched_volume[0][sort_key],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2BzEo%3D","line":232,"in_reply_to":"AAAAVn%2F%2Bzzk%3D","updated":"2014-03-12 03:58:21.000000000","message":"I think, it is not preferable to use those assert which are not in pv26. If in future, that workaround has been removed then, this test breaks, Its one of the suggestion, otherwise it still looks fine.","commit_id":"431f9ce0bbe7a783f2c613dbc501086d3554868a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf2abea9ef9b53f0d752ede9e4c44e1171e35a44","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                   fetched_volume[0][sort_key])"},{"line_number":234,"context_line":"            elif sort_dir \u003d\u003d \u0027desc\u0027:"},{"line_number":235,"context_line":"                self.assertGreater(fetched_volume[0][sort_key],"},{"line_number":236,"context_line":"                                   fetched_volume[1][sort_key])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        _list_detail_with_multiple_params()"},{"line_number":239,"context_line":"        _list_detail_with_multiple_params(sort_dir\u003d\u0027desc\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2B86U%3D","line":236,"updated":"2014-03-11 03:25:57.000000000","message":"Same as above","commit_id":"431f9ce0bbe7a783f2c613dbc501086d3554868a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"258ecd221f78c2f502e89fb268a42b45d96b708a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                             with_detail\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":213,"context_line":"    def test_volume_list_detail_with_multiple_params(self):"},{"line_number":214,"context_line":"        # List volumes detail using combined condition"},{"line_number":215,"context_line":"        def _list_detail_with_multiple_params(limit\u003d2,"},{"line_number":216,"context_line":"                                              status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FqVw%3D","line":213,"updated":"2014-03-14 16:47:50.000000000","message":"I think this should read test_volume_list_details (with the trailing s) to be consistent with previous test names.","commit_id":"fab8f765f60176d997906728c7eca4ff83809087"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"1e3fe4f8b9a1a1f73b1526240d2d9f400900d270","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                             with_detail\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":213,"context_line":"    def test_volume_list_detail_with_multiple_params(self):"},{"line_number":214,"context_line":"        # List volumes detail using combined condition"},{"line_number":215,"context_line":"        def _list_detail_with_multiple_params(limit\u003d2,"},{"line_number":216,"context_line":"                                              status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FkFw%3D","line":213,"in_reply_to":"AAAAWH%2F%2FqVw%3D","updated":"2014-03-17 00:13:32.000000000","message":"Thank you for your comments! I\u0027ll fix it in next patch.","commit_id":"fab8f765f60176d997906728c7eca4ff83809087"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"258ecd221f78c2f502e89fb268a42b45d96b708a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                self.assertTrue(val0 \u003e val1,"},{"line_number":238,"context_line":"                                \"%s \u003e %s\" % (val0, val1))"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        _list_detail_with_multiple_params()"},{"line_number":241,"context_line":"        _list_detail_with_multiple_params(sort_dir\u003d\u0027desc\u0027)"},{"line_number":242,"context_line":"        _list_detail_with_multiple_params(sort_key\u003d\u0027id\u0027)"},{"line_number":243,"context_line":"        _list_detail_with_multiple_params(sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027desc\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FqT4%3D","line":240,"updated":"2014-03-14 16:47:50.000000000","message":"let\u0027s just try one rich combination of things; no need to repeat with multiple combinations","commit_id":"fab8f765f60176d997906728c7eca4ff83809087"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"1e3fe4f8b9a1a1f73b1526240d2d9f400900d270","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                self.assertTrue(val0 \u003e val1,"},{"line_number":238,"context_line":"                                \"%s \u003e %s\" % (val0, val1))"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        _list_detail_with_multiple_params()"},{"line_number":241,"context_line":"        _list_detail_with_multiple_params(sort_dir\u003d\u0027desc\u0027)"},{"line_number":242,"context_line":"        _list_detail_with_multiple_params(sort_key\u003d\u0027id\u0027)"},{"line_number":243,"context_line":"        _list_detail_with_multiple_params(sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027desc\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FkF8%3D","line":240,"in_reply_to":"AAAAWH%2F%2FqT4%3D","updated":"2014-03-17 00:13:32.000000000","message":"Done","commit_id":"fab8f765f60176d997906728c7eca4ff83809087"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"136083439a1fefc09c18fcefbd546ee53b91962a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self._list_by_param_value_and_assert(params, expected_list\u003d[volume],"},{"line_number":210,"context_line":"                                             with_detail\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":213,"context_line":"    def test_volume_list_details_with_multiple_params(self):"},{"line_number":214,"context_line":"        # List volumes detail using combined condition"},{"line_number":215,"context_line":"        def _list_details_with_multiple_params(limit\u003d2,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FNn4%3D","line":212,"updated":"2014-03-19 12:20:34.000000000","message":"May be the two test method with outside helper fits better here.","commit_id":"b5e1d0cb169324f53257ee5067eb3b02bd646a87"}]}