)]}'
{"tempest/common/isolated_creds.py":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"137ce018420239ad608e36b4c7d6095a7864f35a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            self.identity_admin_client.users.delete(user)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _delete_tenant(self, tenant):"},{"line_number":143,"context_line":"        if CONF.service_available.neutron:"},{"line_number":144,"context_line":"            self._cleanup_default_secgroup(tenant)"},{"line_number":145,"context_line":"        if self.tempest_client:"},{"line_number":146,"context_line":"            self.identity_admin_client.delete_tenant(tenant)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FCwQ%3D","line":143,"updated":"2014-03-10 15:39:53.000000000","message":"Honest question: Do we need to do the same cleanup action if the cluster is running nova-network instead of neutron?","commit_id":"e60335cfeef0253c830817b5a7e6dac6c55cd1c3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d1011f2925ea44b35027c74d1f029aa7e7dbd59e","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def _cleanup_default_secgroup(self, tenant):"},{"line_number":473,"context_line":"        net_client \u003d self.network_admin_client"},{"line_number":474,"context_line":"        if self.tempest_client:"},{"line_number":475,"context_line":"            resp, resp_body \u003d net_client.list_security_groups(tenant_id\u003dtenant,"},{"line_number":476,"context_line":"                                                              name\u003d\"default\")"},{"line_number":477,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FC3E%3D","line":474,"updated":"2014-03-10 13:17:42.000000000","message":"I am new to this part of the script. Is the if/else necessary in this case ?","commit_id":"e60335cfeef0253c830817b5a7e6dac6c55cd1c3"},{"author":{"_account_id":7781,"name":"Ala Rezmerita","email":"ala.rezmerita@orange.com","username":"alla"},"change_message_id":"ea83e37243e31819599347b1b864d02171854368","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def _cleanup_default_secgroup(self, tenant):"},{"line_number":473,"context_line":"        net_client \u003d self.network_admin_client"},{"line_number":474,"context_line":"        if self.tempest_client:"},{"line_number":475,"context_line":"            resp, resp_body \u003d net_client.list_security_groups(tenant_id\u003dtenant,"},{"line_number":476,"context_line":"                                                              name\u003d\"default\")"},{"line_number":477,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B68E%3D","line":474,"in_reply_to":"AAAAVn%2F%2FC3E%3D","updated":"2014-03-11 15:42:06.000000000","message":"This if is necessary, because for the tempest scenarios, network project client (neutronclient) will be used (self.tempest_client \u003d\u003d False) which will return a tuple, and for regular tests it will use tempest network client (self.tempest_client \u003d\u003d True) which returns a dict","commit_id":"e60335cfeef0253c830817b5a7e6dac6c55cd1c3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d1011f2925ea44b35027c74d1f029aa7e7dbd59e","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        for secgroup in secgroups_to_delete:"},{"line_number":482,"context_line":"            try:"},{"line_number":483,"context_line":"                net_client.delete_security_group(secgroup[\u0027id\u0027])"},{"line_number":484,"context_line":"            except Exception:"},{"line_number":485,"context_line":"                pass"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def _clear_isolated_net_resources(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FC5s%3D","line":484,"updated":"2014-03-10 13:17:42.000000000","message":"This is too large...","commit_id":"e60335cfeef0253c830817b5a7e6dac6c55cd1c3"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4b0486dcdd87fbb6cbd1bf698fc5d496c0be2aac","unresolved":false,"context_lines":[{"line_number":484,"context_line":"            try:"},{"line_number":485,"context_line":"                net_client.delete_security_group(secgroup[\u0027id\u0027])"},{"line_number":486,"context_line":"            except exceptions.NotFound:"},{"line_number":487,"context_line":"                LOG.warn(\u0027Security group %s, id %s not found for clean-up\u0027 %"},{"line_number":488,"context_line":"                         (secgroup[\u0027name\u0027], secgroup[\u0027id\u0027]))"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def _clear_isolated_net_resources(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FyII%3D","line":487,"updated":"2014-04-10 12:56:17.000000000","message":"nit: i think dictionary substitution is preferred over positional/tuple\n\n LOG.warn(\u0027Security group %(name)s, id %(id)s not found for clean-up\u0027, {\u0027name\u0027: secgroup[\u0027name\u0027], \u0027id\u0027: secgroup[\u0027id\u0027]})","commit_id":"aa9cf22dfb7b1c7f12f26d44299e9dcec22d84f6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8c246802bbd7c0e463489f890fc27bf94d8dd98c","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _delete_tenant(self, tenant):"},{"line_number":143,"context_line":"        # TODO(arezmerita) Clean-up secgroups for nova-network"},{"line_number":144,"context_line":"        if CONF.service_available.neutron:"},{"line_number":145,"context_line":"            self._cleanup_default_secgroup(tenant)"},{"line_number":146,"context_line":"        if self.tempest_client:"},{"line_number":147,"context_line":"            self.identity_admin_client.delete_tenant(tenant)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2FVVw%3D","line":144,"updated":"2014-04-22 13:13:29.000000000","message":"if we are doing this, we should do it for both services at the same time.","commit_id":"6f6e59b21f5ecc547b321c694db1a15e97ed9036"}]}