)]}'
{"tempest/api/compute/security_groups/test_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"75d12f09ccc8a5b52140555a878674e4b2db23c3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        sg_name \u003d \u0027 sample securitygroup \u0027"},{"line_number":67,"context_line":"        resp, securitygroup \u003d self.create_security_group(name\u003dsg_name)"},{"line_number":68,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":69,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"},{"line_number":70,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":71,"context_line":"        securitygroup_name_list \u003d map(lambda x: x[\u0027name\u0027], fetched_list)"},{"line_number":72,"context_line":"        self.assertIn(sg_name, securitygroup_name_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B7I4%3D","line":69,"updated":"2014-03-11 09:02:26.000000000","message":"we can remove the list_security_groups(), as newly created security group can be verified from create_security_group() response. we can rely on create_security_group response as its response code is 200.","commit_id":"40273d95711a1c4f425bc1c93cf96755d3b9adab"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"652ad1279c205e69e518c459b891efc74f3f9c10","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        sg_name \u003d \u0027 sample securitygroup \u0027"},{"line_number":67,"context_line":"        resp, securitygroup \u003d self.create_security_group(name\u003dsg_name)"},{"line_number":68,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":69,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"},{"line_number":70,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":71,"context_line":"        securitygroup_name_list \u003d map(lambda x: x[\u0027name\u0027], fetched_list)"},{"line_number":72,"context_line":"        self.assertIn(sg_name, securitygroup_name_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2By6A%3D","line":69,"in_reply_to":"AAAAVn%2F%2B6Ek%3D","updated":"2014-03-12 04:43:04.000000000","message":"I agree with Ghanshyam. Please make it more readable.\n\nBut I am not understanding the worth of this test.","commit_id":"40273d95711a1c4f425bc1c93cf96755d3b9adab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b22620f9a81f22ddceeaabbf00184bf2a60ef0b1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        sg_name \u003d \u0027 sample securitygroup \u0027"},{"line_number":67,"context_line":"        resp, securitygroup \u003d self.create_security_group(name\u003dsg_name)"},{"line_number":68,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":69,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"},{"line_number":70,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":71,"context_line":"        securitygroup_name_list \u003d map(lambda x: x[\u0027name\u0027], fetched_list)"},{"line_number":72,"context_line":"        self.assertIn(sg_name, securitygroup_name_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B6Ek%3D","line":69,"in_reply_to":"AAAAVn%2F%2B6gs%3D","updated":"2014-03-11 12:00:48.000000000","message":"Ok. my comment was as per name of this test. I think you can add \"list\" also in the name otherwise its ok.","commit_id":"40273d95711a1c4f425bc1c93cf96755d3b9adab"},{"author":{"_account_id":10300,"name":"Pranali Deore","email":"pranalideore@gmail.com","username":"PranaliDeore"},"change_message_id":"d90116c4c0148871bcbae5a1f7467521cd00f8df","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        sg_name \u003d \u0027 sample securitygroup \u0027"},{"line_number":67,"context_line":"        resp, securitygroup \u003d self.create_security_group(name\u003dsg_name)"},{"line_number":68,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":69,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"},{"line_number":70,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":71,"context_line":"        securitygroup_name_list \u003d map(lambda x: x[\u0027name\u0027], fetched_list)"},{"line_number":72,"context_line":"        self.assertIn(sg_name, securitygroup_name_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2B6gs%3D","line":69,"in_reply_to":"AAAAVn%2F%2B7I4%3D","updated":"2014-03-11 10:40:47.000000000","message":"Here we are checking that whether  list_security_groups() also returns the security group name with spaces in it.","commit_id":"40273d95711a1c4f425bc1c93cf96755d3b9adab"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"6357a538cbbc743f1f14f96ffc161f0f59a80875","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        sg_name \u003d \u0027 sample securitygroup \u0027"},{"line_number":67,"context_line":"        resp, securitygroup \u003d self.create_security_group(name\u003dsg_name)"},{"line_number":68,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":69,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"},{"line_number":70,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":71,"context_line":"        securitygroup_name_list \u003d map(lambda x: x[\u0027name\u0027], fetched_list)"},{"line_number":72,"context_line":"        self.assertIn(sg_name, securitygroup_name_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2ByOc%3D","line":69,"in_reply_to":"AAAAVn%2F%2By6A%3D","updated":"2014-03-12 06:48:46.000000000","message":"This test is similar to test_security_groups_create_list_delete. the only different is \u0027name\u0027. Is it possible merged this test into test_security_groups_create_list_delete?","commit_id":"40273d95711a1c4f425bc1c93cf96755d3b9adab"}]}