)]}'
{"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"50e70d4a3c533ff113d9533c26ca1ef068ad1115","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        Freeform characters in the hostname are replaced with dashes"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ac886150_1bcf91e7","line":108,"updated":"2021-07-19 20:42:25.000000000","message":"This is already called in L96, I do not think it is needed again.","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":33602,"name":"Pavan Kesava Rao","email":"pkesavar@redhat.com","username":"pkesav"},"change_message_id":"177ab3353d7618beb0154930387d8a6d9e07a03e","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        Freeform characters in the hostname are replaced with dashes"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"}],"source_content_type":"text/x-python","patch_set":4,"id":"977c9660_a975301a","line":108,"in_reply_to":"86c54a70_f978fc19","updated":"2021-07-22 03:01:39.000000000","message":"Ack","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c2ffc7565a7d07ad040de47dc3120c48609cfde5","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        Freeform characters in the hostname are replaced with dashes"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"}],"source_content_type":"text/x-python","patch_set":4,"id":"86c54a70_f978fc19","line":108,"in_reply_to":"ac886150_1bcf91e7","updated":"2021-07-21 18:23:47.000000000","message":"yeah, we donot need this","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"50e70d4a3c533ff113d9533c26ca1ef068ad1115","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"},{"line_number":112,"context_line":"            self.ssh_user,"},{"line_number":113,"context_line":"            self.password,"},{"line_number":114,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"364aac28_a8cd803c","line":111,"updated":"2021-07-19 20:42:25.000000000","message":"I think you should be passing just server here based on what you created in L98, not self.server that was created via the resource class.","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c2ffc7565a7d07ad040de47dc3120c48609cfde5","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"},{"line_number":112,"context_line":"            self.ssh_user,"},{"line_number":113,"context_line":"            self.password,"},{"line_number":114,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"dd53eca5_b301acc4","line":111,"in_reply_to":"364aac28_a8cd803c","updated":"2021-07-21 18:23:47.000000000","message":"and somehow it is impacting the self.server and test_host_name_is_same_as_server_name fail\n\nhttps://zuul.opendev.org/t/openstack/build/77fe35447a9148e9bc0ce91a7442d6fe/log/job-output.txt#28271","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":33602,"name":"Pavan Kesava Rao","email":"pkesavar@redhat.com","username":"pkesav"},"change_message_id":"177ab3353d7618beb0154930387d8a6d9e07a03e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":109,"context_line":"            self.os_primary)"},{"line_number":110,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":111,"context_line":"            self.get_server_ip(self.server, validation_resources),"},{"line_number":112,"context_line":"            self.ssh_user,"},{"line_number":113,"context_line":"            self.password,"},{"line_number":114,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"98a2d597_17aef991","line":111,"in_reply_to":"dd53eca5_b301acc4","updated":"2021-07-22 03:01:39.000000000","message":"The wrapper called in validation_resources L51 can only manage one guest instance for the entire class and consumed by all tests in the base class. However, the fqdn test requires the hostname to be updated to fqdn like name structure and be managed via another validation_resource. As the latter is not possible to achieve in the base class, am restructuring the test case to be defined in a separate class.","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"50e70d4a3c533ff113d9533c26ca1ef068ad1115","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            self.ssh_user,"},{"line_number":113,"context_line":"            self.password,"},{"line_number":114,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":115,"context_line":"            server\u003dself.server,"},{"line_number":116,"context_line":"            servers_client\u003dself.client)"},{"line_number":117,"context_line":"        hostname \u003d linux_client.exec_command(\"hostname\").rstrip()"},{"line_number":118,"context_line":"        self.assertEqual(\u0027guest-instance-1-domain-com\u0027, hostname)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bef088fe_4025d5c8","line":115,"updated":"2021-07-19 20:42:25.000000000","message":"Ditto as comment for L111.","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":33602,"name":"Pavan Kesava Rao","email":"pkesavar@redhat.com","username":"pkesav"},"change_message_id":"177ab3353d7618beb0154930387d8a6d9e07a03e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            self.ssh_user,"},{"line_number":113,"context_line":"            self.password,"},{"line_number":114,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":115,"context_line":"            server\u003dself.server,"},{"line_number":116,"context_line":"            servers_client\u003dself.client)"},{"line_number":117,"context_line":"        hostname \u003d linux_client.exec_command(\"hostname\").rstrip()"},{"line_number":118,"context_line":"        self.assertEqual(\u0027guest-instance-1-domain-com\u0027, hostname)"}],"source_content_type":"text/x-python","patch_set":4,"id":"57920851_ee74612f","line":115,"in_reply_to":"bef088fe_4025d5c8","updated":"2021-07-22 03:01:39.000000000","message":"Ack","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c2ffc7565a7d07ad040de47dc3120c48609cfde5","unresolved":true,"context_lines":[{"line_number":159,"context_line":"    @decorators.idempotent_id(\u0027ac1ad47f-984b-4441-9274-c9079b7a0666\u0027)"},{"line_number":160,"context_line":"    @testtools.skipUnless(CONF.validation.run_validation,"},{"line_number":161,"context_line":"                          \u0027Instance validation tests are disabled.\u0027)"},{"line_number":162,"context_line":"    def test_host_name_is_same_as_server_name(self):"},{"line_number":163,"context_line":"        \"\"\"Verify the instance host name is the same as the server name\"\"\""},{"line_number":164,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":165,"context_line":"            self.os_primary)"},{"line_number":166,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":167,"context_line":"            self.get_server_ip(self.server, validation_resources),"},{"line_number":168,"context_line":"            self.ssh_user,"},{"line_number":169,"context_line":"            self.password,"},{"line_number":170,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":171,"context_line":"            server\u003dself.server,"},{"line_number":172,"context_line":"            servers_client\u003dself.client)"},{"line_number":173,"context_line":"        hostname \u003d linux_client.exec_command(\"hostname\").rstrip()"},{"line_number":174,"context_line":"        msg \u003d (\u0027Failed while verifying servername equals hostname. Expected \u0027"},{"line_number":175,"context_line":"               \u0027hostname \"%s\" but got \"%s\".\u0027 %"},{"line_number":176,"context_line":"               (self.name, hostname.split(\".\")[0]))"},{"line_number":177,"context_line":"        # NOTE(zhufl): Some images will add postfix for the hostname, e.g.,"},{"line_number":178,"context_line":"        # if hostname is \"aaa\", postfix \".novalocal\" may be added to it, and"},{"line_number":179,"context_line":"        # the hostname will be \"aaa.novalocal\" then, so we should ignore the"},{"line_number":180,"context_line":"        # postfix when checking whether hostname equals self.name."},{"line_number":181,"context_line":"        self.assertEqual(self.name.lower(), hostname.split(\".\")[0], msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ServersTestManualDisk(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":4,"id":"161e0b3d_84b3b3c1","line":181,"range":{"start_line":162,"start_character":0,"end_line":181,"end_character":72},"updated":"2021-07-21 18:23:47.000000000","message":"this test is failing in devstack patch, we need to update thistest also?\n\nhttps://zuul.opendev.org/t/openstack/build/77fe35447a9148e9bc0ce91a7442d6fe/log/job-output.txt#28271","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":33602,"name":"Pavan Kesava Rao","email":"pkesavar@redhat.com","username":"pkesav"},"change_message_id":"177ab3353d7618beb0154930387d8a6d9e07a03e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    @decorators.idempotent_id(\u0027ac1ad47f-984b-4441-9274-c9079b7a0666\u0027)"},{"line_number":160,"context_line":"    @testtools.skipUnless(CONF.validation.run_validation,"},{"line_number":161,"context_line":"                          \u0027Instance validation tests are disabled.\u0027)"},{"line_number":162,"context_line":"    def test_host_name_is_same_as_server_name(self):"},{"line_number":163,"context_line":"        \"\"\"Verify the instance host name is the same as the server name\"\"\""},{"line_number":164,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":165,"context_line":"            self.os_primary)"},{"line_number":166,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":167,"context_line":"            self.get_server_ip(self.server, validation_resources),"},{"line_number":168,"context_line":"            self.ssh_user,"},{"line_number":169,"context_line":"            self.password,"},{"line_number":170,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":171,"context_line":"            server\u003dself.server,"},{"line_number":172,"context_line":"            servers_client\u003dself.client)"},{"line_number":173,"context_line":"        hostname \u003d linux_client.exec_command(\"hostname\").rstrip()"},{"line_number":174,"context_line":"        msg \u003d (\u0027Failed while verifying servername equals hostname. Expected \u0027"},{"line_number":175,"context_line":"               \u0027hostname \"%s\" but got \"%s\".\u0027 %"},{"line_number":176,"context_line":"               (self.name, hostname.split(\".\")[0]))"},{"line_number":177,"context_line":"        # NOTE(zhufl): Some images will add postfix for the hostname, e.g.,"},{"line_number":178,"context_line":"        # if hostname is \"aaa\", postfix \".novalocal\" may be added to it, and"},{"line_number":179,"context_line":"        # the hostname will be \"aaa.novalocal\" then, so we should ignore the"},{"line_number":180,"context_line":"        # postfix when checking whether hostname equals self.name."},{"line_number":181,"context_line":"        self.assertEqual(self.name.lower(), hostname.split(\".\")[0], msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ServersTestManualDisk(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":4,"id":"66cb7a17_ae1394f5","line":181,"range":{"start_line":162,"start_character":0,"end_line":181,"end_character":72},"in_reply_to":"161e0b3d_84b3b3c1","updated":"2021-07-22 03:01:39.000000000","message":"The test is failing since self.name.lower() is fetched from the first validation_resources in L56 and hostname.split(\".\")[0] is fetched from the second validation_resources in L96. Two validation_resources cannot be handled in the same class which fails this test. So, am restructing my test case to be placed in a separate class in the next patchset","commit_id":"f3375e7ebfdfa3e96cb678eaa4f1cc0ebb17362d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0658df38776f97f4fea31077eeb5e1de1c2c0133","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    @decorators.idempotent_id(\u0027622066d2-39fc-4c09-9eeb-35903c114a0a\u0027)"},{"line_number":203,"context_line":"    @testtools.skipUnless("},{"line_number":204,"context_line":"        CONF.compute_feature_enabled.hostname_fqdn_sanitization,"},{"line_number":205,"context_line":"        \u0027FQDN hostname sanitization is not supported.\u0027)"},{"line_number":206,"context_line":"    def test_create_server_with_fqdn_name(self):"},{"line_number":207,"context_line":"        \"\"\"Test to create an instance with FQDN type name scheme\"\"\""},{"line_number":208,"context_line":"        validation_resources \u003d self.get_class_validation_resources("}],"source_content_type":"text/x-python","patch_set":7,"id":"f63c3089_12a46241","line":205,"range":{"start_line":205,"start_character":53,"end_line":205,"end_character":55},"updated":"2021-07-22 23:55:10.000000000","message":"problem of failure in nova-ceph-multistore job is run_validation is false there and we do not create any validation resource of run_validation is false.\n\nWe need to add below skip decorator for this test too so that we run this test which need validation only when run_validation is configured to True.\n\n    @testtools.skipUnless(CONF.validation.run_validation,\n                          \u0027Instance validation tests are disabled.\u0027)","commit_id":"98039036d0eec865c372cc2346f38f68fa66a33f"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24b1d16a7fc0936f9ef74cd1a4c19b4dabff7bd4","unresolved":true,"context_lines":[{"line_number":437,"context_line":"    cfg.BoolOpt(\u0027disk_config\u0027,"},{"line_number":438,"context_line":"                default\u003dTrue,"},{"line_number":439,"context_line":"                help\u003d\"If false, skip disk config tests\"),"},{"line_number":440,"context_line":"    cfg.BoolOpt(\u0027hostname_fqdn_sanitization\u0027,"},{"line_number":441,"context_line":"                default\u003dFalse,"},{"line_number":442,"context_line":"                help\u003d\"If false, skip fqdn instance sanitization tests\"),"},{"line_number":443,"context_line":"    cfg.ListOpt(\u0027api_extensions\u0027,"},{"line_number":444,"context_line":"                default\u003d[\u0027all\u0027],"},{"line_number":445,"context_line":"                help\u003d\u0027A list of enabled compute extensions with a special \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0bc3ef_052bcc44","line":442,"range":{"start_line":440,"start_character":0,"end_line":442,"end_character":72},"updated":"2021-07-08 17:04:43.000000000","message":"nova fixed it in wallaby onwards and Tempest master support stable/train onwards. We can enable this flag in devstack wallaby onwards and make it true by default here once wallaby is oldest supported stable for Tempest.\n\ncan you add a todo here and more clear in help:\n\n    # TODO: Make it True by default once wallaby is oldest supported stable\n    # for Tempest.\n    cfg.BoolOpt(\u0027hostname_fqdn_sanitization\u0027,\n                default\u003dFalse,\n                help\u003d\"If false, skip fqdn instance sanitization tests. \"\n                     \"Nova started sanitizing the instance name by replacing \"\n                     \"the \u0027.\u0027 with \u0027-\u0027 to comply with fqdn hostname. Nova \"\n                     \"changed that in Wallaby cycle, if your cloud is older \"\n                     \"that wallaby then you can keep/make it False.\"),","commit_id":"273a67c1f57c10a5997b555f2b545f5b29bdbfcd"},{"author":{"_account_id":33602,"name":"Pavan Kesava Rao","email":"pkesavar@redhat.com","username":"pkesav"},"change_message_id":"b465ac9cf05449e1f0a747c3f52fec1b6ce1b657","unresolved":false,"context_lines":[{"line_number":437,"context_line":"    cfg.BoolOpt(\u0027disk_config\u0027,"},{"line_number":438,"context_line":"                default\u003dTrue,"},{"line_number":439,"context_line":"                help\u003d\"If false, skip disk config tests\"),"},{"line_number":440,"context_line":"    cfg.BoolOpt(\u0027hostname_fqdn_sanitization\u0027,"},{"line_number":441,"context_line":"                default\u003dFalse,"},{"line_number":442,"context_line":"                help\u003d\"If false, skip fqdn instance sanitization tests\"),"},{"line_number":443,"context_line":"    cfg.ListOpt(\u0027api_extensions\u0027,"},{"line_number":444,"context_line":"                default\u003d[\u0027all\u0027],"},{"line_number":445,"context_line":"                help\u003d\u0027A list of enabled compute extensions with a special \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3004a6ca_35e1752d","line":442,"range":{"start_line":440,"start_character":0,"end_line":442,"end_character":72},"in_reply_to":"ba0bc3ef_052bcc44","updated":"2021-07-19 17:22:22.000000000","message":"Done","commit_id":"273a67c1f57c10a5997b555f2b545f5b29bdbfcd"}]}