)]}'
{"tempest/tests/test_commands.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d8339154b95932cc2fb8ee0e362733ac6503aab9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        ns_list \u003d commands.ip_ns_list()"},{"line_number":63,"context_line":"        for ns in ns_list:"},{"line_number":64,"context_line":"            with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":65,"context_line":"                print(ns)"},{"line_number":66,"context_line":"                expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, ns,"},{"line_number":67,"context_line":"                            \u0027ip\u0027, \u0027a\u0027]"},{"line_number":68,"context_line":"                commands.ip_ns_addr(ns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9ge8%3D","line":65,"updated":"2014-04-04 02:53:34.000000000","message":"Can you remove this? I think this is just for debugging.","commit_id":"a1ab88bb3e0df876711e42b08806db5baaf8fe1b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"5703ebfe0c8360b1165ac17ba54a9f617544483f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        ns_list \u003d commands.ip_ns_list()"},{"line_number":63,"context_line":"        for ns in ns_list:"},{"line_number":64,"context_line":"            with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":65,"context_line":"                print(ns)"},{"line_number":66,"context_line":"                expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, ns,"},{"line_number":67,"context_line":"                            \u0027ip\u0027, \u0027a\u0027]"},{"line_number":68,"context_line":"                commands.ip_ns_addr(ns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9gUs%3D","line":65,"in_reply_to":"AAAAWH%2F9ge8%3D","updated":"2014-04-04 03:39:04.000000000","message":"Sorry, I forgot to remove this.","commit_id":"a1ab88bb3e0df876711e42b08806db5baaf8fe1b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"012aac6033fce51eb721be5b52ba8c1f0e627136","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                                \u0027stderr\u0027: subprocess.STDOUT}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_ip_addr_raw(self):"},{"line_number":30,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":31,"context_line":"            expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027a\u0027]"},{"line_number":32,"context_line":"            commands.ip_addr_raw()"},{"line_number":33,"context_line":"            mocked.assert_called_with(expected, **self.subprocess_args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9aLs%3D","line":30,"updated":"2014-04-04 18:09:22.000000000","message":"Since the whole method is under the with I probably would have used the @mock.patch decorator instead. But, this works fine too.","commit_id":"fe0719c644712b717441dccf03b83b334e858e30"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"7109ca1580754559e676c3ff833a3993c546f656","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                                \u0027stderr\u0027: subprocess.STDOUT}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_ip_addr_raw(self):"},{"line_number":30,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":31,"context_line":"            expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027a\u0027]"},{"line_number":32,"context_line":"            commands.ip_addr_raw()"},{"line_number":33,"context_line":"            mocked.assert_called_with(expected, **self.subprocess_args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWn%2F%2F9cs%3D","line":30,"in_reply_to":"AAAAWH%2F9aLs%3D","updated":"2014-04-08 08:54:23.000000000","message":"I see. I\u0027ll do it.","commit_id":"fe0719c644712b717441dccf03b83b334e858e30"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"012aac6033fce51eb721be5b52ba8c1f0e627136","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":31,"context_line":"            expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027a\u0027]"},{"line_number":32,"context_line":"            commands.ip_addr_raw()"},{"line_number":33,"context_line":"            mocked.assert_called_with(expected, **self.subprocess_args)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_ip_route_raw(self):"},{"line_number":36,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9aKg%3D","line":33,"updated":"2014-04-04 18:09:22.000000000","message":"Why called_with as opposed to called_once_with? I think it would be better to be explicit here and say that the method should only call the command once.","commit_id":"fe0719c644712b717441dccf03b83b334e858e30"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"7109ca1580754559e676c3ff833a3993c546f656","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"},{"line_number":31,"context_line":"            expected \u003d [\u0027/usr/bin/sudo\u0027, \u0027-n\u0027, \u0027ip\u0027, \u0027a\u0027]"},{"line_number":32,"context_line":"            commands.ip_addr_raw()"},{"line_number":33,"context_line":"            mocked.assert_called_with(expected, **self.subprocess_args)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_ip_route_raw(self):"},{"line_number":36,"context_line":"        with mock.patch(\u0027subprocess.Popen\u0027) as mocked:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWn%2F%2F9Uw%3D","line":33,"in_reply_to":"AAAAWH%2F9aKg%3D","updated":"2014-04-08 08:54:23.000000000","message":"I see, I\u0027ll use assert_called_once_with instead of assert_called_with","commit_id":"fe0719c644712b717441dccf03b83b334e858e30"}]}