)]}'
{"tempest/api/network/admin/test_negative_quotas.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"79cc4c4e57ea8dcc360f115176d64037702f3665","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        super(QuotasNegativeTest, self).tearDown()"},{"line_number":57,"context_line":"        # Delete default security group"},{"line_number":58,"context_line":"        auth_provider \u003d self.creds_client.users_client.auth_provider"},{"line_number":59,"context_line":"        region \u003d self.creds_client.users_client.region"},{"line_number":60,"context_line":"        sec_client \u003d SecurityGroupsClient(auth_provider, \u0027network\u0027, region)"},{"line_number":61,"context_line":"        resp_body \u003d sec_client.list_security_groups("},{"line_number":62,"context_line":"            tenant_id\u003dself.project[\u0027id\u0027],"},{"line_number":63,"context_line":"            name\u003d\"default\")"},{"line_number":64,"context_line":"        if resp_body[\u0027security_groups\u0027]:"},{"line_number":65,"context_line":"            sec_group_id \u003d resp_body[\u0027security_groups\u0027][0][\u0027id\u0027]"},{"line_number":66,"context_line":"            sec_client.delete_security_group(sec_group_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027644f4e1b-1bf9-4af0-9fd8-eb56ac0f51cf\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"aae83630_fa2e0c21","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":58},"updated":"2021-06-30 14:33:28.000000000","message":"maybe this could be replaced by:\n```\nself.credentials_provider._cleanup_default_secgroup(self.project[\u0027id\u0027])\n```\nIt should be the same as it\u0027s in here:\nhttps://github.com/openstack/tempest/blob/53c02181f87804a4ba8ddf6288ea1f7717234c2a/tempest/lib/common/dynamic_creds.py#L571","commit_id":"2770fcffec97db536e1437531420f009a3870490"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"305716ec680e9f3bf872c182cfacc575183868ef","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        super(QuotasNegativeTest, self).tearDown()"},{"line_number":57,"context_line":"        # Delete default security group"},{"line_number":58,"context_line":"        auth_provider \u003d self.creds_client.users_client.auth_provider"},{"line_number":59,"context_line":"        region \u003d self.creds_client.users_client.region"},{"line_number":60,"context_line":"        sec_client \u003d SecurityGroupsClient(auth_provider, \u0027network\u0027, region)"},{"line_number":61,"context_line":"        resp_body \u003d sec_client.list_security_groups("},{"line_number":62,"context_line":"            tenant_id\u003dself.project[\u0027id\u0027],"},{"line_number":63,"context_line":"            name\u003d\"default\")"},{"line_number":64,"context_line":"        if resp_body[\u0027security_groups\u0027]:"},{"line_number":65,"context_line":"            sec_group_id \u003d resp_body[\u0027security_groups\u0027][0][\u0027id\u0027]"},{"line_number":66,"context_line":"            sec_client.delete_security_group(sec_group_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027644f4e1b-1bf9-4af0-9fd8-eb56ac0f51cf\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"54a330fc_44aa2dc6","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":58},"in_reply_to":"aae83630_fa2e0c21","updated":"2021-07-03 17:36:11.000000000","message":"+1, _cleanup_default_secgroup use admin client to cleanup any project\u0027s sec group.\n\nand we can make _cleanup_default_secgroup() method as public method.","commit_id":"2770fcffec97db536e1437531420f009a3870490"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"6637c1accbaaa5af703ecb18a50ff0abd4563aba","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def tearDown(self):"},{"line_number":55,"context_line":"        super(QuotasNegativeTest, self).tearDown()"},{"line_number":56,"context_line":"        self.credentials_provider.cleanup_default_secgroup(self.project[\u0027id\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027644f4e1b-1bf9-4af0-9fd8-eb56ac0f51cf\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2ce58d40_a1d48a74","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":78},"updated":"2021-08-05 21:13:35.000000000","message":"This would cause test failure as cleanup_default_secgroup is not defined and implemented for other provider i.e. PreProvisionedCredentialProvider. Bug reported via https://bugs.launchpad.net/tempest/+bug/1939049","commit_id":"619e0f4161fdc1c4feb97c71e0fd2a7f70b7372c"}]}