)]}'
{"releasenotes/notes/Add-chunk_size-config-for-volume-tests-041f7d25fc2f3e05.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ccbf1e1bf3da399f0ec227ff3472afdf0784bf08","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config for volume tests is added which allows to specify chunk size"},{"line_number":5,"context_line":"    which is beneficial for tested systems where the chunk size is other than"},{"line_number":6,"context_line":"    1 (originally hardoced in the tests).:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    CONF.volume.chunk_size"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6552f701_72d6cd97","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":26},"updated":"2021-06-25 12:31:48.000000000","message":"nit, typo: hardcoded.","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"3637c56f229e7759163cc90ab805c232a7170d19","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config for volume tests is added which allows to specify chunk size"},{"line_number":5,"context_line":"    which is beneficial for tested systems where the chunk size is other than"},{"line_number":6,"context_line":"    1 (originally hardoced in the tests).:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    CONF.volume.chunk_size"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"61405dcf_d1b15d12","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":26},"in_reply_to":"6552f701_72d6cd97","updated":"2021-06-28 20:47:12.000000000","message":"I would suggest adding \"option\" (A new config option).","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"}],"tempest/config.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ccbf1e1bf3da399f0ec227ff3472afdf0784bf08","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    cfg.IntOpt(\u0027chunk_size\u0027,"},{"line_number":1004,"context_line":"               default\u003d1,"},{"line_number":1005,"context_line":"               help\u003d\"Size in GB a volume is extended about (volume_size +\""},{"line_number":1006,"context_line":"                    \"volume_size_extend).\"),"},{"line_number":1007,"context_line":"    cfg.ListOpt(\u0027manage_volume_ref\u0027,"},{"line_number":1008,"context_line":"                default\u003d[\u0027source-name\u0027, \u0027volume-%s\u0027],"},{"line_number":1009,"context_line":"                help\u003d\"A reference to existing volume for volume manage. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5db4b302_e8c939ca","line":1006,"updated":"2021-06-25 12:31:48.000000000","message":"isn\u0027t volume_size_extend the same as chunk_size? The new volume size is calculated by adding additional chunk_size, so the final size will be volume_size+chunk_size.\n\nTerminology note: I\u0027m not sure \"extend about\" is the correct terminology but it\u0027d better if a native speaker would check it.","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"3637c56f229e7759163cc90ab805c232a7170d19","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    cfg.IntOpt(\u0027chunk_size\u0027,"},{"line_number":1004,"context_line":"               default\u003d1,"},{"line_number":1005,"context_line":"               help\u003d\"Size in GB a volume is extended about (volume_size +\""},{"line_number":1006,"context_line":"                    \"volume_size_extend).\"),"},{"line_number":1007,"context_line":"    cfg.ListOpt(\u0027manage_volume_ref\u0027,"},{"line_number":1008,"context_line":"                default\u003d[\u0027source-name\u0027, \u0027volume-%s\u0027],"},{"line_number":1009,"context_line":"                help\u003d\"A reference to existing volume for volume manage. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"faacb2df_bd3ca468","line":1006,"in_reply_to":"3ac69577_72bf2eda","updated":"2021-06-28 20:47:12.000000000","message":"Agree with Luigi about \"extend about\". \nProbably \"extend by\" will be more natural.","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"93c2045c1aa1a8a418b669f5c6911a32106726ae","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    cfg.IntOpt(\u0027chunk_size\u0027,"},{"line_number":1004,"context_line":"               default\u003d1,"},{"line_number":1005,"context_line":"               help\u003d\"Size in GB a volume is extended about (volume_size +\""},{"line_number":1006,"context_line":"                    \"volume_size_extend).\"),"},{"line_number":1007,"context_line":"    cfg.ListOpt(\u0027manage_volume_ref\u0027,"},{"line_number":1008,"context_line":"                default\u003d[\u0027source-name\u0027, \u0027volume-%s\u0027],"},{"line_number":1009,"context_line":"                help\u003d\"A reference to existing volume for volume manage. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac69577_72bf2eda","line":1006,"in_reply_to":"5db4b302_e8c939ca","updated":"2021-06-28 19:46:55.000000000","message":"as I\u0027m rereading all the descriptions, volume_size_extend makes more sense - it\u0027s up to user to consider the chunk size of the tested system.\n\nuse case:\nsystem\u0027s chunk size is 4 and a user wants the tests in question to make the second volume 8 GBs bigger ... if the option was called chunk_size, the user could be confused and set the chunk_size to 4 instead of 8 ... therefore volume_size_extend makes more sense.","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"05e727fc8b6dafed57e97a614dd8dafa312af10e","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    cfg.IntOpt(\u0027chunk_size\u0027,"},{"line_number":1004,"context_line":"               default\u003d1,"},{"line_number":1005,"context_line":"               help\u003d\"Size in GB a volume is extended about (volume_size +\""},{"line_number":1006,"context_line":"                    \"volume_size_extend).\"),"},{"line_number":1007,"context_line":"    cfg.ListOpt(\u0027manage_volume_ref\u0027,"},{"line_number":1008,"context_line":"                default\u003d[\u0027source-name\u0027, \u0027volume-%s\u0027],"},{"line_number":1009,"context_line":"                help\u003d\"A reference to existing volume for volume manage. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"b8c73e9f_7ed8a8ac","line":1006,"in_reply_to":"faacb2df_bd3ca468","updated":"2021-06-29 07:02:36.000000000","message":"thanks!","commit_id":"b7b89007f89ffbbe0dcda591412748ea8f1447b2"}]}