)]}'
{"tempest/api/network/admin/test_provider_network_extension.py":[{"author":{"_account_id":7827,"name":"Zhang Gong","email":"gong.zhang.bj@gmail.com","username":"zhanggbj"},"change_message_id":"302e026577ca3c25663ff62a8811fb4d1e31f5ce","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        is \u0027vlan\u0027"},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setUpClass(cls):"},{"line_number":54,"context_line":"        super(NetworkProviderExtJSON, cls).setUpClass()"},{"line_number":55,"context_line":"        if not test.is_extension_enabled(\u0027provider\u0027, \u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2BqeQ%3D","line":52,"updated":"2014-03-25 07:53:30.000000000","message":"Should we add a decorator here to avoid resource leaking if an error occurs in setUpClass()?\nFor example, add \"@test.safe_setup\" as https://review.openstack.org/#/c/82427/ did.","commit_id":"9de0dedac219bf1f284cf5a9b4c555bad39578d6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"af4035d7fc1c0658b245d0aa6a0ce9b37b152f9c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":91,"context_line":"        updated_net \u003d body[\u0027network\u0027]"},{"line_number":92,"context_line":"        self.assertEqual(updated_net[\u0027name\u0027], new_name)"},{"line_number":93,"context_line":"        # Delete network"},{"line_number":94,"context_line":"        resp, body \u003d self.admin_client.delete_network(net_id)"},{"line_number":95,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fikw%3D","line":93,"updated":"2014-03-17 07:58:54.000000000","message":"I think that you should add \"delete\" to the name of test, like test_create_update_delete_local_network_with_provider_attributes. May be it is better to add more checks for deletion like that it is not in the list of networks.","commit_id":"9de0dedac219bf1f284cf5a9b4c555bad39578d6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"af4035d7fc1c0658b245d0aa6a0ce9b37b152f9c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":117,"context_line":"        updated_net \u003d body[\u0027network\u0027]"},{"line_number":118,"context_line":"        self.assertEqual(updated_net[\u0027name\u0027], new_name)"},{"line_number":119,"context_line":"        # Delete network"},{"line_number":120,"context_line":"        resp, body \u003d self.admin_client.delete_network(net_id)"},{"line_number":121,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fij8%3D","line":119,"updated":"2014-03-17 07:58:54.000000000","message":"the same as above","commit_id":"9de0dedac219bf1f284cf5a9b4c555bad39578d6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"af4035d7fc1c0658b245d0aa6a0ce9b37b152f9c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        networks \u003d body[\u0027networks\u0027]"},{"line_number":140,"context_line":"        found \u003d None"},{"line_number":141,"context_line":"        for n in networks:"},{"line_number":142,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d self.network[\u0027id\u0027]):"},{"line_number":143,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":144,"context_line":"                self.assertEqual(n[\u0027provider:network_type\u0027],"},{"line_number":145,"context_line":"                                 self.provider_net_type)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fimk%3D","line":142,"updated":"2014-03-17 07:58:54.000000000","message":"Why do you use parentheses here? They are unnecessary.","commit_id":"9de0dedac219bf1f284cf5a9b4c555bad39578d6"}]}