)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"b5bd2d41b881ae9327a905b8a92e77d9c1180e05","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerrit Code Review \u003creview@openstack.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-18 11:23:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network Firewall API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements netwrok firewall API test for -"},{"line_number":10,"context_line":"firewall-policy-insert-rule API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAWH%2F%2FPfY%3D","line":7,"updated":"2014-03-19 06:42:36.000000000","message":"As this  change add tests to this https://review.openstack.org/78857, may be it is better to name it \"Network Firewall API tests (part 2)\"?","commit_id":"4799829276e03b693fab7ca76c25a6e71a7d90e9"}],"tempest/api/network/test_fwaas_extensions.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8e161b981fb77a7c076a978e16d182f9c053050b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":242,"context_line":"        fw_rule_id \u003d fw_rule[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":243,"context_line":"        self.addCleanup(self.client.delete_firewall_rule, fw_rule_id)"},{"line_number":244,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":245,"context_line":"        # Create firewall policy"},{"line_number":246,"context_line":"        resp, fw_policy \u003d self.client.create_firewall_policy("},{"line_number":247,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3iM%3D","line":244,"updated":"2014-03-13 09:29:36.000000000","message":"status code checking should be close to api call.","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"34b5a08d1e0e91998b500d27216149a054b0e51b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":242,"context_line":"        fw_rule_id \u003d fw_rule[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":243,"context_line":"        self.addCleanup(self.client.delete_firewall_rule, fw_rule_id)"},{"line_number":244,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":245,"context_line":"        # Create firewall policy"},{"line_number":246,"context_line":"        resp, fw_policy \u003d self.client.create_firewall_policy("},{"line_number":247,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2ls%3D","line":244,"in_reply_to":"AAAAWH%2F%2F3iM%3D","updated":"2014-03-13 11:14:00.000000000","message":"Will do in next patch","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8e161b981fb77a7c076a978e16d182f9c053050b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":249,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":250,"context_line":"        self.addCleanup(self.client.delete_firewall_policy, fw_policy_id)"},{"line_number":251,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":252,"context_line":"        # Insert firewall rule in policy"},{"line_number":253,"context_line":"        resp, body \u003d self.client.insert_firewall_rule_in_policy(fw_rule_id,"},{"line_number":254,"context_line":"                                                                fw_policy_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3iI%3D","line":251,"updated":"2014-03-13 09:29:36.000000000","message":"ditto","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"34b5a08d1e0e91998b500d27216149a054b0e51b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        fw_policy \u003d fw_policy[\u0027firewall_policy\u0027]"},{"line_number":249,"context_line":"        fw_policy_id \u003d fw_policy[\u0027id\u0027]"},{"line_number":250,"context_line":"        self.addCleanup(self.client.delete_firewall_policy, fw_policy_id)"},{"line_number":251,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":252,"context_line":"        # Insert firewall rule in policy"},{"line_number":253,"context_line":"        resp, body \u003d self.client.insert_firewall_rule_in_policy(fw_rule_id,"},{"line_number":254,"context_line":"                                                                fw_policy_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2lk%3D","line":251,"in_reply_to":"AAAAWH%2F%2F3iI%3D","updated":"2014-03-13 11:14:00.000000000","message":"ditto","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8e161b981fb77a7c076a978e16d182f9c053050b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":257,"context_line":"        self.assertEqual(fw_policy[\u0027tenant_id\u0027], body[\u0027tenant_id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(fw_policy[\u0027shared\u0027], body[\u0027shared\u0027])"},{"line_number":259,"context_line":"        self.assertEqual(fw_policy[\u0027audited\u0027], body[\u0027audited\u0027])"},{"line_number":260,"context_line":"        # Remove firewall rule from policy"},{"line_number":261,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":262,"context_line":"                                                                  fw_policy_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3g8%3D","line":259,"updated":"2014-03-13 09:29:36.000000000","message":"here should add check to make sure rule is added using get method.","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"34b5a08d1e0e91998b500d27216149a054b0e51b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":257,"context_line":"        self.assertEqual(fw_policy[\u0027tenant_id\u0027], body[\u0027tenant_id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(fw_policy[\u0027shared\u0027], body[\u0027shared\u0027])"},{"line_number":259,"context_line":"        self.assertEqual(fw_policy[\u0027audited\u0027], body[\u0027audited\u0027])"},{"line_number":260,"context_line":"        # Remove firewall rule from policy"},{"line_number":261,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":262,"context_line":"                                                                  fw_policy_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2kk%3D","line":259,"in_reply_to":"AAAAWH%2F%2F3g8%3D","updated":"2014-03-13 11:14:00.000000000","message":"I had done this piece of coding but, here I don\u0027t know why created body goes in status \"PENDING_CREATE\".\nI had also put a check to wait until ACTIVE but it does not go in \"ACTIVE\" state for too long time in any attempt. So I have to remove it.","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"8e161b981fb77a7c076a978e16d182f9c053050b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":262,"context_line":"                                                                  fw_policy_id)"},{"line_number":263,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":264,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3hk%3D","line":264,"updated":"2014-03-13 09:29:36.000000000","message":"here need a check to make sure fw_rule_id is really removed.","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"34b5a08d1e0e91998b500d27216149a054b0e51b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":262,"context_line":"                                                                  fw_policy_id)"},{"line_number":263,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":264,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2jg%3D","line":264,"in_reply_to":"AAAAWH%2F%2F3hk%3D","updated":"2014-03-13 11:14:00.000000000","message":"In case of deletion I had also added a piece of code to check for actually deletion.\nBut here after delete status goes in \"PENDING_DELETE\". So I had to drop it also.","commit_id":"93d372d35b67270413a2e262d7c9408914d026e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e5cd95b0dd553d8079863b214cce5e3a3fcbd69","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        resp, body \u003d self.client.insert_firewall_rule_in_policy(fw_rule_id,"},{"line_number":224,"context_line":"                                                                fw_policy_id)"},{"line_number":225,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":226,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":227,"context_line":"        self.assertEqual(fw_policy[\u0027tenant_id\u0027], body[\u0027tenant_id\u0027])"},{"line_number":228,"context_line":"        self.assertEqual(fw_policy[\u0027shared\u0027], body[\u0027shared\u0027])"},{"line_number":229,"context_line":"        self.assertEqual(fw_policy[\u0027audited\u0027], body[\u0027audited\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FQI4%3D","line":226,"updated":"2014-03-19 08:29:32.000000000","message":"same comment as in patch2 given by Liu.\nCan you please investigate why it is going to ACTIVE and at least show method should contain the rule. That check is needed here.","commit_id":"4799829276e03b693fab7ca76c25a6e71a7d90e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e5cd95b0dd553d8079863b214cce5e3a3fcbd69","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        self.assertEqual(fw_policy[\u0027tenant_id\u0027], body[\u0027tenant_id\u0027])"},{"line_number":228,"context_line":"        self.assertEqual(fw_policy[\u0027shared\u0027], body[\u0027shared\u0027])"},{"line_number":229,"context_line":"        self.assertEqual(fw_policy[\u0027audited\u0027], body[\u0027audited\u0027])"},{"line_number":230,"context_line":"        # Remove firewall rule from policy"},{"line_number":231,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":232,"context_line":"                                                                  fw_policy_id)"},{"line_number":233,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FQJM%3D","line":230,"updated":"2014-03-19 08:29:32.000000000","message":"convert these assert into for loop. same as https://review.openstack.org/#/c/78857/10/tempest/api/network/test_fwaas_extensions.py.","commit_id":"4799829276e03b693fab7ca76c25a6e71a7d90e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e5cd95b0dd553d8079863b214cce5e3a3fcbd69","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        # Remove firewall rule from policy"},{"line_number":231,"context_line":"        resp, body \u003d self.client.remove_firewall_rule_from_policy(fw_rule_id,"},{"line_number":232,"context_line":"                                                                  fw_policy_id)"},{"line_number":233,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":234,"context_line":"        self.assertEqual(fw_policy_id, body[\u0027id\u0027])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FQI0%3D","line":233,"updated":"2014-03-19 08:29:32.000000000","message":"same as L226.","commit_id":"4799829276e03b693fab7ca76c25a6e71a7d90e9"}]}