)]}'
{"tempest/api/identity/base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"527cb886ae28d44ea0961468d463dc206375fed2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                func(id)"},{"line_number":182,"context_line":"            except Exception:"},{"line_number":183,"context_line":"                pass"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        def teardown_all(self):"},{"line_number":186,"context_line":"            for user in self.users:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fx34%3D","line":183,"updated":"2014-03-13 21:16:00.000000000","message":"I would prefer instead that you catch NotFound exceptions specifically (and pass on them), and for a generic except Exception block, at a minimum, issue a LOG.warning() with the exception text.","commit_id":"f15aa0f8ec3c83bc5835d8feaca45292dbb743fa"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c3ba830277d122906d40e421c0fbd567a4128721","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                func(id)"},{"line_number":182,"context_line":"            except Exception:"},{"line_number":183,"context_line":"                pass"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        def teardown_all(self):"},{"line_number":186,"context_line":"            for user in self.users:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FwFA%3D","line":183,"in_reply_to":"AAAAWH%2F%2Fx34%3D","updated":"2014-03-14 02:09:58.000000000","message":"Sure. make sense to me. I\u0027ll fix in the next patch-set.","commit_id":"f15aa0f8ec3c83bc5835d8feaca45292dbb743fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a969d50c3ad98b73cab9e3391b2b5ab4499398a0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                try:"},{"line_number":185,"context_line":"                    func(item[\u0027id\u0027])"},{"line_number":186,"context_line":"                except exceptions.NotFound:"},{"line_number":187,"context_line":"                    LOG.debug(\"%s is not found.\" % item[\u0027id\u0027])"},{"line_number":188,"context_line":"                    pass"},{"line_number":189,"context_line":"                except Exception as exc:"},{"line_number":190,"context_line":"                    LOG.warning(\"Unexpected exception occurred in %s deletion.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvrY%3D","line":187,"updated":"2014-03-14 03:10:37.000000000","message":"I actually think this log line is just noise (since we actually expect the item to be gone, right?). Might be best to just pass here with no log message. What do you think?","commit_id":"5152202b5ea97e63b2ca7f4f05261d97e2874ae5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ec48b797c7a547f1fff629ade799c45a2b4d9645","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                try:"},{"line_number":185,"context_line":"                    func(item[\u0027id\u0027])"},{"line_number":186,"context_line":"                except exceptions.NotFound:"},{"line_number":187,"context_line":"                    LOG.debug(\"%s is not found.\" % item[\u0027id\u0027])"},{"line_number":188,"context_line":"                    pass"},{"line_number":189,"context_line":"                except Exception as exc:"},{"line_number":190,"context_line":"                    LOG.warning(\"Unexpected exception occurred in %s deletion.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Fvmg%3D","line":187,"in_reply_to":"AAAAWH%2F%2FvrY%3D","updated":"2014-03-14 03:25:31.000000000","message":"I agree with you. Indeed, this is just noise for debugging. I\u0027ll remove this.","commit_id":"5152202b5ea97e63b2ca7f4f05261d97e2874ae5"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9f5a8021446bb724b5b1597707f2fb3df0b65e8a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            except Exception as exc:"},{"line_number":188,"context_line":"                LOG.warning(\"Unexpected exception occurred in %s deletion.\""},{"line_number":189,"context_line":"                            \" But ignored here.\" % item[\u0027id\u0027])"},{"line_number":190,"context_line":"                LOG.exception(exc)"},{"line_number":191,"context_line":"                pass"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        def teardown_all(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bad4c104_d62479c8","line":190,"updated":"2014-04-29 13:06:44.000000000","message":"LOG.exception isn\u0027t used this way. It automatically logs the exception. So replace the LOG.warning with it instead.","commit_id":"3a8815a0afa0dda1608dfcafa54af35b02f65b9c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ce8933995cfce57ebef1bcbbe364cd76c87cbe07","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                LOG.warning(\"Unexpected exception occurred in %s deletion.\""},{"line_number":189,"context_line":"                            \" But ignored here.\" % item[\u0027id\u0027])"},{"line_number":190,"context_line":"                LOG.exception(exc)"},{"line_number":191,"context_line":"                pass"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        def teardown_all(self):"},{"line_number":194,"context_line":"            # NOTE(masayukig): v3 client doesn\u0027t have v2 method."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FsMw%3D","line":191,"updated":"2014-04-11 05:28:44.000000000","message":"The pass is not required here.","commit_id":"3a8815a0afa0dda1608dfcafa54af35b02f65b9c"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"d3be90a1453e3964195390ca413424b1e3fde3e4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                LOG.warning(\"Unexpected exception occurred in %s deletion.\""},{"line_number":189,"context_line":"                            \" But ignored here.\" % item[\u0027id\u0027])"},{"line_number":190,"context_line":"                LOG.exception(exc)"},{"line_number":191,"context_line":"                pass"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        def teardown_all(self):"},{"line_number":194,"context_line":"            # NOTE(masayukig): v3 client doesn\u0027t have v2 method."}],"source_content_type":"text/x-python","patch_set":7,"id":"bad4c104_009f7b60","line":191,"in_reply_to":"AAAAW3%2F%2FsMw%3D","updated":"2014-04-29 11:47:02.000000000","message":"+1","commit_id":"3a8815a0afa0dda1608dfcafa54af35b02f65b9c"}]}