)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29f8b2e507368306c4a2bb43dd7a51ab02554d97","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        # Create a server with scheduler hints."},{"line_number":191,"context_line":"        hints \u003d {"},{"line_number":192,"context_line":"            \u0027build_near_host_ip\u0027: \u0027127.0.0.1\u0027,"},{"line_number":193,"context_line":"            \u0027cidr\u0027: \u00278\u0027"},{"line_number":194,"context_line":"        }"},{"line_number":195,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"},{"line_number":196,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2B%2Fis%3D","line":193,"updated":"2014-03-21 05:23:11.000000000","message":"Here should be\n\n \u0027cidr\u0027: \u0027/8\u0027\n\nbecause of\n\nnova/scheduler/filters/affinity_filter.py\n 89         affinity_cidr \u003d scheduler_hints.get(\u0027cidr\u0027, \u0027/24\u0027)\n 90         affinity_host_addr \u003d scheduler_hints.get(\u0027build_near_host_ip\u0027)\n 91         host_ip \u003d host_state.host_ip\n 92         if affinity_host_addr:\n 93             affinity_net \u003d netaddr.IPNetwork(str.join(\u0027\u0027, (affinity_host_addr,\n 94                                                            affinity_cidr)))\n\nbuild_near_host_ip and cidr are joined without \"/\".\n\nIn addition, this schedle(SimpleCIDRAffinityFilter) is a little difficult and the gate does not use it in the default. so how about SameHostFilter?\n\n         hints \u003d {\n            \u0027same_host\u0027: self.s1_id\n         }\n\nSameHostFilter also is not used in the gate but it is easier.","commit_id":"a2b781fcb6df08ff94d7a8d5345307eb2530b801"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8eac271354127448777c85ca8077cdb70e56e7bd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def test_create_server_with_scheduling_hint(self):"},{"line_number":116,"context_line":"        # Create a server with scheduler hints."},{"line_number":117,"context_line":"        hints \u003d {"},{"line_number":118,"context_line":"            \u0027build_near_host_ip\u0027: \u0027192.168.3.1\u0027,"},{"line_number":119,"context_line":"            \u0027cidr\u0027: \u002724\u0027"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6to%3D","line":118,"updated":"2014-03-12 23:50:16.000000000","message":"Is it no problem to specify non-existent ip address here?","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"dea8ac878fd078da1e323ddcca463b6363785437","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def test_create_server_with_scheduling_hint(self):"},{"line_number":116,"context_line":"        # Create a server with scheduler hints."},{"line_number":117,"context_line":"        hints \u003d {"},{"line_number":118,"context_line":"            \u0027build_near_host_ip\u0027: \u0027192.168.3.1\u0027,"},{"line_number":119,"context_line":"            \u0027cidr\u0027: \u002724\u0027"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F5ms%3D","line":118,"in_reply_to":"AAAAWH%2F%2F6to%3D","updated":"2014-03-13 02:53:17.000000000","message":"Will confirm in next patch.","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2a0e8419dd74cbdd292d590f4467fa02c5b8656d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"},{"line_number":122,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fxow%3D","line":123,"updated":"2014-03-13 21:47:28.000000000","message":"This needs to assert more than just 202 Accepted is returned. We need to assert that the server was indeed created near 192.168.3.1 host, but there\u0027s no real way to test that using the API :(. In addition, this is an admin-only operation, so shouldn\u0027t this be in the admin tests?","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"25b3c9341e041b96709726ae61571fa1edca3fe8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"},{"line_number":122,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FqlY%3D","line":123,"in_reply_to":"AAAAWH%2F%2Fqn4%3D","updated":"2014-03-14 16:06:00.000000000","message":"Ok, I will move this under admin in patch#4","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"42c9b9ef5b0f22ea67a5eba9945336d95fe427ea","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"},{"line_number":122,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fqn4%3D","line":123,"in_reply_to":"AAAAWH%2F%2FtPc%3D","updated":"2014-03-14 15:59:52.000000000","message":"No non-admin would have access to know what a host IP address was in the system. Therefore, by nature, this is an admin-only operation.","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"75fda03cd1373b001d7daf4fae86e8e2c1796223","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        resp, server \u003d self.create_test_server(sched_hints\u003dhints,"},{"line_number":122,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FtPc%3D","line":123,"in_reply_to":"AAAAWH%2F%2Fxow%3D","updated":"2014-03-14 10:36:43.000000000","message":"Actually returned body does not show information of scheduler hint so check will be tough using API.\nI think this not admin only operation because I see here - \nhttps://github.com/openstack/nova/blob/master/etc/nova/policy.json#L206\n\n\"compute_extension:v3:os-scheduler-hints:discoverable\": \"\"","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8eac271354127448777c85ca8077cdb70e56e7bd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                       \u0027availability_zone\u0027, \u0027accessIPv4\u0027, \u0027accessIPv6\u0027,"},{"line_number":68,"context_line":"                       \u0027min_count\u0027, \u0027max_count\u0027, (\u0027metadata\u0027, \u0027meta\u0027),"},{"line_number":69,"context_line":"                       (\u0027OS-DCF:diskConfig\u0027, \u0027disk_config\u0027),"},{"line_number":70,"context_line":"                       (\u0027os:scheduler_hints\u0027, \u0027sched_hints\u0027),"},{"line_number":71,"context_line":"                       \u0027return_reservation_id\u0027]:"},{"line_number":72,"context_line":"            if isinstance(option, tuple):"},{"line_number":73,"context_line":"                post_param \u003d option[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6qI%3D","line":70,"updated":"2014-03-12 23:50:16.000000000","message":"This position is not right.\nscheduer_hint\u0027 position is the same as \u0027server\u0027 like the following:\n\n {\n    \"server\": {\n        \"name\": \"new-server-test\",\n        \"imageRef\": \"70a599e0-31e7-49b7-b260-868f441e862b\",\n        \"flavorRef\": \"1\"\n    },\n    \"os:scheduler_hints\": {\n        \"hypervisor\": \"xen\",\n        \"near\": \"2b7c42eb-7736-4a0f-afab-f23969a35ada\"\n    }\n }\n\nCurrent this patch creates:\n\n {\n    \"server\": {\n        \"name\": \"new-server-test\",\n        \"imageRef\": \"70a599e0-31e7-49b7-b260-868f441e862b\",\n        \"flavorRef\": \"1\",\n        \"os:scheduler_hints\": {\n            \"hypervisor\": \"xen\",\n            \"near\": \"2b7c42eb-7736-4a0f-afab-f23969a35ada\"\n        }\n    }\n }\n\nNova API ignores current scheduler_hints and works now.","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"dea8ac878fd078da1e323ddcca463b6363785437","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                       \u0027availability_zone\u0027, \u0027accessIPv4\u0027, \u0027accessIPv6\u0027,"},{"line_number":68,"context_line":"                       \u0027min_count\u0027, \u0027max_count\u0027, (\u0027metadata\u0027, \u0027meta\u0027),"},{"line_number":69,"context_line":"                       (\u0027OS-DCF:diskConfig\u0027, \u0027disk_config\u0027),"},{"line_number":70,"context_line":"                       (\u0027os:scheduler_hints\u0027, \u0027sched_hints\u0027),"},{"line_number":71,"context_line":"                       \u0027return_reservation_id\u0027]:"},{"line_number":72,"context_line":"            if isinstance(option, tuple):"},{"line_number":73,"context_line":"                post_param \u003d option[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F5m8%3D","line":70,"in_reply_to":"AAAAWH%2F%2F6qI%3D","updated":"2014-03-13 02:53:17.000000000","message":"Yes you are right, In next patch I will correct it.","commit_id":"b4e9ffc8fb994098b5ab686b834e99ab41cf226f"}]}