)]}'
{"tempest/api/volume/admin/test_group_types.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4ea3f2aadad7813fff08e870b3e4fa99b082062b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    @decorators.idempotent_id(\u00272eb459f0-97f0-4789-a0e6-35c08159bb90\u0027)"},{"line_number":69,"context_line":"    def test_group_type_delete(self):"},{"line_number":70,"context_line":"        \"\"\"Test delete group type\"\"\""},{"line_number":71,"context_line":"        name \u003d data_utils.rand_name(\"group-type\")"},{"line_number":72,"context_line":"        description \u003d data_utils.rand_name(\"group-type-description\")"},{"line_number":73,"context_line":"        group_specs \u003d {\"consistent_group_snapshot_enabled\": \"\u003cis\u003e False\"}"},{"line_number":74,"context_line":"        params \u003d {\u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"60810052_a3b3a283","line":71,"range":{"start_line":71,"start_character":36,"end_line":71,"end_character":48},"updated":"2021-08-30 08:03:48.000000000","message":"this could be (self.__class__.__name__ + \u0027-group-type\u0027) as it\u0027s in the test above just to keep it consistent","commit_id":"9bca434a78704881158b55ea8814a3636cb4eed5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4ea3f2aadad7813fff08e870b3e4fa99b082062b","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                  \u0027is_public\u0027: True}"},{"line_number":78,"context_line":"        group_type_id \u003d self.admin_group_types_client.create_group_type("},{"line_number":79,"context_line":"            **params)[\u0027group_type\u0027][\u0027id\u0027]"},{"line_number":80,"context_line":"        self.admin_group_types_client.delete_group_type(group_type_id)"},{"line_number":81,"context_line":"        group_list \u003d ("},{"line_number":82,"context_line":"            self.admin_group_types_client.list_group_types()[\u0027group_types\u0027])"},{"line_number":83,"context_line":"        group_ids \u003d [it[\u0027id\u0027] for it in group_list]"},{"line_number":84,"context_line":"        self.assertNotIn(group_type_id, group_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e61148e5_8748d30a","line":84,"range":{"start_line":80,"start_character":8,"end_line":84,"end_character":50},"updated":"2021-08-30 08:03:48.000000000","message":"basically just these 5 lines is different from the test above, what about appending these lines to the above tests and renaming it (well, adding \"_delete\" suffix to the name)? - modifying the test shouldn\u0027t be a problem in this case, especially when it just extends it (no current logic is modified) - plus the test would be extended about a check which has been done anyway (in the tearDown methods)\n\nThe test is also not a part of interop: https://codesearch.opendev.org/?q\u003ddd71e5f9-393e-4d4f-90e9-fa1b8d278864\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"9bca434a78704881158b55ea8814a3636cb4eed5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed6a85d6363e765a60fad150605537541670c697","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                  \u0027is_public\u0027: True}"},{"line_number":78,"context_line":"        group_type_id \u003d self.admin_group_types_client.create_group_type("},{"line_number":79,"context_line":"            **params)[\u0027group_type\u0027][\u0027id\u0027]"},{"line_number":80,"context_line":"        self.admin_group_types_client.delete_group_type(group_type_id)"},{"line_number":81,"context_line":"        group_list \u003d ("},{"line_number":82,"context_line":"            self.admin_group_types_client.list_group_types()[\u0027group_types\u0027])"},{"line_number":83,"context_line":"        group_ids \u003d [it[\u0027id\u0027] for it in group_list]"},{"line_number":84,"context_line":"        self.assertNotIn(group_type_id, group_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c55f2b7c_7f7444fd","line":84,"range":{"start_line":80,"start_character":8,"end_line":84,"end_character":50},"in_reply_to":"e61148e5_8748d30a","updated":"2021-09-29 02:43:53.000000000","message":"+1, this is admin test so ok to add operation operation in existing tests","commit_id":"9bca434a78704881158b55ea8814a3636cb4eed5"}]}