)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- Created a volume snapshot and delete it before reboot instance"},{"line_number":14,"context_line":"- Write data to the attached volume and read post instance reboot."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Covers https://bugs.launchpad.net/cinder/+bug/1860913"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4151715954b3a12e6c790836d4b7bd50c0407720"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"015dc173_91defed8","line":16,"updated":"2021-10-06 15:32:03.000000000","message":"Change to\n\nRelated-Bug: #1860913","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4d8e9c7c903140f22e9ec7fca8c006cca539666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c7eafd8_d43a92dc","updated":"2021-11-08 23:17:15.000000000","message":"recheck to get fresh logs","commit_id":"46bff71adb612f1187b37e7f290dd2e48786c5d6"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8fb61a65c25e1543240fb5991bfca923062482e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cce9004_95fe799d","updated":"2022-01-26 07:03:43.000000000","message":"Any progress ? ","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"062bf3fbdf9b9fe66b0f2287e5ca9a4a0a412394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"44082ea3_1486fdf6","updated":"2021-12-13 09:20:52.000000000","message":"I only rebased it","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"878e57648124e83ec62af063e9c0ef3ab85aa6bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6883c2c0_e5ea25fa","updated":"2022-05-17 22:26:26.000000000","message":"lgtm, test running fine and in 88 sec\n\nhttps://zuul.opendev.org/t/openstack/build/85d5c4426c1c4c82b40e423e70307cef/log/job-output.txt#25982","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"de08d908e8067132c39e4095f620deb5e5cea7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa8cb18f_0961b044","updated":"2022-06-24 10:47:48.000000000","message":"lgtm, the test passes fine, let\u0027s proceed","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"124817f8b3220b97e11bf1882b656760501ccb5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fe6d2036_0ece5845","updated":"2022-06-15 12:08:07.000000000","message":"recheck","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"703d6a58fba17cb1157093a74c7ffcf3f5f126cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c95052e_a74150e7","updated":"2022-05-18 02:14:11.000000000","message":"recheck detach volume timeout ","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9fba01c36bcddf662050ad0c52b6834c2793f469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"abd9f065_fdb7d750","updated":"2022-05-11 15:31:42.000000000","message":"recheck refresh the log","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8306bd07b14e21c842c23d7170b69f9731167f24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8b5d746c_f5ed1253","updated":"2022-05-17 22:26:34.000000000","message":"recheck volume detach issue","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8fb61a65c25e1543240fb5991bfca923062482e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5fff7de2_3a280c94","in_reply_to":"44082ea3_1486fdf6","updated":"2022-01-26 07:03:43.000000000","message":"thanks !","commit_id":"d4d49b0a4b4822f407e48a2dc7999b9392ff0eea"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d152ed44506a45193dd991a1796a27cfc3e79a4a","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestMinimumBasicScenario(manager.ScenarioTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\"This is a basic minimum scenario test."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"be7e7a59_f1629189","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":30},"updated":"2021-08-12 09:14:51.000000000","message":"Is this really the right place to test something as involved as volume snapshots?","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8ce8cb96142984e6960cb21c29b2e8ceeb04fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestMinimumBasicScenario(manager.ScenarioTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\"This is a basic minimum scenario test."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ce3e2fb2_b0eb5c1d","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":30},"in_reply_to":"be7e7a59_f1629189","updated":"2021-08-19 12:19:29.000000000","message":"well arguably cinder should not be invovled in this at all.\n\na min basic senario test should just be \n\n\n    1. Create image\n    2. Create keypair\n    3. Boot instance with keypair and get list of instances\n    6. Add IP to instance\n    7. Create and add security group to instance\n    8. Check SSH connection to instance\n\nthe reboot and volume parts are not part of a minium test.\n\nthey are part of basic tests but not min basic.","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d152ed44506a45193dd991a1796a27cfc3e79a4a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    * check command outputs"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Steps:"},{"line_number":39,"context_line":"    1. Create image"},{"line_number":40,"context_line":"    2. Create keypair"},{"line_number":41,"context_line":"    3. Boot instance with keypair and get list of instances"},{"line_number":42,"context_line":"    4. Create volume and show list of volumes"},{"line_number":43,"context_line":"    5. Attach volume to instance and getlist of volumes"},{"line_number":44,"context_line":"    6. Create a snapshot from volume"},{"line_number":45,"context_line":"    7. Add IP to instance"},{"line_number":46,"context_line":"    8. Create and add security group to instance"},{"line_number":47,"context_line":"    9. Check SSH connection to instance"},{"line_number":48,"context_line":"    10. Write data timestamp to the attached volume"},{"line_number":49,"context_line":"    11. Delete volume snapshot before reboot instance"},{"line_number":50,"context_line":"    12. Reboot instance (HARD)"},{"line_number":51,"context_line":"    13. Check SSH connection to instance after reboot"},{"line_number":52,"context_line":"    14. Verify attached disk data timestamp post instance reboot"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f8eb0747_dd6a0526","line":52,"range":{"start_line":39,"start_character":0,"end_line":52,"end_character":64},"updated":"2021-08-12 09:14:51.000000000","message":"Overall the steps appear valid but I still question stuffing this into this test class.","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8ce8cb96142984e6960cb21c29b2e8ceeb04fb","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    * check command outputs"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Steps:"},{"line_number":39,"context_line":"    1. Create image"},{"line_number":40,"context_line":"    2. Create keypair"},{"line_number":41,"context_line":"    3. Boot instance with keypair and get list of instances"},{"line_number":42,"context_line":"    4. Create volume and show list of volumes"},{"line_number":43,"context_line":"    5. Attach volume to instance and getlist of volumes"},{"line_number":44,"context_line":"    6. Create a snapshot from volume"},{"line_number":45,"context_line":"    7. Add IP to instance"},{"line_number":46,"context_line":"    8. Create and add security group to instance"},{"line_number":47,"context_line":"    9. Check SSH connection to instance"},{"line_number":48,"context_line":"    10. Write data timestamp to the attached volume"},{"line_number":49,"context_line":"    11. Delete volume snapshot before reboot instance"},{"line_number":50,"context_line":"    12. Reboot instance (HARD)"},{"line_number":51,"context_line":"    13. Check SSH connection to instance after reboot"},{"line_number":52,"context_line":"    14. Verify attached disk data timestamp post instance reboot"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ad403c45_379b7154","line":52,"range":{"start_line":39,"start_character":0,"end_line":52,"end_character":64},"in_reply_to":"f8eb0747_dd6a0526","updated":"2021-08-19 12:19:29.000000000","message":"ya i kind of agree that they should be done in a spereate test case","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d152ed44506a45193dd991a1796a27cfc3e79a4a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                got_volume, excluded_keys\u003dexcluded_keys))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def nova_reboot(self, server, hard\u003dFalse):"},{"line_number":75,"context_line":"        self.servers_client.reboot_server(server[\u0027id\u0027],"},{"line_number":76,"context_line":"                                          type\u003d\"HARD\" if hard else \"SOFT\")"},{"line_number":77,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":78,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"55088487_06415a6d","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":74},"updated":"2021-08-12 09:14:51.000000000","message":"style nit \n\n  self.servers_client.reboot_server(\n      server[\u0027id\u0027], type\u003d\"HARD\" if hard else \"SOFT\")","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d152ed44506a45193dd991a1796a27cfc3e79a4a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                        address[\u0027addr\u0027] \u003d\u003d floating_ip[\u0027floating_ip_address\u0027]):"},{"line_number":109,"context_line":"                    return address"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":112,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":113,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":114,"context_line":"        image \u003d self.image_create()"},{"line_number":115,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"264b8d7d_18b63486","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":42},"updated":"2021-08-12 09:14:51.000000000","message":"I wonder if this also needs a skipUnless decorator for run_validation as I\u0027ve suggested for test_network_basic_ops in I585c34aeefb46f2fe08c64b6240b1b8ccde6017f","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"b014574affe9364f47a21d3fa2bc702029bdf7da","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                        address[\u0027addr\u0027] \u003d\u003d floating_ip[\u0027floating_ip_address\u0027]):"},{"line_number":109,"context_line":"                    return address"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":112,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":113,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":114,"context_line":"        image \u003d self.image_create()"},{"line_number":115,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a229f7d4_1cfb5394","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":42},"in_reply_to":"264b8d7d_18b63486","updated":"2021-08-12 11:07:22.000000000","message":"I changed the nova reboot to HARD to simulate a real reboot and added snapshot for volume , creating a new testcase will duplicate this test flow and only need to create a volume snapshot which is not a time consuming action compares with new testcase.\n\nUsually cinder driver supports snapshot .","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d28daa788a3ad70ee64ed8363e5e0717f7c88e31","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                        address[\u0027addr\u0027] \u003d\u003d floating_ip[\u0027floating_ip_address\u0027]):"},{"line_number":109,"context_line":"                    return address"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":112,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":113,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":114,"context_line":"        image \u003d self.image_create()"},{"line_number":115,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"78dcad05_d652170c","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":42},"in_reply_to":"40a4c917_c5bc1e50","updated":"2021-08-19 10:39:43.000000000","message":"ACK.","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"60467c862ba5a3ae3c090bc6498eb55ea672f501","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                        address[\u0027addr\u0027] \u003d\u003d floating_ip[\u0027floating_ip_address\u0027]):"},{"line_number":109,"context_line":"                    return address"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":112,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":113,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":114,"context_line":"        image \u003d self.image_create()"},{"line_number":115,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"40a4c917_c5bc1e50","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":42},"in_reply_to":"a229f7d4_1cfb5394","updated":"2021-08-18 17:43:54.000000000","message":"for run_validation skip decorator, I commented in https://review.opendev.org/c/openstack/tempest/+/797868. for scenario test we do not need that.","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1196c88e9560dc073e7c993b4bc6e21da1e1760","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        self.cinder_show(volume)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":130,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027], force\u003dTrue)"},{"line_number":131,"context_line":"        self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":132,"context_line":"        self.cinder_show(volume)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f14ce67_6785af69","line":130,"range":{"start_line":130,"start_character":7,"end_line":130,"end_character":72},"updated":"2021-09-07 14:21:49.000000000","message":"Martin brought good point about snapshot feature. not all env has the snapshot feature available/enable so we should check it with CONF.volume_feature_enabled.snapshot config option.\n\nand if we skip the snapshot steps with this config option then it will be silently ignoring the snapshot verification but test passing which might not be noticed.\n\nWith that I think it make more sense to have it as a separate test and skip that test based on config option.","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"287f1c48131a8dd095243ee93b90facf495c1ff0","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        self.cinder_show(volume)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":130,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume[\u0027id\u0027], force\u003dTrue)"},{"line_number":131,"context_line":"        self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":132,"context_line":"        self.cinder_show(volume)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e721039e_e57053fe","line":130,"range":{"start_line":130,"start_character":7,"end_line":130,"end_character":72},"in_reply_to":"7f14ce67_6785af69","updated":"2021-09-07 16:58:56.000000000","message":"Hi , \nPlease look at the requirment for cinder :\nhttps://docs.openstack.org/cinder/rocky/reference/support-matrix.html\n\nThere are a number of functions that are required to be accepted as a Cinder driver , create snapshot is one of them.  i agree that attach a volume snapshot its a feature that is not supported by all backends but its not the case here , we do not attach the snapshot.\n\n\nSo if the create_snapshot is a must for cinder driver","commit_id":"68072b98733091a5200e67e5cd46ea7e17ff3969"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \"\"\"This is a basic minimum scenario test."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This tests below:"},{"line_number":35,"context_line":"    * across the multiple components"},{"line_number":36,"context_line":"    * as a regular user"},{"line_number":37,"context_line":"    * with and without optional parameters"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce7bd0c4_1eff1b6f","line":34,"updated":"2021-10-06 15:32:03.000000000","message":"nit: if changed, \"These tests below\"","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \"\"\"This is a basic minimum scenario test."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This tests below:"},{"line_number":35,"context_line":"    * across the multiple components"},{"line_number":36,"context_line":"    * as a regular user"},{"line_number":37,"context_line":"    * with and without optional parameters"}],"source_content_type":"text/x-python","patch_set":3,"id":"d5138723_306cad0b","line":34,"in_reply_to":"ce7bd0c4_1eff1b6f","updated":"2021-10-06 16:04:44.000000000","message":"Done","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":97,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":98,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":99,"context_line":"        \"\"\"This is a basic minimum scenario multiple components"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        Steps:"},{"line_number":102,"context_line":"        1. Create image"}],"source_content_type":"text/x-python","patch_set":3,"id":"5defa3df_7d7ec47f","line":99,"updated":"2021-10-06 15:32:03.000000000","message":"nit: minimum scenario tests with multiple components","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @decorators.idempotent_id(\u0027bdbb5441-9204-419d-a225-b4fdbfb1a1a8\u0027)"},{"line_number":97,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":98,"context_line":"    def test_minimum_basic_scenario(self):"},{"line_number":99,"context_line":"        \"\"\"This is a basic minimum scenario multiple components"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        Steps:"},{"line_number":102,"context_line":"        1. Create image"}],"source_content_type":"text/x-python","patch_set":3,"id":"0773ba18_ed6ced69","line":99,"in_reply_to":"5defa3df_7d7ec47f","updated":"2021-10-06 16:04:44.000000000","message":"Done","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        floating_ip \u003d None"},{"line_number":133,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":134,"context_line":"        if (CONF.network_feature_enabled.floating_ips and"},{"line_number":135,"context_line":"                CONF.network.floating_network_name):"},{"line_number":136,"context_line":"            fip \u003d self.create_floating_ip(server)"},{"line_number":137,"context_line":"            floating_ip \u003d self.associate_floating_ip("},{"line_number":138,"context_line":"                fip, server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"acc9cba1_f6809c1f","line":135,"updated":"2021-10-06 15:32:03.000000000","message":"Uhm, if this is needed for pep8 reasons, why wasn\u0027t it noticed before?","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        floating_ip \u003d None"},{"line_number":133,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":134,"context_line":"        if (CONF.network_feature_enabled.floating_ips and"},{"line_number":135,"context_line":"                CONF.network.floating_network_name):"},{"line_number":136,"context_line":"            fip \u003d self.create_floating_ip(server)"},{"line_number":137,"context_line":"            floating_ip \u003d self.associate_floating_ip("},{"line_number":138,"context_line":"                fip, server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9105927c_3f3e8165","line":135,"in_reply_to":"acc9cba1_f6809c1f","updated":"2021-10-06 16:04:44.000000000","message":"Its a cosmetic change , no impact . hope its ok.","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            # delete the floating IP, this should refresh the server addresses"},{"line_number":171,"context_line":"            self.disassociate_floating_ip(floating_ip)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            def is_floating_ip_detached_from_server():"},{"line_number":174,"context_line":"                server_info \u003d self.servers_client.show_server("},{"line_number":175,"context_line":"                    server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":176,"context_line":"                address \u003d self._get_floating_ip_in_server_addresses("}],"source_content_type":"text/x-python","patch_set":3,"id":"34030b9d_bc888974","line":173,"updated":"2021-10-06 15:32:03.000000000","message":"this nested function is now duplicated","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            # delete the floating IP, this should refresh the server addresses"},{"line_number":171,"context_line":"            self.disassociate_floating_ip(floating_ip)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            def is_floating_ip_detached_from_server():"},{"line_number":174,"context_line":"                server_info \u003d self.servers_client.show_server("},{"line_number":175,"context_line":"                    server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":176,"context_line":"                address \u003d self._get_floating_ip_in_server_addresses("}],"source_content_type":"text/x-python","patch_set":3,"id":"72b4c701_2dd54951","line":173,"in_reply_to":"34030b9d_bc888974","updated":"2021-10-06 16:04:44.000000000","message":"Thanks , good point .fixed","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            # delete the floating IP, this should refresh the server addresses"},{"line_number":279,"context_line":"            self.disassociate_floating_ip(floating_ip)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            def is_floating_ip_detached_from_server():"},{"line_number":282,"context_line":"                server_info \u003d self.servers_client.show_server("},{"line_number":283,"context_line":"                    server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":284,"context_line":"                address \u003d self._get_floating_ip_in_server_addresses("}],"source_content_type":"text/x-python","patch_set":3,"id":"7ca00d31_db1b3e2e","line":281,"updated":"2021-10-06 15:32:03.000000000","message":"this nested function is now duplicated","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            # delete the floating IP, this should refresh the server addresses"},{"line_number":279,"context_line":"            self.disassociate_floating_ip(floating_ip)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            def is_floating_ip_detached_from_server():"},{"line_number":282,"context_line":"                server_info \u003d self.servers_client.show_server("},{"line_number":283,"context_line":"                    server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":284,"context_line":"                address \u003d self._get_floating_ip_in_server_addresses("}],"source_content_type":"text/x-python","patch_set":3,"id":"f80a1b0d_f368e18f","line":281,"in_reply_to":"7ca00d31_db1b3e2e","updated":"2021-10-06 16:04:44.000000000","message":"Done","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"429b324a7e2fba2c5f0b719f4c89fc37ca173180","unresolved":true,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if not test_utils.call_until_true("},{"line_number":289,"context_line":"                is_floating_ip_detached_from_server,"},{"line_number":290,"context_line":"                    CONF.compute.build_timeout, CONF.compute.build_interval):"},{"line_number":291,"context_line":"                msg \u003d (\"Floating IP \u0027%s\u0027 should not be in server addresses: %s\""},{"line_number":292,"context_line":"                       % (floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":293,"context_line":"                          server[\u0027addresses\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5b237ec_b1664e78","line":290,"updated":"2021-10-06 15:32:03.000000000","message":"couldn\u0027t it stay as it was before on two lines?","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9a42bdff708b03e0ae6180166668eeabf995a574","unresolved":true,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if not test_utils.call_until_true("},{"line_number":289,"context_line":"                is_floating_ip_detached_from_server,"},{"line_number":290,"context_line":"                    CONF.compute.build_timeout, CONF.compute.build_interval):"},{"line_number":291,"context_line":"                msg \u003d (\"Floating IP \u0027%s\u0027 should not be in server addresses: %s\""},{"line_number":292,"context_line":"                       % (floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":293,"context_line":"                          server[\u0027addresses\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"17b3991b_5245c0eb","line":290,"in_reply_to":"c5b237ec_b1664e78","updated":"2021-10-06 16:04:44.000000000","message":"Not sure if its critical , cosmetic","commit_id":"66fb363fdb18bdba2a438028c0f05ad5ee203dea"}]}