)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bfeef8851441068d0ece1ddf49afe944e3fb1432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60b22d48_e6ada6c2","updated":"2021-10-28 16:21:39.000000000","message":"lgtm, please add release notes also for the new lib interface. Example: https://github.com/openstack/tempest/blob/master/releasenotes/notes/add-group-type-specs-apis-to-v3-group-types-client-10390b52dedede54.yaml","commit_id":"556b574bebf34930893822ae3195e57ae706f08c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0d6d10550e729aaf58ad10f8ab6ecee560b0e472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"601b3e94_41f43083","in_reply_to":"60b22d48_e6ada6c2","updated":"2021-11-02 17:19:34.000000000","message":"Done","commit_id":"556b574bebf34930893822ae3195e57ae706f08c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7d509f92a16f1764a49a9cc13de88975d9642aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"23143857_8356410b","updated":"2021-11-04 08:43:06.000000000","message":"a few comments below, other than that, lgtm","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b563c48c3852906c785a44715789b4fc40adcd35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"13e5a7ca_803115a1","updated":"2021-11-08 22:53:08.000000000","message":"LGTM, thanks!","commit_id":"efa21d3bb915e2e9793ec5072ad8ce45356a11b1"}],"releasenotes/notes/add-qos-minimum-packet-rule-client-c8bfe09873032d4a.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0dcc08eb27b0909bd895623798e5f12cd8070507","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    * create_minimum_packet_rate_rule"},{"line_number":7,"context_line":"    * update_minimum_packet_rate_rule"},{"line_number":8,"context_line":"    * show_minimum_packet_rate_rule"},{"line_number":9,"context_line":"    * list_minimum_packet_rate_rules"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fe273ef4_9a0aada5","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":36},"updated":"2021-11-02 18:41:37.000000000","message":"delete_minimum_packet_rate_rule also","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"56872a265ea29ad8bfcb633fce0fd91fc0d0f74a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    * create_minimum_packet_rate_rule"},{"line_number":7,"context_line":"    * update_minimum_packet_rate_rule"},{"line_number":8,"context_line":"    * show_minimum_packet_rate_rule"},{"line_number":9,"context_line":"    * list_minimum_packet_rate_rules"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9bbad403_a462cae4","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":36},"in_reply_to":"e3df100d_e11ac314","updated":"2021-11-04 12:33:58.000000000","message":"Done","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7d509f92a16f1764a49a9cc13de88975d9642aa4","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    * create_minimum_packet_rate_rule"},{"line_number":7,"context_line":"    * update_minimum_packet_rate_rule"},{"line_number":8,"context_line":"    * show_minimum_packet_rate_rule"},{"line_number":9,"context_line":"    * list_minimum_packet_rate_rules"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e3df100d_e11ac314","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":36},"in_reply_to":"fe273ef4_9a0aada5","updated":"2021-11-04 08:43:06.000000000","message":"+1","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"}],"tempest/lib/services/network/qos_minimum_packet_rate_rules_client.py":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"08714ef1646f3d7a3381213447858ee28eda3ed6","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        return self.update_resource(uri, post_data)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def show_minimum_packet_rate_rule(self, qos_policy_id, rule_id, **fields):"},{"line_number":44,"context_line":"        \"\"\"Show details of a minimum packet_rate rule."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":47,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b039c19b_d38fea79","line":44,"updated":"2021-09-07 10:26:24.000000000","message":"Why is packet rate spelled here with a  \u0027_\u0027 whereas in other methods it is without  \u0027_\u0027?","commit_id":"2375821229a9062c9d120cd4fbabe5235929bad2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4ea3614a5aa5cb4f8af6da1fe0f44ff9931b147c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return self.update_resource(uri, post_data)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def show_minimum_packet_rate_rule(self, qos_policy_id, rule_id, **fields):"},{"line_number":44,"context_line":"        \"\"\"Show details of a minimum packet_rate rule."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":47,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":2,"id":"495c757c_a0eb33b8","line":44,"in_reply_to":"b039c19b_d38fea79","updated":"2021-10-12 10:58:34.000000000","message":"Done","commit_id":"2375821229a9062c9d120cd4fbabe5235929bad2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7d509f92a16f1764a49a9cc13de88975d9642aa4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"9d5802c3_d317130d","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":6},"updated":"2021-11-04 08:43:06.000000000","message":"aren\u0027t there some lines above missing? Copyright one and \u0027All Rights Reserved\u0027?","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b563c48c3852906c785a44715789b4fc40adcd35","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"7efe4038_3be5f35d","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":6},"in_reply_to":"0d5fbabc_669035b9","updated":"2021-11-08 22:53:08.000000000","message":"i see, thanks for checking, since we already have similar headers, it\u0027s probably ok, let\u0027s merge this","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"56872a265ea29ad8bfcb633fce0fd91fc0d0f74a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"0d5fbabc_669035b9","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":6},"in_reply_to":"9d5802c3_d317130d","updated":"2021-11-04 12:33:58.000000000","message":"I did not find any official statement in the openstack wiki what is the official header. There is this form of license header in the files in tempest. e.g.[1][2]\n\nDo we have somewhere an official statement about how the header should look like?\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/lib/services/network/security_group_rules_client.py\n[2] https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"}],"tempest/tests/lib/services/network/test_qos_minimum_packet_rate_rules_client.py":[{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"d6c07681762ec7f8426fa2949dc826b2cad57ad8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    FAKE_MIN_PPS_RULE_RESPONSE \u003d {"},{"line_number":32,"context_line":"        \u0027minimum_packet_rate_rule\u0027: {"},{"line_number":33,"context_line":"            \u0027id\u0027: FAKE_MIN_PPS_RULE_ID,"},{"line_number":34,"context_line":"            \u0027min_kbps\u0027: 1000,"},{"line_number":35,"context_line":"            \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"10f5313f_fbfd3c75","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":21},"updated":"2021-08-27 07:13:36.000000000","message":"min_kpps","commit_id":"d27cf238a3a96af2113831bd5a6ee8903834a5d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07612a96bca43120804b94147db0ce94ba459ae6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    FAKE_MIN_PPS_RULE_RESPONSE \u003d {"},{"line_number":32,"context_line":"        \u0027minimum_packet_rate_rule\u0027: {"},{"line_number":33,"context_line":"            \u0027id\u0027: FAKE_MIN_PPS_RULE_ID,"},{"line_number":34,"context_line":"            \u0027min_kbps\u0027: 1000,"},{"line_number":35,"context_line":"            \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"95b8aa30_b65e2daa","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":21},"in_reply_to":"10f5313f_fbfd3c75","updated":"2021-08-27 10:40:11.000000000","message":"Done","commit_id":"d27cf238a3a96af2113831bd5a6ee8903834a5d2"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"d6c07681762ec7f8426fa2949dc826b2cad57ad8","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _test_update_qos_polcy(self, bytes_body\u003dFalse):"},{"line_number":83,"context_line":"        update_kwargs \u003d {"},{"line_number":84,"context_line":"            \"min_kbps\": \"20000\""},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        resp_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae1ac904_60e137f4","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":21},"updated":"2021-08-27 07:13:36.000000000","message":"min_kpps","commit_id":"d27cf238a3a96af2113831bd5a6ee8903834a5d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07612a96bca43120804b94147db0ce94ba459ae6","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _test_update_qos_polcy(self, bytes_body\u003dFalse):"},{"line_number":83,"context_line":"        update_kwargs \u003d {"},{"line_number":84,"context_line":"            \"min_kbps\": \"20000\""},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        resp_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"065d9c6f_0464ee2c","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":21},"in_reply_to":"ae1ac904_60e137f4","updated":"2021-08-27 10:40:11.000000000","message":"Done","commit_id":"d27cf238a3a96af2113831bd5a6ee8903834a5d2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7d509f92a16f1764a49a9cc13de88975d9642aa4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c982ba7_fb77b719","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":5},"updated":"2021-11-04 08:43:06.000000000","message":"aren\u0027t there some lines above missing? Copyright one and \u0027All Rights Reserved\u0027?","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"56872a265ea29ad8bfcb633fce0fd91fc0d0f74a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"d9bd84c0_fee56d30","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":5},"in_reply_to":"4c982ba7_fb77b719","updated":"2021-11-04 12:33:58.000000000","message":"ditto","commit_id":"ebc8e396dea83b39f98abe934243e24f6edfdbea"}]}