)]}'
{"tempest/api/identity/admin/v3/test_tokens.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1279ef81b7e45bc8bb07ef4494cc0869fa07edff","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        user_name \u003d data_utils.rand_name(name\u003d\u0027user-\u0027)"},{"line_number":61,"context_line":"        user_password \u003d data_utils.rand_name(name\u003d\u0027pass-\u0027)"},{"line_number":62,"context_line":"        resp, user \u003d self.client.create_user(user_name, password\u003duser_password)"},{"line_number":63,"context_line":"        self.assertTrue(resp[\u0027status\u0027].startswith(\u00272\u0027))"},{"line_number":64,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Create a project."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FlyA%3D","line":63,"updated":"2014-03-15 19:13:38.000000000","message":"If you\u0027re checking the response code this has to be the specific response code.  Just saying it\u0027s a 2XX response isn\u0027t specific enough. (and also allows for completely invalid HTTP response codes) This is true for all the checks where you did the same thing below.","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5293ee8c56fba9f155977fb83dab272868e79442","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        user_name \u003d data_utils.rand_name(name\u003d\u0027user-\u0027)"},{"line_number":61,"context_line":"        user_password \u003d data_utils.rand_name(name\u003d\u0027pass-\u0027)"},{"line_number":62,"context_line":"        resp, user \u003d self.client.create_user(user_name, password\u003duser_password)"},{"line_number":63,"context_line":"        self.assertTrue(resp[\u0027status\u0027].startswith(\u00272\u0027))"},{"line_number":64,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Create a project."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkpQ%3D","line":63,"in_reply_to":"AAAAWH%2F%2FlyA%3D","updated":"2014-03-16 15:40:25.000000000","message":"Done","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"}],"tempest/services/identity/v3/json/identity_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1279ef81b7e45bc8bb07ef4494cc0869fa07edff","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        return self.auth2(user\u003duser, password\u003dpassword, tenant\u003dtenant,"},{"line_number":473,"context_line":"                          user_type\u003duser_type, domain\u003ddomain)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def auth2(self, user\u003dNone, password\u003dNone, token\u003dNone, tenant\u003dNone,"},{"line_number":476,"context_line":"              user_type\u003d\u0027id\u0027, domain\u003dNone):"},{"line_number":477,"context_line":"        \"\"\""},{"line_number":478,"context_line":"        :param user: user id or name, as specified in user_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Flxw%3D","line":475,"updated":"2014-03-15 19:13:38.000000000","message":"Why do you need to make a second method here? This should work fine if auth is just changed to make user, and password optional. Especially since all auth() does is call auth2(). You can use kwargs in order or with the keyword.\n\nIf you were going to split it into a common private method with different public ones that had different use cases that would be fine, but I really don\u0027t see that here.","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5293ee8c56fba9f155977fb83dab272868e79442","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        return self.auth2(user\u003duser, password\u003dpassword, tenant\u003dtenant,"},{"line_number":473,"context_line":"                          user_type\u003duser_type, domain\u003ddomain)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def auth2(self, user\u003dNone, password\u003dNone, token\u003dNone, tenant\u003dNone,"},{"line_number":476,"context_line":"              user_type\u003d\u0027id\u0027, domain\u003dNone):"},{"line_number":477,"context_line":"        \"\"\""},{"line_number":478,"context_line":"        :param user: user id or name, as specified in user_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fko4%3D","line":475,"in_reply_to":"AAAAWH%2F%2Flxw%3D","updated":"2014-03-16 15:40:25.000000000","message":"Done","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"}],"tempest/services/identity/v3/xml/identity_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1279ef81b7e45bc8bb07ef4494cc0869fa07edff","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        return self.auth2(user\u003duser, password\u003dpassword, tenant\u003dtenant,"},{"line_number":459,"context_line":"                          user_type\u003duser_type, domain\u003ddomain)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def auth2(self, user\u003dNone, password\u003dNone, token\u003dNone, tenant\u003dNone,"},{"line_number":462,"context_line":"              user_type\u003d\u0027id\u0027, domain\u003dNone):"},{"line_number":463,"context_line":"        \"\"\""},{"line_number":464,"context_line":"        :param user: user id or name, as specified in user_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Flxk%3D","line":461,"updated":"2014-03-15 19:13:38.000000000","message":"Same here.","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5293ee8c56fba9f155977fb83dab272868e79442","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        return self.auth2(user\u003duser, password\u003dpassword, tenant\u003dtenant,"},{"line_number":459,"context_line":"                          user_type\u003duser_type, domain\u003ddomain)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def auth2(self, user\u003dNone, password\u003dNone, token\u003dNone, tenant\u003dNone,"},{"line_number":462,"context_line":"              user_type\u003d\u0027id\u0027, domain\u003dNone):"},{"line_number":463,"context_line":"        \"\"\""},{"line_number":464,"context_line":"        :param user: user id or name, as specified in user_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fko0%3D","line":461,"in_reply_to":"AAAAWH%2F%2Flxk%3D","updated":"2014-03-16 15:40:25.000000000","message":"Done","commit_id":"099bae016ee33423facdb4fe701b6b23af3bb742"}]}