)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee8b974e67917cb338e6b4f35e8bcacb202f752a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to verify that the change has no other side effects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I72d34c253816cfc4c05008f504c9abe6d2182efd"},{"line_number":13,"context_line":"Implements: bug 1293543"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FMQM%3D","line":13,"updated":"2014-03-19 15:29:21.000000000","message":"Please see https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references\n\nright now the reference to the bug isn\u0027t correct because this fix will close the bug.","commit_id":"1244ae6f03a3fbc43bf656b3ac196df7b0828440"}],"tempest/common/generator/base_generator.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6c882076446422843504ae1f713f73a8bb75d9ef","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        self.types_dict[type].append(method)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def validate_schema(self, schema):"},{"line_number":108,"context_line":"        if \"json-schema\" in schema:"},{"line_number":109,"context_line":"            jsonschema.Draft4Validator(schema[\"json-schema\"])"},{"line_number":110,"context_line":"        jsonschema.validate(schema, self.schema)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVQo%3D","line":108,"updated":"2014-03-18 15:21:40.000000000","message":"Is this meant to check if the attr is there or if it\u0027s an empty dict like in the template above? Right now this will be true as long as the json-schema attr is present.","commit_id":"021dedefc43960916927a759b480f874b74c8c17"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2896f2bbc974ae6c4784d92ad690e34b1c8cc844","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        self.types_dict[type].append(method)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def validate_schema(self, schema):"},{"line_number":108,"context_line":"        if \"json-schema\" in schema:"},{"line_number":109,"context_line":"            jsonschema.Draft4Validator(schema[\"json-schema\"])"},{"line_number":110,"context_line":"        jsonschema.validate(schema, self.schema)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVG4%3D","line":108,"in_reply_to":"AAAAWH%2F%2FVQo%3D","updated":"2014-03-18 15:37:43.000000000","message":"If the json-schema is present it should be checked. The empty dict above only indicates that the type of the value is not specified.","commit_id":"021dedefc43960916927a759b480f874b74c8c17"}],"tempest/tests/negative/test_negative_generators.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6c882076446422843504ae1f713f73a8bb75d9ef","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_validate_schema(self):"},{"line_number":58,"context_line":"        gen \u003d base_generator.BasicGeneratorSet()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        gen.validate_schema(self.valid_desc)"},{"line_number":61,"context_line":"        gen.validate_schema(self.minimal_desc)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertRaises(jsonschema.ValidationError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVPg%3D","line":60,"updated":"2014-03-18 15:21:40.000000000","message":"I think you should split this test case out in to separate ones for each desc dict above.\n\nAlso you should do some validation that the working schemas are doing the right thing.","commit_id":"021dedefc43960916927a759b480f874b74c8c17"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"93edbd1f4f6c5ff21047734422a9ab5e735c11ca","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_validate_schema(self):"},{"line_number":58,"context_line":"        gen \u003d base_generator.BasicGeneratorSet()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        gen.validate_schema(self.valid_desc)"},{"line_number":61,"context_line":"        gen.validate_schema(self.minimal_desc)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertRaises(jsonschema.ValidationError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVAM%3D","line":60,"in_reply_to":"AAAAWH%2F%2FVC8%3D","updated":"2014-03-18 15:43:40.000000000","message":"Then just mock jsonschema call and verify it\u0027s called with the right inputs. I just feel like a test that calls something and expects it to work needs to verify that. \n\nJust having it not raise an exception doesn\u0027t feel like the best test case to me.","commit_id":"021dedefc43960916927a759b480f874b74c8c17"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2896f2bbc974ae6c4784d92ad690e34b1c8cc844","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_validate_schema(self):"},{"line_number":58,"context_line":"        gen \u003d base_generator.BasicGeneratorSet()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        gen.validate_schema(self.valid_desc)"},{"line_number":61,"context_line":"        gen.validate_schema(self.minimal_desc)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertRaises(jsonschema.ValidationError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVC8%3D","line":60,"in_reply_to":"AAAAWH%2F%2FVPg%3D","updated":"2014-03-18 15:37:43.000000000","message":"To be honest I am not sure if validating working schemas is easy possible. Since at the end I am unit testing jsonschema and not the definition.","commit_id":"021dedefc43960916927a759b480f874b74c8c17"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee8b974e67917cb338e6b4f35e8bcacb202f752a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_validate_schema_with_valid_input(self, jsonschema_mock):"},{"line_number":60,"context_line":"        gen \u003d base_generator.BasicGeneratorSet()"},{"line_number":61,"context_line":"        gen.validate_schema(self.valid_desc)"},{"line_number":62,"context_line":"        self.assertEqual(jsonschema_mock.call_count, 1)"},{"line_number":63,"context_line":"        gen.validate_schema(self.minimal_desc)"},{"line_number":64,"context_line":"        self.assertEqual(jsonschema_mock.call_count, 2)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FMP0%3D","line":62,"updated":"2014-03-19 15:29:21.000000000","message":"You could also verify the args to the call are correct to verify you\u0027re making the correct calls.","commit_id":"1244ae6f03a3fbc43bf656b3ac196df7b0828440"}]}