)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"604d733f1e19b4149e42d9c55ee15c3d6d9e9fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"803820d6_8389899c","updated":"2021-11-09 22:12:32.000000000","message":"recheck","commit_id":"36b0b2db8f4f464c1d6910a53b06fbd269c8bd31"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69a2e68ac2c27db888673fc4c8f731001282c1a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8fe047cf_ea9b22b1","updated":"2021-11-18 00:15:25.000000000","message":"I think we need to setup a job first and then based on what all test or service side code need fix we can add config option we will end up skipping many tests","commit_id":"e2ce6edd80a77f7d8bb6ccc1c6b72e94aee7bc39"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a41ba26ec5aa43b0e19aa1e2b81199bcc251b3df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c875c056_6103ab0a","updated":"2021-11-17 22:06:01.000000000","message":"lgtm, thanks for the change, I\u0027ll +w once the gates pass\nit would be also good to add a releasenote so that the new tempest option is documented in the change log","commit_id":"e2ce6edd80a77f7d8bb6ccc1c6b72e94aee7bc39"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"673b3f477c103663596ba9e1001e8425de7b6300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc4bee95_fb28c287","in_reply_to":"8fe047cf_ea9b22b1","updated":"2021-12-01 23:08:42.000000000","message":"There are many tests that are currently underway with FIPS enabled.  You can find some of them using:\nhttps://review.opendev.org/q/topic:%22add_fips_job%22+(status:open%20OR%20status:merged)\n\nSome others may have a different topic, but essentially, we\u0027ve been trying to run tempest and functional tests in keystone, barbican, nova, glance, designate, octavia, neutron, ironic, cinder, manila, swift, aodh etc., and a whole slew in tripleo.\n\nSo far, we have identified two tests that need to be skipped - this one and basically the same test in the barbican tempest plugin.  I added the skip option here so that I would not have to define it again in the barbican-tempest-plugin.\n\nI anticipate that there will be more - if not here - then in the other tempest plugins, but I don\u0027t know of any yet.\n\nThe advantage of using this single option is that we can ultimate grep through all the plugins and document all the tests that are failing in all the tempest plugins.","commit_id":"e2ce6edd80a77f7d8bb6ccc1c6b72e94aee7bc39"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"08ba8a58b9a487281305041c6951e3516cca9fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d9576964_eccfb828","updated":"2022-01-03 14:50:25.000000000","message":"recheck","commit_id":"69425461c1f28d50d0b6ae9095534f37f0bc7a0f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"d246c3358ded155b91d288df2df8ec17ef9fab4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c515cb48_6ce12713","updated":"2022-01-12 23:14:22.000000000","message":"recheck","commit_id":"0b35f95c7461e23ca46d819323a38d2d1fa2f12c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4fa995b8a395bc32ea71ae533432c05109d28233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7277d5d6_898b62b3","updated":"2022-01-14 19:30:21.000000000","message":"recheck","commit_id":"6675d7b1edd1e2b74801739101bbc9f05fe35265"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"cf20cb78fab9fef4f45f88256be990d80f883db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa3eeea2_9624a916","updated":"2022-01-17 18:44:26.000000000","message":"recheck","commit_id":"6675d7b1edd1e2b74801739101bbc9f05fe35265"}],"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69a2e68ac2c27db888673fc4c8f731001282c1a5","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":63,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(CONF.validation.fips,"},{"line_number":66,"context_line":"                      \u0027PLAIN encryptor provider not supported in FIPS mode\u0027)"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4717-910f-956cce965722\u0027)"},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":69,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"097ba8d5_fdfec90c","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":76},"updated":"2021-11-18 00:15:25.000000000","message":"how we know this is failing, I think right direction is to add a job with fips and then we will see what all things we need to adjust in tests or service side code and then keep doing those.","commit_id":"e2ce6edd80a77f7d8bb6ccc1c6b72e94aee7bc39"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"673b3f477c103663596ba9e1001e8425de7b6300","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":63,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(CONF.validation.fips,"},{"line_number":66,"context_line":"                      \u0027PLAIN encryptor provider not supported in FIPS mode\u0027)"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4717-910f-956cce965722\u0027)"},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":69,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"be2bc649_e174c380","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":76},"in_reply_to":"097ba8d5_fdfec90c","updated":"2021-12-01 23:08:42.000000000","message":"We know this is failing because we already ran jobs with fips, analyzed the results, and determined this was failing exactly for this reeason.\n\nThe jobs were run here:  https://review.opendev.org/c/openstack/cinder/+/790535\n\nUnfortunately, it looks like the run where this test was not skipped and failed has already aged out.  Here is one run where it has been skipped.\n\nhttps://47bdbd494f610b5d96fd-3d3a6bc3fe9b59f117c29f93d14fbf4d.ssl.cf5.rackcdn.com/790535/19/check/cinder-tempest-plugin-lvm-lio-barbican-fips/eb662ab/testr_results.html\n\nWe see exactly the same failure in a test that is basically the same as this one in the barbican-tempest-plugin -- which we are skipping for the same reason here --\n\nhttps://review.opendev.org/c/openstack/barbican-tempest-plugin/+/810782\n\nWe can see that test fail here:\n\nhttps://d86090b7d54df0827d49-db3d40af5818e6e3e7d50951d8a4c856.ssl.cf1.rackcdn.com/808215/55/check/tripleo-ci-centos-8-scenario002-standalone/a7ec7c0/logs/undercloud/var/log/tempest/stestr_results.html","commit_id":"e2ce6edd80a77f7d8bb6ccc1c6b72e94aee7bc39"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"57bb8dba55ee27a090934af3dd3059a5982e6807","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":63,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(CONF.validation.fips,"},{"line_number":66,"context_line":"                      \u0027PLAIN encryptor provider not supported in FIPS mode\u0027)"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4717-910f-956cce965722\u0027)"},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":69,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"54a8e97b_5360f7e2","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":76},"updated":"2022-01-22 00:43:57.000000000","message":"I m am fine to skip but can you please open os-bricks bug and add it here is skip_decorator\n\n    @decorators.skip_because(bug\u003d\u0027xyz\u0027,\n                             condition\u003dCONF.validation.fips)","commit_id":"3b4f672a0260d28d33031c0dffa98c41e049affe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6fc24c9012af0d06acd3a4994021990747d6e47","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":63,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(CONF.validation.fips,"},{"line_number":66,"context_line":"                      \u0027PLAIN encryptor provider not supported in FIPS mode\u0027)"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4717-910f-956cce965722\u0027)"},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":69,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"d430de3b_2c22dbb0","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":76},"in_reply_to":"54a8e97b_5360f7e2","updated":"2022-01-24 12:13:49.000000000","message":"i dont hink its a bug.\n\nif the volume is encypted usign a specific algortihtm when we cant presumable change that and still read the data without decyrpting and rencyrpting the volume.\n\nto me this is a feature not a bug to support althernitive fips compliant algorthms  when usign the depercated plain encyptor provider.\n\nunless we un deprecate it we should not add new features to it so i dobut we will ever extend fips support to this mode.\n\nas such i think the current skip if is more correct then skip_becuase(bug…)","commit_id":"3b4f672a0260d28d33031c0dffa98c41e049affe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39535ddd9a6c68f69eeb018798facf13565287fd","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":63,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(CONF.validation.fips,"},{"line_number":66,"context_line":"                      \u0027PLAIN encryptor provider not supported in FIPS mode\u0027)"},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4717-910f-956cce965722\u0027)"},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":69,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"c8c4dad4_fcc59909","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":76},"in_reply_to":"d430de3b_2c22dbb0","updated":"2022-01-24 18:16:27.000000000","message":"That is my main concern. So we are skipping the test, which will not run/fix (by bug or feature) anytime. Tempest Skip tests (automatically) for feature configuration test is for (say resize server test will be skipped if env does not support resize) or known bugs. \n\nIn this case, where we do not know whether test feature will be fixed on the project side, I will say we exclude the test to run in FIPs mode. You can use --exclude-regex or --exclude-list param to exclude such tests. And later, when we have more clarity on what we are fixing in OpenStack for FIPs, we can re-iterate it.\n\nautomatically skipping tests for intermediate things is dangerous and hide the things we should notice during testing.","commit_id":"3b4f672a0260d28d33031c0dffa98c41e049affe"}]}