)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1d6fb1c786c744d9ccd85fd2a96cb31f53806bfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88fb4753_d46c22dc","updated":"2021-10-14 14:06:07.000000000","message":"\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e (2 comments)\n\u003e \n\u003e Needs tests (tempest.tests.common.test_waiters) and I\u0027d rather see two waiters instead of one here.\n\nI can add tests for the timeout case, the happy path is exercised in the code itself.","commit_id":"63c5b33c6a7c4230d46ca3d329d384e8d28d6d50"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ac0ab4e54715a044cfdcfc56f0fbb0a011732cf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6500e649_227c95cf","updated":"2021-11-01 15:01:05.000000000","message":"LGTM","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"c2138d995a93d90e41b4820fe5306df57a12cd76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c7b68a8_e4b79d17","updated":"2021-11-12 12:50:36.000000000","message":"Looks like tempest comes across race condition here. Adding waiter can be a good choice here.\nThanks. LGTM!!","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"e60d6e3762d17556ca285f9167f8ce19b523ccb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cc53b8c_96be2c48","updated":"2021-11-22 12:42:07.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"528ce27b447cf060d2d7f721187bb3a96b05de8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a924e0d_09af773d","updated":"2021-11-19 10:54:01.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3d884ae2363453034e81cf92edc736b850c9a04d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84d9f77f_26615785","updated":"2021-11-19 16:51:00.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7658e4bb76f41c6b56c8a93cf5d29bc77a37b4ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9db996e3_8d702d6e","updated":"2021-11-23 13:19:23.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"47b7fdbe5686b5ee3b40548b35f98b4f9f2b6b2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c82b3b5e_f08a31c4","updated":"2021-10-20 18:14:26.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b06e8584b44b597d07b8459a9abc4853172a6947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e83d7681_d734a39f","updated":"2021-10-14 17:00:53.000000000","message":"recheck","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"56aeb870bef263a16953b2d2d9ec114b3e092682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2ec6b2c_756dc3d3","updated":"2021-11-18 14:51:20.000000000","message":"recheck as it\u0027s been a month since it was checked by the jobs and +2, lgtm","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ff8f4a36467b650f0b42fa4563f89a6c61a70e5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"275cf155_c88c15b8","updated":"2021-11-08 23:24:46.000000000","message":"reviewing this .. btw, I\u0027ve hit the exact same issue with different test and was trying to solve it similarly (by a waiter) - I\u0027ll reuse the waiter from this patch .. anyway, my test modification fails on ceph, if you have any insight, please, feel free to share it - https://review.opendev.org/c/openstack/tempest/+/814085","commit_id":"8a959ead1edcd71a55ac0570db407040a36e29b9"}],"tempest/common/waiters.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"16f8a9bae567e0780c8d1375dd62dbf7f7a4a77d","unresolved":true,"context_lines":[{"line_number":527,"context_line":"        time.sleep(client.build_interval)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"def wait_for_server_floating_ip(servers_client, server, floating_ip,"},{"line_number":531,"context_line":"                                wait_for_disassociate\u003dFalse):"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _get_floating_ip_in_server_addresses(floating_ip, server):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bf351b6_1dec3850","line":530,"range":{"start_line":530,"start_character":4,"end_line":530,"end_character":31},"updated":"2021-10-04 12:40:15.000000000","message":"nit - I\u0027d rather pull the common logic out and have two separate waiters if possible.","commit_id":"63c5b33c6a7c4230d46ca3d329d384e8d28d6d50"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1d6fb1c786c744d9ccd85fd2a96cb31f53806bfd","unresolved":true,"context_lines":[{"line_number":527,"context_line":"        time.sleep(client.build_interval)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"def wait_for_server_floating_ip(servers_client, server, floating_ip,"},{"line_number":531,"context_line":"                                wait_for_disassociate\u003dFalse):"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _get_floating_ip_in_server_addresses(floating_ip, server):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5dd46f99_ecd56acf","line":530,"range":{"start_line":530,"start_character":4,"end_line":530,"end_character":31},"in_reply_to":"0bf351b6_1dec3850","updated":"2021-10-14 14:06:07.000000000","message":"That won\u0027t really improve anything because you still need the conditional logic inside the loop to decide whether you return \u0027None\u0027 (wait_for_disassociate\u003dTrue), or return \u003caddress\u003e (wait_for_disassociate\u003dFalse).","commit_id":"63c5b33c6a7c4230d46ca3d329d384e8d28d6d50"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"16f8a9bae567e0780c8d1375dd62dbf7f7a4a77d","unresolved":true,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"def wait_for_server_floating_ip(servers_client, server, floating_ip,"},{"line_number":531,"context_line":"                                wait_for_disassociate\u003dFalse):"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _get_floating_ip_in_server_addresses(floating_ip, server):"},{"line_number":534,"context_line":"        for addresses in server[\u0027addresses\u0027].values():"},{"line_number":535,"context_line":"            for address in addresses:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afd5124_4af72e54","line":532,"updated":"2021-10-04 12:40:15.000000000","message":"Needs a doc-string.","commit_id":"63c5b33c6a7c4230d46ca3d329d384e8d28d6d50"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1d6fb1c786c744d9ccd85fd2a96cb31f53806bfd","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"def wait_for_server_floating_ip(servers_client, server, floating_ip,"},{"line_number":531,"context_line":"                                wait_for_disassociate\u003dFalse):"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _get_floating_ip_in_server_addresses(floating_ip, server):"},{"line_number":534,"context_line":"        for addresses in server[\u0027addresses\u0027].values():"},{"line_number":535,"context_line":"            for address in addresses:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ef11819_8982beae","line":532,"in_reply_to":"5afd5124_4af72e54","updated":"2021-10-14 14:06:07.000000000","message":"Done","commit_id":"63c5b33c6a7c4230d46ca3d329d384e8d28d6d50"}]}