)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"874a128cf43cf392e7115eda40254e471c35ada7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1bd90f1e_fa1cde8f","updated":"2021-10-12 10:58:01.000000000","message":"recheck","commit_id":"d7a6e560d804af2d2b23808f6f801cfed3e53b5e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86f7d2ee38adf4f9dffd0eb2df9c6f48a52639d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2da3fa59_2acc9b19","updated":"2021-10-28 16:24:25.000000000","message":"lgtm, do we have testing patch to run this test in neutron-ovs-tempest-multinode-full job on neutron side?","commit_id":"5e55617bc5fe6175e7e97a21b68ca949e412c96f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"400922f182bc9396b0210e7f8a2c16d3f3771391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"625a6797_1c40be73","updated":"2021-11-01 15:57:43.000000000","message":"lgtm, test are passing in https://review.opendev.org/c/openstack/neutron/+/815898","commit_id":"5e55617bc5fe6175e7e97a21b68ca949e412c96f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c46ac86f63934f46bf6c584653bbce824b142ce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf39548c_6776d39b","in_reply_to":"2da3fa59_2acc9b19","updated":"2021-10-28 22:17:12.000000000","message":"testing in this https://review.opendev.org/c/openstack/neutron/+/815898","commit_id":"5e55617bc5fe6175e7e97a21b68ca949e412c96f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"20d47af6cffab7297ca5d43ee7f238989b6caea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf94e395_783e4882","updated":"2021-11-05 10:59:30.000000000","message":"Thanks!","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"78764015d4d7af576f0c9b613ba46156979b0a4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"abbfe450_cb6944d6","updated":"2021-11-04 08:31:42.000000000","message":"small -1, 2 questions below","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"}],"tempest/scenario/test_network_qos_placement.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ff6404e1de97331e9cadb54949318175c1cdbfae","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        self._assert_allocation_is_as_expected(server[\u0027id\u0027],"},{"line_number":301,"context_line":"                                               [valid_port[\u0027id\u0027]])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        self.os_adm.servers_client.confirm_resize_server("},{"line_number":304,"context_line":"            server_id\u003dserver[\u0027id\u0027])"},{"line_number":305,"context_line":"        waiters.wait_for_server_status("},{"line_number":306,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"188653d7_e3675852","line":303,"updated":"2021-11-04 12:21:34.000000000","message":"This is confirming a migration not a resize so it needs an admin client.","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"20d47af6cffab7297ca5d43ee7f238989b6caea4","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        self._assert_allocation_is_as_expected(server[\u0027id\u0027],"},{"line_number":301,"context_line":"                                               [valid_port[\u0027id\u0027]])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        self.os_adm.servers_client.confirm_resize_server("},{"line_number":304,"context_line":"            server_id\u003dserver[\u0027id\u0027])"},{"line_number":305,"context_line":"        waiters.wait_for_server_status("},{"line_number":306,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"4c7361fa_3533c48e","line":303,"in_reply_to":"188653d7_e3675852","updated":"2021-11-05 10:59:30.000000000","message":"oh, it\u0027s confusing , i couldn\u0027t tell that from the method\u0027s name","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"78764015d4d7af576f0c9b613ba46156979b0a4f","unresolved":true,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        new_flavor \u003d self._create_flavor_to_resize_to()"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.servers_client.resize_server("},{"line_number":334,"context_line":"            server_id\u003dserver[\u0027id\u0027], flavor_ref\u003dnew_flavor[\u0027id\u0027])"},{"line_number":335,"context_line":"        waiters.wait_for_server_status("},{"line_number":336,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d6654f9_2b0404c7","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":41},"updated":"2021-11-04 08:31:42.000000000","message":"just to make sure, resize_server operation doesn\u0027t require an admin client?","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ff6404e1de97331e9cadb54949318175c1cdbfae","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        new_flavor \u003d self._create_flavor_to_resize_to()"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.servers_client.resize_server("},{"line_number":334,"context_line":"            server_id\u003dserver[\u0027id\u0027], flavor_ref\u003dnew_flavor[\u0027id\u0027])"},{"line_number":335,"context_line":"        waiters.wait_for_server_status("},{"line_number":336,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"be02e294_cb470702","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":41},"in_reply_to":"0d6654f9_2b0404c7","updated":"2021-11-04 12:21:34.000000000","message":"no, it does not need admin: https://github.com/openstack/nova/blob/909cfc76369b94b026cf42b86fb5a310dce21a8c/nova/policies/servers.py#L366","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"20d47af6cffab7297ca5d43ee7f238989b6caea4","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        new_flavor \u003d self._create_flavor_to_resize_to()"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.servers_client.resize_server("},{"line_number":334,"context_line":"            server_id\u003dserver[\u0027id\u0027], flavor_ref\u003dnew_flavor[\u0027id\u0027])"},{"line_number":335,"context_line":"        waiters.wait_for_server_status("},{"line_number":336,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"249a98c0_4d2f1fd7","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":41},"in_reply_to":"be02e294_cb470702","updated":"2021-11-05 10:59:30.000000000","message":"perfect, thanks","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"78764015d4d7af576f0c9b613ba46156979b0a4f","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        self._assert_allocation_is_as_expected(server[\u0027id\u0027],"},{"line_number":342,"context_line":"                                               [valid_port[\u0027id\u0027]])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.servers_client.confirm_resize_server(server_id\u003dserver[\u0027id\u0027])"},{"line_number":345,"context_line":"        waiters.wait_for_server_status("},{"line_number":346,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":347,"context_line":"            status\u003d\u0027ACTIVE\u0027, ready_wait\u003dFalse, raise_on_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"07fbfc54_425be2a3","line":344,"range":{"start_line":344,"start_character":8,"end_line":344,"end_character":49},"updated":"2021-11-04 08:31:42.000000000","message":"on line 303 we used admin client for confirm_resize_server operation, which one should be used then?","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ff6404e1de97331e9cadb54949318175c1cdbfae","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self._assert_allocation_is_as_expected(server[\u0027id\u0027],"},{"line_number":342,"context_line":"                                               [valid_port[\u0027id\u0027]])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.servers_client.confirm_resize_server(server_id\u003dserver[\u0027id\u0027])"},{"line_number":345,"context_line":"        waiters.wait_for_server_status("},{"line_number":346,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":347,"context_line":"            status\u003d\u0027ACTIVE\u0027, ready_wait\u003dFalse, raise_on_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e42af6a_cf91896a","line":344,"range":{"start_line":344,"start_character":8,"end_line":344,"end_character":49},"in_reply_to":"07fbfc54_425be2a3","updated":"2021-11-04 12:21:34.000000000","message":"L344 confirms a resize, L303 confirms a migration. Migration needs admin https://github.com/openstack/nova/blob/909cfc76369b94b026cf42b86fb5a310dce21a8c/nova/policies/migrate_server.py#L27 while resize does not.","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"20d47af6cffab7297ca5d43ee7f238989b6caea4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self._assert_allocation_is_as_expected(server[\u0027id\u0027],"},{"line_number":342,"context_line":"                                               [valid_port[\u0027id\u0027]])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.servers_client.confirm_resize_server(server_id\u003dserver[\u0027id\u0027])"},{"line_number":345,"context_line":"        waiters.wait_for_server_status("},{"line_number":346,"context_line":"            client\u003dself.servers_client, server_id\u003dserver[\u0027id\u0027],"},{"line_number":347,"context_line":"            status\u003d\u0027ACTIVE\u0027, ready_wait\u003dFalse, raise_on_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f49b0ca8_90f16733","line":344,"range":{"start_line":344,"start_character":8,"end_line":344,"end_character":49},"in_reply_to":"0e42af6a_cf91896a","updated":"2021-11-05 10:59:30.000000000","message":"thanks for the info, now it makes sense","commit_id":"18accdeb7e78e0c1b75f409d74c81336a09fdcec"}]}