)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5a353aa2a81f521e732c5542a54a09498648ac0","unresolved":false,"context_lines":[{"line_number":940,"context_line":"# value)"},{"line_number":941,"context_line":"#disk_format\u003draw"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"# Size in GB of volumes created by volumes tests (integer"},{"line_number":944,"context_line":"# value)"},{"line_number":945,"context_line":"#volume_size\u003d1"},{"line_number":946,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAWH%2F%2BXN4%3D","line":943,"updated":"2014-03-27 11:27:14.000000000","message":"I\u0027d change the comment a bit here; default size for volumes created by ...","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"71bd2463a597c2b2a1873ecf25b3f88ef146d378","unresolved":false,"context_lines":[{"line_number":940,"context_line":"# value)"},{"line_number":941,"context_line":"#disk_format\u003draw"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"# Size in GB of volumes created by volumes tests (integer"},{"line_number":944,"context_line":"# value)"},{"line_number":945,"context_line":"#volume_size\u003d1"},{"line_number":946,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAWH%2F%2BWrg%3D","line":943,"in_reply_to":"AAAAWH%2F%2BXN4%3D","updated":"2014-03-27 12:42:10.000000000","message":"+1","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}],"tempest/api/compute/volumes/test_volumes_negative.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9f6ac98ae7cd40b89e40c210d4cd57904587ac7a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                          size\u003d\u0027#$%\u0027, display_name\u003dv_name, metadata\u003dmetadata)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":63,"context_line":"    def test_create_volume_with_out_passing_size(self):"},{"line_number":64,"context_line":"        # Negative: Should not be able to create volume without passing size"},{"line_number":65,"context_line":"        # in request"},{"line_number":66,"context_line":"        v_name \u003d data_utils.rand_name(\u0027Volume-\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BZps%3D","side":"PARENT","line":63,"updated":"2014-03-27 02:58:09.000000000","message":"why delete this test?","commit_id":"d3cbf488f7b919cdecb673ba6460f31a82ac1920"}],"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5a353aa2a81f521e732c5542a54a09498648ac0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        v_name \u003d data_utils.rand_name(\u0027Volume\u0027)"},{"line_number":52,"context_line":"        metadata \u003d {\u0027Type\u0027: \u0027Test\u0027}"},{"line_number":53,"context_line":"        # Create a volume"},{"line_number":54,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1,"},{"line_number":55,"context_line":"                                                 display_name\u003dv_name,"},{"line_number":56,"context_line":"                                                 metadata\u003dmetadata,"},{"line_number":57,"context_line":"                                                 **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BXLs%3D","side":"PARENT","line":54,"updated":"2014-03-27 11:27:14.000000000","message":"there a number of other tests where we pass a size ... I think it would be nice to cleanup all of them in this patch to avoid leftovers","commit_id":"d3cbf488f7b919cdecb673ba6460f31a82ac1920"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"71bd2463a597c2b2a1873ecf25b3f88ef146d378","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        v_name \u003d data_utils.rand_name(\u0027Volume\u0027)"},{"line_number":52,"context_line":"        metadata \u003d {\u0027Type\u0027: \u0027Test\u0027}"},{"line_number":53,"context_line":"        # Create a volume"},{"line_number":54,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1,"},{"line_number":55,"context_line":"                                                 display_name\u003dv_name,"},{"line_number":56,"context_line":"                                                 metadata\u003dmetadata,"},{"line_number":57,"context_line":"                                                 **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BWr8%3D","side":"PARENT","line":54,"in_reply_to":"AAAAWH%2F%2BWzI%3D","updated":"2014-03-27 12:42:10.000000000","message":"I too fear that removing \u0027size\u003d1\u0027 everywhere would lead to a big increase of overall volume size requirement. On the other hand, the default conf value is 1G, so if an administrator/cloud operator changes willingly this parameter, he is probably aware of all the consequences.","commit_id":"d3cbf488f7b919cdecb673ba6460f31a82ac1920"},{"author":{"_account_id":9485,"name":"Jerry Cai","email":"caimin@cn.ibm.com","username":"jerrycai"},"change_message_id":"6f58bf99176b8385061abaa2a9b4cbd62b43e6e6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        v_name \u003d data_utils.rand_name(\u0027Volume\u0027)"},{"line_number":52,"context_line":"        metadata \u003d {\u0027Type\u0027: \u0027Test\u0027}"},{"line_number":53,"context_line":"        # Create a volume"},{"line_number":54,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1,"},{"line_number":55,"context_line":"                                                 display_name\u003dv_name,"},{"line_number":56,"context_line":"                                                 metadata\u003dmetadata,"},{"line_number":57,"context_line":"                                                 **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BWzI%3D","side":"PARENT","line":54,"in_reply_to":"AAAAWH%2F%2BXLs%3D","updated":"2014-03-27 12:26:31.000000000","message":"Thanks Giulio, I think cleanup all of \"size\u003d1\" in testcases(I found 10 places) might be too much impact, additionally put \"size\u003d1\" in some cases on purpose is aiming to speed up the create volume process and emphasize on the test logic. \nOnce \"volume_size\" set to 10G that same as image size to satisfy the test_volume_create_get_update_delete_from_image, all other testcases will create the 10G volume which may cost extra resources. What\u0027s your idea?","commit_id":"d3cbf488f7b919cdecb673ba6460f31a82ac1920"}],"tempest/api/volume/test_volumes_negative.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9f6ac98ae7cd40b89e40c210d4cd57904587ac7a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                          size\u003d\u0027#$%\u0027, display_name\u003dv_name, metadata\u003dmetadata)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":59,"context_line":"    def test_create_volume_with_out_passing_size(self):"},{"line_number":60,"context_line":"        # Should not be able to create volume without passing size"},{"line_number":61,"context_line":"        # in request"},{"line_number":62,"context_line":"        v_name \u003d data_utils.rand_name(\u0027Volume-\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BZnY%3D","side":"PARENT","line":59,"updated":"2014-03-27 02:58:09.000000000","message":"same comment","commit_id":"d3cbf488f7b919cdecb673ba6460f31a82ac1920"}],"tempest/config.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b8f786bf29cc68cdabc33fdc0dd3ba898642bb69","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027image_ref_alt\u0027,"},{"line_number":131,"context_line":"               default\u003d\"{$IMAGE_ID_ALT}\","},{"line_number":132,"context_line":"               help\u003d\"Valid secondary image reference to be used in tests.\"),"},{"line_number":133,"context_line":"    cfg.StrOpt(\u0027image_size\u0027,"},{"line_number":134,"context_line":"               default\u003d\"1\","},{"line_number":135,"context_line":"               help\u003d\"Image size(GB) used to create the volume from image.\"),"},{"line_number":136,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Begk%3D","line":133,"updated":"2014-03-26 14:59:56.000000000","message":"So from the bug this is the wrong size option. You need to have a size option in the volume group. This option has nothing to do with nova. It also should specify the volume size that will be created not the image size. The image size is already in the metadata for the image we\u0027re using on glance.\n\nThe option should be something like:\n\ncfg.IntOpt(\u0027volume_size\u0027,\n                  default\u003d1,\n                   help\u003d\u0027Size in GB of volumes created by volumes tests\u0027)\n\nwhich is in the VolumeGroup","commit_id":"7190fe4358c7133f552870e705456bde8e287fc1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5a353aa2a81f521e732c5542a54a09498648ac0","unresolved":false,"context_lines":[{"line_number":443,"context_line":"               help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":444,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":445,"context_line":"               default\u003d1,"},{"line_number":446,"context_line":"               help\u003d\u0027Size in GB of volumes created by volumes tests\u0027),"},{"line_number":447,"context_line":"]"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"volume_feature_group \u003d cfg.OptGroup(name\u003d\u0027volume-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BXLM%3D","line":446,"updated":"2014-03-27 11:27:14.000000000","message":"see my other comment about the text here; using \u0027default\u0027 makes it more obvious that this only applies to the tests were size is not explicitly passed","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"},{"author":{"_account_id":9485,"name":"Jerry Cai","email":"caimin@cn.ibm.com","username":"jerrycai"},"change_message_id":"6f58bf99176b8385061abaa2a9b4cbd62b43e6e6","unresolved":false,"context_lines":[{"line_number":443,"context_line":"               help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":444,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":445,"context_line":"               default\u003d1,"},{"line_number":446,"context_line":"               help\u003d\u0027Size in GB of volumes created by volumes tests\u0027),"},{"line_number":447,"context_line":"]"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"volume_feature_group \u003d cfg.OptGroup(name\u003d\u0027volume-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BWzE%3D","line":446,"in_reply_to":"AAAAWH%2F%2BXLM%3D","updated":"2014-03-27 12:26:31.000000000","message":"Thanks, I\u0027ll modify as your comment.","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}],"tempest/services/volume/json/volumes_client.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"033127fb3707d106b7fc55e2288c9977882ee9b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def create_volume(self, size\u003dNone, **kwargs):"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        Creates a new Volume."},{"line_number":73,"context_line":"        size(Required): Size of volume in GB."},{"line_number":74,"context_line":"        Following optional keyword arguments are accepted:"},{"line_number":75,"context_line":"        display_name: Optional Volume Name."},{"line_number":76,"context_line":"        metadata: A dictionary of values to be used as metadata."}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9wj8%3D","line":73,"updated":"2014-04-02 10:16:57.000000000","message":"Please, also remove \u0027Required\u0027 there.","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}],"tempest/services/volume/v2/json/volumes_client.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"033127fb3707d106b7fc55e2288c9977882ee9b0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def create_volume(self, size\u003dNone, **kwargs):"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        Creates a new Volume."},{"line_number":74,"context_line":"        size(Required): Size of volume in GB."},{"line_number":75,"context_line":"        Following optional keyword arguments are accepted:"},{"line_number":76,"context_line":"        name: Optional Volume Name."},{"line_number":77,"context_line":"        metadata: A dictionary of values to be used as metadata."}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9wkA%3D","line":74,"updated":"2014-04-02 10:16:57.000000000","message":"Please, also remove \u0027Required\u0027 there.","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}],"tempest/services/volume/v2/xml/volumes_client.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"033127fb3707d106b7fc55e2288c9977882ee9b0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def create_volume(self, size\u003dNone, **kwargs):"},{"line_number":121,"context_line":"        \"\"\"Creates a new Volume."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        :param size: Size of volume in GB. (Required)"},{"line_number":124,"context_line":"        :param name: Optional Volume Name."},{"line_number":125,"context_line":"        :param metadata: An optional dictionary of values for metadata."},{"line_number":126,"context_line":"        :param volume_type: Optional Name of volume_type for the volume"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9wkE%3D","line":123,"updated":"2014-04-02 10:16:57.000000000","message":"Please, also remove \u0027Required\u0027 there.","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}],"tempest/services/volume/xml/volumes_client.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"033127fb3707d106b7fc55e2288c9977882ee9b0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def create_volume(self, size\u003dNone, **kwargs):"},{"line_number":122,"context_line":"        \"\"\"Creates a new Volume."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        :param size: Size of volume in GB. (Required)"},{"line_number":125,"context_line":"        :param display_name: Optional Volume Name."},{"line_number":126,"context_line":"        :param metadata: An optional dictionary of values for metadata."},{"line_number":127,"context_line":"        :param volume_type: Optional Name of volume_type for the volume"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9wj4%3D","line":124,"updated":"2014-04-02 10:16:57.000000000","message":"Please, also remove \u0027Required\u0027 there.","commit_id":"4f94253d6d5d4c82ee8657b3f25900ab1cbbfe86"}]}