)]}'
{"tempest/api_schema/compute/aggregates.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4a21ece3d62d20f09245884533998c975e44985a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                    \u0027properties\u0027: {"},{"line_number":25,"context_line":"                        \u0027availability_zone\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"                        \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":27,"context_line":"                        \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":28,"context_line":"                        \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"                        \u0027hosts\u0027: {\u0027type\u0027: \u0027array\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B%2BsQ%3D","line":26,"updated":"2014-03-21 08:03:03.000000000","message":"nit: better to put date info (created_at, deleted_at, updated_at) at the same place for the maintenancebility.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"f11d27c67dd594ebfa58ffdbd049879e3e2b209d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                    \u0027properties\u0027: {"},{"line_number":25,"context_line":"                        \u0027availability_zone\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"                        \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":27,"context_line":"                        \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":28,"context_line":"                        \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"                        \u0027hosts\u0027: {\u0027type\u0027: \u0027array\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B0IA%3D","line":26,"in_reply_to":"AAAAWH%2F%2B%2BsQ%3D","updated":"2014-03-24 04:43:09.000000000","message":"The order of the properties determined like this is trying to be inconsistent with the order of the sample file.\n\nSo I think it\u0027s easy to review in this order.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0784668ea86df1af8a2d8938806bd97780c4d991","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                    \u0027properties\u0027: {"},{"line_number":25,"context_line":"                        \u0027availability_zone\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"                        \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":27,"context_line":"                        \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":28,"context_line":"                        \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"                        \u0027hosts\u0027: {\u0027type\u0027: \u0027array\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B0E0%3D","line":26,"in_reply_to":"AAAAWH%2F%2B0IA%3D","updated":"2014-03-24 04:59:32.000000000","message":"I got it, thanks.\ncurrent order is already nice.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4a21ece3d62d20f09245884533998c975e44985a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":32,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":34,"context_line":"                    }"},{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B%2BtA%3D","line":34,"updated":"2014-03-21 08:03:03.000000000","message":"\u0027required\u0027 seems necessary.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"f11d27c67dd594ebfa58ffdbd049879e3e2b209d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":32,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":34,"context_line":"                    }"},{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B0I0%3D","line":34,"in_reply_to":"AAAAWH%2F%2B%2BtA%3D","updated":"2014-03-24 04:43:09.000000000","message":"@Ken\u0027ichi Ohmichi\n\nThanks for the review.\n\nIf no aggregate is created in advance, we can only get the response like: {\"aggregates\": []}, so I think there is no \u0027required\u0027 property of \u0027aggregates\u0027.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"efc9deeb330fbb63e1eec37721a485bf48b55090","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":32,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":34,"context_line":"                    }"},{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2Bzqs%3D","line":34,"in_reply_to":"AAAAWH%2F%2B0E8%3D","updated":"2014-03-24 06:52:19.000000000","message":"I will add the \u0027required\u0027 attribute.","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0784668ea86df1af8a2d8938806bd97780c4d991","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":32,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":34,"context_line":"                    }"},{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2B0E8%3D","line":34,"in_reply_to":"AAAAWH%2F%2B0I0%3D","updated":"2014-03-24 04:59:32.000000000","message":"The array of line 21 can cover the above case([]).\nSo \u0027required\u0027 is required ;-)","commit_id":"bada27c432fc77616186fc16ccc2e0fbf5c42855"}]}