)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8246372dc8d41f01e35cfff68982683e6fc35f56","unresolved":true,"context_lines":[{"line_number":24,"context_line":"environment and thus it isn\u0027t possible to wait until the instance is"},{"line_number":25,"context_line":"pingable or accessible over ssh."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: https://review.opendev.org/c/openstack/requirements/+/819288"},{"line_number":28,"context_line":"Change-Id: Ib14fa7dc5c8093eed498049cd0a56c8ac6853660"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"02981a5c_84275a84","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":72},"updated":"2021-12-01 21:38:37.000000000","message":"can you push it for master requirements ?","commit_id":"9070f77f9edf8e9bd0ae233cb1236c341fe7dd1a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f00d31e61729aebc256a1af5ace7704da1dedc30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e38923c_188fc1c7","updated":"2021-11-12 08:28:04.000000000","message":"I\u0027ll break this down into a few changes later today and will likely switch out the use of icmplib or lower the requirement to allow it to run on older stable branches.","commit_id":"461a0134513a96ecffa55643f8990781b38d2304"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8246372dc8d41f01e35cfff68982683e6fc35f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1b70e827_a48cb627","updated":"2021-12-01 21:38:37.000000000","message":"overall lgtm, this is correct way to make sure server is ready. I am +2 on this but waiting for the requirement patch to be up and corrected in depends-on","commit_id":"9070f77f9edf8e9bd0ae233cb1236c341fe7dd1a"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"27b1b08a9f45352027895f2da68b9daf96575d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fe3cb37a_518b0db9","updated":"2022-02-07 13:42:01.000000000","message":"Looks like dependent change either need to be removed (not needed) or rebased.\nThe dependent changes also does not uses the icmplib/PING so it might be added at a later time.\n","commit_id":"30febdfc6f162bcabd3e60271d07572fa5ad40ce"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"74b88e37ca2285916bde17810d3627a4d8ae20f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"581be04d_cd84b238","updated":"2022-02-11 14:25:45.000000000","message":"This will probably resolve bug 1960346 as well.","commit_id":"30febdfc6f162bcabd3e60271d07572fa5ad40ce"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6d3b31690cda7455cf4f5071a00e8f5b51b0b1cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"682213ce_046a32f8","updated":"2022-03-03 07:13:37.000000000","message":"recheck","commit_id":"0b4bc3dcc6ac46b05048dd869231f6784fc69389"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8fcfcf9d663b41594114d2ed7f1c3446535499c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"da2fbc79_f14e4cb4","updated":"2022-03-03 14:21:05.000000000","message":"recheck identity error","commit_id":"0b4bc3dcc6ac46b05048dd869231f6784fc69389"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e31c44ea0875f8a13835440335bb810775b88bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5421f8f5_6b332507","updated":"2022-03-03 19:07:15.000000000","message":"this is all good, child patches in this series are enabling the ssh-able and passig fine.","commit_id":"0b4bc3dcc6ac46b05048dd869231f6784fc69389"}],"requirements.txt":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"ffafdfa8ead40fd7c154b0916026fa89c5d84a0e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"PrettyTable\u003e\u003d0.7.1 # BSD"},{"line_number":22,"context_line":"urllib3\u003e\u003d1.21.1 # MIT"},{"line_number":23,"context_line":"debtcollector\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":24,"context_line":"icmplib\u003e\u003d2.1.1 # LGPLv3+"}],"source_content_type":"text/plain","patch_set":12,"id":"76c49d4a_09d24118","line":24,"updated":"2022-02-24 01:18:03.000000000","message":"new requirement on stable branches might be problematic,\ncould this new dep be avoided for the sake of stable branches?","commit_id":"054bb3521ce56c76d75f633b7ac5341297c38d59"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"247a83d240117d82f1e18cce14ad7fbe7088ff05","unresolved":true,"context_lines":[{"line_number":21,"context_line":"PrettyTable\u003e\u003d0.7.1 # BSD"},{"line_number":22,"context_line":"urllib3\u003e\u003d1.21.1 # MIT"},{"line_number":23,"context_line":"debtcollector\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":24,"context_line":"icmplib\u003e\u003d2.1.1 # LGPLv3+"}],"source_content_type":"text/plain","patch_set":12,"id":"fc2fcf83_6ff9770b","line":24,"in_reply_to":"76c49d4a_09d24118","updated":"2022-02-28 16:58:39.000000000","message":"well tempest is branchless and we install tempest in a venv so im not sure it woudl matter in this case. im not sure if this is easy to remvoe or not but i would not avoid a new dep or dep bump on that grounds at the expence of code complexiyt.","commit_id":"054bb3521ce56c76d75f633b7ac5341297c38d59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8169c0680f9d837a064cdfe8f9e82356366f5bd2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"PrettyTable\u003e\u003d0.7.1 # BSD"},{"line_number":22,"context_line":"urllib3\u003e\u003d1.21.1 # MIT"},{"line_number":23,"context_line":"debtcollector\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":24,"context_line":"icmplib\u003e\u003d2.1.1 # LGPLv3+"}],"source_content_type":"text/plain","patch_set":12,"id":"991842c5_16cdd1e0","line":24,"in_reply_to":"fc2fcf83_6ff9770b","updated":"2022-02-28 22:53:33.000000000","message":"I would avoid the new requirement, mainly because in the comments of https://review.opendev.org/c/openstack/requirements/+/820378 it\u0027s mentioned that the lib lacks testing in the codebase, that might be problematic in the future. I think it\u0027s possible to create the waiter even without this dependency, I\u0027ll try have a look at this tomorrow.","commit_id":"054bb3521ce56c76d75f633b7ac5341297c38d59"}],"tempest/common/waiters.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"026f57d2129eaaef7db5f0971b7f7bde4148e37b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"import re"},{"line_number":14,"context_line":"import time"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import icmplib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"2b598dfe_4d973f71","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":14},"updated":"2022-02-28 17:00:43.000000000","message":"ok so looking at the usage the simple way to avoid the dep woudl be to span a shell or use popen to execute the ping.\n\nthat does not seam unreasonable to do but using existing python bindings is often preferable to writing wrappers for cli.","commit_id":"054bb3521ce56c76d75f633b7ac5341297c38d59"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f26ac9496c5f5019efbd10a803a6428b7a0919bc","unresolved":true,"context_lines":[{"line_number":580,"context_line":"        response \u003d os.system(\"ping -c 1 \" + server_ip)"},{"line_number":581,"context_line":"        if response \u003d\u003d 0:"},{"line_number":582,"context_line":"            return"},{"line_number":583,"context_line":"        else:"},{"line_number":584,"context_line":"            if int(time.time()) - start_time \u003e\u003d timeout:"},{"line_number":585,"context_line":"                raise lib_exc.TimeoutException()"},{"line_number":586,"context_line":"            time.sleep(interval)"}],"source_content_type":"text/x-python","patch_set":14,"id":"f0dd2aa0_9ee4ba41","line":583,"range":{"start_line":583,"start_character":7,"end_line":583,"end_character":13},"updated":"2022-03-01 14:39:06.000000000","message":"this can be removed from the logical perspective, it\u0027ll be easier readable","commit_id":"daededf038d63ad05755032000f7aa9e295835e7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f26ac9496c5f5019efbd10a803a6428b7a0919bc","unresolved":true,"context_lines":[{"line_number":586,"context_line":"            time.sleep(interval)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"def wait_for_ssh(ssh_client, timeout):"},{"line_number":590,"context_line":"    \"\"\"Waits for SSH connection to become usable\"\"\""},{"line_number":591,"context_line":"    start \u003d int(time.time())"},{"line_number":592,"context_line":"    while int(time.time()) - start \u003c timeout:"}],"source_content_type":"text/x-python","patch_set":14,"id":"6619b871_2856928f","line":589,"range":{"start_line":589,"start_character":29,"end_line":589,"end_character":36},"updated":"2022-03-01 14:39:06.000000000","message":"maybe set a default value?","commit_id":"daededf038d63ad05755032000f7aa9e295835e7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f26ac9496c5f5019efbd10a803a6428b7a0919bc","unresolved":true,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"def wait_for_ssh(ssh_client, timeout):"},{"line_number":590,"context_line":"    \"\"\"Waits for SSH connection to become usable\"\"\""},{"line_number":591,"context_line":"    start \u003d int(time.time())"},{"line_number":592,"context_line":"    while int(time.time()) - start \u003c timeout:"},{"line_number":593,"context_line":"        try:"},{"line_number":594,"context_line":"            ssh_client.validate_authentication()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3d532e2f_e291bc4a","line":591,"range":{"start_line":591,"start_character":4,"end_line":591,"end_character":9},"updated":"2022-03-01 14:39:06.000000000","message":"use start_time to have in unified with the rest of the waiters","commit_id":"daededf038d63ad05755032000f7aa9e295835e7"}]}