)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"520bccc8316dec30df73798ae7e6b2647fc2116d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"071e704d_9fa7bac5","updated":"2021-11-22 19:43:15.000000000","message":"Thanks; i\u0027m unsure if this is the way to go for plugin config - but, i would like the solution to be consistent with the rest of the services, and this patch makes it so. ","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"06e8bdfd096ad04ec7c08682d1821c675e7b8bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5786df4_a3fb5367","updated":"2021-11-21 14:10:01.000000000","message":"recheck","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"82e54a04a4feb8cc0066c07a0070c88d5ce5538f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffdcb002_5215e5a5","updated":"2021-11-25 14:21:23.000000000","message":"this should go here as suggested judging based on this commit message - https://opendev.org/openstack/tempest/commit/6fb55c8fc3c64317f668440b8d394ad2f052ca73 - although i\u0027m also not sure, adding Ghanshyam to double check that","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3bc3ae2d7b98c3184fb2b41f71494786e355b08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15ac9bf6_31f43664","updated":"2021-11-25 16:37:59.000000000","message":"yeah, we have the way for plugins to register the tempest config option from plugin. there is no difference in those except plugin specific config option lives in plugin\u0027s config.py everything else like registration, access to/from tempest namespace.\n\nYou can add it in manila-tempest-plugin config file like done for service_availability[1] or enforce_scope in other plugins, example.\n\nAdd: https://github.com/openstack/ironic-tempest-plugin/blob/663ced6346fcbb3fe74bd750a8100f66e0c3df5e/ironic_tempest_plugin/config.py#L33\n\nRegister: https://github.com/openstack/ironic-tempest-plugin/blob/663ced6346fcbb3fe74bd750a8100f66e0c3df5e/ironic_tempest_plugin/plugin.py#L46\n\nAccess: https://github.com/openstack/ironic-tempest-plugin/blob/c77d2aebe3f85f1aa38a3561dc3a2eec6ed38e69/ironic_tempest_plugin/tests/scenario/baremetal_manager.py#L95\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/8866127d8b9bc7c2811c9025be8acf2228adb0f8/manila_tempest_tests/plugin.py#L34","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fafebd39999c89b5593ea48349ebe68316c20710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2cccef81_93d2ef2f","in_reply_to":"15ac9bf6_31f43664","updated":"2021-11-25 18:26:33.000000000","message":"Thanks Ghanshyam!\n\nDone here:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/819362","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"}],"tempest/config.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"de38148497786e9c6add2f6926e3df8f8795a90f","unresolved":true,"context_lines":[{"line_number":1248,"context_line":"                help\u003d\u0027Does the Identity service API policies enforce scope? \u0027"},{"line_number":1249,"context_line":"                     \u0027This configuration value should be same as \u0027"},{"line_number":1250,"context_line":"                     \u0027keystone.conf: [oslo_policy].enforce_scope option.\u0027),"},{"line_number":1251,"context_line":"    cfg.BoolOpt(\u0027manila\u0027,"},{"line_number":1252,"context_line":"                default\u003dFalse,"},{"line_number":1253,"context_line":"                help\u003d\u0027Does the Share service API policies enforce scope? \u0027"},{"line_number":1254,"context_line":"                     \u0027This configuration value should be same as \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc6434f2_5e639c53","line":1251,"updated":"2021-11-22 20:20:10.000000000","message":"Not sure its the right place to enable this flag here ? if tempest does not run manila tests it make sense to enable it in the plugin....\nbut maybe i am wrong.","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"26fee48a3b47cf025f17dd1ad0cea8d4b2a73220","unresolved":true,"context_lines":[{"line_number":1248,"context_line":"                help\u003d\u0027Does the Identity service API policies enforce scope? \u0027"},{"line_number":1249,"context_line":"                     \u0027This configuration value should be same as \u0027"},{"line_number":1250,"context_line":"                     \u0027keystone.conf: [oslo_policy].enforce_scope option.\u0027),"},{"line_number":1251,"context_line":"    cfg.BoolOpt(\u0027manila\u0027,"},{"line_number":1252,"context_line":"                default\u003dFalse,"},{"line_number":1253,"context_line":"                help\u003d\u0027Does the Share service API policies enforce scope? \u0027"},{"line_number":1254,"context_line":"                     \u0027This configuration value should be same as \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5ce6e47_b3e18ed7","line":1251,"in_reply_to":"cc6434f2_5e639c53","updated":"2021-11-22 21:11:54.000000000","message":"The flag is for enabling rbac tests which are implemented in the tempest plugins.\nlike: https://github.com/openstack/keystone-tempest-plugin/tree/master/keystone_tempest_plugin/tests/rbac\n\nSo if the plan is to implement those tests only within the plugins, I think it\u0027s fine that it\u0027s here.\n\nIn addition, I added the flag here for consistent with other services.\nLet\u0027s see what @Martin thinks.","commit_id":"f08f91c9bcafdd7723dcec7181c328b2ee659961"}]}