)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1c8f5700f425bc10e384198f12d3fb814e33c91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1be3fce_9a5fa430","updated":"2021-12-01 22:42:44.000000000","message":"thanks, this is nice tests few comments otherwise lgtm","commit_id":"916a189f4c6c7dba1673cd1395d5512d0028566e"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"90462c815dbd555142abd8caa0e4903b9598d2f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5b326f6c_b0c1f0d1","updated":"2021-12-02 08:59:50.000000000","message":"recheck","commit_id":"f8fca90e5cda4fdcbc2084458d0f1681b2b4f896"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"1a8f77950a532a571b71fc847660841ca9eb7f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"307edc3d_0a60f752","updated":"2021-12-14 11:08:36.000000000","message":"It will be very good if we can re-use the tests with nova shutdown / shelve and others \nI think we should create another test file called test_multi_attach_volume.py \nand run all related tests there.\n\nit will be nice to test and try nova stop / shelve / migrate while a volume attached to other instances...\n\nBenny","commit_id":"6d38fb282c047d95338a83bae535ae1e73470f1e"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1c8f5700f425bc10e384198f12d3fb814e33c91","unresolved":true,"context_lines":[{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    @decorators.idempotent_id(\u002740ae5c1a-59eb-4db6-b09c-34489a9c7776\u0027)"},{"line_number":501,"context_line":"    def test_delete_server_with_multiattached_bootable_volume(self):"},{"line_number":502,"context_line":"        \"\"\"Test create a bootable multiattach"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        volume with delete_on_termination\u003dTrue, create server1 from the"},{"line_number":505,"context_line":"        volume, then attach it to server2, and then delete server1 in which"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a60ec39_d6f412ee","line":502,"range":{"start_line":502,"start_character":11,"end_line":502,"end_character":45},"updated":"2021-12-01 22:42:44.000000000","message":"let\u0027s complete this doc string: \n\nTest multiattach volume booted server does not delete multi attachments","commit_id":"916a189f4c6c7dba1673cd1395d5512d0028566e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1c8f5700f425bc10e384198f12d3fb814e33c91","unresolved":true,"context_lines":[{"line_number":501,"context_line":"    def test_delete_server_with_multiattached_bootable_volume(self):"},{"line_number":502,"context_line":"        \"\"\"Test create a bootable multiattach"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        volume with delete_on_termination\u003dTrue, create server1 from the"},{"line_number":505,"context_line":"        volume, then attach it to server2, and then delete server1 in which"},{"line_number":506,"context_line":"        case the volume won\u0027t be deleted because it\u0027s still attached to"},{"line_number":507,"context_line":"        server2 and make sure the volume is still attached to server2."}],"source_content_type":"text/x-python","patch_set":4,"id":"81c581de_eb2caf7c","line":504,"range":{"start_line":504,"start_character":8,"end_line":504,"end_character":15},"updated":"2021-12-01 22:42:44.000000000","message":"Create a bootable multiattach volume.....","commit_id":"916a189f4c6c7dba1673cd1395d5512d0028566e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1c8f5700f425bc10e384198f12d3fb814e33c91","unresolved":true,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":526,"context_line":"            self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        self._detach_multiattach_volume(volume[\u0027id\u0027], server2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"12023e66_dbc2dd52","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":0},"updated":"2021-12-01 22:42:44.000000000","message":"let\u0027s very here of volume is attached to server2 after server1 is deleted\n\n        # Assert the volume is attached to the servers after server1 is deleted.\n        attachments \u003d self.servers_client.list_volume_attachments(\n            server2[\u0027id\u0027])[\u0027volumeAttachments\u0027]\n        self.assertEqual(1, len(attachments))\n        self.assertEqual(volume[\u0027id\u0027], attachments[0][\u0027volumeId\u0027])","commit_id":"916a189f4c6c7dba1673cd1395d5512d0028566e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ec75e079f9379eccad374676aef2757f5383d83","unresolved":true,"context_lines":[{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    @decorators.idempotent_id(\u002740ae5c1a-59eb-4db6-b09c-34489a9c7776\u0027)"},{"line_number":501,"context_line":"    def test_delete_server_with_multiattached_bootable_volume(self):"},{"line_number":502,"context_line":"        \"\"\"Test multiattach volume booted server does not delete multi"},{"line_number":503,"context_line":"        attachments."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        Create a bootable multiattach volume, create server1 from the volume,"},{"line_number":506,"context_line":"        then attach it to server2, and then delete server1 in which case"}],"source_content_type":"text/x-python","patch_set":6,"id":"7bbd1d37_a909fc81","line":503,"range":{"start_line":502,"start_character":11,"end_line":503,"end_character":20},"updated":"2021-12-02 22:31:21.000000000","message":"this needs to be in single line. \n\nTest multiattach volume booted server does not delete multi attachments","commit_id":"f8fca90e5cda4fdcbc2084458d0f1681b2b4f896"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"99806c222021a101bb07959788cf6fe47a2f7ce3","unresolved":false,"context_lines":[{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    @decorators.idempotent_id(\u002740ae5c1a-59eb-4db6-b09c-34489a9c7776\u0027)"},{"line_number":501,"context_line":"    def test_delete_server_with_multiattached_bootable_volume(self):"},{"line_number":502,"context_line":"        \"\"\"Test multiattach volume booted server does not delete multi"},{"line_number":503,"context_line":"        attachments."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        Create a bootable multiattach volume, create server1 from the volume,"},{"line_number":506,"context_line":"        then attach it to server2, and then delete server1 in which case"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5de0e98_d9b0c570","line":503,"range":{"start_line":502,"start_character":11,"end_line":503,"end_character":20},"in_reply_to":"7bbd1d37_a909fc81","updated":"2021-12-14 10:37:04.000000000","message":"Done","commit_id":"f8fca90e5cda4fdcbc2084458d0f1681b2b4f896"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"1a8f77950a532a571b71fc847660841ca9eb7f51","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":439,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":440,"context_line":"            \u0027boot_index\u0027: 0,"},{"line_number":441,"context_line":"            \u0027delete_on_termination\u0027: delete_on_termination}]"},{"line_number":442,"context_line":"        server \u003d self.create_test_server("},{"line_number":443,"context_line":"            image_id\u003d\u0027\u0027, block_device_mapping_v2\u003dbdm, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":444,"context_line":"        # Assert the volume is attached to the server."}],"source_content_type":"text/x-python","patch_set":7,"id":"76e0f28a_985fb089","line":441,"updated":"2021-12-14 11:08:36.000000000","message":"But here you change the way test was created in the first place , cant we delegate the delete to the _create_multiattach_volume function ? \n\nyou just need a waiter for the instance to be deleted.","commit_id":"6d38fb282c047d95338a83bae535ae1e73470f1e"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"bad46bad3308324dee718282d642fbe19b540746","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":439,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":440,"context_line":"            \u0027boot_index\u0027: 0,"},{"line_number":441,"context_line":"            \u0027delete_on_termination\u0027: delete_on_termination}]"},{"line_number":442,"context_line":"        server \u003d self.create_test_server("},{"line_number":443,"context_line":"            image_id\u003d\u0027\u0027, block_device_mapping_v2\u003dbdm, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":444,"context_line":"        # Assert the volume is attached to the server."}],"source_content_type":"text/x-python","patch_set":7,"id":"b28bab73_1253e214","line":441,"in_reply_to":"45f4a1bc_0e7cdea8","updated":"2021-12-16 09:25:33.000000000","message":"the delete_on_termination was False because when you attach the same volume to multiple instances and you decide to delete one of the instances , they assume that the volume is really multi-attached. its ok to have it as param but if you are going to delete on termination you have to verify that the volume attached to a single instance .... \n\nso if you ask to delete the instance when its delete_on_termination\u003dTrue , its ignored on multi-attached when another instance use the same volume?\nIs it expected ?","commit_id":"6d38fb282c047d95338a83bae535ae1e73470f1e"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"72b34f6b57aafc872e91bde373c9b6ca3e692fda","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":439,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":440,"context_line":"            \u0027boot_index\u0027: 0,"},{"line_number":441,"context_line":"            \u0027delete_on_termination\u0027: delete_on_termination}]"},{"line_number":442,"context_line":"        server \u003d self.create_test_server("},{"line_number":443,"context_line":"            image_id\u003d\u0027\u0027, block_device_mapping_v2\u003dbdm, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":444,"context_line":"        # Assert the volume is attached to the server."}],"source_content_type":"text/x-python","patch_set":7,"id":"45f4a1bc_0e7cdea8","line":441,"in_reply_to":"76e0f28a_985fb089","updated":"2021-12-16 09:10:13.000000000","message":"Sorry,do you mean delegate delete_on_termination parameter to _create_multiattach_volume function? but create function does not support this parameter，can you give me some detailed suggestions?","commit_id":"6d38fb282c047d95338a83bae535ae1e73470f1e"}]}