)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"23bf63e7394f5afdd3c2fcbf6746dcbec4b9c846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97372ec7_23e594da","updated":"2021-12-08 17:11:18.000000000","message":"Looks good to me, with optional nits like missing docstrings for classes","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"280b663ca9c443e01a5a1d56776555d6868ec34c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc809f29_44315ab6","updated":"2021-12-08 17:34:05.000000000","message":"Thanks, will update accordingly.","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1328b21af1cad6ad623bfcfe9f259f2ff3560491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bc80ae79_dc7e7e50","updated":"2021-12-09 02:04:34.000000000","message":"positive tests case lgtm but we do not need to add more negative tests in tempest.","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d38e22e62258430d3011322d531a702f41719ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03f0d503_8101eeda","updated":"2021-12-16 16:13:51.000000000","message":"Thanks James. lgtm, can you please add the 2.86 microversion (that it is covered in testing) in this doc also- https://github.com/openstack/tempest/blob/master/doc/source/microversion_testing.rst#microversion-tests-implemented-in-tempest","commit_id":"17b1bc1a88d3fefd3f3335d447b467ce38b21d4f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"fb1b3e3f674a90c542b65f71f200a2040d665174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0901d621_5fe01705","in_reply_to":"03f0d503_8101eeda","updated":"2021-12-16 16:23:34.000000000","message":"Of course!","commit_id":"17b1bc1a88d3fefd3f3335d447b467ce38b21d4f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5976a91183bd017db0f1a4dc8c8f4c37335ca518","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40d97b15_f2a2592c","updated":"2021-12-16 19:28:31.000000000","message":"recheck","commit_id":"ef0da21010406fba92bd497a7743caf00859b766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"88922bb89bed6ed9d46154ad815ccd9b7846ea3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b60795ba_02a7ac71","updated":"2022-01-06 07:22:03.000000000","message":"recheck","commit_id":"ef0da21010406fba92bd497a7743caf00859b766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"acc3715359a47b084592a6e2e8e35f57b9fd4b56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8635e20_29bcf536","updated":"2022-01-06 13:20:33.000000000","message":"recheck","commit_id":"ef0da21010406fba92bd497a7743caf00859b766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"95bfcd19417a74bfd2e5174b00819566b0fd3776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e64e3b86_fca81a18","updated":"2022-01-10 07:18:48.000000000","message":"recheck","commit_id":"ef0da21010406fba92bd497a7743caf00859b766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d2b01f133f59cdf43d1e7d9db030c2be2616d38d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fda4bad5_c4ff38f5","updated":"2022-01-05 17:29:15.000000000","message":"recheck","commit_id":"ef0da21010406fba92bd497a7743caf00859b766"}],"tempest/api/compute/admin/test_flavors_extra_specs.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"23bf63e7394f5afdd3c2fcbf6746dcbec4b9c846","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class FlavorMetadataValidation(base.BaseV2ComputeAdminTest):"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb84f9a9_be701ab0","line":133,"updated":"2021-12-08 17:11:18.000000000","message":"optional: docstrings?","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"280b663ca9c443e01a5a1d56776555d6868ec34c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class FlavorMetadataValidation(base.BaseV2ComputeAdminTest):"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"41b3781f_586200cb","line":133,"in_reply_to":"eb84f9a9_be701ab0","updated":"2021-12-08 17:34:05.000000000","message":"Ack","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1328b21af1cad6ad623bfcfe9f259f2ff3560491","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d3114f03-b0f2-4dc7-be11-70c0abc178b3\u0027)"},{"line_number":148,"context_line":"    def test_flavor_update_with_custom_namespace(self):"},{"line_number":149,"context_line":"        \"\"\"Test non admin user getting specific flavor extra spec key\"\"\""},{"line_number":150,"context_line":"        flavor_name \u003d data_utils.rand_name(self.flavor_name_prefix)"},{"line_number":151,"context_line":"        flavor_id \u003d self.create_flavor(ram\u003dself.ram,"},{"line_number":152,"context_line":"                                       vcpus\u003dself.vcpus,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a0d2ef2_f24705b6","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":72},"updated":"2021-12-09 02:04:34.000000000","message":"it seem admin updating the custome extraspecs right?","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c62c7e999e65facccea6d3bedbd9fd6202eb2392","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @decorators.idempotent_id(\u0027d3114f03-b0f2-4dc7-be11-70c0abc178b3\u0027)"},{"line_number":148,"context_line":"    def test_flavor_update_with_custom_namespace(self):"},{"line_number":149,"context_line":"        \"\"\"Test non admin user getting specific flavor extra spec key\"\"\""},{"line_number":150,"context_line":"        flavor_name \u003d data_utils.rand_name(self.flavor_name_prefix)"},{"line_number":151,"context_line":"        flavor_id \u003d self.create_flavor(ram\u003dself.ram,"},{"line_number":152,"context_line":"                                       vcpus\u003dself.vcpus,"}],"source_content_type":"text/x-python","patch_set":1,"id":"23b3a959_49e87486","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":72},"in_reply_to":"4a0d2ef2_f24705b6","updated":"2021-12-15 20:12:09.000000000","message":"Correct this needs to be updated.","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"}],"tempest/api/compute/admin/test_flavors_extra_specs_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1328b21af1cad6ad623bfcfe9f259f2ff3560491","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                          \u0027hw:numa_nodes\u0027,"},{"line_number":145,"context_line":"                          **{\u0027hw:numa_nodes\u0027: \u00271\u0027, \u0027hw:cpu_policy\u0027: \u0027shared\u0027})"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class FlavorMetadataNegativeValidation(base.BaseV2ComputeAdminTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"56ab2bcb_3d30f072","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":68},"updated":"2021-12-09 02:04:34.000000000","message":"We do not need to add more negative test in tempest as such instead they can be covered in nova functional/unit tests.\n\nhttps://docs.openstack.org/tempest/latest/HACKING.html#negative-tests\n\nExisting negative tests we have kept in tempest is only for the interop WG.","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c62c7e999e65facccea6d3bedbd9fd6202eb2392","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                          \u0027hw:numa_nodes\u0027,"},{"line_number":145,"context_line":"                          **{\u0027hw:numa_nodes\u0027: \u00271\u0027, \u0027hw:cpu_policy\u0027: \u0027shared\u0027})"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class FlavorMetadataNegativeValidation(base.BaseV2ComputeAdminTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"43f896d7_f539aaeb","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":68},"in_reply_to":"56ab2bcb_3d30f072","updated":"2021-12-15 20:12:09.000000000","message":"ACK, thanks for the pointer as well.","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"23bf63e7394f5afdd3c2fcbf6746dcbec4b9c846","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class FlavorMetadataNegativeValidation(base.BaseV2ComputeAdminTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3db6ae34_479a0764","line":149,"updated":"2021-12-08 17:11:18.000000000","message":"optional: docstrings?","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"280b663ca9c443e01a5a1d56776555d6868ec34c","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class FlavorMetadataNegativeValidation(base.BaseV2ComputeAdminTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    min_microversion \u003d \u00272.86\u0027"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8b94bae_e0661214","line":149,"in_reply_to":"3db6ae34_479a0764","updated":"2021-12-08 17:34:05.000000000","message":"Ack","commit_id":"997d7c27674ffd187922bc67bdf187003e72ad00"}]}