)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"513c36531547992652bfc821ab8981729c1d9b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6576866c_62afd856","updated":"2021-12-02 16:51:53.000000000","message":"thanks","commit_id":"b0ee03e568560a3ec558da09e811284ee996bdd2"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8db8b33a73060acdf4616c2a3f91410fc194fd08","unresolved":true,"context_lines":[{"line_number":658,"context_line":"            cls.os_admin.availability_zone_client)"},{"line_number":659,"context_line":"        cls.admin_flavors_client \u003d cls.os_admin.flavors_client"},{"line_number":660,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":661,"context_line":"        cls.admin_image_client \u003d cls.os_admin.image_client_v2"},{"line_number":662,"context_line":"        cls.admin_assisted_volume_snapshots_client \u003d \\"},{"line_number":663,"context_line":"            cls.os_admin.assisted_volume_snapshots_client"},{"line_number":664,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f9e37158_527dadf5","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":61},"updated":"2021-12-01 21:42:46.000000000","message":"so you are changing it because admin test derived from BaseV2ComputeAdminTest will get self.image_client as admin client and no way to use self.image_client as non admin right ? though you can do cls.os_primary.image_client_v2 but self/image_client can be confusing.\n\nIf that is use case I am good on this change.\n\n\nThese alias are killing things, sometime we should just remove all and let tests do os_admin|primary.*","commit_id":"b0ee03e568560a3ec558da09e811284ee996bdd2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1f99272df25aef83dd48386f7f2947175aa73a0e","unresolved":true,"context_lines":[{"line_number":658,"context_line":"            cls.os_admin.availability_zone_client)"},{"line_number":659,"context_line":"        cls.admin_flavors_client \u003d cls.os_admin.flavors_client"},{"line_number":660,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":661,"context_line":"        cls.admin_image_client \u003d cls.os_admin.image_client_v2"},{"line_number":662,"context_line":"        cls.admin_assisted_volume_snapshots_client \u003d \\"},{"line_number":663,"context_line":"            cls.os_admin.assisted_volume_snapshots_client"},{"line_number":664,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4c389267_e293a2e7","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":61},"in_reply_to":"f9e37158_527dadf5","updated":"2021-12-01 21:56:05.000000000","message":"\u003e so you are changing it because admin test derived from BaseV2ComputeAdminTest will get self.image_client as admin client and no way to use self.image_client as non admin right ? though you can do cls.os_primary.image_client_v2 but self/image_client can be confusing.\n\nYes.\n\n\u003e If that is use case I am good on this change.\n\nCool!\n\n\u003e These alias are killing things, sometime we should just remove all and let tests do os_admin|primary.*\n\n+1000 😄","commit_id":"b0ee03e568560a3ec558da09e811284ee996bdd2"}]}