)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ebfa1996d5c490fa39c4bab2a45acfbd886d8878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9abc1e2_57f84b84","updated":"2022-01-10 13:13:43.000000000","message":"I don\u0027t think we don\u0027t need this any more because we found RGW had come up but had crashed. We didn\u0027t need to sleep to wait for it. Instead we get it to not crash as  described in this review.\n\n https://review.opendev.org/c/openstack/tripleo-ci/+/808215\n\nI recommend this patch be abandoned. ","commit_id":"e2c7ca2ea53d57e3ac8bc6a6e3776047d542fc50"}],"tempest/scenario/test_object_storage_basic_ops.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"dd071eb7cf57e2cec85d5821875b0217e6e0ac1f","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        5. Delete the object and container"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        # temporarily add sleep to see if this fixes this test for ceph"},{"line_number":66,"context_line":"        time.sleep(120)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        container_name \u003d self.create_container()"},{"line_number":69,"context_line":"        obj_name, obj_data \u003d self.upload_object_to_container(container_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3879be4c_2bfa4a28","line":66,"updated":"2021-12-06 07:08:21.000000000","message":"I think we should add waiters and verify_resouce actions for swift.\nif we create a resource we should wait till it created with proper status.","commit_id":"e3d82506e58ebce9bba7c03507abe1386f4d0511"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b07fa924e9b15e25bad1ec0a681161348740bee1","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        5. Delete the object and container"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        # temporarily add sleep to see if this fixes this test for ceph"},{"line_number":66,"context_line":"        time.sleep(120)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        container_name \u003d self.create_container()"},{"line_number":69,"context_line":"        obj_name, obj_data \u003d self.upload_object_to_container(container_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd159a5a_0359f412","line":66,"in_reply_to":"3879be4c_2bfa4a28","updated":"2021-12-06 14:53:49.000000000","message":"I agree. Something like:\n\n  i \u003d 0\n  while resp.status \u003c 500\n    resp, _ \u003d self.object_client.raw_request(obj_url, \u0027GET\u0027)\n    time.sleep(120)\n    i +\u003d 1\n    if i \u003e 50:\n      break","commit_id":"e3d82506e58ebce9bba7c03507abe1386f4d0511"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e05b2233f789687405ec8b2ee583927e4fb442e6","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        5. Delete the object and container"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        # temporarily add sleep to see if this fixes this test for ceph"},{"line_number":66,"context_line":"        time.sleep(120)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        container_name \u003d self.create_container()"},{"line_number":69,"context_line":"        obj_name, obj_data \u003d self.upload_object_to_container(container_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ff8c8c4_0df0e7e9","line":66,"in_reply_to":"bd159a5a_0359f412","updated":"2021-12-09 06:40:12.000000000","message":"Yes, we have to add:\n#1 def wait_for_resource_deletion(self, id, *args, **kwargs)\nUnder rest client code we can veify that resource is being deleted in case of dependency,\n\n#2 under tempest/common/waiters.py we can add the method for :\ndef wait_for_object_storage_status(client, obj_id, status)\n\nI think we should add when  we create or update resource , move to the next command only when we got active state . it will allow us to jump to next commend when resource show returns valid status.\nLet me know , lets have the problematic tests with random failures and we / I can add patch for that.\n\nBenny","commit_id":"e3d82506e58ebce9bba7c03507abe1386f4d0511"}]}
