)]}'
{"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ceb5b618c6d3d4e02167aa70519228dac25de369","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ServersTestJSON(base.CommonComputeTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _api_version \u003d 2"},{"line_number":24,"context_line":"    _access_ip_v6 \u003d \"accessIPv6\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_bc02263c","line":21,"updated":"2014-05-03 08:12:43.000000000","message":"s/base.CommonComputeTest/base.BaseComputeTest/","commit_id":"bb700d2732d3d9846a8583b6297375c71815d400"}],"tempest/api/compute/v3/servers/test_servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ceb5b618c6d3d4e02167aa70519228dac25de369","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    _api_version \u003d 3"},{"line_number":21,"context_line":"    _access_ip_v6 \u003d \u0027os-access-ips:access_ip_v6\u0027"},{"line_number":22,"context_line":"    _access_ip_v4 \u003d \u0027os-access-ips:access_ip_v4\u0027"},{"line_number":23,"context_line":"    _admin_password \u003d \u0027admin_password\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_1ce1529a","line":23,"updated":"2014-05-03 08:12:43.000000000","message":"Now the design has been changed, so please move this test class into tempest/api/compute/servers/test_servers.py and remove this file for more cleanup.","commit_id":"bb700d2732d3d9846a8583b6297375c71815d400"}],"tempest/services/compute/v3/json/servers_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ef9458943e44ebf8ffd340df78d56f70c9ac3ba0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        server_id: The id of an existing server."},{"line_number":115,"context_line":"        name: The name of the server."},{"line_number":116,"context_line":"        access_ip_v4: The IPv4 access address for the server."},{"line_number":117,"context_line":"        access_ip_v6: The IPv6 access address for the server."},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        post_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_7fae8b82","line":117,"updated":"2014-05-06 16:58:37.000000000","message":"Please update the docstring.\n\nOn another level, I dont like the way the method\u0027s signature is \"offuscated\" with one big kwarg argument. If we expect for sure something that represents an IP address, then the signature should reflect this.","commit_id":"5a4971df4f6c0d21312908dcea1d1653875f5b82"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"346c4debbdf39e5a2a33f1dc9bf54e59a5b8e08a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        server_id: The id of an existing server."},{"line_number":115,"context_line":"        name: The name of the server."},{"line_number":116,"context_line":"        access_ip_v4: The IPv4 access address for the server."},{"line_number":117,"context_line":"        access_ip_v6: The IPv6 access address for the server."},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        post_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_49060422","line":117,"in_reply_to":"9ad9bd40_7fae8b82","updated":"2014-05-08 07:49:04.000000000","message":"yes, but we need cover access_ip_v6 and accessIPv6","commit_id":"5a4971df4f6c0d21312908dcea1d1653875f5b82"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"64a539ae10a5ff136cd3cdb62c01f1c53629b0be","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    \u0027access_ip_v4\u0027:"},{"line_number":91,"context_line":"                    kwargs.get(\u0027access_ip_v4\u0027) or kwargs.get(\u0027accessIPv4\u0027),"},{"line_number":92,"context_line":"                    \u0027access_ip_v6\u0027:"},{"line_number":93,"context_line":"                    kwargs.get(\u0027access_ip_v6\u0027) or kwargs.get(\u0027accessIPv6\u0027)"},{"line_number":94,"context_line":"                }[key]"},{"line_number":95,"context_line":"            else:"},{"line_number":96,"context_line":"                value \u003d kwargs.get(key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_2bba85de","line":93,"updated":"2014-05-08 14:20:01.000000000","message":"Why we need to add v2 code into v3 client?\nCan\u0027t we avoid it?\n\nThis mix would make less readability.","commit_id":"f3375e20ef799def70f79f6fe3f2c76c8384fd0a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"523a251842f06d55b94d7801c1c45fd4933cadc8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    \u0027access_ip_v4\u0027:"},{"line_number":91,"context_line":"                    kwargs.get(\u0027access_ip_v4\u0027) or kwargs.get(\u0027accessIPv4\u0027),"},{"line_number":92,"context_line":"                    \u0027access_ip_v6\u0027:"},{"line_number":93,"context_line":"                    kwargs.get(\u0027access_ip_v6\u0027) or kwargs.get(\u0027accessIPv6\u0027)"},{"line_number":94,"context_line":"                }[key]"},{"line_number":95,"context_line":"            else:"},{"line_number":96,"context_line":"                value \u003d kwargs.get(key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_51b01443","line":93,"in_reply_to":"7adec928_2bba85de","updated":"2014-05-14 07:06:57.000000000","message":"I wanted to cover both v2 and v3 keywords args.\neg:https://review.openstack.org/#/c/82030/4/tempest/api/compute/servers/test_servers.py#L108","commit_id":"f3375e20ef799def70f79f6fe3f2c76c8384fd0a"}]}
