)]}'
{"tempest/api/orchestration/stacks/test_nova_keypair_resources.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0c9f6a1dbb1985d24f9603d2ec0c1e1a12bd664c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @attr(type\u003d\u0027slow\u0027)"},{"line_number":109,"context_line":"    @testtools.skip(\"Skipped so that https://review.openstack.org/76904 can \""},{"line_number":110,"context_line":"                    \"merge\")"},{"line_number":111,"context_line":"    def test_stack_keypairs_output(self):"},{"line_number":112,"context_line":"        resp, stack \u003d self.client.get_stack(self.stack_name)"},{"line_number":113,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BYbM%3D","line":110,"updated":"2014-03-27 07:39:03.000000000","message":"Please use\n\n @test.skip_because(bug\u003d\"1297685\")\n\ninstead of using testtools.skip directly.","commit_id":"2e93697674bd6f62bedbd2167f528828f5900fbe"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"47529f560b3b2e944e3f490621e2d7f970673936","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            output_map[outputs[\u0027output_key\u0027]] \u003d outputs[\u0027output_value\u0027]"},{"line_number":119,"context_line":"        #Test that first key generated public and private keys"},{"line_number":120,"context_line":"        self.assertTrue(\u0027KeyPair_PublicKey\u0027 in output_map)"},{"line_number":121,"context_line":"        self.assertTrue(\"Generated by\" in output_map[\u0027KeyPair_PublicKey\u0027])"},{"line_number":122,"context_line":"        self.assertTrue(\u0027KeyPair_PrivateKey\u0027 in output_map)"},{"line_number":123,"context_line":"        self.assertTrue(\u0027-----BEGIN\u0027 in output_map[\u0027KeyPair_PrivateKey\u0027])"},{"line_number":124,"context_line":"        #Test that second key generated public key, and private key is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bjw0%3D","line":121,"updated":"2014-03-25 22:21:24.000000000","message":"why not just make this assertTrue less strict?","commit_id":"2e93697674bd6f62bedbd2167f528828f5900fbe"},{"author":{"_account_id":2036,"name":"Juerg Haefliger","email":"juerg.haefliger@hpe.com","username":"juergh"},"change_message_id":"aa0b455e3a08e0ce1f16cda0099646f94dcb4612","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            output_map[outputs[\u0027output_key\u0027]] \u003d outputs[\u0027output_value\u0027]"},{"line_number":119,"context_line":"        #Test that first key generated public and private keys"},{"line_number":120,"context_line":"        self.assertTrue(\u0027KeyPair_PublicKey\u0027 in output_map)"},{"line_number":121,"context_line":"        self.assertTrue(\"Generated by\" in output_map[\u0027KeyPair_PublicKey\u0027])"},{"line_number":122,"context_line":"        self.assertTrue(\u0027KeyPair_PrivateKey\u0027 in output_map)"},{"line_number":123,"context_line":"        self.assertTrue(\u0027-----BEGIN\u0027 in output_map[\u0027KeyPair_PrivateKey\u0027])"},{"line_number":124,"context_line":"        #Test that second key generated public key, and private key is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BgxM%3D","line":121,"in_reply_to":"AAAAWH%2F%2Bjw0%3D","updated":"2014-03-26 09:33:19.000000000","message":"I don\u0027t have a good argument against that other than that it makes the test slightly more complicated and lazy.\n\nI could do:\n(re.search(\u0027Generated[ \\-]by\u0027, output_map[\u0027KeyPair_PublicKey\u0027] is not None)\nor: \n(\"Generated by\" in output_map[\u0027KeyPair_PublicKey\u0027] or \"Generated-by\" in output_map[\u0027KeyPair_PublicKey\u0027])\n\nOr do you have another suggestion?","commit_id":"2e93697674bd6f62bedbd2167f528828f5900fbe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"d2ef957b5ada716cbaad7e79b7435f21b585bdfe","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        for outputs in stack[\u0027outputs\u0027]:"},{"line_number":117,"context_line":"            output_map[outputs[\u0027output_key\u0027]] \u003d outputs[\u0027output_value\u0027]"},{"line_number":118,"context_line":"        #Test that first key generated public and private keys"},{"line_number":119,"context_line":"        self.assertTrue(\u0027KeyPair_PublicKey\u0027 in output_map)"},{"line_number":120,"context_line":"        self.assertTrue(\"Generated by\" in output_map[\u0027KeyPair_PublicKey\u0027])"},{"line_number":121,"context_line":"        self.assertTrue(\u0027KeyPair_PrivateKey\u0027 in output_map)"},{"line_number":122,"context_line":"        self.assertTrue(\u0027-----BEGIN\u0027 in output_map[\u0027KeyPair_PrivateKey\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FVhQ%3D","line":119,"updated":"2014-04-15 09:57:14.000000000","message":"Isn\u0027t enough to remove \u0027  by\u0027  here ?","commit_id":"14c5c5dc97e250530220006b7f8450dcaae45ba0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e12dfdde3108d80fa206f3701037b33b4d34e5bb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        for outputs in stack[\u0027outputs\u0027]:"},{"line_number":117,"context_line":"            output_map[outputs[\u0027output_key\u0027]] \u003d outputs[\u0027output_value\u0027]"},{"line_number":118,"context_line":"        #Test that first key generated public and private keys"},{"line_number":119,"context_line":"        self.assertTrue(\u0027KeyPair_PublicKey\u0027 in output_map)"},{"line_number":120,"context_line":"        self.assertTrue(\"Generated by\" in output_map[\u0027KeyPair_PublicKey\u0027])"},{"line_number":121,"context_line":"        self.assertTrue(\u0027KeyPair_PrivateKey\u0027 in output_map)"},{"line_number":122,"context_line":"        self.assertTrue(\u0027-----BEGIN\u0027 in output_map[\u0027KeyPair_PrivateKey\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fp60%3D","line":119,"in_reply_to":"AAAAW3%2F%2FVhQ%3D","updated":"2014-04-18 13:51:04.000000000","message":"I agree. I fear that is we skip the test, it will be month before it gets reactivated.\nJust checking that \"Generated\" or \"Nova\" is in output_map[\u0027KeyPair_PublicKey\u0027] should be enough.","commit_id":"14c5c5dc97e250530220006b7f8450dcaae45ba0"}]}