)]}'
{"tempest/clients.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"790ef4539e15d37d0b21df33876ac08c01ef2e9a","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            return None"},{"line_number":561,"context_line":"        import heatclient.client"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        keystone \u003d self._get_identity_client(credentials)"},{"line_number":564,"context_line":"        region \u003d CONF.identity.region"},{"line_number":565,"context_line":"        endpoint_type \u003d CONF.orchestration.endpoint_type"},{"line_number":566,"context_line":"        token \u003d keystone.auth_token"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad9bd40_cee466e3","line":563,"updated":"2014-05-05 21:25:22.000000000","message":"Note that the deleted code is setting tenant_name to the non-admin value even though the username and password are admin. I remember one of the heat devs explaining that this was necessary and I don\u0027t see where the new code takes this into account. This may be why \n\ncheck-tempest-dsvm-neutron-heat-slow-icehouse\n\nis failing. It is non-voting for reasons not clear to me and the failure looks non-flaky.","commit_id":"f30f14b3b2819aad065c7a7d1cea5c46f23d36fa"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"ccd552bf95012bf76a3c38be2d51d3ef5359f0ad","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            return None"},{"line_number":561,"context_line":"        import heatclient.client"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        keystone \u003d self._get_identity_client(credentials)"},{"line_number":564,"context_line":"        region \u003d CONF.identity.region"},{"line_number":565,"context_line":"        endpoint_type \u003d CONF.orchestration.endpoint_type"},{"line_number":566,"context_line":"        token \u003d keystone.auth_token"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad9bd40_0d15669b","line":563,"in_reply_to":"9ad9bd40_cee466e3","updated":"2014-05-06 10:52:12.000000000","message":"In fact this logic is never used, as username password and tenants are never empty. The same logic is defined again in http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/manager.py#n1056. \nThe refactor I proposed for that is incorrect in the way you described above.\nI will leave this unchanged, and fix scenario/manager.py instead.","commit_id":"f30f14b3b2819aad065c7a7d1cea5c46f23d36fa"}],"tempest/scenario/manager.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"ccd552bf95012bf76a3c38be2d51d3ef5359f0ad","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @classmethod"},{"line_number":1048,"context_line":"    def credentials(cls):"},{"line_number":1049,"context_line":"        return auth.get_default_credentials(\u0027identity_admin\u0027)"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"    def _load_template(self, base_file, file_name):"},{"line_number":1052,"context_line":"        filepath \u003d os.path.join(os.path.dirname(os.path.realpath(base_file)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad9bd40_6d027270","line":1049,"updated":"2014-05-06 10:52:12.000000000","message":"This is not a correct refactor, it should include the regular user tenant.","commit_id":"f30f14b3b2819aad065c7a7d1cea5c46f23d36fa"}]}