)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"272e11c8f2c6b6c9e53ffcbb1785105b1a428968","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-09 21:36:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The expectation is that the test will fail less often, but it is acknowledged that this is not a complete fix. There should be a failure rate decrease of ~50% ... based on my testing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d0b4a1a7_4a417776","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2021-12-13 10:53:19.000000000","message":"when the commit message contains too long lines, gerrit doesn\u0027t know how to render that and the whole look of the review is weird,\nplease check the commit message format: https://docs.openstack.org/contributors/common/git.html#commit-messages\n\nEvery commit message should have a title - first line, then an empty line should follow, then body of the commit message should follow.\nEvery line should be \u003c 72 chars and in case you reference a bug, it should be referenced by a footer of the commit message:\nCloses-Bug: #number\nor\nRelated-Bug: #number and etc, see https://docs.opendev.org/opendev/infra-manual/latest/developers.html#development-workflow","commit_id":"bb8fda254a19c88102848c5b7e2374ee670e900b"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"e56093f0d7e732daed939c4b301275acd4757605","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-09 21:36:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The expectation is that the test will fail less often, but it is acknowledged that this is not a complete fix. There should be a failure rate decrease of ~50% ... based on my testing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3da8bc9b_928a8a6d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"d0b4a1a7_4a417776","updated":"2021-12-14 14:17:52.000000000","message":"Done","commit_id":"bb8fda254a19c88102848c5b7e2374ee670e900b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a0f8e482feace444a4ad50eada23e09a13bb8d9e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Author:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2021-12-09 16:26:13 -0500"},{"line_number":4,"context_line":"Commit:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-14 16:07:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The expectation is that the test will fail less often, but it is acknowledged that this is not a complete fix. There should be a failure rate decrease of ~50% ... based on my testing"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fee51d4d_c4fb48ab","line":5,"updated":"2021-12-14 22:51:52.000000000","message":"please keep the commit message formatted the following way:\n\u003ctitle of the commit message\u003e\n\u003cempty line\u003e\n\u003cbody of the commit message\u003e","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaed62af0cee28d29f1290d5844349ef5060de9f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-20 14:31:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The bug was in check_uuid.py and not in the test itself. As part of the fix, enabled check_uuid.py to run a validation of a module in any dir by adding --libpath parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7b7a8c8e_05ffdf75","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2021-12-21 09:52:17.000000000","message":"edit the commit message so that it follows certain rules set for commit messages - https://docs.openstack.org/contributors/common/git.html#commit-messages\n\nMainly 2 things are missing here:\n* title of the commit message divided from the body of the message by an empty line \n* lines shouldn\u0027t be longer than 72 chars","commit_id":"cb05fbfab67818f20f52d681311ca80b3c4bf4d9"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"dc0de73b4b52e818ab70590346f67cb9a690a691","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Yefimov \u003cayefimov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-20 14:31:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The bug was in check_uuid.py and not in the test itself. As part of the fix, enabled check_uuid.py to run a validation of a module in any dir by adding --libpath parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"a4a2a47f_1a621a60","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"in_reply_to":"7b7a8c8e_05ffdf75","updated":"2021-12-21 18:41:37.000000000","message":"Done -- sorry. This is the second time you reminded be about the commit message format","commit_id":"cb05fbfab67818f20f52d681311ca80b3c4bf4d9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaed62af0cee28d29f1290d5844349ef5060de9f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-12-20 14:31:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The bug was in check_uuid.py and not in the test itself. As part of the fix, enabled check_uuid.py to run a validation of a module in any dir by adding --libpath parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"0669d174_40ad9813","line":8,"updated":"2021-12-21 09:52:17.000000000","message":"put here the following line:\nCloses-Bug: #1918316\n\nThanks to that ^^ this commit will be linked with the bug, so readers will easily find the associated fix.","commit_id":"cb05fbfab67818f20f52d681311ca80b3c4bf4d9"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"dc0de73b4b52e818ab70590346f67cb9a690a691","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-12-20 14:31:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a fix for intermittent tempest unittest failure of \"test_fix_argument_yes\". The bug was in check_uuid.py and not in the test itself. As part of the fix, enabled check_uuid.py to run a validation of a module in any dir by adding --libpath parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If5d3a3852320e1d3b26af433f7a66be7d42e2b84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"6c065a5f_b0f13dba","line":8,"in_reply_to":"0669d174_40ad9813","updated":"2021-12-21 18:41:37.000000000","message":"Done","commit_id":"cb05fbfab67818f20f52d681311ca80b3c4bf4d9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"59f255b4defbf69b31f718571c666dbe939548f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c460c10_66fe63d2","updated":"2021-12-09 21:32:55.000000000","message":"Sorry for the previous review request. I messed it up and decided to start from scratch on this unitest issue. See initial fix here: https://review.opendev.org/c/openstack/tempest/+/804839","commit_id":"300f00f07a7346ddd1565b224783495cd99808bc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"272e11c8f2c6b6c9e53ffcbb1785105b1a428968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d4db1ba_fed9c398","updated":"2021-12-13 10:53:19.000000000","message":"I wrote comments for patch set 4 but forgot to publish them :/ ","commit_id":"48d80336e7146ec715b694446eb1cf9a4313997f"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"4ce9be02e0cabc869515dfdba930939b4c124fdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b5dd896d_6e695c78","in_reply_to":"3d4db1ba_fed9c398","updated":"2021-12-17 16:25:23.000000000","message":"Replied to patch set 4 comments.","commit_id":"48d80336e7146ec715b694446eb1cf9a4313997f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f6d95531d11af63c21482f9a447b863d30724bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ae4de2bc_9b8bd0d3","updated":"2021-12-14 20:09:25.000000000","message":"looks good to me, i think the issue should be fixed by this approach (not generating a fake module on the fly), so let\u0027s try to remove the sleep statement and let\u0027s recheck the patch ~10 times to verify the issue is not happening anymore (the patch triggers only a few unit test jobs which take \u003c 10 minutes, so it\u0027s ok to keep rechecking this for a while - we won\u0027t waste resources for this experiment)","commit_id":"d1038e8999b4837e8fbb1729b9f8181fda5315b7"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"4ce9be02e0cabc869515dfdba930939b4c124fdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5824133b_3cef5032","in_reply_to":"ae4de2bc_9b8bd0d3","updated":"2021-12-17 16:25:23.000000000","message":"Martin,\n\nI already the tested suite multiple times and noticed that the error still happens, but it happens less often. So, this is not a fix but a move toward better performance. This issue never reproduces if the \"test_fix_argument_yes\" test is run independently. It reproduces only when run in \"batch\" with all the other unit tests.","commit_id":"d1038e8999b4837e8fbb1729b9f8181fda5315b7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85defd53bfc1a47f1ad615f9b06f712b78898998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"548d2c0f_a789576b","updated":"2021-12-15 08:46:55.000000000","message":"oh, we\u0027ve hit the issue again 😞 ","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c47554a4e8b24fb0cc3b297ce52553bce5bba120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"543068f1_6c387b13","updated":"2021-12-14 23:12:03.000000000","message":"recheck","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a0f8e482feace444a4ad50eada23e09a13bb8d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ed7bc906_5c275e74","updated":"2021-12-14 22:51:52.000000000","message":"recheck ","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e8a6641bce56458291da2d88070260138725b639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e5ef379a_708fbc8d","updated":"2021-12-15 07:53:09.000000000","message":"recheck (meanwhile I\u0027m rechecking to verify this solution doesn\u0027t cause the same issue)","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaed62af0cee28d29f1290d5844349ef5060de9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9f611997_13703a75","updated":"2021-12-21 09:52:17.000000000","message":"please fix the commit message and also include a releasenote, see this patch as an example: https://review.opendev.org/c/openstack/tempest/+/708833\n\nReno doc: https://docs.openstack.org/reno/latest/user/usage.html\nThanks to a releasenote when a new release is cut, the list of the changes in that particular release is listed, see https://docs.openstack.org/releasenotes/tempest/unreleased.html\n\napart from that it looks good","commit_id":"cb05fbfab67818f20f52d681311ca80b3c4bf4d9"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"dc0de73b4b52e818ab70590346f67cb9a690a691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0def7b47_d397d097","updated":"2021-12-21 18:41:37.000000000","message":"dd","commit_id":"09428b87809b2357e169c7c6d808b230a4f4d11b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bfaf899892dcb7dcbd6d78501027f8591752672f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7132eb28_579a579b","updated":"2021-12-23 12:51:11.000000000","message":"let\u0027s merge, testing patch shows it\u0027s working good enough, thank you Alex for fixing this!","commit_id":"09428b87809b2357e169c7c6d808b230a4f4d11b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"551531ad9e09308bac51ea6555f06ebc4d7b5f86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4da5b680_d2a4552f","updated":"2021-12-21 16:33:29.000000000","message":"lgtm, leaving +w to Martin after his testing. ","commit_id":"09428b87809b2357e169c7c6d808b230a4f4d11b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"026524a33ca65af0c063edb27b60cf099f39fdf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4cf27a5e_24124214","updated":"2021-12-21 16:19:56.000000000","message":"thanks, I\u0027m testing this here - https://review.opendev.org/c/openstack/tempest/+/819002 - where I\u0027m rechecking it and am hoping it won\u0027t fail, it looks great so far, I\u0027ll recheck that a few more times, if it doesn\u0027t fail, I\u0027ll vote +w on this","commit_id":"09428b87809b2357e169c7c6d808b230a4f4d11b"}],"tempest/tests/lib/cmd/test_check_uuid.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"272e11c8f2c6b6c9e53ffcbb1785105b1a428968","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dummy_init \u003d os.path.join(self.scriptDir, \"__init__.py\")"},{"line_number":35,"context_line":"        init_file \u003d os.path.join(self.directory, \"__init__.py\")"},{"line_number":36,"context_line":"        shutil.copy(dummy_init, init_file)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        dummy_module_name \u003d \"fake_module.py\""},{"line_number":39,"context_line":"        self.src_module \u003d os.path.join(\".\", \"tempest\", \"tests\", \"lib\", dummy_module_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1bd4cd26_bb9a6258","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":30},"updated":"2021-12-13 10:53:19.000000000","message":"I\u0027m not sure you can copy this file, dummy_init var contains only a path, however, the file at that location doesn\u0027t actually exist, does it?","commit_id":"bb8fda254a19c88102848c5b7e2374ee670e900b"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"e56093f0d7e732daed939c4b301275acd4757605","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dummy_init \u003d os.path.join(self.scriptDir, \"__init__.py\")"},{"line_number":35,"context_line":"        init_file \u003d os.path.join(self.directory, \"__init__.py\")"},{"line_number":36,"context_line":"        shutil.copy(dummy_init, init_file)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        dummy_module_name \u003d \"fake_module.py\""},{"line_number":39,"context_line":"        self.src_module \u003d os.path.join(\".\", \"tempest\", \"tests\", \"lib\", dummy_module_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4cc18e66_92b26af1","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":30},"in_reply_to":"1bd4cd26_bb9a6258","updated":"2021-12-14 14:17:52.000000000","message":"the __init__ file does exist,and it is empty. So instead of adding an dummy __init__ I decided to use an existing one. Will that cause problems?","commit_id":"bb8fda254a19c88102848c5b7e2374ee670e900b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f6d95531d11af63c21482f9a447b863d30724bad","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dummy_init \u003d os.path.join(self.scriptDir, \"__init__.py\")"},{"line_number":35,"context_line":"        init_file \u003d os.path.join(self.directory, \"__init__.py\")"},{"line_number":36,"context_line":"        shutil.copy(dummy_init, init_file)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        dummy_module_name \u003d \"fake_module.py\""},{"line_number":39,"context_line":"        self.src_module \u003d os.path.join(\".\", \"tempest\", \"tests\", \"lib\", dummy_module_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2556adf_448d822e","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":30},"in_reply_to":"4cc18e66_92b26af1","updated":"2021-12-14 20:09:25.000000000","message":"oh, I see, I missed that before, I\u0027m sorry for that, it makes sense to me now ... no, no problems should be caused by that","commit_id":"bb8fda254a19c88102848c5b7e2374ee670e900b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f6d95531d11af63c21482f9a447b863d30724bad","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        sys.argv \u003d [sys.argv[0]] + [\"--fix\", \"--package\","},{"line_number":56,"context_line":"                                    os.path.relpath(self.directory)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        time.sleep(.05)  # Sleep statement does not seem to effect test"},{"line_number":59,"context_line":"        check_uuid.run()"},{"line_number":60,"context_line":"        with open(self.test_file, \"r\") as f:"},{"line_number":61,"context_line":"            with open(self.src_module, \"r\") as fm:"}],"source_content_type":"text/x-python","patch_set":14,"id":"b910f116_71d1af8a","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":25},"updated":"2021-12-14 20:09:25.000000000","message":"I\u0027d propose to remove this and recheck the patch multiple times - if we don\u0027t reproduce the issue again, we\u0027ll merge it","commit_id":"d1038e8999b4837e8fbb1729b9f8181fda5315b7"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"4ce9be02e0cabc869515dfdba930939b4c124fdd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        sys.argv \u003d [sys.argv[0]] + [\"--fix\", \"--package\","},{"line_number":56,"context_line":"                                    os.path.relpath(self.directory)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        time.sleep(.05)  # Sleep statement does not seem to effect test"},{"line_number":59,"context_line":"        check_uuid.run()"},{"line_number":60,"context_line":"        with open(self.test_file, \"r\") as f:"},{"line_number":61,"context_line":"            with open(self.src_module, \"r\") as fm:"}],"source_content_type":"text/x-python","patch_set":14,"id":"640d7091_8c7d69f5","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":25},"in_reply_to":"b910f116_71d1af8a","updated":"2021-12-17 16:25:23.000000000","message":"I already the tested suite multiple times and noticed that the error still happens, but it happens less often. So, this is not a fix but a move toward better performance. This issue never reproduces if the \"test_fix_argument_yes\" test is run independently. It reproduces only when run in \"batch\" with all the other unit tests. \n\nI will remove the sleep statement as it has little impact on the test.","commit_id":"d1038e8999b4837e8fbb1729b9f8181fda5315b7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85defd53bfc1a47f1ad615f9b06f712b78898998","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestCLInterface, self).setUp()"},{"line_number":29,"context_line":"        self.directory \u003d tempfile.mkdtemp(prefix\u003d\u0027check-uuid\u0027, dir\u003d\".\")"},{"line_number":30,"context_line":"        self.scriptDir \u003d os.path.dirname(os.path.realpath(__file__))"},{"line_number":31,"context_line":"        self.addCleanup(shutil.rmtree, self.directory, ignore_errors\u003dTrue)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"b59bd87d_4e2dc8b4","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":71},"updated":"2021-12-15 08:46:55.000000000","message":"what we can try is not to use tempfile at all, let\u0027s try to create a whole fake module and store it in tempest/tempest/tests/files/ per Ghanshyam\u0027s suggestion.\n\ne.g.\ntempest/tempest/tests/files/fake_module/\n -\u003e __init__.py\n -\u003e fake_module.py","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efceaa77693b07bd0a0dcc406f6450b9bfa443b7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        shutil.copy(dummy_init, init_file)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        dummy_module_name \u003d \"fake_module.py\""},{"line_number":38,"context_line":"        self.src_module \u003d os.path.join(\".\", \"tempest\", \"tests\","},{"line_number":39,"context_line":"                                       \"lib\", dummy_module_name)"},{"line_number":40,"context_line":"        self.test_file \u003d os.path.join(self.directory, dummy_module_name)"},{"line_number":41,"context_line":"        shutil.copy(self.src_module, self.test_file)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dd6a379e_a1b28f3a","line":39,"range":{"start_line":38,"start_character":26,"end_line":39,"end_character":64},"updated":"2021-12-14 23:38:05.000000000","message":"you can move that to tempest/tempest/tests/files/ where other files used in tests are placed.","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"},{"author":{"_account_id":34308,"name":"Alex Yefimov","display_name":"Alex Yefimov","email":"ayefimov@redhat.com","username":"ayefimov"},"change_message_id":"4ce9be02e0cabc869515dfdba930939b4c124fdd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        shutil.copy(dummy_init, init_file)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        dummy_module_name \u003d \"fake_module.py\""},{"line_number":38,"context_line":"        self.src_module \u003d os.path.join(\".\", \"tempest\", \"tests\","},{"line_number":39,"context_line":"                                       \"lib\", dummy_module_name)"},{"line_number":40,"context_line":"        self.test_file \u003d os.path.join(self.directory, dummy_module_name)"},{"line_number":41,"context_line":"        shutil.copy(self.src_module, self.test_file)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"675458c3_68580c91","line":39,"range":{"start_line":38,"start_character":26,"end_line":39,"end_character":64},"in_reply_to":"dd6a379e_a1b28f3a","updated":"2021-12-17 16:25:23.000000000","message":"With the patch 17 the test stays the same and I think the real bug is fixed.","commit_id":"ecc1a0212f470f117e5d98cf0740a920a09250e1"}]}