)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee5d27db9a6fc19b12c5367ec746904e6b23a308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"66c14857_33f88663","updated":"2022-12-27 01:58:44.000000000","message":"Thanks, you need to add these new method in base abstract class too https://github.com/openstack/tempest/blob/54fd0732ec54907ce6cf45a36e9d15386d33fc2b/tempest/lib/common/cred_provider.py#L109\n\nAlso, add the releasenotes to mention about Tempest support manager persona.  ","commit_id":"060cc72efe9678339fabfd48e532b0234a2c906d"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"16409acd0b5546de2ed3b36a137000d0c7475355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"beb7061a_73877b28","updated":"2022-01-11 10:27:06.000000000","message":"looks good to me!","commit_id":"060cc72efe9678339fabfd48e532b0234a2c906d"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"2894d1935d3a7090f2f06b0d2e7f587b53d16ee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"64121f03_986a4db4","updated":"2023-01-04 06:40:54.000000000","message":"removing my votes until the points hinted by gmann are addressed!","commit_id":"060cc72efe9678339fabfd48e532b0234a2c906d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9ea1f56e1c64f7fa13aab70411ea768104d42f24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99b1e39c_b1869bf3","in_reply_to":"66c14857_33f88663","updated":"2025-04-03 11:51:50.000000000","message":"Added release notes and `manager` methods in base abstract class","commit_id":"060cc72efe9678339fabfd48e532b0234a2c906d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"b0cfe5f3f2694c11039cb9ce9aae0def33551262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bc371697_773617bf","updated":"2025-04-07 10:21:11.000000000","message":"Tests failed `test_alt_creds_within_same_project, test_creds_within_same_project`","commit_id":"bdb81c8b5af53c2bce9167c9bb1a0f17a23829e4"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3186bc3da2a466f184d175362efd9c499bc87a8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2a060db8_4ca4ec3c","updated":"2025-05-11 05:33:43.000000000","message":"recheck","commit_id":"bdb81c8b5af53c2bce9167c9bb1a0f17a23829e4"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"356ee4bef0f5bfb31a61d66cd649786d84829072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7577505d_ed553bcd","updated":"2025-05-09 11:24:46.000000000","message":"recheck","commit_id":"bdb81c8b5af53c2bce9167c9bb1a0f17a23829e4"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"609d8816be6d9b67340c498668f24cfbfd191603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"61390b36_8cd00514","updated":"2025-05-11 05:37:16.000000000","message":"recheck","commit_id":"26cb1ccf62e98a408ab7541c6b973e70233995c0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a045ec6bf6cf57837cd39a9006448354b2d0ec4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8d83d6dd_87ac114e","updated":"2025-05-13 16:30:55.000000000","message":"also, I am adding some test to make sure that manager user have same project as of other user of same test. Because alt_project_manager is not present I had to remove it from my change, can you please rebased this change on top of mine - https://review.opendev.org/c/openstack/tempest/+/949534\n\nand then add its test. You can see in this diff about what exactly changes you need to add https://review.opendev.org/c/openstack/tempest/+/949534/2..3/tempest/tests/lib/common/test_dynamic_creds.py","commit_id":"09f0adb6368c2a72713f2680a3eb6328de16ba76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"70460e56063773d65ec11e8006ab331a9ef63e06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"364e744f_8e1fc511","in_reply_to":"8d83d6dd_87ac114e","updated":"2025-05-14 22:51:41.000000000","message":"can you also add test for alt manager like I mentioned above","commit_id":"09f0adb6368c2a72713f2680a3eb6328de16ba76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5e53c0e497d926d7295a1f9ee6431cd72bdfdded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e2107ad8_b0dabfe6","updated":"2025-06-12 18:14:20.000000000","message":"I rebased on top of mine, if you fix the tests (I commented), it should pass","commit_id":"bed36d7fd8a9bed14da373cb2a26035fbe556bfa"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"c1346588db09d9e34eac832de3427dc62869a3d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"4df3aaf1_bc83edc3","updated":"2025-11-29 13:03:06.000000000","message":"recheck","commit_id":"c2bd5af22458f2373c91ba183a7b2e293e65f737"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"13689c8be1b786b938b06d3e13510260bfc32973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"541a8655_5d263d7e","updated":"2025-09-01 06:40:55.000000000","message":"recheck","commit_id":"c2bd5af22458f2373c91ba183a7b2e293e65f737"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"9b18d2b9e8349a468ba3e8674955c090cea2c6c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c7652109_6d9aa77b","updated":"2025-11-29 18:21:06.000000000","message":"recheck","commit_id":"c2bd5af22458f2373c91ba183a7b2e293e65f737"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7b41544d519218bae31855303ace7f43b55d47c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"4fe2bcaa_09b3b574","updated":"2025-11-30 15:13:48.000000000","message":"recheck (Request timed out)","commit_id":"c2bd5af22458f2373c91ba183a7b2e293e65f737"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d501c9a532752f463286e73fd2fa457b8b7c5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d0175905_2065bfcf","updated":"2025-09-03 22:46:16.000000000","message":"recheck lgtm, new test is passing","commit_id":"c2bd5af22458f2373c91ba183a7b2e293e65f737"}],"tempest/lib/common/cred_provider.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"18be398425a2b0df84038ec815ab36a205ad11a1","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @abc.abstractmethod"},{"line_number":119,"context_line":"    def get_project_manager_creds(self):"},{"line_number":120,"context_line":"        return"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @abc.abstractmethod"},{"line_number":123,"context_line":"    def get_project_alt_manager_creds(self):"},{"line_number":124,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"c20c1010_c3bc49c6","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":0},"updated":"2025-04-03 17:00:31.000000000","message":"project manager persona has been added in I2d133326eddb3cf70e2bb1711d8e20f4514f8fca\n\nyou can update this patch to add project alt manager","commit_id":"f072d87e927e4d42920fb8dad176c1b30c11759e"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"2ab56c20b0ae3a61b4d7cae85fa7c7b4e0b4096e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @abc.abstractmethod"},{"line_number":119,"context_line":"    def get_project_manager_creds(self):"},{"line_number":120,"context_line":"        return"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @abc.abstractmethod"},{"line_number":123,"context_line":"    def get_project_alt_manager_creds(self):"},{"line_number":124,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"dabf0592_d465507d","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":0},"in_reply_to":"c20c1010_c3bc49c6","updated":"2025-06-17 08:29:40.000000000","message":"Done","commit_id":"f072d87e927e4d42920fb8dad176c1b30c11759e"}],"tempest/lib/common/dynamic_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"70460e56063773d65ec11e8006ab331a9ef63e06","unresolved":true,"context_lines":[{"line_number":425,"context_line":"                        roles\u003dcredential_type, scope\u003dscope)"},{"line_number":426,"context_line":"                elif credential_type in [[\u0027admin\u0027], [\u0027alt_admin\u0027]]:"},{"line_number":427,"context_line":"                    credentials \u003d self._create_creds("},{"line_number":428,"context_line":"                        admin\u003dTrue, scope\u003dscope, project_id\u003dproject_id)"},{"line_number":429,"context_line":"                elif credential_type in [[\u0027alt_member\u0027], [\u0027alt_reader\u0027]]:"},{"line_number":430,"context_line":"                    cred_type \u003d credential_type[0][4:]"},{"line_number":431,"context_line":"                    if isinstance(cred_type, str):"}],"source_content_type":"text/x-python","patch_set":12,"id":"476d35df_53d0ca26","side":"PARENT","line":428,"range":{"start_line":428,"start_character":47,"end_line":428,"end_character":71},"updated":"2025-05-14 22:51:41.000000000","message":"this is still needed for project admin or alt project admin","commit_id":"b72f28e6fc622f813e43a883ed57919dc748d8e9"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"2ab56c20b0ae3a61b4d7cae85fa7c7b4e0b4096e","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                        roles\u003dcredential_type, scope\u003dscope)"},{"line_number":426,"context_line":"                elif credential_type in [[\u0027admin\u0027], [\u0027alt_admin\u0027]]:"},{"line_number":427,"context_line":"                    credentials \u003d self._create_creds("},{"line_number":428,"context_line":"                        admin\u003dTrue, scope\u003dscope, project_id\u003dproject_id)"},{"line_number":429,"context_line":"                elif credential_type in [[\u0027alt_member\u0027], [\u0027alt_reader\u0027]]:"},{"line_number":430,"context_line":"                    cred_type \u003d credential_type[0][4:]"},{"line_number":431,"context_line":"                    if isinstance(cred_type, str):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d40a9daf_882a5fae","side":"PARENT","line":428,"range":{"start_line":428,"start_character":47,"end_line":428,"end_character":71},"in_reply_to":"476d35df_53d0ca26","updated":"2025-06-17 08:29:40.000000000","message":"Done","commit_id":"b72f28e6fc622f813e43a883ed57919dc748d8e9"}],"tempest/tests/lib/common/test_dynamic_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5e53c0e497d926d7295a1f9ee6431cd72bdfdded","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        # Now request for the project manager creds which should not create new"},{"line_number":292,"context_line":"        # project instead should use the project_id of member_creds already"},{"line_number":293,"context_line":"        # created project."},{"line_number":294,"context_line":"        # TODO(gmaan): test test_alt_creds also once alt project"},{"line_number":295,"context_line":"        # manager is available."},{"line_number":296,"context_line":"        if not test_alt_creds:"},{"line_number":297,"context_line":"            self._request_and_check_second_creds("},{"line_number":298,"context_line":"                creds, manager_func, member_creds, show_mock, sm_count\u003d3)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3998112d_52626b98","line":296,"range":{"start_line":294,"start_character":0,"end_line":296,"end_character":30},"updated":"2025-06-12 18:14:20.000000000","message":"you can remove this condition now","commit_id":"64be6d95dac5b7b4a2e95fffe91ae66bba250db2"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"2ab56c20b0ae3a61b4d7cae85fa7c7b4e0b4096e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        # Now request for the project manager creds which should not create new"},{"line_number":292,"context_line":"        # project instead should use the project_id of member_creds already"},{"line_number":293,"context_line":"        # created project."},{"line_number":294,"context_line":"        # TODO(gmaan): test test_alt_creds also once alt project"},{"line_number":295,"context_line":"        # manager is available."},{"line_number":296,"context_line":"        if not test_alt_creds:"},{"line_number":297,"context_line":"            self._request_and_check_second_creds("},{"line_number":298,"context_line":"                creds, manager_func, member_creds, show_mock, sm_count\u003d3)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"0c7bb16c_cf05433d","line":296,"range":{"start_line":294,"start_character":0,"end_line":296,"end_character":30},"in_reply_to":"3998112d_52626b98","updated":"2025-06-17 08:29:40.000000000","message":"Done","commit_id":"64be6d95dac5b7b4a2e95fffe91ae66bba250db2"}]}
