)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2e1cc666c05f23631fa12c1739aaa7d0208efed5","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://docs.openstack.org/tempest/latest/account_generator.html"},{"line_number":19,"context_line":"[2] https://bugs.launchpad.net/tempest/+bug/1948935"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iada980beff9db3c8cd02c84d0d7602264b66ddf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c9208ce_6c499bc6","line":20,"updated":"2021-12-21 09:29:54.000000000","message":"Closes-Bug: #1948935","commit_id":"ec6e0e75ab183b0e42a857a30327a4eb67408b0a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c00184f0067e01dceb8cd69032ed9382b3f4f4eb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Make account-generator produce concurrency * 2 accounts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the documentation of tempest account-generator it is stated that"},{"line_number":10,"context_line":"the number of required accounts to make tempest run sucessfully is"},{"line_number":11,"context_line":"CONCURRENCY * 2 [1]. However the tempest account-generator produces only"},{"line_number":12,"context_line":"CONCURRENCY accounts. This makes some tests for object storage fail when"},{"line_number":13,"context_line":"pre-provisioned credentials are generated with concurrency of 1 [2]."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b037c812_bd3c0e8c","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":21},"updated":"2021-12-21 16:30:57.000000000","message":"this is not 100% true. It depends on test to test. if any tests need more than one creds (this bug case) then yes two are needed and if any tests require 3 creds than 3 accounts needed. and rest all test needed single creds can be run with single account in account.yaml","commit_id":"25df590d22049e41ff9c6db0fef4938b1d1680fd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"891f1381db0e3c0906c23e7ed51cd6d7fce3b468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7624e0f2_9ea4dca7","updated":"2022-01-13 10:40:46.000000000","message":"lgtm,thanks","commit_id":"41b767a639a39932b23af5a8c8748b4035b7ce44"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c876b734a4494d8acd933445497eeb9f788c4565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe5acc11_50ffc439","updated":"2022-01-13 15:55:54.000000000","message":"thanks, lgtm. sorry i forget but it will be good to add the default value change in upgrade releasenotes ","commit_id":"41b767a639a39932b23af5a8c8748b4035b7ce44"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3d4b77fec0290cc4721bde7dbdb6af7582520a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0db5127d_edcb224a","in_reply_to":"ec52ac18_6cc6dc49","updated":"2022-01-14 08:30:08.000000000","message":"Ok np, I added the releasenotes.","commit_id":"41b767a639a39932b23af5a8c8748b4035b7ce44"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"92d54001fc0ad9c7dfe717c21548eaf16cba0f5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec52ac18_6cc6dc49","in_reply_to":"fe5acc11_50ffc439","updated":"2022-01-13 16:25:12.000000000","message":"oh, yeah, +1","commit_id":"41b767a639a39932b23af5a8c8748b4035b7ce44"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"46a69558f740ab813307d6df3715cac3b15e75bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"97aee3b2_2bbd5d54","updated":"2022-01-15 19:41:56.000000000","message":"recheck","commit_id":"bd722d366e1787f101dd26e8770e24f22970a4f7"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"2e3d915fef0629a9138ff274c14aa42cbd2e4b74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a5c6d53_7a6ce3af","updated":"2022-01-14 13:13:41.000000000","message":"recheck","commit_id":"bd722d366e1787f101dd26e8770e24f22970a4f7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"35f4d0a5d905908d163a5dddcbbb944af92c9450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6572a3ad_f15d0fe8","updated":"2022-01-16 15:59:25.000000000","message":"thanks!","commit_id":"bd722d366e1787f101dd26e8770e24f22970a4f7"}],"tempest/cmd/account_generator.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c00184f0067e01dceb8cd69032ed9382b3f4f4eb","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  for the further using, cleaning resources."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* ``-r, --concurrency CONCURRENCY`` (Optional) Concurrency count"},{"line_number":85,"context_line":"  (default: 1). The number of accounts required can be estimated as"},{"line_number":86,"context_line":"  CONCURRENCY x 2. Each user provided in *accounts.yaml* file will be in"},{"line_number":87,"context_line":"  a different tenant. This is required to provide isolation between test for"},{"line_number":88,"context_line":"  running in parallel."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"39d95948_286c2954","line":86,"range":{"start_line":85,"start_character":16,"end_line":86,"end_character":19},"updated":"2021-12-21 16:30:57.000000000","message":"this help message is a little confusing here. \"The number of accounts required can be estimated as\n  CONCURRENCY x 2. \" this does not say account-generator tool will *generate* two accounts for --concurrency  1 it says required account which also not so clear to me what is required means here?\n\nAny tests can have more than two creds also like any test need project_member, project_adnmin, system_admin etc in that case generating 2 accounts will not be sufficient. We cannot make complete tempest or tempest plugins test run successfully with the default account generated by this tool.\n\nAnd making concurrency\u003d1 generating two accounts means tempest test need single creds run always in parallel and no way to run them serially. This does not sound good and is more confusing.\n\nAs tests need two creds are more cases, we can make the default value of concurrency as 2 (which is 1 currently) and if anyone wants to generate only a single account and run tests-need-single-cred serially they can set it to 1. But let this tool generate the same number of accounts what mentioned in ``-r, --concurrency CONCURRENCY``  option.","commit_id":"25df590d22049e41ff9c6db0fef4938b1d1680fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"55ffe14f1365ebb4288295d2a7ded5be92a29143","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  for the further using, cleaning resources."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* ``-r, --concurrency CONCURRENCY`` (Optional) Concurrency count"},{"line_number":85,"context_line":"  (default: 1). The number of accounts required can be estimated as"},{"line_number":86,"context_line":"  CONCURRENCY x 2. Each user provided in *accounts.yaml* file will be in"},{"line_number":87,"context_line":"  a different tenant. This is required to provide isolation between test for"},{"line_number":88,"context_line":"  running in parallel."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dc1c98db_3eccc564","line":86,"range":{"start_line":85,"start_character":16,"end_line":86,"end_character":19},"in_reply_to":"39d95948_286c2954","updated":"2021-12-23 13:09:50.000000000","message":"yes, it\u0027s confusing and not only the documentation but also the name of the argument - concurrency - as I understand it now, the account-generator with concurrency set to 1 will generate enough credentials for running all tempest tests serially. With concurrency set to 2 it will generate twice as many credentials (as with concurrency set to 1) so that tempest can be run with concurrency \u003d\u003d 2 (2 workers executing tests). \n\nSo I think we have 2 options here:\n1. leave the --concurrency arg as it is and proceed with this patch\n2. improve the documentation of the argument as you suggested in the other comment and rename the argument as well - let\u0027s go with something like --creds-number","commit_id":"25df590d22049e41ff9c6db0fef4938b1d1680fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c00184f0067e01dceb8cd69032ed9382b3f4f4eb","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  for the further using, cleaning resources."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* ``-r, --concurrency CONCURRENCY`` (Optional) Concurrency count"},{"line_number":85,"context_line":"  (default: 1). The number of accounts required can be estimated as"},{"line_number":86,"context_line":"  CONCURRENCY x 2. Each user provided in *accounts.yaml* file will be in"},{"line_number":87,"context_line":"  a different tenant. This is required to provide isolation between test for"},{"line_number":88,"context_line":"  running in parallel."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* ``--with-admin`` (Optional) Creates admin for each concurrent group"}],"source_content_type":"text/x-python","patch_set":2,"id":"c104ce8f_28e1812f","line":87,"range":{"start_line":85,"start_character":16,"end_line":87,"end_character":32},"updated":"2021-12-21 16:30:57.000000000","message":"and this help message can be made more clear with something like below:\n\n* ``-r, --concurrency CONCURRENCY`` (Optional) Concurrency count\n  (default: 2). The number of accounts generated will be same as\n  CONCURRENCY. It can be changed to 1 if you want to run tests need single \n  creds in serial (if you try to run test need more than single creds then it\n  will fail) or more than 2 if any tests need more then 2 creds. Having CONCURRENCY\n  more than 1 (default is 2) means few tests need single creds will run in parallel.","commit_id":"25df590d22049e41ff9c6db0fef4938b1d1680fd"}]}