)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ccac2845d0370d74056e3c31082b5b642ab98ca5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-31 07:24:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add image chache client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/glance/+/792022"},{"line_number":10,"context_line":"Change-Id: Idecb129d0ca96eb44c16f4e682b441a61cab42fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f195297e_4a7abfa8","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":16},"updated":"2022-02-02 16:37:53.000000000","message":"\"cache\"","commit_id":"5d320579c5d6fa5beedb3518b162069cd9dddb19"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dd225e236ee9377df6124f0d03cba247e7356a6e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-31 07:24:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add image chache client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/glance/+/792022"},{"line_number":10,"context_line":"Change-Id: Idecb129d0ca96eb44c16f4e682b441a61cab42fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"16bb4e86_72846be1","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":16},"in_reply_to":"f195297e_4a7abfa8","updated":"2022-02-02 16:56:45.000000000","message":"Done","commit_id":"5d320579c5d6fa5beedb3518b162069cd9dddb19"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dd225e236ee9377df6124f0d03cba247e7356a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"acb0999e_0ff2c83e","updated":"2022-02-02 16:56:45.000000000","message":"Thank you for review.","commit_id":"edfbb1f0101e27ea6aa455ee8550854cb06de613"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d9837e5328bcff15ece2a06a3e082a62f99e69d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8338f85b_7a31881e","updated":"2022-06-21 15:29:03.000000000","message":"Looks good to me but lets wait to the pep tests ... ","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2d3a53d1b9fc35ae5c2e25bd45ce239b7559f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d5ecba52_ac62daa3","updated":"2022-06-21 13:57:51.000000000","message":"Thank you Beeny for review, made changes as per your suggestion!","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"08a37e85daa27ce3e0683519dd065b82b0757d12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"77840efa_8f44be56","updated":"2022-06-22 06:01:54.000000000","message":"Thank you Benny, made changes as per your suggestons!","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0150739d4ce0da58728647cb54860e8f3824dee9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ac2a8d0_37010e25","updated":"2022-06-28 05:47:45.000000000","message":"Thank you Martin for pointing it out, I have submitted a patch in glance to correct the response codes, once it is merged I will update this patch.\n\nhttps://review.opendev.org/c/openstack/glance/+/847877\n\nTill then I am setting workflow to -1","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a78589409cc0ad15f86a6a10af20954ddfb48ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"89f038e7_4b9a8d69","updated":"2022-06-24 10:35:02.000000000","message":"looks good, although some of the return codes don\u0027t match the documentation , you could also write a brief releasenote as we had for example here: https://review.opendev.org/c/openstack/tempest/+/763148","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"dd953e5febe3ba947168bcbd1e4b78c880ab7db0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"979eb104_cfb9878a","updated":"2022-07-13 08:28:42.000000000","message":"From the doc it refers to Lists all images in cache or queue. (Since Image API v2.14)\n\nWhere exactly do we see 2.14 here ? ","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"c548614cf37742d9e0a2bda1ece31fa31ac2be99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9189cd3d_b73adb07","updated":"2022-07-22 05:11:06.000000000","message":"Here is the result wherein the test is passing:-\nhttps://efa218cfaf4e38ae14ec-407789a006c18491d0ad02a611fbe821.ssl.cf1.rackcdn.com/847139/5/check/tempest-integrated-storage-import/81045d7/testr_results.html\n\nThis is change can be merged.","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"9bafe0966738261446b76e9cb8e0654834061952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"682699c1_6a0a5540","updated":"2022-06-30 12:42:08.000000000","message":"LGTM","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf0c6a70046cf44b6481bc6ae4b4e1ebd9f884d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ee42bf99_13950a15","updated":"2022-07-25 19:48:02.000000000","message":"LGTM, thanks","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"900955b84b5d9a45d21cca0bbf849807edf15e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab340dba_5973b796","updated":"2022-07-21 14:04:28.000000000","message":"Looks good to me!","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e8eb75055bed3b6ad6a38dac088f40fe97cf1178","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bdb61243_c2730125","in_reply_to":"979eb104_cfb9878a","updated":"2022-07-13 08:39:36.000000000","message":"Should we add micro-version support here ?  -1 the patch till we clarify it.","commit_id":"86df53bb054d2e47d8626c4380a250ca6fd8abe7"}],"tempest/lib/services/image/v2/image_cache_client.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"218f11ebcfdee093ddce502fe12e993ac4b9a7f4","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v2\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def list_cache(self):"},{"line_number":25,"context_line":"        url \u003d \u0027cache\u0027"},{"line_number":26,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":27,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":28,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfea1a26_aacb572f","line":25,"updated":"2022-06-21 08:14:44.000000000","message":"Please add comment with reference to API .\nhttps://docs.openstack.org/api-ref/image/v2/?expanded\u003d#cache-manage\nLists all images in cache or queue. (Since Image API v2.14)","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2d3a53d1b9fc35ae5c2e25bd45ce239b7559f78","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v2\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def list_cache(self):"},{"line_number":25,"context_line":"        url \u003d \u0027cache\u0027"},{"line_number":26,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":27,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":28,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af57bd2_e0d87968","line":25,"in_reply_to":"bfea1a26_aacb572f","updated":"2022-06-21 13:57:51.000000000","message":"Done","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"218f11ebcfdee093ddce502fe12e993ac4b9a7f4","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def cache_queue(self, image_id):"},{"line_number":32,"context_line":"        # Queue image for prefetching"},{"line_number":33,"context_line":"        url \u003d \u0027cache/%s\u0027 % image_id"},{"line_number":34,"context_line":"        resp, body \u003d self.put(url, body\u003dNone)"},{"line_number":35,"context_line":"        self.expected_success(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0ad4e421_dfedfa3e","line":32,"updated":"2022-06-21 08:14:44.000000000","message":"Please add comment with reference to API .","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"2dfd19c75498dcd2f65ed55890071214e01ccc86","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def cache_queue(self, image_id):"},{"line_number":32,"context_line":"        # Queue image for prefetching"},{"line_number":33,"context_line":"        url \u003d \u0027cache/%s\u0027 % image_id"},{"line_number":34,"context_line":"        resp, body \u003d self.put(url, body\u003dNone)"},{"line_number":35,"context_line":"        self.expected_success(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd333548_ab25b13c","line":32,"in_reply_to":"0ad4e421_dfedfa3e","updated":"2022-06-21 08:38:24.000000000","message":"https://docs.openstack.org/api-ref/image/v2/?expanded\u003dqueue-image-detail,delete-image-from-cache-detail,clear-images-from-cache-detail#queue-image","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2d3a53d1b9fc35ae5c2e25bd45ce239b7559f78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def cache_queue(self, image_id):"},{"line_number":32,"context_line":"        # Queue image for prefetching"},{"line_number":33,"context_line":"        url \u003d \u0027cache/%s\u0027 % image_id"},{"line_number":34,"context_line":"        resp, body \u003d self.put(url, body\u003dNone)"},{"line_number":35,"context_line":"        self.expected_success(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d5464cf_d606e1bc","line":32,"in_reply_to":"dd333548_ab25b13c","updated":"2022-06-21 13:57:51.000000000","message":"Done","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"eb453c979dc67935f5215fbfebae78f11bf0215d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"442e3122_50a11c77","line":53,"updated":"2022-06-21 08:29:26.000000000","message":"--target {both,cache,queue}  , here are valid params ,\nWhy do you assert it here ? i think it should be handled later by rest_client\n\nthis is the only part  self.expected_success(200, resp.status) , if user send something wrong we should expect to get error from server.\n\nNot sure if we need to create schema here...","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8eafb2cf5a6393fb069c79543788fe8b1258d07a","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a032b145_9462f12a","line":53,"in_reply_to":"442e3122_50a11c77","updated":"2022-06-21 09:06:30.000000000","message":"aren\u0027t we getting response at line 52 from server?\nI am just validating it here based on target values.","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8f6089e975c04ddfbbec02d1263645f476e7099c","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"cdfbefa5_c6447f3a","line":53,"in_reply_to":"a032b145_9462f12a","updated":"2022-06-21 09:12:04.000000000","message":"Here are the reply debug:\nwith target:\n\nDEBUG:keystoneauth.session:REQ: curl -g -i -X DELETE http://192.168.101.10/image/v2/cache -H \"Content-Type: application/octet-stream\" -H \"User-Agent: python-glanceclient\" -H \"X-Auth-Token: {SHA256}2d3ad7cf01c77b63beacab08d4601807a726cea036a8f942126ce06934382e4e\" -H \"x-image-cache-clear-target: queue\"\n\n\n\nwithout target:\n\nDEBUG:keystoneauth.session:REQ: curl -g -i -X DELETE http://192.168.101.10/image/v2/cache -H \"Content-Type: application/octet-stream\" -H \"User-Agent: python-glanceclient\" -H \"X-Auth-Token: {SHA256}5a3ca11dcc33b0bfbd9e7c7b9f0323fcbdf364c02574113d8649a024dca2cd8e\"","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a000f99794de8d1e937438cc2a7b60f2b61dbc00","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"f838f0e2_2f1660ac","line":53,"in_reply_to":"a4c26304_78f5e883","updated":"2022-06-21 09:44:37.000000000","message":"ohh, now I see it clearly, thank you for pointing it out.","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e206a802567212c65ff6628227d2d8336f8b51e0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4c26304_78f5e883","line":53,"in_reply_to":"cdfbefa5_c6447f3a","updated":"2022-06-21 09:27:53.000000000","message":"The image-cache-clear-target: queue looks like additional header , in the command you sent i dont see the header ... \nsee in line 52 you sent the request but do tou sent the header ? \n\nthe header is a local param which can be added by the user (target) . accpet 3 options : {both,cache,queue} , and in the DELETE command sent as image-cache-clear-target: queue\" in -H \n\n\ni think the DELETE command should be sent with this header ... -H \"x-image-cache-clear-target: queue\" .  hope i explained my self properly.","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5a7a2f57eac0c656282e4d6a97087a180e7789c4","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa47df92_f4d4e31d","line":53,"in_reply_to":"cdfbefa5_c6447f3a","updated":"2022-06-21 09:18:21.000000000","message":"right, that is because a scenario is missing in child patch, I will add that scenario when I fix the other comments.","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2d3a53d1b9fc35ae5c2e25bd45ce239b7559f78","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if target:"},{"line_number":51,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":52,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":53,"context_line":"        if target not in (\u0027\u0027, \u0027cache\u0027, \u0027queue\u0027):"},{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1669a97d_7c4691e9","line":53,"in_reply_to":"f838f0e2_2f1660ac","updated":"2022-06-21 13:57:51.000000000","message":"Done","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"eb453c979dc67935f5215fbfebae78f11bf0215d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"},{"line_number":57,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":58,"context_line":"        body \u003d json.loads(body)"},{"line_number":59,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f055d24_b49e1f83","line":57,"updated":"2022-06-21 08:29:26.000000000","message":"Sorry , i dont see headers in the requests , am i missing it ?","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8eafb2cf5a6393fb069c79543788fe8b1258d07a","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"},{"line_number":57,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":58,"context_line":"        body \u003d json.loads(body)"},{"line_number":59,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c942c8a0_fe0405c8","line":57,"in_reply_to":"6f055d24_b49e1f83","updated":"2022-06-21 09:06:30.000000000","message":"Need to add that scenario in the test case, will add it","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2d3a53d1b9fc35ae5c2e25bd45ce239b7559f78","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            assert 400 \u003d\u003d resp.status"},{"line_number":55,"context_line":"            return rest_client.ResponseBody(resp)"},{"line_number":56,"context_line":"        else:"},{"line_number":57,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":58,"context_line":"        body \u003d json.loads(body)"},{"line_number":59,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbb67ee1_20d6040d","line":57,"in_reply_to":"c942c8a0_fe0405c8","updated":"2022-06-21 13:57:51.000000000","message":"Done","commit_id":"aec5ae9685440eae0c2d6f8204b997cf7877097c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d9837e5328bcff15ece2a06a3e082a62f99e69d1","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":47,"context_line":"        if body:"},{"line_number":48,"context_line":"            body \u003d json.loads(body)"},{"line_number":49,"context_line":"            return rest_client.ResponseBody(resp, body)"},{"line_number":50,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def cache_delete(self, image_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7111e8_3e7c0bd8","line":49,"updated":"2022-06-21 15:29:03.000000000","message":"Whats the reason for if body here ? we can send body as None in case its really returned ?\nHere is the ResponseBody , \ndef __init__(self, response, body\u003dNone):\n\nIs there any case when the body can returned with info and once without ???","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"08a37e85daa27ce3e0683519dd065b82b0757d12","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":47,"context_line":"        if body:"},{"line_number":48,"context_line":"            body \u003d json.loads(body)"},{"line_number":49,"context_line":"            return rest_client.ResponseBody(resp, body)"},{"line_number":50,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def cache_delete(self, image_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b8d56ca3_d2ad5898","line":49,"in_reply_to":"3a7111e8_3e7c0bd8","updated":"2022-06-22 06:01:54.000000000","message":"Ack","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e88d9c45e3dbbf649343d921e385cb471f2f0fcf","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":62,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def cache_clear(self, target\u003d\u0027\u0027):"},{"line_number":65,"context_line":"        \"\"\"Clears the cache and its queue. (Since Image API v2.14)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":6,"id":"b7616a11_caa1722c","line":64,"updated":"2022-06-21 15:34:01.000000000","message":"Not critical but you can set the target\u003dNone...","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"08a37e85daa27ce3e0683519dd065b82b0757d12","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":62,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def cache_clear(self, target\u003d\u0027\u0027):"},{"line_number":65,"context_line":"        \"\"\"Clears the cache and its queue. (Since Image API v2.14)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":6,"id":"91238080_729e3e1e","line":64,"in_reply_to":"b7616a11_caa1722c","updated":"2022-06-22 06:01:54.000000000","message":"Ack","commit_id":"34d0533b376ca68f2694aaa0397f13f49ba20ea4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a78589409cc0ad15f86a6a10af20954ddfb48ed","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        url \u003d \u0027cache/%s\u0027 % image_id"},{"line_number":57,"context_line":"        resp, _ \u003d self.delete(url)"},{"line_number":58,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":59,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def cache_clear(self, target\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"281b842a_9c66b15f","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"updated":"2022-06-24 10:35:02.000000000","message":"204?","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0150739d4ce0da58728647cb54860e8f3824dee9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        url \u003d \u0027cache/%s\u0027 % image_id"},{"line_number":57,"context_line":"        resp, _ \u003d self.delete(url)"},{"line_number":58,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":59,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def cache_clear(self, target\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9e9b5385_da685a99","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"in_reply_to":"281b842a_9c66b15f","updated":"2022-06-28 05:47:45.000000000","message":"Ack","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a78589409cc0ad15f86a6a10af20954ddfb48ed","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        if target:"},{"line_number":71,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":72,"context_line":"        resp, body \u003d self.delete(url, headers\u003dheaders)"},{"line_number":73,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":74,"context_line":"        body \u003d json.loads(body)"},{"line_number":75,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b72db23c_7496c67e","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":33},"updated":"2022-06-24 10:35:02.000000000","message":"204?","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0150739d4ce0da58728647cb54860e8f3824dee9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        if target:"},{"line_number":71,"context_line":"            headers[\u0027x-image-cache-clear-target\u0027] \u003d target"},{"line_number":72,"context_line":"        resp, body \u003d self.delete(url, headers\u003dheaders)"},{"line_number":73,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":74,"context_line":"        body \u003d json.loads(body)"},{"line_number":75,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7d32a097_2298a9bf","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":33},"in_reply_to":"b72db23c_7496c67e","updated":"2022-06-28 05:47:45.000000000","message":"Ack","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9472c6710d62242c6273ca0ad4ce3f324411fb24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"e300ad69_fde25495","line":1,"updated":"2022-06-30 07:34:41.000000000","message":"Not critical but on one of the cycles , maybe change the year:)","commit_id":"686a29669e2465196390140e4873e284ebc9cb49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d1ff3dd53b69a5676a1ad45f302f5477afe25c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"51dcc7fe_83ef6656","line":1,"in_reply_to":"e300ad69_fde25495","updated":"2022-07-05 14:02:26.000000000","message":"Done","commit_id":"686a29669e2465196390140e4873e284ebc9cb49"}],"tempest/tests/lib/services/image/v2/test_image_cache_client.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a78589409cc0ad15f86a6a10af20954ddfb48ed","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            self.client.cache_delete,"},{"line_number":55,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.delete\u0027,"},{"line_number":56,"context_line":"            fake_result, image_id\u003d\"e485aab9-0907-4973-921c-bb6da8a8fcf8\","},{"line_number":57,"context_line":"            status\u003d200)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_cache_clear_without_target(self):"},{"line_number":60,"context_line":"        fake_result \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a65af42_de633bef","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":22},"updated":"2022-06-24 10:35:02.000000000","message":"204","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0150739d4ce0da58728647cb54860e8f3824dee9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            self.client.cache_delete,"},{"line_number":55,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.delete\u0027,"},{"line_number":56,"context_line":"            fake_result, image_id\u003d\"e485aab9-0907-4973-921c-bb6da8a8fcf8\","},{"line_number":57,"context_line":"            status\u003d200)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_cache_clear_without_target(self):"},{"line_number":60,"context_line":"        fake_result \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"ceaae24e_e67cc779","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":22},"in_reply_to":"0a65af42_de633bef","updated":"2022-06-28 05:47:45.000000000","message":"Ack","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a78589409cc0ad15f86a6a10af20954ddfb48ed","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.check_service_client_function("},{"line_number":65,"context_line":"            self.client.cache_clear,"},{"line_number":66,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.delete\u0027,"},{"line_number":67,"context_line":"            fake_result, status\u003d200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"827b9b60_004ac5ad","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":35},"updated":"2022-06-24 10:35:02.000000000","message":"204","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0150739d4ce0da58728647cb54860e8f3824dee9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.check_service_client_function("},{"line_number":65,"context_line":"            self.client.cache_clear,"},{"line_number":66,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.delete\u0027,"},{"line_number":67,"context_line":"            fake_result, status\u003d200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"633c941c_ee3de43b","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":35},"in_reply_to":"827b9b60_004ac5ad","updated":"2022-06-28 05:47:45.000000000","message":"Ack","commit_id":"f48b03b994357218336c45ce36e5525f9ddf0688"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9472c6710d62242c6273ca0ad4ce3f324411fb24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6b16db3_1c46dec2","line":1,"updated":"2022-06-30 07:34:41.000000000","message":"Update year and company ...","commit_id":"686a29669e2465196390140e4873e284ebc9cb49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d1ff3dd53b69a5676a1ad45f302f5477afe25c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"aa8dcda4_cb31eee4","line":1,"in_reply_to":"b6b16db3_1c46dec2","updated":"2022-07-05 14:02:26.000000000","message":"Done","commit_id":"686a29669e2465196390140e4873e284ebc9cb49"}]}