)]}'
{"tempest/hacking/checks.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"cbf5d5ee0e92e8d8726ba7e540d5885cfbe6f901","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":19,"context_line":"                  \u0027trove\u0027, \u0027ironic\u0027, \u0027savanna\u0027, \u0027heat\u0027, \u0027ceilometer\u0027,"},{"line_number":20,"context_line":"                  \u0027marconi\u0027, \u0027sahara\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":23,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Buf0%3D","line":20,"updated":"2014-03-24 19:37:31.000000000","message":"If you add \u0027sahara\u0027, let\u0027s remove \u0027savanna\u0027 from this list.","commit_id":"7481350fcaa8b50f081305e0e8f54898fffe4dc6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"97da9f754df8a178cee3fa6db12f068d830083aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":19,"context_line":"                  \u0027trove\u0027, \u0027ironic\u0027, \u0027savanna\u0027, \u0027heat\u0027, \u0027ceilometer\u0027,"},{"line_number":20,"context_line":"                  \u0027marconi\u0027, \u0027sahara\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":23,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bn3A%3D","line":20,"in_reply_to":"AAAAWH%2F%2BrS4%3D","updated":"2014-03-25 14:12:11.000000000","message":"As long as there is a savannaclient on pypi there is a valid reason for it to be on this list. But, you do realize this has nothing todo with functionality right? \n\nEven if there wasn\u0027t a pypi package anymore it\u0027s just a hacking check, IMO there really wouldn\u0027t be a reason to remove it. We don\u0027t want to approve code that has a savannaclient import in an api tests it would still be incorrect.","commit_id":"7481350fcaa8b50f081305e0e8f54898fffe4dc6"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"e42d7255dfd463298b70eca62bc2a343495c3a07","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":19,"context_line":"                  \u0027trove\u0027, \u0027ironic\u0027, \u0027savanna\u0027, \u0027heat\u0027, \u0027ceilometer\u0027,"},{"line_number":20,"context_line":"                  \u0027marconi\u0027, \u0027sahara\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":23,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BrS4%3D","line":20,"in_reply_to":"AAAAWH%2F%2BueI%3D","updated":"2014-03-25 05:38:15.000000000","message":"Ok, when we plan to remove savanna from this list?","commit_id":"7481350fcaa8b50f081305e0e8f54898fffe4dc6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"bd6c82b5a6c19141d85204ab348cb0e49d842f33","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":19,"context_line":"                  \u0027trove\u0027, \u0027ironic\u0027, \u0027savanna\u0027, \u0027heat\u0027, \u0027ceilometer\u0027,"},{"line_number":20,"context_line":"                  \u0027marconi\u0027, \u0027sahara\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":23,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BueI%3D","line":20,"in_reply_to":"AAAAWH%2F%2Buf0%3D","updated":"2014-03-24 19:43:33.000000000","message":"That was intentional, someone might still have savanna client installed. Even if it\u0027s deprecated it\u0027s still out there. We don\u0027t want someone importing it either in the api tests. In fact it\u0027s even more invalid because it won\u0027t be updated.","commit_id":"7481350fcaa8b50f081305e0e8f54898fffe4dc6"}]}