)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ddfcd211fe24953cf6ed2a0a0290d109344f2155","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     sreekovili \u003cskovili@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-26 21:30:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug 1945082: Code Changes on cleanup service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I33154be93b2e91387fe2abbe771689e5fa03ff40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d3856dbe_1dbc1848","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":44},"updated":"2022-04-28 19:23:57.000000000","message":"Let\u0027s be more descriptive here","commit_id":"a2f7a3a63e025c19ba0356f4c836f244e550283c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ddfcd211fe24953cf6ed2a0a0290d109344f2155","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-01-26 21:30:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug 1945082: Code Changes on cleanup service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I33154be93b2e91387fe2abbe771689e5fa03ff40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f75f8b9d_cb03fbac","line":8,"updated":"2022-04-28 19:23:57.000000000","message":"Put the following as a footer (above Change-Id and below the body of the commit message - there has to be one empty line after the body of the commit message):\nCloses-Bug: #1945082\n\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#development-workflow","commit_id":"a2f7a3a63e025c19ba0356f4c836f244e550283c"}],"tempest/cmd/cleanup_service.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ddfcd211fe24953cf6ed2a0a0290d109344f2155","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    def list(self):"},{"line_number":157,"context_line":"        client \u003d self.client"},{"line_number":158,"context_line":"        snaps \u003d client.list_snapshots()[\u0027snapshots\u0027]"},{"line_number":159,"context_line":"        snaps \u003d [snap for snap in snaps if snap[\u0027name\u0027].startswith(\"tempest-\")]"},{"line_number":160,"context_line":"        if not self.is_save_state:"},{"line_number":161,"context_line":"            # recreate list removing saved snapshots"},{"line_number":162,"context_line":"            snaps \u003d [snap for snap in snaps if snap[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"16d5d63d_216def08","line":159,"range":{"start_line":159,"start_character":55,"end_line":159,"end_character":78},"updated":"2022-04-28 19:23:57.000000000","message":"what if we centralized this a bit, we could create a function which checks whether the given resource starts with \"tempest-\" and call this function from every service\u0027s list method - the advantage would be that we could pass an option to the filter function which would enable the filter (function would filter out all resources whose name starts with \"tempest-\") or disable it (function would practically return the given input) - that way we don\u0027t we have only one if statement and can control whether we want this new feature have enabled or not (there are still some situations when cleanup_service can be used to delete everything it finds ...)","commit_id":"a2f7a3a63e025c19ba0356f4c836f244e550283c"}]}
