)]}'
{"tempest/api_schema/compute/flavors_extra_specs.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"cbf2dc685f5a40c2d256594a49f490f13b3cfb1b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0027response_body\u0027: {"},{"line_number":18,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"        \u0027properties\u0027: {"},{"line_number":20,"context_line":"            \u0027extra_specs\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"        \u0027required\u0027: [\u0027extra_specs\u0027]"},{"line_number":23,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9VAI%3D","line":20,"updated":"2014-04-07 01:04:54.000000000","message":"Can\u0027t you check that extra specs is an array of format:\n\n\u0027string\u0027: something","commit_id":"e1ddab8f77544abb8fcd2d140095d008ad3ecd8b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"67badc262167678225ce3c65837d93eab5b8f557","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0027response_body\u0027: {"},{"line_number":18,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"        \u0027properties\u0027: {"},{"line_number":20,"context_line":"            \u0027extra_specs\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"        \u0027required\u0027: [\u0027extra_specs\u0027]"},{"line_number":23,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F8X8%3D","line":20,"in_reply_to":"AAAAWH%2F9VAI%3D","updated":"2014-04-08 11:00:31.000000000","message":"Thanks Chris. This is nice idea.\nDone.","commit_id":"e1ddab8f77544abb8fcd2d140095d008ad3ecd8b"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"cbf2dc685f5a40c2d256594a49f490f13b3cfb1b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"flavor_extra_specs_key \u003d {"},{"line_number":27,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":28,"context_line":"    \u0027response_body\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9U%2F4%3D","line":28,"updated":"2014-04-07 01:04:54.000000000","message":"ditto - check that it is of the format is\n\nkey: value\n\nalso the key is going to be of the format:\n\nVALID_EXTRASPEC_NAME_REGEX \u003d re.compile(r\"[\\w\\.\\- :]+$\", re.UNICODE)\n\nbecause of the input validation","commit_id":"e1ddab8f77544abb8fcd2d140095d008ad3ecd8b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"67badc262167678225ce3c65837d93eab5b8f557","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"flavor_extra_specs_key \u003d {"},{"line_number":27,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":28,"context_line":"    \u0027response_body\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F8X0%3D","line":28,"in_reply_to":"AAAAWH%2F9U%2F4%3D","updated":"2014-04-08 11:00:31.000000000","message":"Done.","commit_id":"e1ddab8f77544abb8fcd2d140095d008ad3ecd8b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"580950565be88b490f9320b564171649927a656b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":21,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"                \u0027patternProperties\u0027: {"},{"line_number":23,"context_line":"                    \u0027^[a-zA-Z0-9_\\-\\. :]+$\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":24,"context_line":"                }"},{"line_number":25,"context_line":"            }"},{"line_number":26,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FzFU%3D","line":23,"updated":"2014-04-17 11:32:53.000000000","message":"I\u0027m not sure this pattern is right for extra_specs.\nHow about relaxing the pattern with\n\n \u0027^.+$\u0027: {\u0027type\u0027: \u0027string\u0027}\n\ninstead?","commit_id":"91ef1a0643752b071063f7a79ae15f7023255ed6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"030e46722c897a74601a4c16b4aaab76e0675304","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":21,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"                \u0027patternProperties\u0027: {"},{"line_number":23,"context_line":"                    \u0027^[a-zA-Z0-9_\\-\\. :]+$\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":24,"context_line":"                }"},{"line_number":25,"context_line":"            }"},{"line_number":26,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fsas%3D","line":23,"in_reply_to":"AAAAXH%2F%2FtT8%3D","updated":"2014-04-18 06:46:51.000000000","message":"Thanks for your explanation, that is good for me.\nCurrent pattern is already nice, thanks.","commit_id":"91ef1a0643752b071063f7a79ae15f7023255ed6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3a43ed0d124188311990dee50d103931d4b726e7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":21,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"                \u0027patternProperties\u0027: {"},{"line_number":23,"context_line":"                    \u0027^[a-zA-Z0-9_\\-\\. :]+$\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":24,"context_line":"                }"},{"line_number":25,"context_line":"            }"},{"line_number":26,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FtT8%3D","line":23,"in_reply_to":"AAAAXH%2F%2FzFU%3D","updated":"2014-04-18 02:35:50.000000000","message":"Actually, same expression is being verified during extra spec APIs. ( https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/flavorextraspecs.py#L65 )  Which is defined in https://github.com/openstack/nova/blob/master/nova/compute/flavors.py#L64 \n\nBut still we can relax the pattern as mentioned by you to have more flexibility. Please provide your opinion.","commit_id":"91ef1a0643752b071063f7a79ae15f7023255ed6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"580950565be88b490f9320b564171649927a656b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027response_body\u0027: {"},{"line_number":34,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":35,"context_line":"        \u0027patternProperties\u0027: {"},{"line_number":36,"context_line":"            \u0027^[a-zA-Z0-9_\\-\\. :]+$\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FzFQ%3D","line":36,"updated":"2014-04-17 11:32:53.000000000","message":"ditto","commit_id":"91ef1a0643752b071063f7a79ae15f7023255ed6"}]}
