)]}'
{"tempest/api/orchestration/stacks/test_non_empty_stack.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3dd7b077b4f9df28d159a6f45a134c72f1f568ab","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        # Start by creating an empty stack"},{"line_number":285,"context_line":"        template \u003d \u0027heat_template_version: 2013-05-23\u0027"},{"line_number":286,"context_line":"        stack_identifier \u003d self.create_stack(\u0027test_stack_update\u0027, template)"},{"line_number":287,"context_line":"        self.addCleanup(self.clear_stacks, [stack_identifier])"},{"line_number":288,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":289,"context_line":"        self.assertEqual({}, self._list_resources(stack_identifier))"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BW%2BU%3D","line":287,"updated":"2014-03-27 12:03:05.000000000","message":"I don\u0027t think this is needed, as we\u0027ll do the cleanup already with create_stack","commit_id":"a04eb8c2fc3943a30832b51f86114d1dfd4e3329"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cc5fc354eb440fd5d693e03ca4814610003cbfc3","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        # Start by creating an empty stack"},{"line_number":285,"context_line":"        template \u003d \u0027heat_template_version: 2013-05-23\u0027"},{"line_number":286,"context_line":"        stack_identifier \u003d self.create_stack(\u0027test_stack_update\u0027, template)"},{"line_number":287,"context_line":"        self.addCleanup(self.clear_stacks, [stack_identifier])"},{"line_number":288,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":289,"context_line":"        self.assertEqual({}, self._list_resources(stack_identifier))"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BW10%3D","line":287,"in_reply_to":"AAAAWH%2F%2BW%2BU%3D","updated":"2014-03-27 12:20:05.000000000","message":"The idea was to remove only the stacks created by the test, otherwise any subsequent tests which expected only the stack created in setUpClass might fail.\n\nI\u0027m actually considering reworking this so we have a separate test_update.py which might be clearer?","commit_id":"a04eb8c2fc3943a30832b51f86114d1dfd4e3329"}],"tempest/api/orchestration/stacks/test_update.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"76c8d6266e8e8304c4c23f8735451dd100b88827","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update_stack(self, stack_identifier, template):"},{"line_number":35,"context_line":"        stack_name \u003d stack_identifier.split(\u0027/\u0027)[0]"},{"line_number":36,"context_line":"        resp, body \u003d self.client.update_stack("},{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BMdA%3D","line":36,"updated":"2014-03-28 14:04:45.000000000","message":"unused variable \"body\"","commit_id":"debef25c7b20436b3e8b41aed9dc0fd5e7dd008d"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d7c94b6a57b333b8f4d4ac0a0beea5f217c2f3be","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update_stack(self, stack_identifier, template):"},{"line_number":35,"context_line":"        stack_name \u003d stack_identifier.split(\u0027/\u0027)[0]"},{"line_number":36,"context_line":"        resp \u003d self.client.update_stack("},{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BMQE%3D","line":36,"updated":"2014-03-28 14:28:27.000000000","message":"may be would be better use \"resp, _\"?","commit_id":"fe458ddb5f6826b7fbceee19b161e0028a9c9bfb"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"a2ef887941a655ce506bd91df4f294118f213509","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update_stack(self, stack_identifier, template):"},{"line_number":35,"context_line":"        stack_name \u003d stack_identifier.split(\u0027/\u0027)[0]"},{"line_number":36,"context_line":"        resp \u003d self.client.update_stack("},{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BMDM%3D","line":36,"in_reply_to":"AAAAWH%2F%2BMF4%3D","updated":"2014-03-28 14:48:03.000000000","message":"ok","commit_id":"fe458ddb5f6826b7fbceee19b161e0028a9c9bfb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e903e52188a7fba93cd7a8ef40ddf364b5fb535e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update_stack(self, stack_identifier, template):"},{"line_number":35,"context_line":"        stack_name \u003d stack_identifier.split(\u0027/\u0027)[0]"},{"line_number":36,"context_line":"        resp \u003d self.client.update_stack("},{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BMF4%3D","line":36,"in_reply_to":"AAAAWH%2F%2BMQE%3D","updated":"2014-03-28 14:45:41.000000000","message":"I\u0027ve just followed the convention used in other tests, and personally I really hate using \"_\"  as a variable name so would prefer not to do it that way, if you don\u0027t mind :)\n\nI don\u0027t really get the obsession with purging \"unused\" variables - all you\u0027re proposing here is replacing a descriptive unused variable with a non descriptive one.  All it does is makes the code less readable IMO.","commit_id":"fe458ddb5f6826b7fbceee19b161e0028a9c9bfb"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d7c94b6a57b333b8f4d4ac0a0beea5f217c2f3be","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"},{"line_number":40,"context_line":"        self.assertEqual(\u0027202\u0027, resp[0][\u0027status\u0027])"},{"line_number":41,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027UPDATE_COMPLETE\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BMPk%3D","line":40,"updated":"2014-03-28 14:28:27.000000000","message":"and here you can use resp[\u0027status\u0027]","commit_id":"fe458ddb5f6826b7fbceee19b161e0028a9c9bfb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e903e52188a7fba93cd7a8ef40ddf364b5fb535e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            stack_identifier\u003dstack_identifier,"},{"line_number":38,"context_line":"            name\u003dstack_name,"},{"line_number":39,"context_line":"            template\u003dtemplate)"},{"line_number":40,"context_line":"        self.assertEqual(\u0027202\u0027, resp[0][\u0027status\u0027])"},{"line_number":41,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027UPDATE_COMPLETE\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BMGI%3D","line":40,"in_reply_to":"AAAAWH%2F%2BMPk%3D","updated":"2014-03-28 14:45:41.000000000","message":"Yeah, like in the first patch..","commit_id":"fe458ddb5f6826b7fbceee19b161e0028a9c9bfb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8a5698c953eb3c74ff77b7b3ded874c1d0370101","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                         self.list_resources(stack_identifier))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Add one resource via a stack update"},{"line_number":67,"context_line":"        update_template \u003d copy.deepcopy(self.template)"},{"line_number":68,"context_line":"        rsrc_snippet \u003d \u0027  random2:\\n    type: \\\u0027OS::Heat::RandomString\\\u0027\\n\u0027"},{"line_number":69,"context_line":"        update_template +\u003d rsrc_snippet"},{"line_number":70,"context_line":"        self.update_stack(stack_identifier, update_template)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F9rq8%3D","line":67,"updated":"2014-04-02 20:34:25.000000000","message":"Defining a self.update_template at the top would make it more clear what we\u0027re updating to. I can see update tests performing updates on a collection of templates so it would be good to establish that pattern now.","commit_id":"4d4a341eda80c3e6695489d3b8d41445d8d1080e"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8c2200a2053d7974f4809690d5f417fe6aea7c6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                         self.list_resources(stack_identifier))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Add one resource via a stack update"},{"line_number":67,"context_line":"        update_template \u003d copy.deepcopy(self.template)"},{"line_number":68,"context_line":"        rsrc_snippet \u003d \u0027  random2:\\n    type: \\\u0027OS::Heat::RandomString\\\u0027\\n\u0027"},{"line_number":69,"context_line":"        update_template +\u003d rsrc_snippet"},{"line_number":70,"context_line":"        self.update_stack(stack_identifier, update_template)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F9byo%3D","line":67,"in_reply_to":"AAAAWH%2F9rq8%3D","updated":"2014-04-04 14:53:49.000000000","message":"Ok, that makes sense.  I\u0027m also a little unclear when we\u0027re supposed to define templates inline, and when they should be defined in tempest/api/orchestration/stacks/templates/","commit_id":"4d4a341eda80c3e6695489d3b8d41445d8d1080e"}]}