)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c7c06202fe7262ec6b82c3921d3f2443ddeea1ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"626a3823_49865968","updated":"2022-03-02 21:43:35.000000000","message":"This test works but there\u0027s one failure which I\u0027m unable to understand and need help with.\nIt fails the validation check in tempest[1] even when I\u0027m not introducing any new parameters to the rebuild response.\nSkipping the validation check passes the test[2]\n\n\n[1] https://paste.opendev.org/show/bB6bea3xtGhwWfnyi66M/\n[2] https://paste.opendev.org/show/bdnPlcMIX51oz46oX9Vk/","commit_id":"e5621a7560291b8785377a1de2f224c2e2c72193"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8edb5a3f6de60f08b1f66efec4df39cbfdfa0c1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8e54a5d8_ad09d9d5","in_reply_to":"4816b30c_03a2536c","updated":"2022-03-03 08:59:17.000000000","message":"Thanks!","commit_id":"e5621a7560291b8785377a1de2f224c2e2c72193"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0370289da474efba3ee2eb9020df29675b3d2389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5c69310_12445d8a","in_reply_to":"626a3823_49865968","updated":"2022-03-03 00:40:23.000000000","message":"those are missing schema from old microversion, I will fix those in separate patch.","commit_id":"e5621a7560291b8785377a1de2f224c2e2c72193"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"debe1124fd9df8305a64ab9c9b1d1b60be271d24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4816b30c_03a2536c","in_reply_to":"c5c69310_12445d8a","updated":"2022-03-03 04:37:32.000000000","message":"adding the missing schema in https://review.opendev.org/c/openstack/tempest/+/831628","commit_id":"e5621a7560291b8785377a1de2f224c2e2c72193"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7dffbe8925d862929c73b97e2bd6f17e1d0fbcbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b9a6356_00b25e5f","updated":"2022-03-22 14:06:22.000000000","message":"It looks to me like the volume rebuild failed, based on the logs. Looks to me like we\u0027re failing to re-attach (details below). I\u0027m not really sure why the test would pass, unless we\u0027re just re-attaching the old volume and not realizing that it failed. That\u0027s a good reason to do a file-based validation.\n\n Mar 09 15:43:43.116330 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: DEBUG oslo_concurrency.lockutils [None req-0709e5ad-8698-430c-8a75-3744f88a8f49 tempest-ServerActionsV291TestJSON-252078166 tempest-ServerActionsV291TestJSON-252078166-project] Lock \"connect_volume\" acquired by \"os_brick.initiator.connectors.iscsi.ISCSIConnector.disconnect_volume\" :: waited 0.000s {{(pid\u003d98584) inner /usr/local/lib/python3.8/dist-packages/oslo_concurrency/lockutils.py:386}}\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi [None req-0709e5ad-8698-430c-8a75-3744f88a8f49 tempest-ServerActionsV291TestJSON-252078166 tempest-ServerActionsV291TestJSON-252078166-project] Exception encountered during portal discovery: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: Command: iscsiadm -m discoverydb -o show -P 1\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: Exit code: 21\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: Stdout: \u0027SENDTARGETS:\\nNo targets found.\\niSNS:\\nNo targets found.\\nSTATIC:\\nNo targets found.\\nFIRMWARE:\\nNo targets found.\\n\u0027\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: Stderr: \u0027\u0027\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Traceback (most recent call last):\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/opt/stack/nova/nova/compute/manager.py\", line 3883, in _do_rebuild_instance\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     self.driver.rebuild(**kwargs)\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/opt/stack/nova/nova/virt/driver.py\", line 341, in rebuild\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     raise NotImplementedError()\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi NotImplementedError\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi \nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi During handling of the above exception, another exception occurred:\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi \nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Traceback (most recent call last):\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/os_brick/initiator/connectors/iscsi.py\", line 206, in _get_ips_iqns_luns\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     ips_iqns_luns \u003d method(connection_properties)\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/os_brick/initiator/connectors/iscsi.py\", line 365, in _get_discoverydb_portals\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     out \u003d self._run_iscsiadm_bare([\u0027-m\u0027, \u0027discoverydb\u0027,\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/os_brick/initiator/connectors/iscsi.py\", line 1160, in _run_iscsiadm_bare\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     (out, err) \u003d self._execute(\u0027iscsiadm\u0027,\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/os_brick/executor.py\", line 53, in _execute\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     result \u003d self.__execute(*args, **kwargs)\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/os_brick/privileged/rootwrap.py\", line 172, in execute\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     return execute_root(*cmd, **kwargs)\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/oslo_privsep/priv_context.py\", line 271, in _wrap\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     return self.channel.remote_call(name, args, kwargs,\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi   File \"/usr/local/lib/python3.8/dist-packages/oslo_privsep/daemon.py\", line 215, in remote_call\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi     raise exc_type(*result[2])\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Command: iscsiadm -m discoverydb -o show -P 1\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Exit code: 21\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Stdout: \u0027SENDTARGETS:\\nNo targets found.\\niSNS:\\nNo targets found.\\nSTATIC:\\nNo targets found.\\nFIRMWARE:\\nNo targets found.\\n\u0027\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi Stderr: \u0027\u0027\nMar 09 15:43:43.136147 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: ERROR os_brick.initiator.connectors.iscsi \nMar 09 15:43:43.139733 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: DEBUG os_brick.initiator.connectors.iscsi [None req-0709e5ad-8698-430c-8a75-3744f88a8f49 tempest-ServerActionsV291TestJSON-252078166 tempest-ServerActionsV291TestJSON-252078166-project] Skipping cleanup Unable to find target portal 10.208.225.98:3260. {{(pid\u003d98584) _cleanup_connection /usr/local/lib/python3.8/dist-packages/os_brick/initiator/connectors/iscsi.py:923}}\nMar 09 15:43:43.139884 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: DEBUG oslo_concurrency.lockutils [None req-0709e5ad-8698-430c-8a75-3744f88a8f49 tempest-ServerActionsV291TestJSON-252078166 tempest-ServerActionsV291TestJSON-252078166-project] Lock \"connect_volume\" \"released\" by \"os_brick.initiator.connectors.iscsi.ISCSIConnector.disconnect_volume\" :: held 0.023s {{(pid\u003d98584) inner /usr/local/lib/python3.8/dist-packages/oslo_concurrency/lockutils.py:400}}\nMar 09 15:43:43.140293 ubuntu-focal-rax-dfw-0028762650 nova-compute[98584]: DEBUG os_brick.initiator.connectors.iscsi [None req-0709e5ad-8698-430c-8a75-3744f88a8f49 tempest-ServerActionsV291TestJSON-252078166 tempest-ServerActionsV291TestJSON-252078166-project] \u003c\u003d\u003d disconnect_volume: return (24ms) None {{(pid\u003d98584) trace_logging_wrapper /usr/local/lib/python3.8/dist-packages/os_brick/utils.py:194}}","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b3e8352800f52dde79574821b08598edaaf992d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"72908e88_fa01c919","updated":"2022-04-15 06:03:22.000000000","message":"Sorry I got busy with other work but will resume and focus on this one now.","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"86db4d803e452c377afd11eda3cf7861df63c8b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ea45c1e_b4e9c635","updated":"2022-03-21 14:50:23.000000000","message":"Where is this running? I don\u0027t see it in tempest-full jobs...","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fde56b9a74df0afef520851dbe2a83ed70ecba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"74ef5d4c_03cfcd9d","updated":"2022-04-15 06:03:32.000000000","message":"recheck\n\nfor fresh logs","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ea69ea6dfb235ced9dcab351a0e83abe3420ecfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d293243_9071d2be","in_reply_to":"2b9a6356_00b25e5f","updated":"2022-03-22 19:02:26.000000000","message":"\u003e It looks to me like the volume rebuild failed, based on the logs. Looks to me like we\u0027re failing to re-attach (details below). I\u0027m not really sure why the test would pass, unless we\u0027re just re-attaching the old volume and not realizing that it failed. That\u0027s a good reason to do a file-based validation.\n\nYeah, I hacked in a change to touch a file before the rebuild and then make sure it\u0027s not there after and can confirm that it\u0027s still present after the rebuild supposedly completed. I can clean that up and push that up as a change to this if you like, just say the word.\n\nAlso, I can confirm that the rebuild fails 100% of the time for me locally in the same way that it does in the job here.","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81cd3e7af7e751aff8bdebca0890fe21861c4306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"636582f2_5b1a233d","in_reply_to":"6e9d0e1d_37aadbdd","updated":"2022-04-18 14:03:12.000000000","message":"No problem, I figured :)\n\nI thought I had accidentally lost it, but it seems I saved it, so I will work on getting it cleaned up and added to this in the next couple of days.","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e866120a14939fdf84654cdd88e46d9e76522cdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fc191acf_e046abb9","in_reply_to":"7ea45c1e_b4e9c635","updated":"2022-03-22 09:39:59.000000000","message":"It\u0027s there in tempest-full-py3[1]\n\ntempest.api.compute.servers.test_server_actions.ServerActionsV291TestJSON\ntest_rebuild_volume_backed_server[id-6652dab9-ea24-4c93-ab5a-93d79c3041cf,volume]\npass\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9bd/831018/5/check/tempest-full-py3/9bd61bb/testr_results.html","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b3e8352800f52dde79574821b08598edaaf992d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e9d0e1d_37aadbdd","in_reply_to":"8d293243_9071d2be","updated":"2022-04-15 06:03:22.000000000","message":"Sure, if you\u0027ve the code ready, you can push the changes and if not (since I\u0027m too late to reply), I can update that as per the suggestion.","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"304c08d38445096463e25638230fb18b99aa3251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"490f42dd_dc1d9170","in_reply_to":"fc191acf_e046abb9","updated":"2022-03-22 13:56:45.000000000","message":"Huh, yeah, I must have been mistyping in my search. Apologies :)","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1b618068b253189cc18f18f89caa1b3588333124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d4e224e_4d8ce000","updated":"2022-04-19 17:37:13.000000000","message":"Looks like the latest run of this is still failing because the test file still exists after rebuild.","commit_id":"599e3fb4de9cbeb2df045c32cb3617ba50d2a53e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6a404b2c9dfb32ea5d825e8bc700413b8876e517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ce5ea726_3949a9c9","updated":"2022-04-27 10:34:25.000000000","message":"recheck","commit_id":"599e3fb4de9cbeb2df045c32cb3617ba50d2a53e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1a8a6debb75362d81adb4a812976d37d0f08c0c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ddbd4cfb_26041e7f","updated":"2022-04-19 06:02:07.000000000","message":"recheck","commit_id":"599e3fb4de9cbeb2df045c32cb3617ba50d2a53e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6a404b2c9dfb32ea5d825e8bc700413b8876e517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7669b8d5_8f3a5b37","in_reply_to":"3d4e224e_4d8ce000","updated":"2022-04-27 10:34:25.000000000","message":"Yeah i was working on it locally. I found out the issue in the nova patch, the root volume was getting detached earlier than expected failing the operation. I\u0027ve fixed the issue with latest changes in compute manager[1]. The operation still fails locally for me but there is no error trace in nova or cinder logs. I will follow up on the issue.\n\n[1] https://review.opendev.org/c/openstack/nova/+/820368/27..28/nova/compute/manager.py","commit_id":"599e3fb4de9cbeb2df045c32cb3617ba50d2a53e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"84139e011b2c03cb42b3919a16b207f71b3d42c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3017a591_0ca942be","updated":"2022-05-18 08:37:21.000000000","message":"recheck","commit_id":"945cd77f194c674035079ad29af769606b9285ae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df5966451a1962823e908005eb5dab1c822087af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"face6822_7df5455e","updated":"2022-05-19 06:45:47.000000000","message":"recheck","commit_id":"0f6986d8725db1c1aea564f8c60f60351be70d4e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"942410784edfd082c470ddca55fb0d45abafe391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"10e6ad85_9eb0ec7d","updated":"2022-05-24 17:43:01.000000000","message":"so over all i think we need 6 tests cases\n\nbfv\u003dFalse old micorversoin -\u003e rebuild new or old image erases data (2 tests)\nbfv\u003dtrue old micorversion -\u003e rebuild new image result in error\nbfv\u003dtrue old micorversion -\u003e rebuild old image preseves data\nbfv\u003dtrue new micorversion -\u003e rebuild new or old image erases data (2 tests)\n\n\nand then when the image chagne we shoudl not try to revert back to the old image in cleanup.\n","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7306fb52db9730100f1fa24f7b3edc64c04c7db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"568818ac_0fefdbce","updated":"2022-05-25 11:36:11.000000000","message":"Sean\u0027s comments still apply.","commit_id":"293ea8d0b30dfc768896193e18ab0407423a1d91"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ac5e9cf18ccaeaac2b826a8eb7c9f0a4ab1b4734","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1d3ce616_f17641f8","updated":"2022-05-25 18:33:51.000000000","message":"recheck","commit_id":"293ea8d0b30dfc768896193e18ab0407423a1d91"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0a7ce010_de0015d8","updated":"2022-06-10 15:43:13.000000000","message":"I will push up a change to this, but the comments here document what needs changing.","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e8574cdb31ba53f832e7a95638f756c19018ca7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"bd71bcd7_38c70dc6","updated":"2022-07-18 08:52:14.000000000","message":"recheck","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd740585cc9458812cc40f29333aa6c0993a5d16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c3385ea8_a6de6d18","updated":"2022-08-23 16:25:05.000000000","message":"recheck test run logs are stale","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cb533e8f8bd09b2d5f2695f1f7ed7144f2339bce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9e4eba4c_c766991d","updated":"2022-08-24 06:39:50.000000000","message":"recheck","commit_id":"2137600e1e9727b2a36cb85e3fcdd8de422f9366"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49d8b666bf4f8f8488c900437a1534397a2af2e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"115e54ff_15cc3a0a","updated":"2022-08-30 21:06:57.000000000","message":"There are some issues with zuul here but I tested the patch locally against the latest nova and cinder changes (including[1]) and it is passing.\n\nstack@devstack-VirtualBox:~/tempest$ tempest run --regex tempest.api.compute.servers.test_server_actions.ServerActionsV294TestJSON\n{0} tempest.api.compute.servers.test_server_actions.ServerActionsV294TestJSON.test_rebuild_volume_backed_server [149.887095s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 149.8871 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 149.8871 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (1 tests) \u003d\u003e 0:02:29.887095\n\n\n[1] https://review.opendev.org/c/openstack/cinder/+/855288","commit_id":"676ab4935f6e51538fabe9e75b45a625a6c2ea91"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f6210d561de619a1268abca1d9a39057135a9d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"897ea7a8_1c548bbc","updated":"2022-08-24 12:14:29.000000000","message":"recheck","commit_id":"676ab4935f6e51538fabe9e75b45a625a6c2ea91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f27d0fc66217c34d8b8070d4973137d55fb81e38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"180a177f_0073e7d2","updated":"2022-08-31 19:39:35.000000000","message":"adding a full job to test this seams pretty heavy\n\nthis shoudl be able to be tested in any tempest job with cinder.","commit_id":"f821c852c21dab4d6d665e934796fa5e7aef312c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"09cc7f0d77195537f4cd8d8180783a0c8e260a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"71e58429_0406e75e","in_reply_to":"180a177f_0073e7d2","updated":"2022-08-31 20:07:11.000000000","message":"This requires two different images to test the main functionality properly and AFAIK other jobs just use one cirros image for testing.","commit_id":"f821c852c21dab4d6d665e934796fa5e7aef312c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ba8924f49e84c016fa01a72badcb1b5215f17ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"0a3cb8c0_7c7f52a7","in_reply_to":"71e58429_0406e75e","updated":"2022-09-01 04:20:24.000000000","message":"Also this is already being tested in tempest full but with rebuild to same image","commit_id":"f821c852c21dab4d6d665e934796fa5e7aef312c"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"b86af78cbdb1f12fb19510a1cc586b0b32560cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"44ab1f8f_0f8fba08","updated":"2022-10-07 15:25:10.000000000","message":"I have locally tested this patch, here is the result:-\n\nstack@devstack:~/tempest$ tempest run --regex tempest.api.compute.servers.test_server_actions.ServerActionsV293TestJSON\n\n{0} tempest.api.compute.servers.test_server_actions.ServerActionsV293TestJSON.test_rebuild_volume_backed_server [49.977620s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 49.9776 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 49.9776 sec.\n\nBy the above result we can say that test runs fine. Another point of consideration is the execution time take by the job - tempest-rebuild-volume-backed[1].\nIt is 26 mins which is also good\n\nBut, I want to know like why are we adding a specific job for test_rebuild_volume_backed_server, because likewise we have so many tests and we dont add specific jobs for all tests.\nThis is one thing I am not sure about this patch, otherwise is all good. I can remove my vote after the explanation.\n\n[1] https://zuul.opendev.org/t/openstack/build/c4755d78c9e04e59a4c151c5fe9f1c5a","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"376d7097355ff5936acf2b5455d59ac0ed3960c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"179da799_8defda71","updated":"2022-11-23 14:33:21.000000000","message":"i wonder whether this failed randomly or it\u0027s something we need to address:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a28/831018/24/check/tempest-full-test-account-no-admin-py3/a280e87/testr_results.html\n\n+ one other comment ","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"332a2079d1e9b601337899e50b95386ab2eef6a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"5c0ac1e7_efe7c5f5","updated":"2022-11-23 09:38:00.000000000","message":"recheck - it looks good, let\u0027s re-trigger the jobs to get fresh logs ","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9e7f0dc7f73399468508efb825e1e0ae9f10b6d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"5615b15d_a61c60f9","updated":"2023-03-02 15:00:36.000000000","message":"recheck we still need to merge this","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e47ca6ebb1c27bafb8721dad2a943d739579aaa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"72e4fdc6_a6bb3f38","in_reply_to":"44ab1f8f_0f8fba08","updated":"2022-11-07 10:22:26.000000000","message":"The difference in this test and other test is, this uses 2 different images to perform the rebuild and you can see it in the new job config[1]. I was unable to find any other job using different images.\nThe reason we want 2 different images is, the rebuild operation worked before with same images before and this feature enables the rebuild to be done with different images.\n\n[1] IMAGE_URLS: http://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img, http://download.cirros-cloud.net/0.5.0/cirros-0.5.0-x86_64-disk.img","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a5edd6c91d228667f5edbf03a2cb39cd641e49a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"09f2133d_beb8cc88","updated":"2023-05-23 11:30:39.000000000","message":"Good catch Martin!","commit_id":"8f58a9eaf997038ac6eb26368a96ecbfc038671b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"68e711dd53bbaaeb8a1d2a25a9a00aa446ca7ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"97df61c1_c8aab6ca","updated":"2023-03-03 16:03:50.000000000","message":"Sorry i got busy with other stuff, surely we want to merge this!","commit_id":"8f58a9eaf997038ac6eb26368a96ecbfc038671b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db5039c37592e8fc2d5223ddbbdf165d1bc00858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"92ae789b_6de0d3d8","updated":"2023-03-03 14:45:12.000000000","message":"This passed the dedicated job, and that test is also running in tempest-full. So I think we should be good to drop the extra job stuff and merge this? This is coverage we\u0027ve been missing for a while.","commit_id":"8f58a9eaf997038ac6eb26368a96ecbfc038671b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6406ada5b0e6b03883c4ecd5bd2a67c32afef036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"876de058_e51ffb8f","updated":"2023-03-05 23:46:18.000000000","message":"one detail otherwise it seems to be passing ok","commit_id":"8f58a9eaf997038ac6eb26368a96ecbfc038671b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"68e711dd53bbaaeb8a1d2a25a9a00aa446ca7ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"5104dc06_173eda43","in_reply_to":"92ae789b_6de0d3d8","updated":"2023-03-03 16:03:50.000000000","message":"The problem with the test running in tempest-full-py3 is it\u0027s using the same image. It does call cinder to reimage the volume (i.e. new flow) which if we consider a correct test then it should be fine but in the new job, we use different image IDs.\n\ntempest-full-py3\nimage_ref_alt \u003d 9e3fcdd5-84a9-4230-b45d-1398ec9fa86c\nimage_ref \u003d 9e3fcdd5-84a9-4230-b45d-1398ec9fa86c\n\ntempest-rebuild-volume-backed\nimage_ref_alt \u003d 4b246f3e-62ee-4e3e-8acd-822b4265f2aa\nimage_ref \u003d 974ab6e3-54b5-43d8-bd5a-36437f483c15","commit_id":"8f58a9eaf997038ac6eb26368a96ecbfc038671b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5089def4a9c27dd51a71629d70172c1d6d5fb98b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"ccd3174b_2c4d37b5","updated":"2023-06-01 09:54:16.000000000","message":"Thanks Martin, will address comments in next PS.","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2071856b79249f6540fad5df6931845ddf8ad286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"791bc30e_e169f3bb","updated":"2023-05-24 13:45:45.000000000","message":"check experimental","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0c6e6ef4710c7e9ca0953f581cb947674fcbad49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"094d7cb5_3d7aa0a2","updated":"2023-05-24 13:45:33.000000000","message":"the test is passing just fine, I just don\u0027t like the fact we need to deploy a whole job to run only a single test :/","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ddba2d53_c69daa5f","updated":"2023-06-02 18:09:27.000000000","message":"few things to fixed here","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4b143151_15016ef9","updated":"2023-06-06 10:34:22.000000000","message":"Hi,\n\nThanks for your review.","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d02a1e58e55049703229ff5ef38d9866781fdea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"6705a8f2_d867d029","updated":"2023-06-07 19:43:16.000000000","message":"thanks Rajat for updates. please check my reply inline.","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c043caa1d108e8af9ecdfcfa0674bfd302129e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"801441da_a3a49f7e","updated":"2023-06-08 09:58:01.000000000","message":"Thanks for the review. Added two images to devstack-tempest job.","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"991012b287ae5306e4d2e9d597d14fa9491eb14a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"dcd4e7d6_a3984703","updated":"2023-06-09 17:29:04.000000000","message":"glance-multistore-cinder-import failure is valid. glance playbook started listing more one image and try to pass all three image in glance show API\n\nhttps://zuul.opendev.org/t/openstack/build/68a4d3ec6ce04c87b21d73a333f5b5cd/log/job-output.txt#23161\n\nwe need to update this script to pick each job one by one and pass to gl;ance show\n\nhttps://github.com/openstack/glance/blob/43b2116adb92e5fbe945b53edd115edadd73a016/playbooks/post-check-metadata-injection.yaml#L13-L19","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f2eae6e75a6c00492c27d41de0235bb5341a945e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"2235bfe1_3dff3a38","updated":"2023-06-09 17:29:37.000000000","message":"other than that, I am satisfy with the result and we can go with the two different image config.","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9bf19107433afd8b8ac712c0458ae6d55f40fc60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"cb89f079_fc06e7f4","updated":"2023-06-09 01:42:17.000000000","message":"recheck another try to check if any impact.","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d1b9b370db4315848c7cfe313e24537284dfd73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"c7e8f5df_f39b000c","updated":"2023-06-08 21:57:03.000000000","message":"recheck another try to see the results to compare","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dad8d13c5f43196b05c0d8d88bb5e206166f0305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ccf21fad_978492fb","updated":"2023-06-08 16:53:16.000000000","message":"recheck to trigger jobs again to see if time is inreased","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"87e982afc2c32a904152e8eb346b62e490ff7012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"7f8f72fb_404c4312","in_reply_to":"dcd4e7d6_a3984703","updated":"2023-06-14 09:31:05.000000000","message":"Proposed a patch to fix the script\nhttps://review.opendev.org/c/openstack/glance/+/886071","commit_id":"6764a158442aeb5dd6a2d11de5b7092a9814c1de"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"87e982afc2c32a904152e8eb346b62e490ff7012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"1dbcc999_750085ca","updated":"2023-06-14 09:31:05.000000000","message":"Added a depends on, on the job fix.","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"441e12c8ae6b6c88a786f059cf4b843811034050","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"49565d18_3032daf8","updated":"2023-06-14 17:50:56.000000000","message":"Looks good to me!","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5f13e08d8d520d54fd99c87f73115814a830e331","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"4384967a_af16e769","updated":"2023-06-14 17:50:25.000000000","message":"discussed during PTG, lgtm, this should not add any extra time to the job,  soo +2","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"53787669d436648b87b0ff74472dc2970fc6c44f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"dbf8654f_d03e69f2","updated":"2023-06-22 09:17:00.000000000","message":"recheck docs job should be passing now","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d5f926c2ce4daa14d53ab1df201657330f85fb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"5a28a8f5_44e4fa78","updated":"2023-06-16 17:13:54.000000000","message":"recheck live migration failures unrelated to the test being added here","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5183f64aaa10c1fdff9b6b8b0b4d35adf3935a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"aa12f231_2938a3e5","updated":"2023-06-14 17:41:21.000000000","message":"recheck multiple errors in rbac job 2023-06-14 11:13:31.164222 | controller |     urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host\u003d\u0027158.69.76.44\u0027, port\u003d9696): Read timed out. (read timeout\u003d60)","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dc7489a3857945a8820924c445441d2cc5cac2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"b8f1ddf1_3ee2b3c1","updated":"2023-06-20 11:21:33.000000000","message":"recheck openstack-tox-docs timed out","commit_id":"768d253670941ed5c88d923452192b385224622f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f79c6a874c0f29e0151cd5c72acbbbc7966f7e95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"ac4ec399_4b8846f6","updated":"2023-06-19 21:42:49.000000000","message":"recheck tempest.lib.exceptions.IdentityError: Got identity error","commit_id":"768d253670941ed5c88d923452192b385224622f"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7dffbe8925d862929c73b97e2bd6f17e1d0fbcbf","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":945,"context_line":"                server\u003drebuilt_server,"},{"line_number":946,"context_line":"                servers_client\u003dself.client)"},{"line_number":947,"context_line":"            linux_client.validate_authentication()"}],"source_content_type":"text/x-python","patch_set":5,"id":"e27b6074_fd8faa50","line":947,"updated":"2022-03-22 14:06:22.000000000","message":"I think we should log into the server before we rebuild, create a file on the root disk and then make sure it\u0027s gone after the rebuild to make sure it worked, right?","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1b618068b253189cc18f18f89caa1b3588333124","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":945,"context_line":"                server\u003drebuilt_server,"},{"line_number":946,"context_line":"                servers_client\u003dself.client)"},{"line_number":947,"context_line":"            linux_client.validate_authentication()"}],"source_content_type":"text/x-python","patch_set":5,"id":"14f3c85d_3c76305c","line":947,"in_reply_to":"3a4b071f_d0eb4da4","updated":"2022-04-19 17:37:13.000000000","message":"Done","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b3e8352800f52dde79574821b08598edaaf992d","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":945,"context_line":"                server\u003drebuilt_server,"},{"line_number":946,"context_line":"                servers_client\u003dself.client)"},{"line_number":947,"context_line":"            linux_client.validate_authentication()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a4b071f_d0eb4da4","line":947,"in_reply_to":"e27b6074_fd8faa50","updated":"2022-04-15 06:03:22.000000000","message":"Makes sense, will update it.","commit_id":"a985133818b44d36aa5f88a8d9aba8cb565f768f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"942410784edfd082c470ddca55fb0d45abafe391","unresolved":true,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":866,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":867,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":868,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":869,"context_line":"        # We have to create a new server that is volume-backed since the one"},{"line_number":870,"context_line":"        # from setUp is not volume-backed."}],"source_content_type":"text/x-python","patch_set":12,"id":"ca20c08a_95c20f32","line":867,"range":{"start_line":867,"start_character":8,"end_line":867,"end_character":41},"updated":"2022-05-24 17:43:01.000000000","message":"so i think we also need to expiclty test the old micorverion behvior here and assert that the rebuild will preseve data for boot form volume and destoy the data for non boot form voluem instances when using the old micorverison.","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f27d0fc66217c34d8b8070d4973137d55fb81e38","unresolved":false,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":866,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":867,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":868,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":869,"context_line":"        # We have to create a new server that is volume-backed since the one"},{"line_number":870,"context_line":"        # from setUp is not volume-backed."}],"source_content_type":"text/x-python","patch_set":12,"id":"fca8807d_81c58381","line":867,"range":{"start_line":867,"start_character":8,"end_line":867,"end_character":41},"in_reply_to":"ca20c08a_95c20f32","updated":"2022-08-31 19:39:35.000000000","message":"we still do not have test coverage of the old micorversion behavior at least not in this file.\n\nit wolld be nice to add that at ome point but im not oging to block on that.","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"09cc7f0d77195537f4cd8d8180783a0c8e260a93","unresolved":false,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":866,"context_line":"    @decorators.idempotent_id(\u00276652dab9-ea24-4c93-ab5a-93d79c3041cf\u0027)"},{"line_number":867,"context_line":"    def test_rebuild_volume_backed_server(self):"},{"line_number":868,"context_line":"        \"\"\"Test rebuilding a volume backed server\"\"\""},{"line_number":869,"context_line":"        # We have to create a new server that is volume-backed since the one"},{"line_number":870,"context_line":"        # from setUp is not volume-backed."}],"source_content_type":"text/x-python","patch_set":12,"id":"40a5a93d_cecd161e","line":867,"range":{"start_line":867,"start_character":8,"end_line":867,"end_character":41},"in_reply_to":"fca8807d_81c58381","updated":"2022-08-31 20:07:11.000000000","message":"I was experimenting with this locally with different parameter that tempest provides like min_microversion, max_microversion, api_microversion etc but none of them worked. I would need some help from QA folks and then will add the old microversion test as well.","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"942410784edfd082c470ddca55fb0d45abafe391","unresolved":true,"context_lines":[{"line_number":913,"context_line":"            adminPass\u003dpassword,"},{"line_number":914,"context_line":"            reimage_boot_volume\u003dTrue)[\u0027server\u0027]"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":917,"context_line":"        # original image once the test ends"},{"line_number":918,"context_line":"        # This is not needed since we are creating a temporary server which"},{"line_number":919,"context_line":"        # won\u0027t affect other tests but is a good validation of vice-versa"},{"line_number":920,"context_line":"        # volume backed rebuild"},{"line_number":921,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":922,"context_line":"            self.addCleanup(self._rebuild_server_vol_backed_check,"},{"line_number":923,"context_line":"                            server[\u0027id\u0027], self.image_ref)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        # Verify the properties in the initial response are correct"},{"line_number":926,"context_line":"        self.assertEqual(server[\u0027id\u0027], rebuilt_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"e7711fb5_621762bf","line":923,"range":{"start_line":916,"start_character":0,"end_line":923,"end_character":57},"updated":"2022-05-24 17:43:01.000000000","message":"i disaggre that this is a good validation this is making the test test multipl thing and add a new failure mode.\nyou should not do this","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ff89db07c3cfc480428c9efd8fb5274c4fb7721","unresolved":false,"context_lines":[{"line_number":913,"context_line":"            adminPass\u003dpassword,"},{"line_number":914,"context_line":"            reimage_boot_volume\u003dTrue)[\u0027server\u0027]"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":917,"context_line":"        # original image once the test ends"},{"line_number":918,"context_line":"        # This is not needed since we are creating a temporary server which"},{"line_number":919,"context_line":"        # won\u0027t affect other tests but is a good validation of vice-versa"},{"line_number":920,"context_line":"        # volume backed rebuild"},{"line_number":921,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":922,"context_line":"            self.addCleanup(self._rebuild_server_vol_backed_check,"},{"line_number":923,"context_line":"                            server[\u0027id\u0027], self.image_ref)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        # Verify the properties in the initial response are correct"},{"line_number":926,"context_line":"        self.assertEqual(server[\u0027id\u0027], rebuilt_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"695d0e14_0b548448","line":923,"range":{"start_line":916,"start_character":0,"end_line":923,"end_character":57},"in_reply_to":"e7711fb5_621762bf","updated":"2022-06-10 09:06:11.000000000","message":"Done","commit_id":"0c2045aeef5fcf050f0e8425e65758229540141f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":true,"context_lines":[{"line_number":846,"context_line":"    @classmethod"},{"line_number":847,"context_line":"    def resource_setup(cls):"},{"line_number":848,"context_line":"        super(ServerActionsV291TestJSON, cls).resource_setup()"},{"line_number":849,"context_line":"        cls.server_id \u003d cls.recreate_server(None, validatable\u003dTrue)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _rebuild_server_vol_backed_check(self, server_id, image_ref):"},{"line_number":852,"context_line":"        rebuilt_server \u003d (self.client.rebuild_server("}],"source_content_type":"text/x-python","patch_set":15,"id":"a43d5632_906a3ca1","line":849,"updated":"2022-06-10 15:43:13.000000000","message":"I think you should patch this back in. It shouldn\u0027t matter, but since there was some confusion about maybe us rebuilding the wrong server (and initially making us think the test worked), we might as well leave it in. Doesn\u0027t hurt anything and keeps us similar to other tests here.","commit_id":"c84ef2ccc1a908fbbf985d47b2cbe2c2350c5853"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa4914bf09fcf2a343409d7956a3b370f63d9f78","unresolved":false,"context_lines":[{"line_number":846,"context_line":"    @classmethod"},{"line_number":847,"context_line":"    def resource_setup(cls):"},{"line_number":848,"context_line":"        super(ServerActionsV291TestJSON, cls).resource_setup()"},{"line_number":849,"context_line":"        cls.server_id \u003d cls.recreate_server(None, validatable\u003dTrue)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _rebuild_server_vol_backed_check(self, server_id, image_ref):"},{"line_number":852,"context_line":"        rebuilt_server \u003d (self.client.rebuild_server("}],"source_content_type":"text/x-python","patch_set":15,"id":"1bcc913c_5e84ba11","line":849,"in_reply_to":"a43d5632_906a3ca1","updated":"2022-08-24 06:24:56.000000000","message":"Done","commit_id":"c84ef2ccc1a908fbbf985d47b2cbe2c2350c5853"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":true,"context_lines":[{"line_number":858,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":859,"context_line":"        server \u003d self.create_test_server(**kwargs)"},{"line_number":860,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":861,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"},{"line_number":862,"context_line":"        volume_before_rebuild \u003d self.volumes_client.show_volume(volume_id)"},{"line_number":863,"context_line":"        image_before_rebuild \u003d ("},{"line_number":864,"context_line":"            volume_before_rebuild[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"2ff2b3a5_9b0dc165","line":861,"updated":"2022-06-10 15:43:13.000000000","message":"Above this, add this to avoid the Secgroup complaint when trying to clean up the test resources:\n\n self.addCleanup(self.delete_server, server[\u0027id\u0027])","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa4914bf09fcf2a343409d7956a3b370f63d9f78","unresolved":false,"context_lines":[{"line_number":858,"context_line":"                           \u0027validation_resources\u0027: validation_resources})"},{"line_number":859,"context_line":"        server \u003d self.create_test_server(**kwargs)"},{"line_number":860,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":861,"context_line":"        volume_id \u003d server[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027]"},{"line_number":862,"context_line":"        volume_before_rebuild \u003d self.volumes_client.show_volume(volume_id)"},{"line_number":863,"context_line":"        image_before_rebuild \u003d ("},{"line_number":864,"context_line":"            volume_before_rebuild[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"fe4e148c_93575f39","line":861,"in_reply_to":"2ff2b3a5_9b0dc165","updated":"2022-08-24 06:24:56.000000000","message":"Done","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":true,"context_lines":[{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        if CONF.validation.run_validation:"},{"line_number":868,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":869,"context_line":"                self.os_primary)"},{"line_number":870,"context_line":"            # Authentication is attempted in the following order of priority:"},{"line_number":871,"context_line":"            # 1.The key passed in, if one was passed in."},{"line_number":872,"context_line":"            # 2.Any key we can find through an SSH agent (if allowed)."}],"source_content_type":"text/x-python","patch_set":16,"id":"6320475a_0932ac78","line":869,"updated":"2022-06-10 15:43:13.000000000","message":"I think this is the reason the ssh stuff below doesn\u0027t work. You\u0027re creating the server with get_test_validation_resources() but you try to ssh with get_class_validation_resources(). I\u0027m not sure what the difference between those two is, but it seems to matter.\n\nIf I remove this line and thus remove the eclipsing of validation_resources from L855, it works.","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa4914bf09fcf2a343409d7956a3b370f63d9f78","unresolved":false,"context_lines":[{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        if CONF.validation.run_validation:"},{"line_number":868,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":869,"context_line":"                self.os_primary)"},{"line_number":870,"context_line":"            # Authentication is attempted in the following order of priority:"},{"line_number":871,"context_line":"            # 1.The key passed in, if one was passed in."},{"line_number":872,"context_line":"            # 2.Any key we can find through an SSH agent (if allowed)."}],"source_content_type":"text/x-python","patch_set":16,"id":"53cc9de7_9c8d2fc0","line":869,"in_reply_to":"6320475a_0932ac78","updated":"2022-08-24 06:24:56.000000000","message":"Done","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ff89db07c3cfc480428c9efd8fb5274c4fb7721","unresolved":true,"context_lines":[{"line_number":873,"context_line":"            # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":874,"context_line":"            #   ~/.ssh/ (if allowed)."},{"line_number":875,"context_line":"            # 4.Plain username/password auth, if a password was given."},{"line_number":876,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":877,"context_line":"                self.get_server_ip(server, validation_resources),"},{"line_number":878,"context_line":"                self.ssh_user,"},{"line_number":879,"context_line":"                password\u003dNone,"},{"line_number":880,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":881,"context_line":"                server\u003dserver,"},{"line_number":882,"context_line":"                servers_client\u003dself.client)"},{"line_number":883,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":884,"context_line":"            # No output means success"},{"line_number":885,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5c94e7e7_c1ae57f1","line":883,"range":{"start_line":876,"start_character":0,"end_line":883,"end_character":65},"updated":"2022-06-10 09:06:11.000000000","message":"so i tested this locally and I\u0027m getting ssh time out here. can\u0027t figure out the issue ...","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":false,"context_lines":[{"line_number":873,"context_line":"            # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":874,"context_line":"            #   ~/.ssh/ (if allowed)."},{"line_number":875,"context_line":"            # 4.Plain username/password auth, if a password was given."},{"line_number":876,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":877,"context_line":"                self.get_server_ip(server, validation_resources),"},{"line_number":878,"context_line":"                self.ssh_user,"},{"line_number":879,"context_line":"                password\u003dNone,"},{"line_number":880,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":881,"context_line":"                server\u003dserver,"},{"line_number":882,"context_line":"                servers_client\u003dself.client)"},{"line_number":883,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":884,"context_line":"            # No output means success"},{"line_number":885,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"6d41b278_ee076d08","line":883,"range":{"start_line":876,"start_character":0,"end_line":883,"end_character":65},"in_reply_to":"5c94e7e7_c1ae57f1","updated":"2022-06-10 15:43:13.000000000","message":"Done","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":true,"context_lines":[{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        if CONF.validation.run_validation:"},{"line_number":926,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":927,"context_line":"                self.os_primary)"},{"line_number":928,"context_line":"            # Authentication is attempted in the following order of priority:"},{"line_number":929,"context_line":"            # 1.The key passed in, if one was passed in."},{"line_number":930,"context_line":"            # 2.Any key we can find through an SSH agent (if allowed)."}],"source_content_type":"text/x-python","patch_set":16,"id":"be480230_a2677f85","line":927,"updated":"2022-06-10 15:43:13.000000000","message":"Same deal here, just delete this.","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa4914bf09fcf2a343409d7956a3b370f63d9f78","unresolved":false,"context_lines":[{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        if CONF.validation.run_validation:"},{"line_number":926,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":927,"context_line":"                self.os_primary)"},{"line_number":928,"context_line":"            # Authentication is attempted in the following order of priority:"},{"line_number":929,"context_line":"            # 1.The key passed in, if one was passed in."},{"line_number":930,"context_line":"            # 2.Any key we can find through an SSH agent (if allowed)."}],"source_content_type":"text/x-python","patch_set":16,"id":"cd9d60d2_32738922","line":927,"in_reply_to":"be480230_a2677f85","updated":"2022-08-24 06:24:56.000000000","message":"Done","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"103dd7c940c275189e9b72107f61a4a5de7931ba","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":945,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":946,"context_line":"            # the file we touched."},{"line_number":947,"context_line":"            self.assertIn(\u0027not found\u0027, e.stderr)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4789519c_c14ef427","line":947,"range":{"start_line":947,"start_character":39,"end_line":947,"end_character":47},"updated":"2022-06-10 15:43:13.000000000","message":"Not sure where I got this, but e.stderr isn\u0027t a thing. Also the string isn\u0027t right. Replace with:\n\n self.assertIn(\u0027No such file or directory\u0027, str(e))","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa4914bf09fcf2a343409d7956a3b370f63d9f78","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":945,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":946,"context_line":"            # the file we touched."},{"line_number":947,"context_line":"            self.assertIn(\u0027not found\u0027, e.stderr)"}],"source_content_type":"text/x-python","patch_set":16,"id":"00ce28cd_94267538","line":947,"range":{"start_line":947,"start_character":39,"end_line":947,"end_character":47},"in_reply_to":"4789519c_c14ef427","updated":"2022-08-24 06:24:56.000000000","message":"Done","commit_id":"6bfde455ef1bcf0f96f22572d3fc48c212f6eb5b"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"85740b97a80823559c878e554d8cce278a41e81d","unresolved":true,"context_lines":[{"line_number":885,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":886,"context_line":"                server\u003dserver,"},{"line_number":887,"context_line":"                servers_client\u003dself.client)"},{"line_number":888,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":889,"context_line":"            # No output means success"},{"line_number":890,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"353d1e2b_e1fdbb17","line":888,"updated":"2022-07-19 09:39:42.000000000","message":"Not sure its a good idea to use name here test_file , maybe we can create a random name with random content and return the md5sum\n\nif you still want to count on the returned value maybe its better to count on\n echo $?  -\u003e 0 for success.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec8910d963b57c5152c2538da8d353675a7ceec5","unresolved":true,"context_lines":[{"line_number":885,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":886,"context_line":"                server\u003dserver,"},{"line_number":887,"context_line":"                servers_client\u003dself.client)"},{"line_number":888,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":889,"context_line":"            # No output means success"},{"line_number":890,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"f2ea63d7_832a35e3","line":888,"in_reply_to":"353d1e2b_e1fdbb17","updated":"2022-07-19 13:23:45.000000000","message":"\u003e Not sure its a good idea to use name here test_file , maybe we can create a random name with random content and return the md5sum\n\nThat\u0027s fair, although it should be a cleanly-booted instance, so not a whole lot of concern.\n\n\u003e if you still want to count on the returned value maybe its better to count on\n\u003e  echo $?  -\u003e 0 for success.\n\nThe \"no output\" assertion isn\u0027t critical, and maybe isn\u0027t even needed. We don\u0027t need to \"echo $?\" because if it\u0027s nonzero, this will raise.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"ec279c8b6db2577b70babf99c57fd316f2b5a96f","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":886,"context_line":"                server\u003dserver,"},{"line_number":887,"context_line":"                servers_client\u003dself.client)"},{"line_number":888,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":889,"context_line":"            # No output means success"},{"line_number":890,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"11c49f73_999e826a","line":888,"in_reply_to":"3929e096_4009ad43","updated":"2022-08-24 06:56:52.000000000","message":"Ack , its the right place to add wrapper for linux command and handled bubbled up exceptions ... just saying that using hardcoded names is something that risk in the future... and better to manage touch/ cat/ zzz commands in a single location if we want to extend capabilites","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"83104202149d31dec7a5edcec7704fc8ee5206ee","unresolved":true,"context_lines":[{"line_number":885,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":886,"context_line":"                server\u003dserver,"},{"line_number":887,"context_line":"                servers_client\u003dself.client)"},{"line_number":888,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":889,"context_line":"            # No output means success"},{"line_number":890,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3929e096_4009ad43","line":888,"in_reply_to":"54341c6e_ec5d8f0c","updated":"2022-08-24 06:39:45.000000000","message":"Currently there is no wrapper available as create_file in remote_client[1] and adding it seems to be not specific to the functionality of test here, would it be OK if i add it in a followup?\n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/common/utils/linux/remote_client.py","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9ef89c02234bfcc54537b269ff09e3cd034db284","unresolved":true,"context_lines":[{"line_number":885,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":886,"context_line":"                server\u003dserver,"},{"line_number":887,"context_line":"                servers_client\u003dself.client)"},{"line_number":888,"context_line":"            output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":889,"context_line":"            # No output means success"},{"line_number":890,"context_line":"            self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"54341c6e_ec5d8f0c","line":888,"in_reply_to":"f2ea63d7_832a35e3","updated":"2022-07-19 13:55:05.000000000","message":"ack , if the command will fail touch test_file , it will bubbule up exception .. \nI think that wrap the touch test_file with command like  linux_client.create_file(name, data, .. ) will be much cleaner.\nNot critical but if we use assert we should understand whats the meaning of \u0027\u0027 here..","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"efddf8217343b043ce3fb73093b7983e3aa89611","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":893,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":894,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"},{"line_number":895,"context_line":"        password \u003d \u0027rebuildPassw0rd\u0027"},{"line_number":896,"context_line":"        rebuilt_server \u003d self.client.rebuild_server("},{"line_number":897,"context_line":"            server[\u0027id\u0027],"},{"line_number":898,"context_line":"            self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":19,"id":"9b5216a3_eafb79da","line":895,"updated":"2022-07-19 10:17:24.000000000","message":"I would also use random password here","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"83104202149d31dec7a5edcec7704fc8ee5206ee","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":893,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":894,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"},{"line_number":895,"context_line":"        password \u003d \u0027rebuildPassw0rd\u0027"},{"line_number":896,"context_line":"        rebuilt_server \u003d self.client.rebuild_server("},{"line_number":897,"context_line":"            server[\u0027id\u0027],"},{"line_number":898,"context_line":"            self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":19,"id":"957e1e68_afc4b34b","line":895,"in_reply_to":"7af35411_86bd3237","updated":"2022-08-24 06:39:45.000000000","message":"I\u0027ve used the same format for rebuild as done in the original rebuild test and you can see the same password used in L#204.\n\nSince nova team don\u0027t have an issue with this, can you remove your vote Arx?","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec8910d963b57c5152c2538da8d353675a7ceec5","unresolved":true,"context_lines":[{"line_number":892,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":893,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":894,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"},{"line_number":895,"context_line":"        password \u003d \u0027rebuildPassw0rd\u0027"},{"line_number":896,"context_line":"        rebuilt_server \u003d self.client.rebuild_server("},{"line_number":897,"context_line":"            server[\u0027id\u0027],"},{"line_number":898,"context_line":"            self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ebfea685_a623a178","line":895,"in_reply_to":"9b5216a3_eafb79da","updated":"2022-07-19 13:23:45.000000000","message":"Why? We don\u0027t use it for anything or test this part of it, we just need to provide something to the rebuild call. In fact, I don\u0027t think we\u0027re even *actually* using it for the authentication after the rebuild before, even though we\u0027re passing it in. Nova requires it, IIRC, so passing whatever we gave here is consistent, but it\u0027s not what we\u0027re testing.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58d8f112b4732e4a7e50e7fe53589ec1ad15f130","unresolved":true,"context_lines":[{"line_number":892,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":893,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":894,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"},{"line_number":895,"context_line":"        password \u003d \u0027rebuildPassw0rd\u0027"},{"line_number":896,"context_line":"        rebuilt_server \u003d self.client.rebuild_server("},{"line_number":897,"context_line":"            server[\u0027id\u0027],"},{"line_number":898,"context_line":"            self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7af35411_86bd3237","line":895,"in_reply_to":"ebfea685_a623a178","updated":"2022-07-28 15:01:54.000000000","message":"i dont think nova requires a password for rebuild. i have never provided one\nso this proably coudl be droped entrily.\n\nbut i agree there isnt really any value in making this random\nit complicates teh test for somethign we are not testing and dont care about.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"85740b97a80823559c878e554d8cce278a41e81d","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"8f3dfeb5_592d14a4","line":947,"updated":"2022-07-19 09:39:42.000000000","message":"So here we expecting that the test_file will be missing , its a little bit confusing and maybe the run validation mandatory and without we need to skip the test .... because if it was disabled we proably passed the test and when it enabled it fails (according to the build run results)\n\nmaybe it will be much cleaner to use the linux_client method instead the cat .. \n\nsomething like:\nlinux_client.create_file(....)  -\u003e return md5\nlinux_client.read_file(...) --\u003e return md5 or bubble up assert.\nWe will be able to use it and define the random size inside , name as random and mode.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5200bd08fdaa56d68040da691588a492efd2fe56","unresolved":false,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"131891ba_fa7f9ff0","line":947,"in_reply_to":"56648abf_6258b293","updated":"2022-08-24 12:14:00.000000000","message":"Done","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec8910d963b57c5152c2538da8d353675a7ceec5","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"abc66875_1b42b1e6","line":947,"in_reply_to":"8f3dfeb5_592d14a4","updated":"2022-07-19 13:23:45.000000000","message":"I don\u0027t understand what you\u0027re saying. Are you saying we need a \"should this work and thus be tested\" flag to indicate whether we even run this test?\n\nAlso, I\u0027m not sure why the linux_client usage is any better than what we\u0027re doing here, but are you saying you think it will be clearer about us expecting the file to be missing? Seems like the comment on the lines below should make that explicit, but if you\u0027d prefer the other then that\u0027s fine.","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9ef89c02234bfcc54537b269ff09e3cd034db284","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"e8fefe23_5441746e","line":947,"in_reply_to":"abc66875_1b42b1e6","updated":"2022-07-19 13:55:05.000000000","message":"saying tthat validation should be in testcase level... because the assert in line #950 is important to the fail/success of the test case.\n\nThanks","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"ec279c8b6db2577b70babf99c57fd316f2b5a96f","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"56648abf_6258b293","line":947,"in_reply_to":"b131bdb6_d4d2010e","updated":"2022-08-24 06:56:52.000000000","message":"Yes , CONF.validation.run_validation should be mandatory for the testcase unless you think that without validation the test hass additional value ....","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"83104202149d31dec7a5edcec7704fc8ee5206ee","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            linux_client.validate_authentication()"},{"line_number":945,"context_line":"            e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":946,"context_line":"                                  linux_client.exec_command,"},{"line_number":947,"context_line":"                                  \u0027cat test_file\u0027)"},{"line_number":948,"context_line":"            # If we rebuilt the boot volume, then we should not find"},{"line_number":949,"context_line":"            # the file we touched."},{"line_number":950,"context_line":"            self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":19,"id":"b131bdb6_d4d2010e","line":947,"in_reply_to":"e8fefe23_5441746e","updated":"2022-08-24 06:39:45.000000000","message":"I\u0027m not sure what the ask is here. We only create the test_file and verify it exists after rebuild if CONF.validation.run_validation is True (see L#888).\nIf we don\u0027t set run_validation to True then we only assert the attributes of the instance which is also a valid test run in itself, this part adds an additional validation layer to the test.\nSo are you saying we should make the file validations as part of the test and remove the if block checking for CONF.validation.run_validation?","commit_id":"a29cd39c61a1bc088fd10636aed7a086f2187673"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"376d7097355ff5936acf2b5455d59ac0ed3960c2","unresolved":true,"context_lines":[{"line_number":877,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":878,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":879,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":880,"context_line":"            self.get_server_ip(server, validation_resources),"},{"line_number":881,"context_line":"            self.ssh_user,"},{"line_number":882,"context_line":"            password\u003dNone,"},{"line_number":883,"context_line":"            pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"f0dd03d4_41e17056","line":880,"range":{"start_line":880,"start_character":39,"end_line":880,"end_character":59},"updated":"2022-11-23 14:33:21.000000000","message":"this isn\u0027t defined if CONF.validation.run_validation is true, it needs a default value\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f97/831018/24/check/devstack-plugin-ceph-tempest-py3/f97e344/testr_results.html","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a5edd6c91d228667f5edbf03a2cb39cd641e49a0","unresolved":false,"context_lines":[{"line_number":877,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":878,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":879,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":880,"context_line":"            self.get_server_ip(server, validation_resources),"},{"line_number":881,"context_line":"            self.ssh_user,"},{"line_number":882,"context_line":"            password\u003dNone,"},{"line_number":883,"context_line":"            pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"344cedc3_d8d58aeb","line":880,"range":{"start_line":880,"start_character":39,"end_line":880,"end_character":59},"in_reply_to":"98a0b04f_9f9c9599","updated":"2023-05-23 11:30:39.000000000","message":"Done","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6406ada5b0e6b03883c4ecd5bd2a67c32afef036","unresolved":true,"context_lines":[{"line_number":877,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":878,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":879,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":880,"context_line":"            self.get_server_ip(server, validation_resources),"},{"line_number":881,"context_line":"            self.ssh_user,"},{"line_number":882,"context_line":"            password\u003dNone,"},{"line_number":883,"context_line":"            pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"98a0b04f_9f9c9599","line":880,"range":{"start_line":880,"start_character":39,"end_line":880,"end_character":59},"in_reply_to":"f0dd03d4_41e17056","updated":"2023-03-05 23:46:18.000000000","message":"https://1091c07913eb4632aa6d-ee11d96724f7ceb5cf79a550bea264c0.ssl.cf5.rackcdn.com/831018/25/check/devstack-plugin-ceph-tempest-py3/9c797f2/testr_results.html","commit_id":"166070f32fb6931a1b9690bff840acff93dd4349"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"class ServerActionsV293TestJSON(base.BaseV2ComputeTest):"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    min_microversion \u003d \u00272.93\u0027"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":27,"id":"170e947b_9d172e00","line":829,"range":{"start_line":829,"start_character":0,"end_line":829,"end_character":29},"updated":"2023-06-02 18:09:27.000000000","message":"you need to set volume_min_microversion also as 3.68","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"class ServerActionsV293TestJSON(base.BaseV2ComputeTest):"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    min_microversion \u003d \u00272.93\u0027"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":27,"id":"478e4eda_c697cf27","line":829,"range":{"start_line":829,"start_character":0,"end_line":829,"end_character":29},"in_reply_to":"170e947b_9d172e00","updated":"2023-06-06 10:34:22.000000000","message":"Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    min_microversion \u003d \u00272.93\u0027"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def tearDown(self):"},{"line_number":835,"context_line":"        super(ServerActionsV293TestJSON, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":27,"id":"21a4b15c_8e1522ae","line":832,"range":{"start_line":831,"start_character":0,"end_line":832,"end_character":54},"updated":"2023-06-02 18:09:27.000000000","message":"nit: you do not need this if calling only base class setup","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    min_microversion \u003d \u00272.93\u0027"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def tearDown(self):"},{"line_number":835,"context_line":"        super(ServerActionsV293TestJSON, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":27,"id":"60988a66_e0e80219","line":832,"range":{"start_line":831,"start_character":0,"end_line":832,"end_character":54},"in_reply_to":"21a4b15c_8e1522ae","updated":"2023-06-06 10:34:22.000000000","message":"Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def tearDown(self):"},{"line_number":835,"context_line":"        super(ServerActionsV293TestJSON, self).tearDown()"},{"line_number":836,"context_line":"        # NOTE(zhufl): Because server_check_teardown will raise Exception"},{"line_number":837,"context_line":"        # which will prevent other cleanup steps from being executed, so"},{"line_number":838,"context_line":"        # server_check_teardown should be called after super\u0027s tearDown."},{"line_number":839,"context_line":"        self.server_check_teardown()"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    @classmethod"},{"line_number":842,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"34869a00_6f83e1c4","line":839,"range":{"start_line":834,"start_character":0,"end_line":839,"end_character":36},"updated":"2023-06-02 18:09:27.000000000","message":"we do not need this until we add more tests in this class and they share the same server.","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    def setUp(self):"},{"line_number":832,"context_line":"        super(ServerActionsV293TestJSON, self).setUp()"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def tearDown(self):"},{"line_number":835,"context_line":"        super(ServerActionsV293TestJSON, self).tearDown()"},{"line_number":836,"context_line":"        # NOTE(zhufl): Because server_check_teardown will raise Exception"},{"line_number":837,"context_line":"        # which will prevent other cleanup steps from being executed, so"},{"line_number":838,"context_line":"        # server_check_teardown should be called after super\u0027s tearDown."},{"line_number":839,"context_line":"        self.server_check_teardown()"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    @classmethod"},{"line_number":842,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"f238d1fc_cd5eb401","line":839,"range":{"start_line":834,"start_character":0,"end_line":839,"end_character":36},"in_reply_to":"34869a00_6f83e1c4","updated":"2023-06-06 10:34:22.000000000","message":"Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":843,"context_line":"        cls.prepare_instance_network()"},{"line_number":844,"context_line":"        super(ServerActionsV293TestJSON, cls).setup_credentials()"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    @classmethod"},{"line_number":847,"context_line":"    def setup_clients(cls):"},{"line_number":848,"context_line":"        super(ServerActionsV293TestJSON, cls).setup_clients()"},{"line_number":849,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    @classmethod"},{"line_number":852,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"6f45c7ff_fc2893c9","line":849,"range":{"start_line":846,"start_character":0,"end_line":849,"end_character":39},"updated":"2023-06-02 18:09:27.000000000","message":"ditto, we can directly use self.servers_client in tests","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        cls.prepare_instance_network()"},{"line_number":844,"context_line":"        super(ServerActionsV293TestJSON, cls).setup_credentials()"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    @classmethod"},{"line_number":847,"context_line":"    def setup_clients(cls):"},{"line_number":848,"context_line":"        super(ServerActionsV293TestJSON, cls).setup_clients()"},{"line_number":849,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    @classmethod"},{"line_number":852,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"186c76b9_2c3cc90c","line":849,"range":{"start_line":846,"start_character":0,"end_line":849,"end_character":39},"in_reply_to":"6f45c7ff_fc2893c9","updated":"2023-06-06 10:34:22.000000000","message":"Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d02a1e58e55049703229ff5ef38d9866781fdea","unresolved":true,"context_lines":[{"line_number":896,"context_line":"        # Since it is a volume backed server, image id will remain empty"},{"line_number":897,"context_line":"        self.assertEqual(\u0027\u0027, rebuilt_image_id)"},{"line_number":898,"context_line":"        self.assert_flavor_equal(self.flavor_ref, rebuilt_server[\u0027flavor\u0027])"},{"line_number":899,"context_line":"        # Verify that image inside volume is our initial image before rebuild"},{"line_number":900,"context_line":"        self.assertEqual(self.image_ref, image_before_rebuild)"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        # Verify the server properties after the rebuild completes"},{"line_number":903,"context_line":"        waiters.wait_for_server_status(self.servers_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"66094d0a_6b2b5df1","line":900,"range":{"start_line":899,"start_character":0,"end_line":900,"end_character":62},"updated":"2023-06-07 19:43:16.000000000","message":"this is little difficult to read as you are comparing the image before rebuild only but as you are doing it after rebuild operation it seems like after rebuild also image stay same which is not the case. can you move this assert at L864 so that it will be clear to read that image in volume backed in self.image_ref and after rebuild it is changed to self.image_ref_alt","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c043caa1d108e8af9ecdfcfa0674bfd302129e6","unresolved":false,"context_lines":[{"line_number":896,"context_line":"        # Since it is a volume backed server, image id will remain empty"},{"line_number":897,"context_line":"        self.assertEqual(\u0027\u0027, rebuilt_image_id)"},{"line_number":898,"context_line":"        self.assert_flavor_equal(self.flavor_ref, rebuilt_server[\u0027flavor\u0027])"},{"line_number":899,"context_line":"        # Verify that image inside volume is our initial image before rebuild"},{"line_number":900,"context_line":"        self.assertEqual(self.image_ref, image_before_rebuild)"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        # Verify the server properties after the rebuild completes"},{"line_number":903,"context_line":"        waiters.wait_for_server_status(self.servers_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"e2ef8c84_c325c5fe","line":900,"range":{"start_line":899,"start_character":0,"end_line":900,"end_character":62},"in_reply_to":"66094d0a_6b2b5df1","updated":"2023-06-08 09:58:01.000000000","message":"Done","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"}],"zuul.d/base.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5f13e08d8d520d54fd99c87f73115814a830e331","unresolved":true,"context_lines":[{"line_number":16,"context_line":"      devstack_localrc:"},{"line_number":17,"context_line":"        IMAGE_URLS: http://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img, http://download.cirros-cloud.net/0.6.1/cirros-0.6.1-x86_64-disk.img"},{"line_number":18,"context_line":"        # When DEFAULT_IMAGE_NAME is set and the image exists in glance,"},{"line_number":19,"context_line":"        # devstack sets both image_ref and image_ref_alt with same image"},{"line_number":20,"context_line":"        # which we don\u0027t want here."},{"line_number":21,"context_line":"        DEFAULT_IMAGE_NAME: \u0027non-existent-image\u0027"},{"line_number":22,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"77943073_d7a2f8c6","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":28},"updated":"2023-06-14 17:50:25.000000000","message":"right\n\nhttps://opendev.org/openstack/devstack/src/commit/c152a409dd72f742c5a52949282207bedf880565/lib/tempest#L162","commit_id":"768d253670941ed5c88d923452192b385224622f"}],"zuul.d/integrated-gate.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        s-proxy: false"},{"line_number":166,"context_line":"        c-bak: false"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: tempest-rebuild-volume-backed"},{"line_number":170,"context_line":"    parent: devstack-tempest"},{"line_number":171,"context_line":"    branches: ^(?!stable/ocata).*$"},{"line_number":172,"context_line":"    description: |"},{"line_number":173,"context_line":"      This job runs volume backed rebuild instance test."},{"line_number":174,"context_line":"    vars:"},{"line_number":175,"context_line":"      tox_envlist: rebuild-volume-backed"},{"line_number":176,"context_line":"      tempest_exclude_regex: \"\""},{"line_number":177,"context_line":"      devstack_localrc:"},{"line_number":178,"context_line":"        USE_PYTHON3: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"c3917f52_a3f83bda","line":175,"range":{"start_line":168,"start_character":0,"end_line":175,"end_character":40},"updated":"2023-06-02 18:09:27.000000000","message":"why we need a separate job to test this? if any different config like image version (commented below) then we can see some existing job to run against it which can run this test too.","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d02a1e58e55049703229ff5ef38d9866781fdea","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        s-proxy: false"},{"line_number":166,"context_line":"        c-bak: false"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: tempest-rebuild-volume-backed"},{"line_number":170,"context_line":"    parent: devstack-tempest"},{"line_number":171,"context_line":"    branches: ^(?!stable/ocata).*$"},{"line_number":172,"context_line":"    description: |"},{"line_number":173,"context_line":"      This job runs volume backed rebuild instance test."},{"line_number":174,"context_line":"    vars:"},{"line_number":175,"context_line":"      tox_envlist: rebuild-volume-backed"},{"line_number":176,"context_line":"      tempest_exclude_regex: \"\""},{"line_number":177,"context_line":"      devstack_localrc:"},{"line_number":178,"context_line":"        USE_PYTHON3: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"d3b44800_96e49c6e","line":175,"range":{"start_line":168,"start_character":0,"end_line":175,"end_character":40},"in_reply_to":"89b4bf8a_96b940d2","updated":"2023-06-07 19:43:16.000000000","message":"You are right. and we test all the rebuild tests with same image. I think we should enable two (different) images in devstack-tempest itself so that we run all those rebuild tests with actual two different images. I think that should be right way and less costly than having another new image. If we see a huge impact of our jobs then we can think of a new job for rebuild tests with two different images.\n\n- https://github.com/openstack/tempest/blob/a1c2fc6aecaf14193b06a8ba953faa2ba23afc2e/zuul.d/base.yaml#LL2C11-L2C27","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        s-proxy: false"},{"line_number":166,"context_line":"        c-bak: false"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: tempest-rebuild-volume-backed"},{"line_number":170,"context_line":"    parent: devstack-tempest"},{"line_number":171,"context_line":"    branches: ^(?!stable/ocata).*$"},{"line_number":172,"context_line":"    description: |"},{"line_number":173,"context_line":"      This job runs volume backed rebuild instance test."},{"line_number":174,"context_line":"    vars:"},{"line_number":175,"context_line":"      tox_envlist: rebuild-volume-backed"},{"line_number":176,"context_line":"      tempest_exclude_regex: \"\""},{"line_number":177,"context_line":"      devstack_localrc:"},{"line_number":178,"context_line":"        USE_PYTHON3: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"89b4bf8a_96b940d2","line":175,"range":{"start_line":168,"start_character":0,"end_line":175,"end_character":40},"in_reply_to":"c3917f52_a3f83bda","updated":"2023-06-06 10:34:22.000000000","message":"We require 2 different images to test the complete code path rebuild of volume backed instances. I haven\u0027t had luck to find any job that uses 2 different images for testing but would be happy to include this in any job if we can\n1) modify existing job to use 2 different images\n2) find a job that is already using 2 different images","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c043caa1d108e8af9ecdfcfa0674bfd302129e6","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        s-proxy: false"},{"line_number":166,"context_line":"        c-bak: false"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: tempest-rebuild-volume-backed"},{"line_number":170,"context_line":"    parent: devstack-tempest"},{"line_number":171,"context_line":"    branches: ^(?!stable/ocata).*$"},{"line_number":172,"context_line":"    description: |"},{"line_number":173,"context_line":"      This job runs volume backed rebuild instance test."},{"line_number":174,"context_line":"    vars:"},{"line_number":175,"context_line":"      tox_envlist: rebuild-volume-backed"},{"line_number":176,"context_line":"      tempest_exclude_regex: \"\""},{"line_number":177,"context_line":"      devstack_localrc:"},{"line_number":178,"context_line":"        USE_PYTHON3: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7c801957_6cd08842","line":175,"range":{"start_line":168,"start_character":0,"end_line":175,"end_character":40},"in_reply_to":"d3b44800_96e49c6e","updated":"2023-06-08 09:58:01.000000000","message":"Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d8f3a6cd462d6293fa190add31605bf82ec03c","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        USE_PYTHON3: true"},{"line_number":179,"context_line":"        FORCE_CONFIG_DRIVE: true"},{"line_number":180,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":181,"context_line":"        IMAGE_URLS: http://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img, http://download.cirros-cloud.net/0.5.0/cirros-0.5.0-x86_64-disk.img"},{"line_number":182,"context_line":"        DEFAULT_IMAGE_NAME: \u0027non-existent-image\u0027"},{"line_number":183,"context_line":"      devstack_services:"},{"line_number":184,"context_line":"        s-account: false"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7da3e352_16bd481f","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":156},"updated":"2023-06-02 18:09:27.000000000","message":"any specific reason to test it against cirros 0.5.1 ? or can we use default version of cirros which is now 0.6.1 in devstack.","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44ef92e066fb67e002974a0d9d3e85c441d18444","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        USE_PYTHON3: true"},{"line_number":179,"context_line":"        FORCE_CONFIG_DRIVE: true"},{"line_number":180,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":181,"context_line":"        IMAGE_URLS: http://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img, http://download.cirros-cloud.net/0.5.0/cirros-0.5.0-x86_64-disk.img"},{"line_number":182,"context_line":"        DEFAULT_IMAGE_NAME: \u0027non-existent-image\u0027"},{"line_number":183,"context_line":"      devstack_services:"},{"line_number":184,"context_line":"        s-account: false"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3a9e94bd_cace6341","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":156},"in_reply_to":"7da3e352_16bd481f","updated":"2023-06-06 10:34:22.000000000","message":"0.5.1 was latest when i wrote this test. I can modify it but the main part here is we need to use 2 different images.\nUpdate: Done","commit_id":"931925e16af3ce8f85fa5b29a0c0495e1a0749e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d02a1e58e55049703229ff5ef38d9866781fdea","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        FORCE_CONFIG_DRIVE: true"},{"line_number":180,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":181,"context_line":"        IMAGE_URLS: http://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img, http://download.cirros-cloud.net/0.6.1/cirros-0.6.1-x86_64-disk.img"},{"line_number":182,"context_line":"        DEFAULT_IMAGE_NAME: \u0027non-existent-image\u0027"},{"line_number":183,"context_line":"      devstack_services:"},{"line_number":184,"context_line":"        s-account: false"},{"line_number":185,"context_line":"        s-container: false"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"f6ca09cd_0faf8da2","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":48},"updated":"2023-06-07 19:43:16.000000000","message":"Due to the devstack logic to set the two image, this is also confusing. please add a note that if DEFAULT_IMAGE_NAME exist in glance then devstack set both image_ref and image_ref_alt with same image, to have two different image we need to set DEFAULT_IMAGE_NAME to some non existing image name","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c043caa1d108e8af9ecdfcfa0674bfd302129e6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        FORCE_CONFIG_DRIVE: true"},{"line_number":180,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":181,"context_line":"        IMAGE_URLS: http://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img, http://download.cirros-cloud.net/0.6.1/cirros-0.6.1-x86_64-disk.img"},{"line_number":182,"context_line":"        DEFAULT_IMAGE_NAME: \u0027non-existent-image\u0027"},{"line_number":183,"context_line":"      devstack_services:"},{"line_number":184,"context_line":"        s-account: false"},{"line_number":185,"context_line":"        s-container: false"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"fa3a87e5_f44710a8","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":48},"in_reply_to":"f6ca09cd_0faf8da2","updated":"2023-06-08 09:58:01.000000000","message":"Done","commit_id":"4c5f9b1d55991d891bf804bba8631dcf86deffc5"}],"zuul.d/project.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0c6e6ef4710c7e9ca0953f581cb947674fcbad49","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            irrelevant-files: *tempest-irrelevant-files-2"},{"line_number":120,"context_line":"        - tempest-full-centos-9-stream:"},{"line_number":121,"context_line":"            # TODO(gmann): make it voting once below fix is merged"},{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9759022d_927de86c","line":122,"range":{"start_line":122,"start_character":14,"end_line":122,"end_character":69},"updated":"2023-05-24 13:45:33.000000000","message":"this is merged already and the tempest-full-centos-9-stream is part of experimental and periodic pipeline, any particular reason why having it also in the check pipeline?","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8276c366645cf7f665a52ec001acf9174c3447ec","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            irrelevant-files: *tempest-irrelevant-files-2"},{"line_number":120,"context_line":"        - tempest-full-centos-9-stream:"},{"line_number":121,"context_line":"            # TODO(gmann): make it voting once below fix is merged"},{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"45cf7ac4_af2c1a00","line":122,"range":{"start_line":122,"start_character":14,"end_line":122,"end_character":69},"in_reply_to":"87b605df_817fe7bd","updated":"2023-06-01 09:56:49.000000000","message":"Done","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5089def4a9c27dd51a71629d70172c1d6d5fb98b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            irrelevant-files: *tempest-irrelevant-files-2"},{"line_number":120,"context_line":"        - tempest-full-centos-9-stream:"},{"line_number":121,"context_line":"            # TODO(gmann): make it voting once below fix is merged"},{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"87b605df_817fe7bd","line":122,"range":{"start_line":122,"start_character":14,"end_line":122,"end_character":69},"in_reply_to":"9759022d_927de86c","updated":"2023-06-01 09:54:16.000000000","message":"I didn\u0027t add it so no reason for me to keep it\nremoving it in next PS","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0c6e6ef4710c7e9ca0953f581cb947674fcbad49","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"},{"line_number":126,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":127,"context_line":"    gate:"},{"line_number":128,"context_line":"      jobs:"},{"line_number":129,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"a039755c_7ec5edf7","line":126,"range":{"start_line":125,"start_character":10,"end_line":126,"end_character":45},"updated":"2023-05-24 13:45:33.000000000","message":"i wonder if there is already existing job we could include the test in, i don\u0027t like the fact that we deploy the whole environment to run only single test, for sure not in both check and gate queue","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8276c366645cf7f665a52ec001acf9174c3447ec","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"},{"line_number":126,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":127,"context_line":"    gate:"},{"line_number":128,"context_line":"      jobs:"},{"line_number":129,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c2e293f1_d47a40ec","line":126,"range":{"start_line":125,"start_character":10,"end_line":126,"end_character":45},"in_reply_to":"03946779_978fe69b","updated":"2023-06-01 09:56:49.000000000","message":"Done","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5089def4a9c27dd51a71629d70172c1d6d5fb98b","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            # https://review.opendev.org/c/openstack/tempest/+/842140"},{"line_number":123,"context_line":"            voting: false"},{"line_number":124,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":125,"context_line":"        - tempest-rebuild-volume-backed:"},{"line_number":126,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":127,"context_line":"    gate:"},{"line_number":128,"context_line":"      jobs:"},{"line_number":129,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"03946779_978fe69b","line":126,"range":{"start_line":125,"start_character":10,"end_line":126,"end_character":45},"in_reply_to":"a039755c_7ec5edf7","updated":"2023-06-01 09:54:16.000000000","message":"I\u0027ve discussed this in the past and had no good results. Initially I tested this in existing tempest-full-py3 runs but that job configures same cirros image as the main image and alternative image.\nThe rebuild feature code path needs to be tested when the initial and final images before/after the rebuild are different hence the new job defining different images for main and alt image.\nI\u0027m happy to make this test part of any existing job if we have the suitable environment configured.\nFor the meantime, I will remove it from the gate job.","commit_id":"de9aaee672ae0df8130c344f412b800f9c4a3209"}]}