)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"9701d9284dfdb18e80dd24647aead3127911eef5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     mitya-eremeev-2 \u003cmitossvyaz@mail.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-03 17:27:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tempest tests are aware of networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some tests are against preprovisioned networks"},{"line_number":10,"context_line":"if static accounts are used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"152832aa_f24a3f41","line":7,"updated":"2022-03-14 15:35:30.000000000","message":"I am unable to understand the issue itself here. What issue are you trying to address here? Commit message should in detail describe the solution/fix. for e.g it should be like:\n\nAdd/Remove/Update the tests","commit_id":"14b58c6fdae30471be986a953d28f6e30fc052c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"2d74eb7b2885e425c526382ba902dba482d9b82d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     mitya-eremeev-2 \u003cmitossvyaz@mail.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-03 17:27:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tempest tests are aware of networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some tests are against preprovisioned networks"},{"line_number":10,"context_line":"if static accounts are used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9b074966_517b9865","line":7,"in_reply_to":"152832aa_f24a3f41","updated":"2022-03-15 09:42:36.000000000","message":"I added link to code where tests explicitly against pre-provisioned networks.\nThe rest of commit message is correct.\nWhat exact details do you expect in commit message?\nThe patch is pretty plain and obvious.","commit_id":"14b58c6fdae30471be986a953d28f6e30fc052c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"cbc7102e87c479e9692c90be495b0ccb101651a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mitya-eremeev-2 \u003cmitossvyaz@mail.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-03 17:27:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tempest tests are aware of networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some tests are against preprovisioned networks"},{"line_number":10,"context_line":"if static accounts are used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bb0ea9ba_d95f4940","line":7,"in_reply_to":"9b074966_517b9865","updated":"2022-05-13 19:14:32.000000000","message":"Done","commit_id":"14b58c6fdae30471be986a953d28f6e30fc052c1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"9701d9284dfdb18e80dd24647aead3127911eef5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e679df24_d50e0b1c","updated":"2022-03-14 15:35:30.000000000","message":"I have dropped comments over the bug also. Can you have a look over the bug please?","commit_id":"14b58c6fdae30471be986a953d28f6e30fc052c1"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"2d74eb7b2885e425c526382ba902dba482d9b82d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc7d836f_a25f69d4","in_reply_to":"e679df24_d50e0b1c","updated":"2022-03-15 09:42:36.000000000","message":"Replied in bug","commit_id":"14b58c6fdae30471be986a953d28f6e30fc052c1"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"dc02016273f649c1f244d5432f22aa92bd542a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a3e1267f_ce3db6b6","updated":"2022-04-28 15:20:00.000000000","message":"Please see the bug report in launchpad. I have dropped a comment there. \n\nI also do not believe this is an entirely correct solution.\nI am thinking about what would happen if we have pre-provisioned credentials and all credentials\ncontain a network? When there is a test that does not require a network but it would be ok to \nuse a project with network the test would be unnecessarily skipped because it would not be able to access any credentials. I am not sure about this. This just occurred to me right now. Am I wrong?","commit_id":"502cf1d22eec17732741c88c704b49000f3d2210"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"cbfc25a74f8f96d671d4fcf0c3dced61d6a98369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"07c5602a_6bea46ce","in_reply_to":"a3e1267f_ce3db6b6","updated":"2022-04-28 15:57:45.000000000","message":"I answered in the bug report.\nIf we use dynamic accounts network resources are created if they are explicitly required.\nI suppose we should be consistent and use the same logic for static accounts.","commit_id":"502cf1d22eec17732741c88c704b49000f3d2210"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"bdb448ac68a9f826171620d58060002039e7940a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"194edd8f_d45cd4c5","updated":"2022-05-19 07:28:12.000000000","message":"recheck","commit_id":"cad57c1cc3190bb2e3360b138da60ecc11d8be85"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"c40670a0612d4c7adf93c1cce9409e53005a2040","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0ec0fd34_66151f4b","updated":"2022-05-27 06:12:18.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"ba139b81d47b38c3c22aec09abad3057565b9d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"170c0d0f_a7c44cf2","updated":"2022-05-23 07:17:16.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"f6ea9a827f1c5e7e6e9c41aed9e3a2f974786b26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1e55fa73_11ee6ee9","updated":"2022-05-25 08:10:42.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"cabe87264d5f9bb4e5404577572360c803d98cfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"26af4977_377e06eb","updated":"2022-05-24 06:25:47.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"9f6ef02a3c0e1c06ebd20e255ae3440f81da25d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"36d023c6_eee60e1f","updated":"2022-05-26 06:44:45.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"031ebfc42809233efd22dd8bb2322c3bbaae96a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4e171df5_beb55e46","updated":"2022-05-22 15:54:47.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"979d66a52c18e401dba72a4ebcb2a8de4d51d70e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7af429d0_9473e28b","updated":"2022-05-20 07:16:01.000000000","message":"recheck","commit_id":"ff4d1ba53de1d2da8d06bc193c5c7460b2693f8d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29f33d248e2edcf70df23b8e387fcc2caf460837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d33233c3_e1202288","updated":"2023-07-20 22:29:29.000000000","message":"sorry for late review. a few comments inline","commit_id":"2b37170343cab050de8b4d2ad4f01d7386f9aa85"}],"tempest/api/compute/admin/test_auto_allocate_network.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29f33d248e2edcf70df23b8e387fcc2caf460837","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            raise cls.skipException("},{"line_number":53,"context_line":"                \u0027auto-allocated-topology extension is not available\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def setup_credentials(cls):"},{"line_number":57,"context_line":"        # Do not create network resources for these tests."},{"line_number":58,"context_line":"        cls.set_network_resources()"},{"line_number":59,"context_line":"        super(AutoAllocateNetworkTest, cls).setup_credentials()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"},{"line_number":62,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":16,"id":"633d4b71_e9257ebb","side":"PARENT","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":63},"updated":"2023-07-20 22:29:29.000000000","message":"we need this so that dynamic cred provider does not create any network in the test tenant.","commit_id":"fc560b3a938c32bc92f577882dfa2be8e15f1719"}],"tempest/common/credentials_factory.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"dc02016273f649c1f244d5432f22aa92bd542a6d","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    :param name: When provided, it makes it possible to associate credential"},{"line_number":123,"context_line":"                 artifacts back to the owner (test class)."},{"line_number":124,"context_line":"    :param network_resources: Dictionary of network resources to be allocated"},{"line_number":125,"context_line":"                              for each test account. Only valid for the dynamic"},{"line_number":126,"context_line":"                              credentials provider."},{"line_number":127,"context_line":"    :param force_tenant_isolation: Always return a `DynamicCredentialProvider`,"},{"line_number":128,"context_line":"                                   regardless of the configuration."},{"line_number":129,"context_line":"    :param identity_version: Use the specified identity API version, regardless"}],"source_content_type":"text/x-python","patch_set":7,"id":"2cd3307d_4fe2e8d8","line":126,"range":{"start_line":124,"start_character":4,"end_line":126,"end_character":51},"updated":"2022-04-28 15:20:00.000000000","message":"We need to update this if we want to push this forward.","commit_id":"502cf1d22eec17732741c88c704b49000f3d2210"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"cbc7102e87c479e9692c90be495b0ccb101651a7","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    :param name: When provided, it makes it possible to associate credential"},{"line_number":123,"context_line":"                 artifacts back to the owner (test class)."},{"line_number":124,"context_line":"    :param network_resources: Dictionary of network resources to be allocated"},{"line_number":125,"context_line":"                              for each test account. Only valid for the dynamic"},{"line_number":126,"context_line":"                              credentials provider."},{"line_number":127,"context_line":"    :param force_tenant_isolation: Always return a `DynamicCredentialProvider`,"},{"line_number":128,"context_line":"                                   regardless of the configuration."},{"line_number":129,"context_line":"    :param identity_version: Use the specified identity API version, regardless"}],"source_content_type":"text/x-python","patch_set":7,"id":"34000855_69d76491","line":126,"range":{"start_line":124,"start_character":4,"end_line":126,"end_character":51},"in_reply_to":"2cd3307d_4fe2e8d8","updated":"2022-05-13 19:14:32.000000000","message":"Done","commit_id":"502cf1d22eec17732741c88c704b49000f3d2210"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29f33d248e2edcf70df23b8e387fcc2caf460837","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                    \"This must be set to \u0027all\u0027 if using the \""},{"line_number":111,"context_line":"                    \"[oslo_policy]/enforce_scope\u003dtrue option for the \""},{"line_number":112,"context_line":"                    \"identity service.\"),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027separate_projects_by_network_existence\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\"If use_dynamic_credentials is set to False and True \""},{"line_number":116,"context_line":"                     \"Tempest divides projects with networks and without \""},{"line_number":117,"context_line":"                     \"networks. To be compatible with old behavior the config \""},{"line_number":118,"context_line":"                     \"option is set to False and project are treated the same \""},{"line_number":119,"context_line":"                     \"regardless their network resources.\")"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"identity_group \u003d cfg.OptGroup(name\u003d\u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"8f9d45c9_31e3c2bb","line":119,"range":{"start_line":113,"start_character":0,"end_line":119,"end_character":59},"updated":"2023-07-20 22:29:29.000000000","message":"I did not get the need of this config option. we can make pre-provisioned account to give creds without network and that test to use that creds only.","commit_id":"2b37170343cab050de8b4d2ad4f01d7386f9aa85"}],"tempest/lib/common/preprov_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29f33d248e2edcf70df23b8e387fcc2caf460837","unresolved":true,"context_lines":[{"line_number":545,"context_line":"                return True"},{"line_number":546,"context_line":"        return False"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @staticmethod"},{"line_number":549,"context_line":"    def is_account_needed(tests_require_projects_with_networks, account,"},{"line_number":550,"context_line":"                          separate_projects_by_network_existence\u003dFalse):"},{"line_number":551,"context_line":"        \"\"\"decides whether we need account for test class"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        :param tests_require_projects_with_networks: need projects with or"},{"line_number":554,"context_line":"            without network"},{"line_number":555,"context_line":"        :param account: dictionary which contains username, password, resources"},{"line_number":556,"context_line":"        :param separate_projects_by_network_existence: should we separate"},{"line_number":557,"context_line":"            accounts with and without networks"},{"line_number":558,"context_line":"        :return: boolean value"},{"line_number":559,"context_line":"        \"\"\""},{"line_number":560,"context_line":"        if separate_projects_by_network_existence:"},{"line_number":561,"context_line":"            is_network_in_resources \u003d \u0027network\u0027 in account.get(\u0027resources\u0027, {})"},{"line_number":562,"context_line":"            return is_network_in_resources \u003d\u003d\\"},{"line_number":563,"context_line":"                tests_require_projects_with_networks"},{"line_number":564,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":16,"id":"2813ccd2_5be7cada","line":564,"range":{"start_line":548,"start_character":0,"end_line":564,"end_character":19},"updated":"2023-07-20 22:29:29.000000000","message":"I think we do not need to check and do_tests_require_projects_with_networks telling if project need any account without network and if that is not found then return misconfiguration error.","commit_id":"2b37170343cab050de8b4d2ad4f01d7386f9aa85"}]}