)]}'
{"tempest/clients.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ecdf346c9faca691101aa730734b1bafc04f8351","unresolved":false,"context_lines":[{"line_number":642,"context_line":"    def _get_data_processing_client(self, username, password, tenant_name):"},{"line_number":643,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWn%2F%2F7xw%3D","line":645,"updated":"2014-04-08 12:14:54.000000000","message":"OrchestrationScenarioTest and NetworkScenarioTest are checking their service_available in each scenario test class without this kind of method. So how about the similar check?","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"a1a154f6dfc48861dbedf1118051129b81737c1a","unresolved":false,"context_lines":[{"line_number":642,"context_line":"    def _get_data_processing_client(self, username, password, tenant_name):"},{"line_number":643,"context_line":"        if not CONF.service_available.sahara:"},{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FdMM%3D","line":645,"in_reply_to":"AAAAWn%2F%2F7xw%3D","updated":"2014-04-14 13:49:16.000000000","message":"Sahara client is designed to check endpoints and fail if service isn\u0027t available, so, we need to check sahara availability before creating client instance.","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ecdf346c9faca691101aa730734b1bafc04f8351","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        self._validate_credentials(username, password, tenant_name)"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWn%2F%2F72Q%3D","line":647,"updated":"2014-04-08 12:14:54.000000000","message":"How about import the client at the top of this file like the other clients?","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"da8451484a0968f56c67735e3ca12564b9107e6b","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        self._validate_credentials(username, password, tenant_name)"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FYpM%3D","line":647,"in_reply_to":"AAAAW3%2F%2FdL8%3D","updated":"2014-04-15 00:13:20.000000000","message":"I got it, thanks for your explanation.","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"a1a154f6dfc48861dbedf1118051129b81737c1a","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        self._validate_credentials(username, password, tenant_name)"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FdL8%3D","line":647,"in_reply_to":"AAAAW3%2F%2FdPY%3D","updated":"2014-04-14 13:49:16.000000000","message":"Agreed, it means that client will not be imported if service isn\u0027t available.","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"338b580d86a9d10560c399f580f836edcbbcac46","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            # Sahara isn\u0027t available"},{"line_number":645,"context_line":"            return None"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        import saharaclient.client"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        self._validate_credentials(username, password, tenant_name)"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FdPY%3D","line":647,"in_reply_to":"AAAAWn%2F%2F72Q%3D","updated":"2014-04-14 13:43:41.000000000","message":"I actually like this, because it means that you don\u0027t need to have the client installed","commit_id":"a9644d2cad3404fcf7ca48f6b1be81b1305d2ff6"}]}
