)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7716c05bb9142b8c3dc1ae4b5554a3e90d0ebb5b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Driver APIs -"},{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xHU%3D","line":13,"updated":"2014-04-02 09:09:42.000000000","message":"s/does/is/\n\ns/createsd/created/","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a60b5c1a8d1f8e67327b35559e133b14cbfb5e39","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Driver APIs -"},{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9w9M%3D","line":13,"in_reply_to":"AAAAWH%2F9w%2B0%3D","updated":"2014-04-02 09:27:43.000000000","message":"Done","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"33dbdfd0281e46bdde6bda55746b51dd6dde2d54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Driver APIs -"},{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9w%2B0%3D","line":13,"in_reply_to":"AAAAWH%2F9xEQ%3D","updated":"2014-04-02 09:24:07.000000000","message":"not done, s/does/is/","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"225cf3a0b588c2c9e4afe9b7ad1981c8c4c3b14b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Driver APIs -"},{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xEQ%3D","line":13,"in_reply_to":"AAAAWH%2F9xHU%3D","updated":"2014-04-02 09:13:21.000000000","message":"Done","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7716c05bb9142b8c3dc1ae4b5554a3e90d0ebb5b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"},{"line_number":17,"context_line":"Change-Id: I5abe62f2fb9aec103ce4e127a28f488ef1f342df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xGo%3D","line":14,"updated":"2014-04-02 09:09:42.000000000","message":"\"I also confirmed it on IRC.\" is unnecessary.\nThe following words is enough.","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"225cf3a0b588c2c9e4afe9b7ad1981c8c4c3b14b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1. Retrieve a list of drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"},{"line_number":17,"context_line":"Change-Id: I5abe62f2fb9aec103ce4e127a28f488ef1f342df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xEM%3D","line":14,"in_reply_to":"AAAAWH%2F9xGo%3D","updated":"2014-04-02 09:13:21.000000000","message":"Done","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7716c05bb9142b8c3dc1ae4b5554a3e90d0ebb5b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"},{"line_number":17,"context_line":"Change-Id: I5abe62f2fb9aec103ce4e127a28f488ef1f342df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xGc%3D","line":15,"updated":"2014-04-02 09:09:42.000000000","message":"a new line seems necessary.","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"225cf3a0b588c2c9e4afe9b7ad1981c8c4c3b14b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\u0027fake\u0027 driver does createsd by default during ironic installation."},{"line_number":14,"context_line":"I also confirmed it on IRC. For this please have a look on -"},{"line_number":15,"context_line":"https://github.com/openstack/ironic/blob/master/setup.cfg#L33"},{"line_number":16,"context_line":"part of blueprint: missing-baremetal-api-test"},{"line_number":17,"context_line":"Change-Id: I5abe62f2fb9aec103ce4e127a28f488ef1f342df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F9xEI%3D","line":15,"in_reply_to":"AAAAWH%2F9xGc%3D","updated":"2014-04-02 09:13:21.000000000","message":"Done","commit_id":"61e6a49c6e68c3cea902a583fd4d44dd9ef3650a"}],"tempest/api/baremetal/test_drivers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5b822bcc23616bb922dcd5e6e691a7b93bf2569","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BOjI%3D","line":2,"updated":"2014-03-28 09:21:01.000000000","message":"Date and name of company","commit_id":"ce4610e86b004e1cc1e8ffbcefda482f83d87844"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"7948cf9852a1664bdf9fc0940866a2d83a6569d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BOcA%3D","line":2,"in_reply_to":"AAAAWH%2F%2BOjI%3D","updated":"2014-03-28 09:24:08.000000000","message":"Will do in next patch","commit_id":"ce4610e86b004e1cc1e8ffbcefda482f83d87844"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5b822bcc23616bb922dcd5e6e691a7b93bf2569","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_list_drivers(self):"},{"line_number":23,"context_line":"        resp, body \u003d self.client.list_drivers()"},{"line_number":24,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in body[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BOeU%3D","line":25,"updated":"2014-03-28 09:21:01.000000000","message":"can you have check for some more attributes?","commit_id":"ce4610e86b004e1cc1e8ffbcefda482f83d87844"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"7948cf9852a1664bdf9fc0940866a2d83a6569d5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_list_drivers(self):"},{"line_number":23,"context_line":"        resp, body \u003d self.client.list_drivers()"},{"line_number":24,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in body[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BOcE%3D","line":25,"in_reply_to":"AAAAWH%2F%2BOeU%3D","updated":"2014-03-28 09:24:08.000000000","message":"As driver create method does not exits, I have only surety of this parameter only.","commit_id":"ce4610e86b004e1cc1e8ffbcefda482f83d87844"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fb1949648438ec95669ba549b0ad1963d19b0a8c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9yPI%3D","line":24,"updated":"2014-04-02 06:35:12.000000000","message":"Why response code is being removed. Can you please check that?","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16b5e26f886408a92d4b4db75307604d5247278b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9yBw%3D","line":24,"in_reply_to":"AAAAWH%2F9yHY%3D","updated":"2014-04-02 07:16:37.000000000","message":"I will suggest we should check and when you will test in your development environment then that also will get tested whether its right or not.","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"73e9c8520ac78346c3f924da3dfe01eb60d8a225","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9yHY%3D","line":24,"in_reply_to":"AAAAWH%2F9yPI%3D","updated":"2014-04-02 07:00:26.000000000","message":"In all test cases for baremetal, people didn\u0027t use status code checks.\nI followed that trend, Also I didn\u0027t get any of documents showing reference status returned. May be lack of suitable doc could be the reason people did not follwed response code.\nWht you suggest ??","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1a46b70d9219f413df52f8c299565751b7b2b566","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9yPU%3D","line":25,"updated":"2014-04-02 06:35:15.000000000","message":"Why can we get \u0027fake\u0027 always?\n\nThis test class does not create it. My concern is that if \u0027fake\u0027 should not be created always, this test fails.","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2075c3908b9e95028f3040ef3e5d73c100d431ed","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9xNg%3D","line":25,"in_reply_to":"AAAAWH%2F9yGw%3D","updated":"2014-04-02 08:59:09.000000000","message":"Thanks, I got it.\nI think that is important info for the other reviewers and people will see this patchset in the future. So could you write it on the commit log?","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"73e9c8520ac78346c3f924da3dfe01eb60d8a225","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    @test.attr(type\u003d\"smoke\")"},{"line_number":23,"context_line":"    def test_list_drivers(self):"},{"line_number":24,"context_line":"        drivers \u003d self.client.list_drivers()"},{"line_number":25,"context_line":"        self.assertIn(\u0027fake\u0027, [d[\u0027name\u0027] for d in drivers[\u0027drivers\u0027]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9yGw%3D","line":25,"in_reply_to":"AAAAWH%2F9yPU%3D","updated":"2014-04-02 07:00:26.000000000","message":"fake driver does creates by default during ironic installation.\nI also confirmed it on IRC.\nplease have a look on -\nhttps://github.com/openstack/ironic/blob/master/setup.cfg#L33","commit_id":"74690fc1e0be28d1a3d38a38e20734689707e968"}]}