)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"528d4e8681c1d4d24f60bde139c748aad9910cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3278adc6_f7180067","updated":"2022-04-12 21:27:04.000000000","message":"tempest/scenario/manager.py is a stable interface, although this review doesn\u0027t change any current logic, it only adds new functionality in case it\u0027s needed - so no consumer will be affected by this change (in a bad sense).\nSmall doc suggestion inline, otherwise it looks ok to me.","commit_id":"ae4d2518bafc85bfbfaa57b76418950519236fbc"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6c94f353d0d3edb48a9a4ea11e553be00e54d2e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10f48fc0_601f2246","updated":"2022-04-28 20:08:51.000000000","message":"I do not see any downside to this, it looks good to me. \n\n","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"4d3b097a12b5f30f8a6f54dd9936d8b8387bbf94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7eb2e81_e57818bc","updated":"2022-04-22 08:48:56.000000000","message":"LGTM","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a950fc8f045d87e85e7ffa8ef6f3416290c3cf5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05a57ccf_2a9323e1","updated":"2022-04-22 08:47:57.000000000","message":"Works with my proposed tests.\n\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795753","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf5c70bc04c058ca67a77516b4e9c82d06d30b8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b1e3553e_396ce808","updated":"2022-04-25 14:47:10.000000000","message":"it lgtm, later , if we wanted to this with other waiters as well, we can implement this logic in the waiters (decorator, if statement at the beginning of a waiter), although, as this currently introduces the not-wait-at-all feature only on 2 places, it makes sense to me to leave it like this for now","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b5971ec78c32d40916248268c93464ad04d21dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36cb98c9_cb29b060","updated":"2022-04-21 14:01:14.000000000","message":"recheck\n\nunrelated failure in py38\ntempest.tests.common.test_waiters.TestVolumeWaiters.test_wait_for_volume_attachment_not_present\n\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1142, in _execute_mock_call\n    result \u003d next(effect)\nStopIteration\n\n\nalso looks like unrelated failure in tempest-full-centos-9-stream\ntempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.test_resize_volume_backed_server_confirm\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 101, in wait_for_server_status\n    raise lib_exc.TimeoutException(message)\ntempest.lib.exceptions.TimeoutException: Request timed out","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"98548f5c3395e8d7da79b7517de3cdb06d397e59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de0c2213_a5dfa080","updated":"2022-04-19 14:51:49.000000000","message":"recheck - most of the failures should be resolved by workaround here: https://bugs.launchpad.net/devstack/+bug/1968798","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6c94f353d0d3edb48a9a4ea11e553be00e54d2e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cd43a28_a96bf5f3","in_reply_to":"b1e3553e_396ce808","updated":"2022-04-28 20:08:51.000000000","message":"Adding this to the waiters decorator sounds good. Maybe we can create a launchpad bug for it with a low-hanging-fruit tag, in case some interns are looking for small fixes to do.","commit_id":"7beb2d0ceb8f029e70b0a7ff950afd60b1bf5658"}],"tempest/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"528d4e8681c1d4d24f60bde139c748aad9910cf3","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        \"\"\"Creates volume"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        This wrapper utility creates volume and waits for volume to be"},{"line_number":329,"context_line":"        in \u0027available\u0027 state."},{"line_number":330,"context_line":"        This method returns the volume\u0027s full representation by GET request."},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ae15082a_8b7a88de","line":329,"range":{"start_line":329,"start_character":28,"end_line":329,"end_character":29},"updated":"2022-04-12 21:27:04.000000000","message":", by default, If wait_until is None, it means no wait.","commit_id":"ae4d2518bafc85bfbfaa57b76418950519236fbc"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"106ec41a3751be158e086758690c7deac67e0987","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        \"\"\"Creates volume"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        This wrapper utility creates volume and waits for volume to be"},{"line_number":329,"context_line":"        in \u0027available\u0027 state."},{"line_number":330,"context_line":"        This method returns the volume\u0027s full representation by GET request."},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"87b983c0_2c3f976f","line":329,"range":{"start_line":329,"start_character":28,"end_line":329,"end_character":29},"in_reply_to":"ae15082a_8b7a88de","updated":"2022-04-13 04:27:15.000000000","message":"done","commit_id":"ae4d2518bafc85bfbfaa57b76418950519236fbc"}]}