)]}'
{"tempest/scenario/orchestration/test_ha.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"36171ba4c38a4d4084340b5b67c043bbc968ea9c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        stack \u003d self.client.stacks.get(stackname)"},{"line_number":55,"context_line":"        self.addCleanup(stack, \u0027delete\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        sid \u003d \u0027%s/%s\u0027 % (stackname, stack.id)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_8cada19d","line":55,"updated":"2014-05-20 08:24:58.000000000","message":"I think you can use self.set_resource(\u0027stack\u0027, stack) here instead of the explicit addCleanup?","commit_id":"875a5e99fa89d23112da0f251ac38236ae139744"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"870d7d304a9ad8ec4e5f941e6e1bd1e2dd973280","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        stack \u003d self.client.stacks.get(stackname)"},{"line_number":55,"context_line":"        self.addCleanup(stack, \u0027delete\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        sid \u003d \u0027%s/%s\u0027 % (stackname, stack.id)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_6403e50f","line":55,"in_reply_to":"7adec928_8cada19d","updated":"2014-05-27 18:00:26.000000000","message":"Oh, sorry ignore this, I\u0027ve now seen https://review.openstack.org/#/c/62101/ which appears to suggest everything is moving towards cleanup instead.\n\nNote I added a convenience function which allows you to add a delete cleanup and tolerate an already-deleted stack in https://review.openstack.org/#/c/88137/13/tempest/scenario/manager.py","commit_id":"875a5e99fa89d23112da0f251ac38236ae139744"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"36171ba4c38a4d4084340b5b67c043bbc968ea9c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # kill the guest with Nova"},{"line_number":63,"context_line":"        server_id \u003d self.compute_client.servers.get(stackname)"},{"line_number":64,"context_line":"        self.compute_client.servers.delete(server_id)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # TODO(sdague): wait for restart"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_4c8e392f","line":64,"updated":"2014-05-20 08:24:58.000000000","message":"Would it be better to just stop the server here, then prove that heat has deleted it on restart and replaced it with a new one?","commit_id":"875a5e99fa89d23112da0f251ac38236ae139744"}],"tempest/scenario/orchestration/test_ha.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"36171ba4c38a4d4084340b5b67c043bbc968ea9c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        properties:"},{"line_number":23,"context_line":"            Count: 1"},{"line_number":24,"context_line":"            Handle: { get_resource: wait_handle }"},{"line_number":25,"context_line":"            Timeout: 3600"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    instance1:"},{"line_number":28,"context_line":"        type: OS::Nova::Server"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7adec928_6cc935ab","line":25,"updated":"2014-05-20 08:24:58.000000000","message":"We should pass in the timeout via a parameter set from the global build_timeout similar to what I did for API tests in https://review.openstack.org/#/c/87993/","commit_id":"875a5e99fa89d23112da0f251ac38236ae139744"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"36171ba4c38a4d4084340b5b67c043bbc968ea9c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        echo \"AWSSecretKey\u003dsecretkey\" \u003e\u003e /etc/cfn/cfn-credentials"},{"line_number":41,"context_line":"                        chmod 400 /etc/cfn/cfn-credentials"},{"line_number":42,"context_line":"                        nohup bash -c \u0027while true; do /opt/aws/bin/cfn-push-stats --watch alarmref --heartbeat \u0026\u0026 sleep 1; done\u0027\u0026"},{"line_number":43,"context_line":"                        /opt/aws/bin/cfn-signal -e 0 -i \u0027instance1\u0027 \"wc_url\""},{"line_number":44,"context_line":"                    params:"},{"line_number":45,"context_line":"                        wc_url: { get_resource: wait_handle }"},{"line_number":46,"context_line":"                        accesskey: { get_resource: access }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7adec928_0ca7d1a7","line":43,"updated":"2014-05-20 08:24:58.000000000","message":"I\u0027m now wondering if there\u0027s a way to rework this so it only uses the cirros image, e.g using a similar approach to that in \n\nhttps://review.openstack.org/#/c/91475/3/hot/software-config/cirros-example/init.d/heat-deploy-hook\n\nThat won\u0027t work with the HMAC signing of the data sent via cfn-push-stats, but I\u0027ll think about it some more and see if I can figure out an alternative approach (possibly one which removes the Alarm part of this and directly triggers the HARestarter)","commit_id":"875a5e99fa89d23112da0f251ac38236ae139744"}]}