)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2016af07b54fc1cbd31a50ef67e67a522b81b747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d80cdebd_3963d7d3","updated":"2022-05-06 16:34:17.000000000","message":"+1 on idea but waiting to see unit tests to be +2","commit_id":"bbb94556d180200480b655089c95e46afc7a016c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8c37e451c9d05a441a6e5cc3866afc250f9871f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c792ba5_dc0c8681","updated":"2022-05-04 06:00:04.000000000","message":"Hi , \nPlease let me know if you agree with the solution before moving on.\nExpecting to see some failures in testcase (will fix) due the current implementation\nthat methods are classlevel by default inside a testcase.\n\nBenny","commit_id":"bbb94556d180200480b655089c95e46afc7a016c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2016af07b54fc1cbd31a50ef67e67a522b81b747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"384495bd_287d286d","in_reply_to":"3c792ba5_dc0c8681","updated":"2022-05-06 16:34:17.000000000","message":"Thanks Benny, I like the idea and it should work fine. Please add unit test for the decorator functional and we will be good here.","commit_id":"bbb94556d180200480b655089c95e46afc7a016c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"36ccc1ce761614fe423eab80a303340263ae978d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7327ea0e_9261b931","updated":"2022-05-18 04:32:46.000000000","message":"recheck","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"234a04b2_2067526c","updated":"2022-05-30 20:51:36.000000000","message":"almost ready, few comments","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad17309a7231cf8b2c54dd5a0707b230c6892e01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da0b6c41_c8c9b063","updated":"2022-12-13 20:15:20.000000000","message":"I think this is good patch to fix some cleanup order and some issues we are seeing more on Jammy. Agree with arx nits to re-share the code but that can be done in follow up and let\u0027s get actual fix in.","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b094817bbfb1bc62c8a6885b06c4d2f6b34fd26b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e77f7ed3_dcc6e8a2","updated":"2022-12-19 11:18:57.000000000","message":"recheck\n\nThe tox py39 job probably failed because of a race condition inside the unit tests.","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"017a4c2c5da94363f194976558d2b3a5531b3594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"463d3f89_921fbba0","updated":"2022-12-19 19:02:30.000000000","message":"recheck multinode job is flaky","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c5a3f6ae58ca0462d59d6f2be442ee14926dcb21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"715e5fdf_67b4eb8a","updated":"2022-12-19 10:47:37.000000000","message":"recheck random py failure in unit tests","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"161a5af3131746a0a53c12718c79c9bc7739e776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4021922a_ccb90245","updated":"2023-01-05 10:07:07.000000000","message":"recheck timeout","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f90cdaab93b057a18a7e1d9f2a10d7bfce44835c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8a23494b_95fce524","updated":"2023-01-10 11:42:05.000000000","message":"recheck weird timeout issues, CI should be working","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"13274858b352d19687893980e4320b531a66dbf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"981a187a_13a939fd","updated":"2022-09-02 05:15:52.000000000","message":"small nit 😊","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"}],"tempest/api/volume/admin/test_group_snapshots.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6fc77affc504446f9a8040fe82bf02927ea7340","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        for vol in cls.clear_volumes:"},{"line_number":44,"context_line":"            test_utils.call_and_ignore_notfound_exc(cls.delete_volume,"},{"line_number":45,"context_line":"                                                    cls.volumes_client, vol)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _create_group_snapshot(self, **kwargs):"},{"line_number":48,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":49,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"b745d8ec_e210e0fd","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":0},"updated":"2022-05-20 22:18:38.000000000","message":"I did not understand this change, can you please explain. You are making volume cleanup at class level?","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"3f41df3c358f36eba1f2550f7927c2fa8f2f0057","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        for vol in cls.clear_volumes:"},{"line_number":44,"context_line":"            test_utils.call_and_ignore_notfound_exc(cls.delete_volume,"},{"line_number":45,"context_line":"                                                    cls.volumes_client, vol)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _create_group_snapshot(self, **kwargs):"},{"line_number":48,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":49,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"d8fa64c7_be68fad0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":0},"in_reply_to":"b745d8ec_e210e0fd","updated":"2022-05-25 05:03:17.000000000","message":"Yes, the way it was implemented the code is exposed to bugs , some commands in self level while others in cls level.\ni will have to change the testcases here ( the cleanup )\nI did not want to change the test logic but if you dont like it i will fix the testcase that the cleanup will be run in the self scope properly","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0d32cc487b2b286dffbf1b252a40c57b12d5835a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for vol in cls.clear_volumes:"},{"line_number":44,"context_line":"            test_utils.call_and_ignore_notfound_exc(cls.delete_volume,"},{"line_number":45,"context_line":"                                                    cls.volumes_client, vol)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _create_group_snapshot(self, **kwargs):"},{"line_number":48,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":49,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"600158a1_4123aee0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":0},"in_reply_to":"d8fa64c7_be68fad0","updated":"2022-05-30 04:49:30.000000000","message":"Done","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0d32cc487b2b286dffbf1b252a40c57b12d5835a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        grp \u003d self.create_group(group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":92,"context_line":"                                volume_types\u003d[volume_type[\u0027id\u0027]])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # Create volume"},{"line_number":95,"context_line":"        params \u003d {\u0027name\u0027: data_utils.rand_name(\"volume\"),"},{"line_number":96,"context_line":"                  \u0027volume_type\u0027: volume_type[\u0027id\u0027],"},{"line_number":97,"context_line":"                  \u0027group_id\u0027: grp[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3682788_19da3b19","line":94,"updated":"2022-05-30 04:49:30.000000000","message":"the create_volume is instance level now and we can not delete the volumes before we remove the groups. \nvolumes delete handled in delete_group method which is addcleanup .\nIt was working before because volumes cleanup handled in classlevel by default and the group as instance. now when both having the same scope instance level, we hit on the issue of cleanup.","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        grp \u003d self.create_group(group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":92,"context_line":"                                volume_types\u003d[volume_type[\u0027id\u0027]])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # Create volume"},{"line_number":95,"context_line":"        params \u003d {\u0027name\u0027: data_utils.rand_name(\"volume\"),"},{"line_number":96,"context_line":"                  \u0027volume_type\u0027: volume_type[\u0027id\u0027],"},{"line_number":97,"context_line":"                  \u0027group_id\u0027: grp[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"10bdba70_bda394b2","line":94,"in_reply_to":"c3682788_19da3b19","updated":"2022-05-30 20:51:36.000000000","message":"+1, but please add the above as notes here so that we do not forget that why volume cleanup was not done.","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":166,"context_line":"        vol \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":167,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":168,"context_line":"            self.volumes_client, vol[\u0027id\u0027], \u0027available\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Create group_snapshot"},{"line_number":171,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a05d53e_7b782461","line":168,"range":{"start_line":168,"start_character":55,"end_line":168,"end_character":56},"updated":"2022-05-30 20:51:36.000000000","message":"ditto","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":166,"context_line":"        vol \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":167,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":168,"context_line":"            self.volumes_client, vol[\u0027id\u0027], \u0027available\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Create group_snapshot"},{"line_number":171,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6a00f764_543c5797","line":168,"range":{"start_line":168,"start_character":55,"end_line":168,"end_character":56},"in_reply_to":"8a05d53e_7b782461","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                      \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":232,"context_line":"            volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":233,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":234,"context_line":"                self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":235,"context_line":"            volume_list.append(volume[\u0027id\u0027])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        for vol in volume_list:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ad98f152_d04e587e","line":234,"range":{"start_line":234,"start_character":62,"end_line":234,"end_character":63},"updated":"2022-05-30 20:51:36.000000000","message":"ditto","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                      \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":232,"context_line":"            volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":233,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":234,"context_line":"                self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":235,"context_line":"            volume_list.append(volume[\u0027id\u0027])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        for vol in volume_list:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b9a3ffec_b38c8ff7","line":234,"range":{"start_line":234,"start_character":62,"end_line":234,"end_character":63},"in_reply_to":"ad98f152_d04e587e","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":291,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":292,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":293,"context_line":"            self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # Create group snapshot"},{"line_number":296,"context_line":"        group_snapshot \u003d self._create_group_snapshot(group_id\u003dgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"c99f697f_ca24fbc8","line":293,"range":{"start_line":293,"start_character":58,"end_line":293,"end_character":59},"updated":"2022-05-30 20:51:36.000000000","message":"ditto","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":291,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":292,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":293,"context_line":"            self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # Create group snapshot"},{"line_number":296,"context_line":"        group_snapshot \u003d self._create_group_snapshot(group_id\u003dgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0333e03_8de8dd26","line":293,"range":{"start_line":293,"start_character":58,"end_line":293,"end_character":59},"in_reply_to":"c99f697f_ca24fbc8","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"11e14629d05a06391f5d952b42f23a21c02057c5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":168,"context_line":"        vol \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":169,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":170,"context_line":"            self.volumes_client, vol[\u0027id\u0027], \u0027available\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # Create group_snapshot"},{"line_number":173,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c8ca6607_6a00ac90","line":170,"updated":"2022-06-13 11:42:28.000000000","message":"Can\u0027t this be a method, instead of keep repeating the same code in several other places?","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"13274858b352d19687893980e4320b531a66dbf1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":168,"context_line":"        vol \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":169,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":170,"context_line":"            self.volumes_client, vol[\u0027id\u0027], \u0027available\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # Create group_snapshot"},{"line_number":173,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"60152afd_f41ea6ce","line":170,"in_reply_to":"1bad6303_41b08bc7","updated":"2022-09-02 05:15:52.000000000","message":"yes, this piece of code is being repeated throughout the whole test_group_snapshots.py. Hence, having a internal method is great idea.\n\nWould we like to this in fresh new patch or in this patch only?","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"ccb6f49dbda0986e2962a550e3c2778036735721","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":168,"context_line":"        vol \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":169,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":170,"context_line":"            self.volumes_client, vol[\u0027id\u0027], \u0027available\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # Create group_snapshot"},{"line_number":173,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1bad6303_41b08bc7","line":170,"in_reply_to":"c8ca6607_6a00ac90","updated":"2022-06-13 12:17:27.000000000","message":"Yes it can be an inernal method here ... _create_volumne .","commit_id":"951b806347adce32fa7f99b441b9e973af1e789d"}],"tempest/api/volume/admin/test_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6fc77affc504446f9a8040fe82bf02927ea7340","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                                                volume[\u0027id\u0027], \"available\")"},{"line_number":48,"context_line":"        return volume"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class GroupsTest(BaseGroupsTest):"},{"line_number":52,"context_line":"    \"\"\"Tests of volume groups with microversion greater than 3.12\"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"74fbfb07_1cb3a206","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":0},"updated":"2022-05-20 22:18:38.000000000","message":"ditto","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0d32cc487b2b286dffbf1b252a40c57b12d5835a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                                volume[\u0027id\u0027], \"available\")"},{"line_number":48,"context_line":"        return volume"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class GroupsTest(BaseGroupsTest):"},{"line_number":52,"context_line":"    \"\"\"Tests of volume groups with microversion greater than 3.12\"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"38822151_9b86964f","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":0},"in_reply_to":"74fbfb07_1cb3a206","updated":"2022-05-30 04:49:30.000000000","message":"Done","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        # Create Group"},{"line_number":108,"context_line":"        grp \u003d self.create_group(group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":109,"context_line":"                                volume_types\u003d[volume_type[\u0027id\u0027]])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Create volumes"},{"line_number":112,"context_line":"        grp_vols \u003d []"},{"line_number":113,"context_line":"        for _ in range(2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b620f58_8809913d","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":0},"updated":"2022-05-30 20:51:36.000000000","message":"ditto in this file too","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # Create Group"},{"line_number":108,"context_line":"        grp \u003d self.create_group(group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":109,"context_line":"                                volume_types\u003d[volume_type[\u0027id\u0027]])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Create volumes"},{"line_number":112,"context_line":"        grp_vols \u003d []"},{"line_number":113,"context_line":"        for _ in range(2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"40153a5f_6b8ae03b","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":0},"in_reply_to":"9b620f58_8809913d","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"}],"tempest/lib/decorators.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import functools"},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from types import MethodType"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"87b655b9_5cee7e47","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"updated":"2022-05-30 20:51:36.000000000","message":"no new line needed here","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import functools"},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from types import MethodType"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"0c693795_0b80b78d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"in_reply_to":"87b655b9_5cee7e47","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5e375c9a2162eb94680d393b3452beabf5a1fcc","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from types import MethodType"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tempest.lib import exceptions as lib_exc"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfd064b1_ebb1c223","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":0},"updated":"2022-05-30 20:51:36.000000000","message":"no new line needed here","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"99275f0d996650e5345908a81cac80126147dca9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from types import MethodType"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tempest.lib import exceptions as lib_exc"}],"source_content_type":"text/x-python","patch_set":5,"id":"79ab4ee9_9c06832a","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":0},"in_reply_to":"bfd064b1_ebb1c223","updated":"2022-05-31 05:03:45.000000000","message":"Done","commit_id":"29ae3d902b395fa44d0dfad1e0db106d0a4e26cf"}],"tempest/tests/lib/test_decorators.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6fc77affc504446f9a8040fe82bf02927ea7340","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":380,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":381,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":382,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":383,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":384,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":385,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba087577_224d9354","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":70},"updated":"2022-05-20 22:18:38.000000000","message":"why cannot we check this assert?","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"3f41df3c358f36eba1f2550f7927c2fa8f2f0057","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":380,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":381,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":382,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":383,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":384,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":385,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd8d1b4b_64344466","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":70},"in_reply_to":"ba087577_224d9354","updated":"2022-05-25 05:03:17.000000000","message":"Checking","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0d32cc487b2b286dffbf1b252a40c57b12d5835a","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":380,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":381,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":382,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":383,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":384,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":385,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"76a52362_6867120a","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":70},"in_reply_to":"bd8d1b4b_64344466","updated":"2022-05-30 04:49:30.000000000","message":"Done","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6fc77affc504446f9a8040fe82bf02927ea7340","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":393,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":394,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":395,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":396,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":397,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":398,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"75b2a3cf_8238a6c6","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":70},"updated":"2022-05-20 22:18:38.000000000","message":"ditto","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"3f41df3c358f36eba1f2550f7927c2fa8f2f0057","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":393,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":394,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":395,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":396,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":397,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":398,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"803d377e_260e78db","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":70},"in_reply_to":"75b2a3cf_8238a6c6","updated":"2022-05-25 05:03:17.000000000","message":"Checking","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0d32cc487b2b286dffbf1b252a40c57b12d5835a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        self.assertEqual(self._create_volume.__doc__, \"Test doc\")"},{"line_number":393,"context_line":"        # New cleanup created and refers to addClassResourceCleanup"},{"line_number":394,"context_line":"        self.assertTrue(hasattr(self, \"cleanup\"))"},{"line_number":395,"context_line":"        # self.assertEqual(self.cleanup, self.addClassResourceCleanup)"},{"line_number":396,"context_line":"        # Verify function added to instance addClassResourceCleanup"},{"line_number":397,"context_line":"        self.assertIn(type(self)._delete_dummy,"},{"line_number":398,"context_line":"                      [e[0] for e in self.addClassResourceCleanup])"}],"source_content_type":"text/x-python","patch_set":2,"id":"88a2f9eb_8eba0a77","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":70},"in_reply_to":"803d377e_260e78db","updated":"2022-05-30 04:49:30.000000000","message":"Done","commit_id":"c474fdec6a16595b70e6e9eef103a457b85664f5"}]}