)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"603fce1c48f7c3b0cded0e2fb9a0c2d0ac1e367e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42f46456_4329360e","updated":"2022-05-10 13:38:57.000000000","message":"Tests themselves look fine, see inline for comments.","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2fd100593fa8e32e9189f0a66c62d1e590fc4794","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b523ff64_4956e49e","updated":"2022-05-10 14:09:21.000000000","message":"recheck","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e21837c16b956cff41070d3ac5d700ef89f3a3d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eadfd383_ecf3d776","updated":"2022-08-06 16:48:05.000000000","message":"Along with martin commnet, one comment for test name otherwise lgtm","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ba15b2714d43c8f5581b9bacc94186826553e76a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfd32d28_25ca7c89","updated":"2022-07-27 12:25:46.000000000","message":"recheck to get fresh logs","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"de6a56d40e2892df7e2880bb433c5ee9e42e996e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ebe0a197_f6d2bdac","updated":"2022-08-30 15:43:18.000000000","message":"Looks good to me.","commit_id":"7c48148fe248cb7e0e591c26adb0faba2d7a92b9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5dd9ac1aa537d3418d313d2e0abbcb638d9e5e7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"675088d6_af9109f8","updated":"2022-08-30 15:48:15.000000000","message":"merging it.","commit_id":"7c48148fe248cb7e0e591c26adb0faba2d7a92b9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da59a7f64fbddc860a552b38f5691c5fc2bcacdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b2c4d204_3f8a7df3","updated":"2022-08-22 19:04:58.000000000","message":"thanks,lgtm","commit_id":"7c48148fe248cb7e0e591c26adb0faba2d7a92b9"}],"tempest/api/compute/admin/test_servers_on_multinodes.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"603fce1c48f7c3b0cded0e2fb9a0c2d0ac1e367e","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    @classmethod"},{"line_number":137,"context_line":"    def resource_setup(cls):"},{"line_number":138,"context_line":"        super(UnshelveToHostMultiNodesTest, cls).resource_setup()"},{"line_number":139,"context_line":"        cls.client \u003d cls.os_admin.servers_client"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"567ca711_2eaaf6b8","line":139,"updated":"2022-05-10 13:38:57.000000000","message":"Never do this, we learned this the hard way in whitebox. If you need the admin client in a test, refer to it explicitly.","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7c5aaaeb8efc6e700a7b842063d6012f0ae94e41","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    @classmethod"},{"line_number":137,"context_line":"    def resource_setup(cls):"},{"line_number":138,"context_line":"        super(UnshelveToHostMultiNodesTest, cls).resource_setup()"},{"line_number":139,"context_line":"        cls.client \u003d cls.os_admin.servers_client"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @classmethod"},{"line_number":142,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"96b08813_08d0de45","line":139,"in_reply_to":"567ca711_2eaaf6b8","updated":"2022-05-10 14:48:45.000000000","message":"Done","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e21837c16b956cff41070d3ac5d700ef89f3a3d9","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027b5cc0889-50c2-46a0-b8ff-b5fb4c3a6e20\u0027)"},{"line_number":156,"context_line":"    def test_unshelve_to_host(self):"},{"line_number":157,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":158,"context_line":"        host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":159,"context_line":"        otherhost \u003d self.get_host_other_than(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"f942b345_61260639","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":29},"updated":"2022-08-06 16:48:05.000000000","message":"also we can rename test to be more closure to what it test.\n\ntest_unshelve_to_specific_host","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ba15b2714d43c8f5581b9bacc94186826553e76a","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027b5cc0889-50c2-46a0-b8ff-b5fb4c3a6e20\u0027)"},{"line_number":156,"context_line":"    def test_unshelve_to_host(self):"},{"line_number":157,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":158,"context_line":"        host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":159,"context_line":"        otherhost \u003d self.get_host_other_than(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"dd2113b7_758032f4","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":29},"updated":"2022-07-27 12:25:46.000000000","message":"every test case should have a description, a brief docstring: \nhttps://review.opendev.org/q/topic:bp%252Ftestcase-description","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"8813fbf6c72884e175afc2725da532ad2cd39c6c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027b5cc0889-50c2-46a0-b8ff-b5fb4c3a6e20\u0027)"},{"line_number":156,"context_line":"    def test_unshelve_to_host(self):"},{"line_number":157,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":158,"context_line":"        host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":159,"context_line":"        otherhost \u003d self.get_host_other_than(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"09bbdf68_80df6448","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":29},"in_reply_to":"dd2113b7_758032f4","updated":"2022-08-22 09:16:34.000000000","message":"Done","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"8813fbf6c72884e175afc2725da532ad2cd39c6c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027b5cc0889-50c2-46a0-b8ff-b5fb4c3a6e20\u0027)"},{"line_number":156,"context_line":"    def test_unshelve_to_host(self):"},{"line_number":157,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":158,"context_line":"        host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":159,"context_line":"        otherhost \u003d self.get_host_other_than(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"6bec4a74_6416266f","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":29},"in_reply_to":"f942b345_61260639","updated":"2022-08-22 09:16:34.000000000","message":"Done","commit_id":"8a7886e29df832e9115c32132b1d2e9479dad1ed"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"be86faab2aae7065ab9c690ef94be10a5d392e2e","unresolved":true,"context_lines":[{"line_number":149,"context_line":"            server[\u0027id\u0027],"},{"line_number":150,"context_line":"            body\u003d{\u0027unshelve\u0027: {\u0027host\u0027: host}}"},{"line_number":151,"context_line":"            )"},{"line_number":152,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":153,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027b5cc0889-50c2-46a0-b8ff-b5fb4c3a6e20\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"80e22ea0_f09da8da","line":152,"updated":"2022-08-22 10:35:02.000000000","message":"I would vote to add wait for SSHABLE and make sure that the instance is up and running .... need to check if we have similar test with volumes attached","commit_id":"7c48148fe248cb7e0e591c26adb0faba2d7a92b9"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"603fce1c48f7c3b0cded0e2fb9a0c2d0ac1e367e","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        # body to pass so we do not need to check the requested microversion"},{"line_number":634,"context_line":"        # here and always default req body to None."},{"line_number":635,"context_line":"        if not kwargs:"},{"line_number":636,"context_line":"            kwargs[\u0027body\u0027] \u003d {\u0027unshelve\u0027: None}"},{"line_number":637,"context_line":"        return self.action(server_id, \u0027unshelve\u0027, **kwargs)"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def unshelve_server_to_host(self, server_id, host, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"b055314c_1828d2c4","line":636,"updated":"2022-05-10 13:38:57.000000000","message":"We can\u0027t just have the \u0027host\u0027 automagically here? What happens if you call unshelve_server(\u003cuiud\u003e, host\u003d\u003chost\u003e)?","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7c5aaaeb8efc6e700a7b842063d6012f0ae94e41","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        # body to pass so we do not need to check the requested microversion"},{"line_number":634,"context_line":"        # here and always default req body to None."},{"line_number":635,"context_line":"        if not kwargs:"},{"line_number":636,"context_line":"            kwargs[\u0027body\u0027] \u003d {\u0027unshelve\u0027: None}"},{"line_number":637,"context_line":"        return self.action(server_id, \u0027unshelve\u0027, **kwargs)"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def unshelve_server_to_host(self, server_id, host, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4eb4432d_c7327b56","line":636,"in_reply_to":"b055314c_1828d2c4","updated":"2022-05-10 14:48:45.000000000","message":"Done","commit_id":"95950c22bbef79747725cefdea3032c4cd48730f"}]}