)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5350fc65fc46253e82041e2007300c1dc4c90ef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e0250ed_9f948761","updated":"2022-05-17 15:38:00.000000000","message":"1 comment","commit_id":"1caf241ea032c965b2f6c0f7703da8c0af4a2364"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a6472d03b294d60f5c28f7d2cca832b35de7880","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff6b3e11_2d88e8f8","updated":"2022-05-18 02:38:36.000000000","message":"recheck\n\nnot sure why it stuck again in wait, validation resource are there and everything seems fine in logs","commit_id":"86a8d9d9187673d6c4e68cb3688ebf213000afff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"463c88004b3156a66f52861e6515ca6c6dbeadec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"40101def_2745580b","updated":"2022-05-19 17:40:25.000000000","message":"one plus side of all these rechecks is that the test this is fixing has not failed in any of them which is promissing","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a15e11fdbe508365d7bd153a1f32655d49a580ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"17e46863_05a86522","updated":"2022-05-28 07:35:23.000000000","message":"recheck","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9f81740dac64910173ead93fd7e8cbfda1f06e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c6a3ea2_1b77468a","updated":"2022-05-26 21:46:06.000000000","message":"recheck","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"384a8c1811a47899b190d0a814d0078fff1e4792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"809bb8e1_83be6a3a","updated":"2022-05-27 15:35:39.000000000","message":"recheck","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0d2b2c756d10850f1d65bf50df1cde61f256073b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b233b47d_ffa1c771","updated":"2022-05-27 06:20:38.000000000","message":"recheck","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"969622332240dd2833f00baa0348f2b3558f8986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa4b818a_4a356ac3","updated":"2022-05-29 00:10:02.000000000","message":"recheck\n\nfailed tempest-multinode-full-py3 and logs are not available","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07b466e991c5e5cc8d9f1747eab1b32afe60f8c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a482054c_09378529","updated":"2022-05-19 10:50:35.000000000","message":"recheck db connection issues across multiple services","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcdcf9efceb014b713eba4be3f7854c5ed318a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42b8ecc5_80012e39","updated":"2022-05-19 16:31:30.000000000","message":"recheck grenade failed with\nE: Failed to fetch https://mirror.bhs1.ovh.opendev.org/ubuntu/dists/focal/main/binary-amd64/Packages  403  Forbidden [IP: 158.69.73.218 443]","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac6d62c053d5000e4ef9b8c0cea605f8721b2e2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b072be3c_ac69fa56","updated":"2022-05-19 08:05:24.000000000","message":"recheck it seems instance stuck in build state as local image creation never finished [1]\n\n[1] https://zuul.opendev.org/t/openstack/build/d434ebc9708b4c10a048c95bda63696c/log/controller/logs/screen-n-cpu.txt#68486","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee60052b775306c75bcfcafc0b4d4eaa2492b918","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cbe86304_625f6294","updated":"2022-05-20 00:11:39.000000000","message":"recheck pypi indexing issue","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f77aa0993df89cb8eca3baf45986ad0d542ee4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19113cea_48dd1d41","updated":"2022-05-27 20:52:23.000000000","message":"recheck server ping error","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72f0ab47d044bdd0e7275159d09a46636fdd251e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b42c200c_126135aa","updated":"2022-05-29 15:36:54.000000000","message":"recheck ssh timeout","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1ad1ea725dc0cbc69c985504337fd63bfa47876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8703f231_e79d3130","updated":"2022-05-21 01:12:10.000000000","message":"seems like py 36|7 jobs are failures are valid. Not related to this patch but tempest is blocked on this.\n\nPlease hold re check until we fix those.\n\n- https://review.opendev.org/c/openstack/tempest/+/842821","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aacb943c5c5894c20b20ee0abb84bb7aeda002fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab38cea5_a0612c8c","updated":"2022-05-19 04:57:24.000000000","message":"thanks","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e83d4600e6f0f3cf2d5025e089537d31ddafcdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"57e7697f_3060d8a6","updated":"2022-05-18 17:32:53.000000000","message":"thanks, lgtm","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"}],"tempest/api/compute/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e83b30e08dbb2c3338ac3916a2818766d089ddd","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            compute.wait_for_ssh_or_ping("},{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, wait_until)"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"aec916c5_92cf2cbb","line":480,"range":{"start_line":480,"start_character":7,"end_line":480,"end_character":13},"updated":"2022-05-17 15:38:31.000000000","message":"do we need to convert wait_until form (\"SSHABLE\", \"PINGABLE\") to \"ACTIVE\"\nin the else case","commit_id":"1caf241ea032c965b2f6c0f7703da8c0af4a2364"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"18e12b663cf0b4ae7fc5b624243fdc4a907852ea","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            compute.wait_for_ssh_or_ping("},{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, wait_until)"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cb5f3319_7ab1a6b6","line":480,"range":{"start_line":480,"start_character":7,"end_line":480,"end_character":13},"in_reply_to":"aec916c5_92cf2cbb","updated":"2022-05-17 15:50:22.000000000","message":"Done","commit_id":"1caf241ea032c965b2f6c0f7703da8c0af4a2364"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5350fc65fc46253e82041e2007300c1dc4c90ef7","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, wait_until)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":485,"context_line":"        self.assert_flavor_equal(new_flavor_id, server[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"e114d4f7_55a74f4a","line":482,"range":{"start_line":481,"start_character":0,"end_line":482,"end_character":59},"updated":"2022-05-17 15:38:00.000000000","message":"if no validation resource or run)validation is false then we end up waiting for SSH-able here. we should make it hard coded as \u0027Active\u0027","commit_id":"1caf241ea032c965b2f6c0f7703da8c0af4a2364"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"18e12b663cf0b4ae7fc5b624243fdc4a907852ea","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, wait_until)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":485,"context_line":"        self.assert_flavor_equal(new_flavor_id, server[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0dac52c_5050015b","line":482,"range":{"start_line":481,"start_character":0,"end_line":482,"end_character":59},"in_reply_to":"e114d4f7_55a74f4a","updated":"2022-05-17 15:50:22.000000000","message":"Done","commit_id":"1caf241ea032c965b2f6c0f7703da8c0af4a2364"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d9ab95ecca2e3552789a5520ea32e2ef24be43f0","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":485,"context_line":"        self.assert_flavor_equal(new_flavor_id, server[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"82757374_9454a63c","line":482,"range":{"start_line":481,"start_character":11,"end_line":482,"end_character":57},"updated":"2022-05-18 09:25:02.000000000","message":"i think we need to do this unconditionally and then wait for it to be sshable\n\nso\n\n        validation_resources \u003d self.get_class_validation_resources(\n            self.os_primary)\n        if (\n            validation_resources and\n            wait_until in (\"SSHABLE\", \"PINGABLE\") and\n            CONF.validation.run_validation\n        ):\n            server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]\n            tenant_network \u003d self.get_tenant_network()\n            compute.wait_for_ssh_or_ping(\n                server, self.os_primary, tenant_network,\n                True, validation_resources, wait_until, True)\n        else:\n            waiters.wait_for_server_status(\n                self.servers_client, server_id, \u0027ACTIVE\u0027)\n\n\nshoudl be \n\n\n        waiters.wait_for_server_status(\n            self.servers_client, server_id, \u0027ACTIVE\u0027)\n        validation_resources \u003d self.get_class_validation_resources(\n            self.os_primary)\n        if (\n            validation_resources and\n            wait_until in (\"SSHABLE\", \"PINGABLE\") and\n            CONF.validation.run_validation\n        ):\n            server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]\n            tenant_network \u003d self.get_tenant_network()\n            compute.wait_for_ssh_or_ping(\n                server, self.os_primary, tenant_network,\n                True, validation_resources, wait_until, True)","commit_id":"86a8d9d9187673d6c4e68cb3688ebf213000afff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2270e517f4310d36b6a0ba199a7eeb3687231f1e","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":485,"context_line":"        self.assert_flavor_equal(new_flavor_id, server[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"83ff0ec3_7a367eb5","line":482,"range":{"start_line":481,"start_character":11,"end_line":482,"end_character":57},"in_reply_to":"82757374_9454a63c","updated":"2022-05-18 11:13:09.000000000","message":"I\u0027m not sure. I based this on https://review.opendev.org/c/openstack/tempest/+/834350/6/tempest/api/compute/servers/test_server_rescue.py#175 where also either we wait for ACTIVE or we wait for SSHABLE. But it is easy to try.","commit_id":"86a8d9d9187673d6c4e68cb3688ebf213000afff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad7cd2933aeaaa21e1f6142438730ea39e4bc75e","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                server, self.os_primary, tenant_network,"},{"line_number":479,"context_line":"                True, validation_resources, wait_until, True)"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            waiters.wait_for_server_status("},{"line_number":482,"context_line":"                self.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        server \u003d self.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":485,"context_line":"        self.assert_flavor_equal(new_flavor_id, server[\u0027flavor\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"d45ff704_97cfb560","line":482,"range":{"start_line":481,"start_character":11,"end_line":482,"end_character":57},"in_reply_to":"83ff0ec3_7a367eb5","updated":"2022-05-18 15:06:15.000000000","message":"yeah, it depends on if server was active before we try SSH into it (In 834350 we waited for \u0027Active\u0027 server in _create_server_and_rescue_image so that worked) but waiting for active first and then try ssh is right sequence.","commit_id":"86a8d9d9187673d6c4e68cb3688ebf213000afff"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ed63366247478e378795181df3fae4f55e4094be","unresolved":true,"context_lines":[{"line_number":381,"context_line":"        servers \u003d []"},{"line_number":382,"context_line":"        for x in range(2):"},{"line_number":383,"context_line":"            name \u003d \u0027multiattach-server-%i\u0027 % x"},{"line_number":384,"context_line":"            servers.append(self.create_test_server(name\u003dname))"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        # Now wait for the servers to be ACTIVE."},{"line_number":387,"context_line":"        for server in servers:"},{"line_number":388,"context_line":"            waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":389,"context_line":"                                           \u0027ACTIVE\u0027)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        volume \u003d self._create_multiattach_volume()"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"abb3c694_7cc9f81c","line":389,"range":{"start_line":384,"start_character":6,"end_line":389,"end_character":52},"updated":"2022-05-18 14:23:10.000000000","message":"so i think we need to eiter use _create_server here \nhttps://review.opendev.org/c/openstack/tempest/+/842140/4/tempest/api/compute/volumes/test_attach_volume.py#45\n\nso that the validation resouces are created and we wait for them to be sshable before we attach the multi attach voluem\nor we also need that logic here.","commit_id":"a293dc4a854e44a2edee46ed18795ffc0632cbff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df7b13c8858306f0e7ead20942124b989b9a8a25","unresolved":true,"context_lines":[{"line_number":387,"context_line":"            servers.append("},{"line_number":388,"context_line":"                self.create_test_server("},{"line_number":389,"context_line":"                    name\u003dname,"},{"line_number":390,"context_line":"                    validatable\u003dTrue,"},{"line_number":391,"context_line":"                    validation_resources\u003dvalidation_resources"},{"line_number":392,"context_line":"                )"},{"line_number":393,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"af5998f6_a8d47c79","line":390,"range":{"start_line":390,"start_character":32,"end_line":390,"end_character":36},"updated":"2022-05-18 18:25:12.000000000","message":"ok this seams to be workign but a nit shoudl this be\n\nvalidatable\u003dvalidation_resources is not None","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dc21d2624df7e2562d07c918442f4af9b4b52fcd","unresolved":true,"context_lines":[{"line_number":389,"context_line":"                    name\u003dname,"},{"line_number":390,"context_line":"                    validatable\u003dTrue,"},{"line_number":391,"context_line":"                    validation_resources\u003dvalidation_resources"},{"line_number":392,"context_line":"                )"},{"line_number":393,"context_line":"            )"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        # Now wait for the servers to be ACTIVE."}],"source_content_type":"text/x-python","patch_set":5,"id":"6c3dca3e_4fb2d63b","line":392,"updated":"2022-05-18 14:24:48.000000000","message":"do we also need   adminPass\u003dself.image_ssh_password\n\n        server \u003d self.create_test_server(\n            validatable\u003dTrue,\n            validation_resources\u003dvalidation_resources,\n            wait_until\u003d\u0027SSHABLE\u0027,\n            adminPass\u003dself.image_ssh_password)\nis how its being used  in _create_server","commit_id":"d8bbaba415bc5cc027079b1b45aa5ee6e75faddf"}]}